March 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: jobs/ttcn3: add testsuites with io_uring

by jolly

Attention is currently required from: osmith. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36258?usp=email ) Change subject: jobs/ttcn3: add testsuites with io_uring ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36258?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8eb3f4fdfe54268d3b623d88c8746f5395ba509d Gerrit-Change-Number: 36258 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 13 Mar 2024 10:48:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in osmo-ci[master]: jobs/ttcn3: add testsuites with io_uring

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/36258?usp=email ) Change subject: jobs/ttcn3: add testsuites with io_uring ...................................................................... jobs/ttcn3: add testsuites with io_uring Set LIBOSMO_IO_BACKEND=IO_URING via the DOCKER_ARGS variable, which all SUTs already use in docker-playground.git (see ttcn3-*/jenkins.sh). The list of testsuites to test for is takend from: https://osmocom.org/issues/6357#note-9 Closes: OS#6357 Change-Id: I8eb3f4fdfe54268d3b623d88c8746f5395ba509d --- M jobs/ttcn3-testsuites.yml 1 file changed, 32 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/58/36258/1 diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index fbc0f04..7b44cca 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -204,6 +204,18 @@ - TTCN3-centos7-pcap-client-test-latest: timer: H 10 * * * + # With LIBOSMO_IO_BACKEND=IO_URING (OS#6357) + - ttcn3-bsc-test-io_uring: + timer: H 11 * * * + - ttcn3-msc-test-io_uring: + timer: H 11 * * * + - ttcn3-hnbgw-test-io_uring: + timer: H 11 * * * + - ttcn3-gbproxy-test-io_uring: + timer: H 11 * * * + - ttcn3-sgsn-test-io_uring: + timer: H 11 * * * + - job-template: name: '{job-name}' project-type: freestyle @@ -262,6 +274,10 @@ DIR="$(echo "{job-name}" | sed s/^TTCN3-centos7\-/ttcn3-/)" export IMAGE_SUFFIX="master-centos7" ;; + *-io_uring) + DIR="$(echo "{job-name}" | sed s/\-io_uring$//)" + export DOCKER_ARGS="-e LIBOSMO_IO_BACKEND=IO_URING" + ;; *-latest) DIR="$(echo "{job-name}" | sed s/\-latest$//)" export IMAGE_SUFFIX="latest" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36258?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8eb3f4fdfe54268d3b623d88c8746f5395ba509d Gerrit-Change-Number: 36258 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

[M] Change in ...osmo-epdg[master]: aaa_diameter_swm: Look up aaa_ue_fsm process each time it needs to be...

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36231?usp=email ) Change subject: aaa_diameter_swm: Look up aaa_ue_fsm process each time it needs to be accessed ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36231?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ic019d41716284639f6256f7ba24533bf806333b1 Gerrit-Change-Number: 36231 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 13 Mar 2024 08:55:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in ...osmo-epdg[master]: diameter_3gpp_ts29_229.dia: Fix enum Reason-Code not defined

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36226?usp=email ) Change subject: diameter_3gpp_ts29_229.dia: Fix enum Reason-Code not defined ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36226?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I39055e699cfba7b5af70890a22089f7992b2422f Gerrit-Change-Number: 36226 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 13 Mar 2024 08:21:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: bts: rename as_l1_sacch() -> as_l1_sacch_loop()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36255?usp=email ) Change subject: bts: rename as_l1_sacch() -> as_l1_sacch_loop() ...................................................................... bts: rename as_l1_sacch() -> as_l1_sacch_loop() For the sake of consistency with as_l1_{dcch,tch}_loop(). Change-Id: I076efac80ae08551c1098a6baa15a2ca99213ee2 --- M bts/BTS_Tests.ttcn 1 file changed, 21 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/55/36255/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index cf8e7ed..05a3349 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -781,7 +781,7 @@ [] T.timeout { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout expecting " & id); } - [not ignore_other] as_l1_sacch(); + [not ignore_other] as_l1_sacch_loop(); [not ignore_other] as_meas_res(); [not ignore_other] as_l1_dcch_loop(); [not ignore_other] as_l1_tch_loop(); @@ -2166,7 +2166,7 @@ } /* handle incoming downlink SACCH and respond with uplink SACCH (meas res) */ -private altstep as_l1_sacch() runs on ConnHdlr { +private altstep as_l1_sacch_loop() runs on ConnHdlr { var template (value) LapdmFrameAB lb; var L1ctlMessage l1_dl; @@ -2741,7 +2741,7 @@ timer T := 8.0; T.start; alt { - [] as_l1_sacch(); + [] as_l1_sacch_loop(); [] as_meas_res(); [] as_l1_dcch_loop(); [] as_l1_tch_loop(); @@ -3039,7 +3039,7 @@ T.start; var RSL_Message rsl; alt { - [] as_l1_sacch(); + [] as_l1_sacch_loop(); [] L1CTL.receive { repeat; } [] RSL.receive(tr_RSL_MEAS_RES(g_chan_nr, ?, ?, ?)) -> value rsl { if (rsl.ies[3].body.bs_power.power_level == level) { @@ -8290,7 +8290,7 @@ [] L1CTL.receive(tr_L1CTL_TRAFFIC_IND(g_chan_nr)) -> value l1_dl { setverdict(fail, "Rx unexpected TRAFFIC.ind: ", l1_dl); } - [] as_l1_sacch(); + [] as_l1_sacch_loop(); [] T.timeout { setverdict(fail, "Timeout waiting for TRAFFIC.ind"); } @@ -8404,7 +8404,7 @@ "expected (", payload, ")"); Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } - [] as_l1_sacch(); + [] as_l1_sacch_loop(); [] L1CTL.receive { repeat; } [] Td.timeout { setverdict(fail, "Timeout waiting for Downlink speech frames"); @@ -8417,7 +8417,7 @@ Tu.start(2.0); alt { [] as_l1_tch_loop(); - [] as_l1_sacch(); + [] as_l1_sacch_loop(); [] RTPEM_DATA.receive(PDU_RTP:?) -> value rtp_pdu { if (rtp_pdu.data != payload) { repeat; } @@ -8522,7 +8522,7 @@ "expected (", exp_rtp_pl, ")"); Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } - [] as_l1_sacch(); + [] as_l1_sacch_loop(); [] L1CTL.receive { repeat; } [] Td.timeout { setverdict(fail, "Timeout waiting for Downlink speech frames"); @@ -8538,7 +8538,7 @@ Tu.start(2.0); alt { [] as_l1_tch_loop(); - [] as_l1_sacch(); + [] as_l1_sacch_loop(); [] OsmuxEM_DATA.receive(osmux_pdu_exp) -> value osmux_pdu { var boolean matched := false; for (var integer i := 0; i < osmux_pdu.osmux_amr.header.ctr + 1; i := i + 1) { @@ -8659,7 +8659,7 @@ log("FACCH received: ", ddata); repeat; } - [] as_l1_sacch(); + [] as_l1_sacch_loop(); [] L1CTL.receive { repeat; } [] Td.timeout { setverdict(fail, "Timeout waiting for matching Downlink data frame"); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36255?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I076efac80ae08551c1098a6baa15a2ca99213ee2 Gerrit-Change-Number: 36255 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library: add templates for L1CTL_{DATA,TRAFFIC}_CONF

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36254?usp=email ) Change subject: library: add templates for L1CTL_{DATA,TRAFFIC}_CONF ...................................................................... library: add templates for L1CTL_{DATA,TRAFFIC}_CONF Change-Id: I914555ac8bf2784c14e1b5564b116221ecc7b539 --- M library/L1CTL_Types.ttcn 1 file changed, 67 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/54/36254/1 diff --git a/library/L1CTL_Types.ttcn b/library/L1CTL_Types.ttcn index 7571b4f..b977a7d 100644 --- a/library/L1CTL_Types.ttcn +++ b/library/L1CTL_Types.ttcn @@ -836,6 +836,64 @@ } }; + /* for sending and matching L1CTL_DATA_CONF */ + template (value) L1ctlMessage + ts_L1CTL_DATA_CONF(template (value) RslChannelNr chan_nr, + template (value) RslLinkId link_id, + template (value) GsmBandArfcn arfcn, + template (value) GsmFrameNumber fn) := { + header := ts_L1ctlHeader(L1CTL_DATA_CONF), + ul_info := omit, + dl_info := { + chan_nr := chan_nr, + link_id := link_id, + arfcn := arfcn, + frame_nr := fn, + rx_level := 0, + snr := 0, + num_biterr := 0, + fire_crc := 0 + }, + payload := omit + }; + template L1ctlMessage + tr_L1CTL_DATA_CONF(template (present) RslChannelNr chan_nr, + template (present) RslLinkId link_id := ?, + template (present) GsmBandArfcn arfcn := ?, + template (present) GsmFrameNumber fn := ?) := { + header := tr_L1ctlHeader(L1CTL_DATA_CONF), + ul_info := omit, + dl_info := { + chan_nr := chan_nr, + link_id := link_id, + arfcn := arfcn, + frame_nr := fn, + rx_level := ?, + snr := ?, + num_biterr := ?, + fire_crc := ? + }, + payload := omit + }; + + /* for sending and matching L1CTL_TRAFFIC_CONF */ + template (value) L1ctlMessage + ts_L1CTL_TRAFFIC_CONF(template (value) RslChannelNr chan_nr, + template (value) RslLinkId link_id, + template (value) GsmBandArfcn arfcn, + template (value) GsmFrameNumber fn) + modifies ts_L1CTL_DATA_CONF := { + header := ts_L1ctlHeader(L1CTL_TRAFFIC_CONF) + }; + template L1ctlMessage + tr_L1CTL_TRAFFIC_CONF(template (present) RslChannelNr chan_nr, + template (present) RslLinkId link_id := ?, + template (present) GsmBandArfcn arfcn := ?, + template (present) GsmFrameNumber fn := ?) + modifies tr_L1CTL_DATA_CONF := { + header := tr_L1ctlHeader(L1CTL_TRAFFIC_CONF) + }; + /* for matching against incoming TRAFFIC_IND */ template L1ctlMessage tr_L1CTL_TRAFFIC_IND(template (present) RslChannelNr chan_nr, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36254?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I914555ac8bf2784c14e1b5564b116221ecc7b539 Gerrit-Change-Number: 36254 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: bts: dequeue L1CTL {DATA,TRAFFIC}.cnf in as_l1_{sacch,dcch,tcp}_loop()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36256?usp=email ) Change subject: bts: dequeue L1CTL {DATA,TRAFFIC}.cnf in as_l1_{sacch,dcch,tcp}_loop() ...................................................................... bts: dequeue L1CTL {DATA,TRAFFIC}.cnf in as_l1_{sacch,dcch,tcp}_loop() This fixes sporadic failures in testcases using those altsteps. Change-Id: I3538d40ff1a585ccbe37f3a90f3c374c5f0b5767 Related: osmocom-bb.git I0046f9c103bcb9207f0c2643c6a806bd56553d77 --- M bts/BTS_Tests.ttcn 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/56/36256/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 05a3349..0103bbc 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -2190,6 +2190,8 @@ L1CTL.send(ts_L1CTL_DATA_REQ_SACCH(g_chan_nr, ts_RslLinkID_SACCH(0), l1h, l2)); repeat; } + /* dequeue (ignore) L1CTL DATA.cnf for UL SACCH (SAPI=0) */ + [] L1CTL.receive(tr_L1CTL_DATA_CONF(g_chan_nr, tr_RslLinkID_SACCH(0))) { repeat; } } /* handle incoming downlink SACCH, decode the L1 header into the given record */ @@ -2220,6 +2222,8 @@ f_pad_oct(pl, 23, '2B'O))); repeat; } + /* dequeue (ignore) L1CTL DATA.cnf for UL DCCH (SAPI=0) */ + [] L1CTL.receive(tr_L1CTL_DATA_CONF(g_chan_nr, tr_RslLinkID_DCCH(0))) { repeat; } } private altstep as_l1_tch_loop() runs on ConnHdlr { @@ -2240,6 +2244,8 @@ repeat; } + /* dequeue (ignore) L1CTL TRAFFIC.cnf for UL TCH */ + [] L1CTL.receive(tr_L1CTL_TRAFFIC_CONF(g_chan_nr, tr_RslLinkID_DCCH(0))) { repeat; } } private type record MeasElem { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36256?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3538d40ff1a585ccbe37f3a90f3c374c5f0b5767 Gerrit-Change-Number: 36256 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: bts: also test TCH/A[FH]S in TC_speech_no_rtp_tch[fh]

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36257?usp=email ) Change subject: bts: also test TCH/A[FH]S in TC_speech_no_rtp_tch[fh] ...................................................................... bts: also test TCH/A[FH]S in TC_speech_no_rtp_tch[fh] Change-Id: I3c7f91034079169c40c4f20966d9f5fb7c855b27 Related: OS#4823, OS#6049 --- M bts/BTS_Tests.ttcn 1 file changed, 20 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/57/36257/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 0103bbc..29879b9 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -8323,8 +8323,11 @@ vc_conn := f_start_handler(refers(f_TC_speech_no_rtp), pars); vc_conn.done; - /* TODO: we don't know what's the expected behavior for TCH/AFS, so we don't test it here. - * Current osmo-bts is sending FACCH/F with dummy LAPDm func=UI frames. */ + /* TS1, TCH/F, V3 (AMR codec) */ + pars := valueof(t_Pars(ts_RslChanNr_Bm(1), ts_RSL_ChanMode(RSL_CHRT_TCH_F, RSL_CMOD_SP_GSM3))); + pars.mr_conf := valueof(ts_RSL_MultirateCfg); + vc_conn := f_start_handler(refers(f_TC_speech_no_rtp), pars); + vc_conn.done; Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } @@ -8339,8 +8342,11 @@ vc_conn := f_start_handler(refers(f_TC_speech_no_rtp), pars); vc_conn.done; - /* TODO: we don't know what's the expected behavior for TCH/AHS, so we don't test it here. - * Current osmo-bts is sending FACCH/H with dummy LAPDm func=UI frames (whenever possible). */ + /* TS5, TCH/H, V3 (AMR codec) */ + pars := valueof(t_Pars(ts_RslChanNr_Lm(5, 0), ts_RSL_ChanMode(RSL_CHRT_TCH_H, RSL_CMOD_SP_GSM3))); + pars.mr_conf := valueof(ts_RSL_MultirateCfg); + vc_conn := f_start_handler(refers(f_TC_speech_no_rtp), pars); + vc_conn.done; Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36257?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3c7f91034079169c40c4f20966d9f5fb7c855b27 Gerrit-Change-Number: 36257 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

[S] Change in osmocom-bb[master]: trxcon: fix hex formatting in prim_enqeue()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/36252?usp=email ) Change subject: trxcon: fix hex formatting in prim_enqeue() ...................................................................... trxcon: fix hex formatting in prim_enqeue() Change-Id: I78c310bd9cc5d69bbeca575ebf4a480f16971e93 --- M src/host/trxcon/src/sched_prim.c 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/52/36252/1 diff --git a/src/host/trxcon/src/sched_prim.c b/src/host/trxcon/src/sched_prim.c index 1baa125..111c5f1 100644 --- a/src/host/trxcon/src/sched_prim.c +++ b/src/host/trxcon/src/sched_prim.c @@ -368,7 +368,7 @@ if (OSMO_UNLIKELY(lchan == NULL || !lchan->active)) { LOGP_SCHEDD(sched, LOGL_ERROR, "No [active] lchan for primitive " L1SCHED_PRIM_STR_FMT " " - "(fn=%u, chan_nr=%02x, link_id=%02x, len=%u): %s\n", + "(fn=%u, chan_nr=0x%02x, link_id=0x%02x, len=%u): %s\n", L1SCHED_PRIM_STR_ARGS(prim), chdr->frame_nr, chdr->chan_nr, chdr->link_id, msgb_l2len(msg), msgb_hexdump_l2(msg)); @@ -378,7 +378,7 @@ LOGP_LCHAND(lchan, LOGL_DEBUG, "Enqueue primitive " L1SCHED_PRIM_STR_FMT " " - "(fn=%u, chan_nr=%02x, link_id=%02x, len=%u): %s\n", + "(fn=%u, chan_nr=0x%02x, link_id=0x%02x, len=%u): %s\n", L1SCHED_PRIM_STR_ARGS(prim), chdr->frame_nr, chdr->chan_nr, chdr->link_id, msgb_l2len(msg), msgb_hexdump_l2(msg)); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/36252?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I78c310bd9cc5d69bbeca575ebf4a480f16971e93 Gerrit-Change-Number: 36252 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

[S] Change in osmocom-bb[master]: trxcon: fix prim_compose_mr(): indicate proper tn

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/36253?usp=email ) Change subject: trxcon: fix prim_compose_mr(): indicate proper tn ...................................................................... trxcon: fix prim_compose_mr(): indicate proper tn Change-Id: I0046f9c103bcb9207f0c2643c6a806bd56553d77 --- M src/host/trxcon/src/sched_prim.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/53/36253/1 diff --git a/src/host/trxcon/src/sched_prim.c b/src/host/trxcon/src/sched_prim.c index 111c5f1..67be75e 100644 --- a/src/host/trxcon/src/sched_prim.c +++ b/src/host/trxcon/src/sched_prim.c @@ -94,7 +94,7 @@ prim = l1sched_prim_from_msgb(msg); prim->data_req = (struct l1sched_prim_chdr) { - .chan_nr = l1sched_lchan_desc[lchan->type].chan_nr, + .chan_nr = l1sched_lchan_desc[lchan->type].chan_nr | lchan->ts->index, .link_id = L1SCHED_CH_LID_SACCH, }; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/36253?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0046f9c103bcb9207f0c2643c6a806bd56553d77 Gerrit-Change-Number: 36253 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2024