March 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-gsm-manuals[master]: gsup: Document ePDG Tunnel Req/Res/Err

by fixeria

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/36276?usp=email ) Change subject: gsup: Document ePDG Tunnel Req/Res/Err ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/36276?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I9d98d0fbb2d4d006bc980b40828ea38f358d7108 Gerrit-Change-Number: 36276 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 14 Mar 2024 18:05:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in osmo-gsm-manuals[master]: gsup: Document ePDG Tunnel Req/Res/Err

by laforge

Attention is currently required from: fixeria, lynxis lazus, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/36276?usp=email ) Change subject: gsup: Document ePDG Tunnel Req/Res/Err ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/36276?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I9d98d0fbb2d4d006bc980b40828ea38f358d7108 Gerrit-Change-Number: 36276 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 14 Mar 2024 18:03:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in libosmo-abis[rel-1.4.2]: [cosmetic] input/ipaccess.c: We use tab indent, not spaces [wtf]

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/36286?usp=email ) Change subject: [cosmetic] input/ipaccess.c: We use tab indent, not spaces [wtf] ...................................................................... [cosmetic] input/ipaccess.c: We use tab indent, not spaces [wtf] Change-Id: I6ba728ccf7f6d81dc42d1ff82a29b557752e80ba (cherry picked from commit 361488f83f2cd721bc735ad65936320b2571590b) --- M src/input/ipaccess.c 1 file changed, 20 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/86/36286/1 diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index 418606e..4f6353b 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -639,15 +639,15 @@ LOGP(DLINP, LOGL_ERROR, "Failed to set keepalive count: %s\n", strerror(errno)); - val = 1000 * line->keepalive_num_probes * - line->keepalive_probe_interval + - line->keepalive_idle_timeout; - ret = setsockopt(fd, IPPROTO_TCP, TCP_USER_TIMEOUT, - &val, sizeof(val)); - if (ret < 0) + val = 1000 * line->keepalive_num_probes * + line->keepalive_probe_interval + + line->keepalive_idle_timeout; + ret = setsockopt(fd, IPPROTO_TCP, TCP_USER_TIMEOUT, + &val, sizeof(val)); + if (ret < 0) LOGP(DLINP, LOGL_ERROR, - "Failed to set user timoeut: %s\n", - strerror(errno)); + "Failed to set user timoeut: %s\n", + strerror(errno)); } val = 1; @@ -718,8 +718,8 @@ struct osmo_fd *bfd; int i, ret; - /* We don't know yet which OML link to associate it with. Thus, we - * allocate a temporary E1 line until we have received ID. */ + /* We don't know yet which OML link to associate it with. Thus, we + * allocate a temporary E1 line until we have received ID. */ line = e1inp_line_clone(tall_ipa_ctx, link->line, "ipa_bfd"); if (line == NULL) { LOGP(DLINP, LOGL_ERROR, "could not clone E1 line\n"); -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36286?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: rel-1.4.2 Gerrit-Change-Id: I6ba728ccf7f6d81dc42d1ff82a29b557752e80ba Gerrit-Change-Number: 36286 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

[S] Change in libosmo-abis[rel-1.4.2]: input/ipaccess: Make sure to say "TCP keepalive"

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/36277?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: input/ipaccess: Make sure to say "TCP keepalive" ...................................................................... input/ipaccess: Make sure to say "TCP keepalive" We have TCP and IPA keepalive. Reading a message like "input/ipaccess.c:612 Keepalive is set: 0" is misleading, as one might assume it relates to IPA. Be explicit. Related: SYS#6801, OS#6375 Change-Id: I01cbda27eb7826eb11f44e034d746b7c39b399a4 (cherry picked from commit 715653778c33e31980452de86029720735cdcf4a) --- M src/input/ipaccess.c 1 file changed, 32 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/77/36277/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36277?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: rel-1.4.2 Gerrit-Change-Id: I01cbda27eb7826eb11f44e034d746b7c39b399a4 Gerrit-Change-Number: 36277 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 5 months

1
0
0 0

[S] Change in libosmo-abis[rel-1.4.2]: Bump version: 1.4.1.3-b8a4 → 1.4.2

by fixeria

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/36279?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Bump version: 1.4.1.3-b8a4 → 1.4.2 ...................................................................... Bump version: 1.4.1.3-b8a4 → 1.4.2 Change-Id: I9072cd5c89d2deb0eb75f47c8fd04ad175549e41 --- M debian/changelog M src/Makefile.am 2 files changed, 19 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/79/36279/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36279?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: rel-1.4.2 Gerrit-Change-Id: I9072cd5c89d2deb0eb75f47c8fd04ad175549e41 Gerrit-Change-Number: 36279 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 year, 5 months

1
0
0 0

[M] Change in libosmo-abis[rel-1.4.2]: Fix critical bug in default TCP keepalive user timeout

by fixeria

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/36278?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Fix critical bug in default TCP keepalive user timeout ...................................................................... Fix critical bug in default TCP keepalive user timeout It turns out that our calculation of the TCP_USER_TIMEOUT value was flawed in several ways: * there should have been parenthesis around the + operator (line->keepalive_probe_interval + line->keepalive_idle_timeout) as the keepalive_idle_timeout is in seconds, not milli-seconds. * in the default case, all those values are configured to -1 (E1INP_USE_DEFAULT). This means we're using 1000 * -1 * -1 + -1 = 999 i.e. just below a second which clearly is not enough for a lossy satellite or wifi back-haul. This fixes a regression introduced in Ia7659c209aea0d26eb37d31e771adc91b17ae668 (libosmo-abis >= 1.4.0) when TCP keepalive user timeouts became enabled by default. The initial support for TCP_USER_TIMEOUT was merged in I5e7425958472aa5d758e09bfbefc7d7d37bf6f5f (libosmo-abis >= 0.7.0) but since TCP keepalives were not yet enabled by default, only users with explicit TCP keepalive configuration in their config files would be affected - and then only of the second part of the bug (operator precedence). In addition, let's print the actually-used values to the log, helping to spot unintended values. Change-Id: Idca24d3e676a45d860d9eec60dc2097d8d87f3bf Related: OS#5785, OS#6375, SYS#6801 Fixes: Ia7659c209aea0d26eb37d31e771adc91b17ae668 (cherry picked from commit 12fae9aeebd86e242abd5c682a12fd1c9da68497) --- M src/input/ipaccess.c 1 file changed, 57 insertions(+), 21 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/78/36278/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36278?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: rel-1.4.2 Gerrit-Change-Id: Idca24d3e676a45d860d9eec60dc2097d8d87f3bf Gerrit-Change-Number: 36278 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 year, 5 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: epdg: Introduce test TC_hss_initiated_update_user_profile(_unknown)

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36285?usp=email ) Change subject: epdg: Introduce test TC_hss_initiated_update_user_profile(_unknown) ...................................................................... epdg: Introduce test TC_hss_initiated_update_user_profile(_unknown) This test so far only validates the SWx interface during the procedure. It can be extended at a later time when implementing propagation of the procedure to other interfaces in osmo-epdg. Related: OS#6042 Change-Id: Ic7c19a3fe7b2b1411414fb6b78ab9a665a1aa42b --- M epdg/EPDG_Tests.ttcn M epdg/expected-results.xml M library/DIAMETER_ts29_273_Templates.ttcn 3 files changed, 147 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/85/36285/1 diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn index bc4219b..1742fd7 100644 --- a/epdg/EPDG_Tests.ttcn +++ b/epdg/EPDG_Tests.ttcn @@ -471,6 +471,32 @@ } } +/* Send PPR as HSS to AAA server, expect back PPA */ +private function f_DIA_SWx_PP(template (present) GenericAVP exp_result_tmpl := tr_AVP_ResultCode(DIAMETER_SUCCESS)) runs on EPDG_ConnHdlr { + var PDU_DIAMETER rx_dia; + var UINT32 hbh_id := f_rnd_octstring(4); + var UINT32 ete_id := f_rnd_octstring(4); + var octetstring reason_info := char2oct("test"); + + /* Unlike PPR, PPA contains no IMSI. Register ete_id in DIAMETER_Emulation, + * so PPA is forwarded back to us in DIAMETER port instead of MTC_CT.DIAMETER_UNIT. + */ + f_epdg_connhldr_SWx_expect_eteid(ete_id); + + SWx.send(ts_DIA_SWx_PPR(g_pars.imsi, + IPv4, + g_pars.apn, + hbh_id := hbh_id, + ete_id := ete_id)); + + alt { + [] SWx.receive(tr_DIA_SWx_PPA(exp_result_tmpl, hbh_id := hbh_id, ete_id := ete_id)) -> value rx_dia {} + [] SWx.receive(PDU_DIAMETER:?) -> value rx_dia { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Unexpected Diameter SWx msg rx: ", rx_dia)); + } + } +} + /* Send RTR as HSS to AAA server, expect back RTA */ private function f_DIA_SWx_RT(template (value) CxDx_3GPP_Reason_Code reason_code, template (present) GenericAVP exp_result_tmpl := tr_AVP_ResultCode(DIAMETER_SUCCESS), @@ -1138,6 +1164,41 @@ setverdict(pass); } +/* + * 3GPP TS 29.273 8.1.2.3 HSS Initiated Update of User Profile + * 3GPP TS 29.273 8.2.2.2 HSS Initiated Update of User Profile Procedure + */ +private function f_TC_hss_initiated_update_user_profile(charstring id) runs on EPDG_ConnHdlr { + f_initial_attach(); + /* Procedure should be performed properly: */ + f_DIA_SWx_PP(tr_AVP_ResultCode(DIAMETER_SUCCESS)); +} +testcase TC_hss_initiated_update_user_profile() runs on MTC_CT { + var EPDG_ConnHdlrPars pars := f_init_pars(); + var EPDG_ConnHdlr vc_conn; + f_init(); + vc_conn := f_start_handler(refers(f_TC_hss_initiated_update_user_profile), pars); + vc_conn.done; + setverdict(pass); +} + +/* + * Same as TC_hss_initiated_update_user_profile_unknown, but without registering + * subscriber first, so expect DIAMETER_ERROR_USER_UNKNOWN in answer. + */ +private function f_TC_hss_initiated_update_user_profile_unknown(charstring id) runs on EPDG_ConnHdlr { + var DIAMETER_ts29_229_ExperimentalResultcode erc := DIAMETER_ERROR_USER_UNKNOWN; + f_DIA_SWx_PP(tr_AVP_ExperimentalResult(vendor_id_3GPP, int2oct(enum2int(erc), 4))); +} +testcase TC_hss_initiated_update_user_profile_unknown() runs on MTC_CT { + var EPDG_ConnHdlrPars pars := f_init_pars(); + var EPDG_ConnHdlr vc_conn; + f_init(); + vc_conn := f_start_handler(refers(f_TC_hss_initiated_update_user_profile_unknown), pars); + vc_conn.done; + setverdict(pass); +} + private function f_TC_concurrent_ues(charstring id) runs on EPDG_ConnHdlr { COORD.send(COORD_CMD_READY); COORD.receive(COORD_CMD_START); @@ -1236,6 +1297,8 @@ execute ( TC_s2b_CreateSession_rejected() ); execute ( TC_hss_initiated_deregister_new_server_assigned() ); execute ( TC_hss_initiated_deregister_permanent_termination() ); + execute ( TC_hss_initiated_update_user_profile() ); + execute ( TC_hss_initiated_update_user_profile_unknown() ); execute ( TC_concurrent_ues2() ); execute ( TC_concurrent_ues100() ); execute ( TC_upf_echo_req() ); diff --git a/epdg/expected-results.xml b/epdg/expected-results.xml index ccc69cb..83155cd 100644 --- a/epdg/expected-results.xml +++ b/epdg/expected-results.xml @@ -9,6 +9,8 @@ <testcase classname='EPDG_Tests' name='TC_s2b_CreateSession_rejected' time='MASKED'/> <testcase classname='EPDG_Tests' name='TC_hss_initiated_deregister_new_server_assigned' time='MASKED'/> <testcase classname='EPDG_Tests' name='TC_hss_initiated_deregister_permanent_termination' time='MASKED'/> + <testcase classname='EPDG_Tests' name='TC_hss_initiated_update_user_profile' time='MASKED'/> + <testcase classname='EPDG_Tests' name='TC_hss_initiated_update_user_profile_unknown' time='MASKED'/> <testcase classname='EPDG_Tests' name='TC_concurrent_ues2' time='MASKED'/> <testcase classname='EPDG_Tests' name='TC_concurrent_ues100' time='MASKED'/> <testcase classname='EPDG_Tests' name='TC_upf_echo_req' time='MASKED'/> diff --git a/library/DIAMETER_ts29_273_Templates.ttcn b/library/DIAMETER_ts29_273_Templates.ttcn index e1a0700..dcb5a31 100644 --- a/library/DIAMETER_ts29_273_Templates.ttcn +++ b/library/DIAMETER_ts29_273_Templates.ttcn @@ -205,6 +205,74 @@ ts_AVP_UserNameImsi(valueof(imsi)) }); +/* Push-Profile-Request, + * 3GPP TS 29.273 8.1.2.3 HSS Initiated Update of User Profile + * 3GPP TS 29.273 8.2.2.2 HSS Initiated Update of User Profile Procedure + */ +template (value) PDU_DIAMETER +ts_DIA_SWx_PPR(template (value) hexstring imsi, + template (value) AAA_3GPP_PDN_Type pdn_type, + template (value) charstring apn, + template (value) uint32_t vendor_app_id := c_DIAMETER_3GPP_SWx_AID, + template (value) octetstring sess_id := c_def_sess_id, + template (value) charstring orig_host := "hss.localdomain", + template (value) charstring orig_realm := "localdomain", + template (value) charstring dest_host := "aaa.localdomain", + template (value) charstring dest_realm := "localdomain", + template (value) UINT32 hbh_id := '00000000'O, + template (value) UINT32 ete_id := '00000000'O) := + ts_DIAMETER(flags := '11000000'B, + cmd_code := Push_Profile, + app_id := int2oct(c_DIAMETER_3GPP_SWx_AID, 4), + hbh_id := hbh_id, + ete_id := ete_id, + avps := { + ts_AVP_SessionId(sess_id), + ts_AVP_VendorSpecAppId(vendor_id_3GPP, valueof(vendor_app_id)), + ts_AVP_AuthSessionState(NO_STATE_MAINTAINED), + ts_AVP_OriginHost(orig_host), + ts_AVP_OriginRealm(orig_realm), + ts_AVP_DestinationHost(dest_host), + ts_AVP_DestinationRealm(dest_realm), + ts_AVP_UserNameImsi(imsi), + ts_AVP_3GPP_Non_3GPP_User_Data(pdn_type, apn) + /* Optional: PPR-Flags */ + /* TODO: + * *[ Supported-Features ] + */ + }); + +/* Push-Profile-Answer, + * 3GPP TS 29.273 8.1.2.3 HSS Initiated Update of User Profile + * 3GPP TS 29.273 8.2.2.2 HSS Initiated Update of User Profile Procedure + */ +template (present) PDU_DIAMETER +tr_DIA_SWx_PPA(template (present) GenericAVP tmpl_result := ?, + template (present) octetstring sess_id := ?, + template (present) charstring orig_host := ?, + template (present) charstring orig_realm := ?, + template (present) charstring dest_host := ?, + template (present) charstring dest_realm := ?, + template (present) UINT32 hbh_id := ?, + template (present) UINT32 ete_id := ?) := + tr_DIAMETER(flags := '0???????'B, + cmd_code := Push_Profile, + app_id := int2oct(c_DIAMETER_3GPP_SWx_AID, 4), + hbh_id := hbh_id, ete_id := ete_id, + avps := superset( + tr_AVP_SessionId(sess_id), + tr_AVP_VendorSpecAppId(?, ?), + tmpl_result, + tr_AVP_AuthSessionState(NO_STATE_MAINTAINED), + tr_AVP_OriginHost(orig_host), + tr_AVP_OriginRealm(orig_realm) + /* Optional: + * [ Access-Network-Info ] + * [ Local-Time-Zone ] + * *[ Supported-Features ] + */ + )); + /* Server-Assignment-Request, * 3GPP TS 29.273 8.1.2.2.2 UE/PDN Registration/DeRegistration Notification * 3GPP TS 29.273 8.2.2.3 Non-3GPP IP Access Registration Procedure */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36285?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic7c19a3fe7b2b1411414fb6b78ab9a665a1aa42b Gerrit-Change-Number: 36285 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

[M] Change in ...osmo-epdg[master]: SWx: Answer PPR with PPA

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36284?usp=email ) Change subject: SWx: Answer PPR with PPA ...................................................................... SWx: Answer PPR with PPA The whole propagation of the update procedure is left as TODO for the future, but let's at least answer to it instead of crashing. Related: OS#6042 Change-Id: I8070728099af7d650c40d17104d1af4883d83972 --- M src/aaa_diameter_swx_cb.erl 1 file changed, 50 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/84/36284/1 diff --git a/src/aaa_diameter_swx_cb.erl b/src/aaa_diameter_swx_cb.erl index 5f5b72f..93335a2 100644 --- a/src/aaa_diameter_swx_cb.erl +++ b/src/aaa_diameter_swx_cb.erl @@ -70,6 +70,43 @@ %% handle_request/3 +%% 3GPP TS 29.273 8.2.2.2 HSS Initiated Update of User Profile Procedure +handle_request(#diameter_packet{msg = Req, errors = []}, _SvcName, {_, Caps}) when is_record(Req, 'PPR') -> + lager:info("SWx Rx PPR from ~p: ~p~n", [Caps, Req]), + #diameter_caps{origin_host = {OH,_}, origin_realm = {OR,_}} = Caps, + #'PPR'{'Session-Id' = SessionId, + 'Vendor-Specific-Application-Id' = VendorAppId, + 'Auth-Session-State' = AuthSessState, + 'User-Name' = Imsi, + 'Non-3GPP-User-Data' = N3UAopt} = Req, + case aaa_ue_fsm:get_pid_by_imsi(Imsi) of + Pid when is_pid(Pid) -> + _PGWAddresses = parse_pgw_addr_from_N3UA(N3UAopt), + %% TODO: in successful case, we want to validate how this prcoedure extends to other interfaces: + %% """ 3GPP TS 29.273 8.1.2.3.3: + %% After a successful user profile download, the 3GPP AAA Server shall + %% initiate re-authentication procedure as described + %% in clause 7.2.2.4 if the subscriber has previously been authenticated + %% and authorized to untrusted non-3GPP access. + %% """ + Res = 2001, %% Success + ERes = []; + undefined -> + Res = [], + %% TS 29.229 6.2.2.1 DIAMETER_ERROR_USER_UNKNOWN + ERes = #'Experimental-Result'{'Vendor-Id' = ?VENDOR_ID_3GPP, + 'Experimental-Result-Code' = 5001} + end, + Resp = #'PPA'{'Session-Id' = SessionId, + 'Vendor-Specific-Application-Id' = VendorAppId, + 'Result-Code' = Res, + 'Experimental-Result' = ERes, + 'Auth-Session-State' = AuthSessState, + 'Origin-Host' = OH, + 'Origin-Realm' = OR}, + lager:info("SWx Tx to ~p: ~p~n", [Caps, Resp]), + {reply, Resp}; + %% 3GPP TS 29.273 8.2.2.4 Network Initiated De-Registration by HSS Procedure handle_request(#diameter_packet{msg = Req, errors = []}, _SvcName, {_, Caps}) when is_record(Req, 'RTR') -> lager:info("SWx Rx RTR from ~p: ~p~n", [Caps, Req]), -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36284?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I8070728099af7d650c40d17104d1af4883d83972 Gerrit-Change-Number: 36284 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

[S] Change in libosmo-abis[rel-1.5.2]: Bump version: 1.5.1.3-0eed → 1.5.2

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/36283?usp=email ) Change subject: Bump version: 1.5.1.3-0eed → 1.5.2 ...................................................................... Bump version: 1.5.1.3-0eed → 1.5.2 Change-Id: I307eac0e6d5f68e356250b1bea289645693073e4 --- M debian/changelog M src/Makefile.am 2 files changed, 19 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/83/36283/1 diff --git a/debian/changelog b/debian/changelog index 37f214f..1a3ec80 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,12 @@ +libosmo-abis (1.5.2) unstable; urgency=medium + + [ Harald Welte ] + * [cosmetic] input/ipaccess.c: We use tab indent, not spaces [wtf] + * input/ipaccess: Make sure to say "TCP keepalive" + * Fix critical bug in default TCP keepalive user timeout + + -- Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> Fri, 15 Mar 2024 00:32:06 +0700 + libosmo-abis (1.5.1) unstable; urgency=medium [ Harald Welte ] diff --git a/src/Makefile.am b/src/Makefile.am index 927d63f..0ef418c 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html -ABIS_LIBVERSION=13:1:0 +ABIS_LIBVERSION=13:2:0 TRAU_LIBVERSION=9:1:7 AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_builddir) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36283?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: rel-1.5.2 Gerrit-Change-Id: I307eac0e6d5f68e356250b1bea289645693073e4 Gerrit-Change-Number: 36283 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

[S] Change in libosmo-abis[rel-1.5.2]: [cosmetic] input/ipaccess.c: We use tab indent, not spaces [wtf]

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/36280?usp=email ) Change subject: [cosmetic] input/ipaccess.c: We use tab indent, not spaces [wtf] ...................................................................... [cosmetic] input/ipaccess.c: We use tab indent, not spaces [wtf] Change-Id: I6ba728ccf7f6d81dc42d1ff82a29b557752e80ba (cherry picked from commit 361488f83f2cd721bc735ad65936320b2571590b) --- M src/input/ipaccess.c 1 file changed, 20 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/80/36280/1 diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index 48a1d40..d63c0d2 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -639,15 +639,15 @@ LOGP(DLINP, LOGL_ERROR, "Failed to set keepalive count: %s\n", strerror(errno)); - val = 1000 * line->keepalive_num_probes * - line->keepalive_probe_interval + - line->keepalive_idle_timeout; - ret = setsockopt(fd, IPPROTO_TCP, TCP_USER_TIMEOUT, - &val, sizeof(val)); - if (ret < 0) + val = 1000 * line->keepalive_num_probes * + line->keepalive_probe_interval + + line->keepalive_idle_timeout; + ret = setsockopt(fd, IPPROTO_TCP, TCP_USER_TIMEOUT, + &val, sizeof(val)); + if (ret < 0) LOGP(DLINP, LOGL_ERROR, - "Failed to set user timoeut: %s\n", - strerror(errno)); + "Failed to set user timoeut: %s\n", + strerror(errno)); } val = 1; @@ -718,8 +718,8 @@ struct osmo_fd *bfd; int i, ret; - /* We don't know yet which OML link to associate it with. Thus, we - * allocate a temporary E1 line until we have received ID. */ + /* We don't know yet which OML link to associate it with. Thus, we + * allocate a temporary E1 line until we have received ID. */ line = e1inp_line_clone(tall_ipa_ctx, link->line, "ipa_bfd"); if (line == NULL) { LOGP(DLINP, LOGL_ERROR, "could not clone E1 line\n"); -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36280?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: rel-1.5.2 Gerrit-Change-Id: I6ba728ccf7f6d81dc42d1ff82a29b557752e80ba Gerrit-Change-Number: 36280 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2024