February 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: osmo_io: Add osmo_io_get_ioops() function

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36076?usp=email ) Change subject: osmo_io: Add osmo_io_get_ioops() function ...................................................................... Patch Set 1: (1 comment) File include/osmocom/core/osmo_io.h: https://gerrit.osmocom.org/c/libosmocore/+/36076/comment/4c518b00_3d5c1975 PS1, Line 112: void osmo_iofd_get_ioops(struct osmo_io_fd *iofd, struct osmo_io_ops *ioops); > It may make more sense to return a "const struct osmo_io_ops*" so that no copy is needed by default. […] If you want to make it generic, it would probably be best to decoupple the segmentation callback from the other callbacks, or even all of the callbacks from each other. That way there wouldn't be any shared struct between the lib and applications. Using a const pointer doesn't really guarantee that the user won't be able to modify the instance of the struct used/owned by the library. The user can just type-cast it to non-const and then overwrite library data. The copy avoids that. Regarding struct size: The application and lib already need to agree on this, as the set_io_ops operating also uses that very same struct. So if they need to agree on the "set" side, it is not a problem if the same assumption holds true for the "get" -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36076?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I03398c811b9534f50c6644b21eea89a04be29fb0 Gerrit-Change-Number: 36076 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 Feb 2024 09:14:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library/M3UA: support TCP transport, implement desegmentation

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36098?usp=email ) Change subject: library/M3UA: support TCP transport, implement desegmentation ...................................................................... library/M3UA: support TCP transport, implement desegmentation Change-Id: If1dcdb185d08a08dc5a06c37d9d6ffe7d6da9325 Related: libosmo-sccp.git I8c76d271472befacbeb998a93bbdc9e8660d9b5d Related: SYS#5424 --- M library/M3UA_CodecPort.ttcn M library/M3UA_CodecPort_CtrlFunct.ttcn M library/M3UA_CodecPort_CtrlFunctDef.cc 3 files changed, 48 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/98/36098/1 diff --git a/library/M3UA_CodecPort.ttcn b/library/M3UA_CodecPort.ttcn index 94d16d6..e88b6a0 100644 --- a/library/M3UA_CodecPort.ttcn +++ b/library/M3UA_CodecPort.ttcn @@ -15,6 +15,7 @@ import from IPL4asp_PortType all; import from IPL4asp_Types all; + import from M3UA_CodecPort_CtrlFunct all; import from M3UA_Types all; type record M3UA_RecvFrom { @@ -37,7 +38,7 @@ type record M3UA_Send { ConnectionId connId, - integer stream, + integer stream optional, PDU_M3UA msg } @@ -59,14 +60,18 @@ private function M3UA_to_IPL4_Send(in M3UA_Send pin, out ASP_Send pout) { pout.connId := pin.connId; - pout.proto := { - sctp := { - sinfo_stream := pin.stream, - sinfo_ppid := 3, - remSocks := omit, - assocId := omit - } - }; + if (ispresent(pin.stream)) { + pout.proto := { + sctp := { + sinfo_stream := pin.stream, + sinfo_ppid := 3, + remSocks := omit, + assocId := omit + } + }; + } else { + pout.proto := { tcp := { } }; + } pout.msg := enc_PDU_M3UA(pin.msg); } with { extension "prototype(fast)" }; @@ -80,5 +85,12 @@ in(ASP_RecvFrom -> M3UA_RecvFrom: function(IPL4_to_M3UA_RecvFrom); ASP_ConnId_ReadyToRelease -> ASP_ConnId_ReadyToRelease: simple; ASP_Event -> ASP_Event: simple)" + }; + + function f_set_tcp_segmentation(M3UA_CODEC_PT pt, ConnectionId connId) { + /* Set function for dissecting the binary stream into packets */ + var f_IPL4_getMsgLen vl_f := refers(f_IPL4_fixedMsgLen); + /* Offset: 4, size of length: 4, delta: 0, multiplier: 1, big-endian */ + M3UA_CodecPort_CtrlFunct.f_IPL4_setGetMsgLen(pt, connId, vl_f, {4, 4, 0, 1, 0}); } } diff --git a/library/M3UA_CodecPort_CtrlFunct.ttcn b/library/M3UA_CodecPort_CtrlFunct.ttcn index fc38e43..6f06e2c 100644 --- a/library/M3UA_CodecPort_CtrlFunct.ttcn +++ b/library/M3UA_CodecPort_CtrlFunct.ttcn @@ -40,5 +40,12 @@ out UserData userData ) return Result; + external function f_IPL4_setGetMsgLen( + inout M3UA_CODEC_PT portRef, + in ConnectionId id, + inout f_IPL4_getMsgLen f, + in ro_integer msgLenArgs + ) + } diff --git a/library/M3UA_CodecPort_CtrlFunctDef.cc b/library/M3UA_CodecPort_CtrlFunctDef.cc index 62533de..7ddacdc 100644 --- a/library/M3UA_CodecPort_CtrlFunctDef.cc +++ b/library/M3UA_CodecPort_CtrlFunctDef.cc @@ -51,6 +51,15 @@ { return f__IPL4__PROVIDER__getUserData(portRef, connId, userData); } + + void f__IPL4__setGetMsgLen( + M3UA__CodecPort::M3UA__CODEC__PT& portRef, + const IPL4asp__Types::ConnectionId& connId, + Socket__API__Definitions::f__getMsgLen& f, + const Socket__API__Definitions::ro__integer& msgLenArgs) + { + return f__IPL4__PROVIDER__setGetMsgLen(portRef, connId, f, msgLenArgs); + } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36098?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If1dcdb185d08a08dc5a06c37d9d6ffe7d6da9325 Gerrit-Change-Number: 36098 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 4 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: stp/osmo-stp.cfg: tune the logging formatting

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36097?usp=email ) Change subject: stp/osmo-stp.cfg: tune the logging formatting ...................................................................... stp/osmo-stp.cfg: tune the logging formatting Change-Id: Ieafa0599246f40958be6333512b7c41379b38a20 --- M stp/osmo-stp.cfg 1 file changed, 13 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/97/36097/1 diff --git a/stp/osmo-stp.cfg b/stp/osmo-stp.cfg index 5f67dff..13b1b71 100644 --- a/stp/osmo-stp.cfg +++ b/stp/osmo-stp.cfg @@ -4,11 +4,12 @@ ! log stderr logging filter all 1 - logging color 1 - logging print category-hex 1 + logging print file basename last + logging print category-hex 0 logging print category 1 + logging print level 1 logging timestamp 0 - logging print file 1 + logging color 1 logging level lglobal notice logging level llapd notice logging level linp notice -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36097?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ieafa0599246f40958be6333512b7c41379b38a20 Gerrit-Change-Number: 36097 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 4 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: WIP

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36099?usp=email ) Change subject: WIP ...................................................................... WIP Change-Id: I6dfed05adb332c29404997ea7dc93ec3dabfc43a --- M start-testsuite.sh M stp/STP_Tests.ttcn M stp/STP_Tests_M3UA.ttcn M ttcn3-tcpdump-start.sh M ttcn3-tcpdump-stop.sh 5 files changed, 141 insertions(+), 33 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/99/36099/1 diff --git a/start-testsuite.sh b/start-testsuite.sh index 4b88501..6ffacd2 100755 --- a/start-testsuite.sh +++ b/start-testsuite.sh @@ -50,8 +50,8 @@ ulimit -n 100000 # below is for the debian packages -TTCN3_BIN_DIR="${TTCN3_BIN_DIR:-/usr/bin}" -TITAN_LIBRARY_PATH="${TITAN_LIBRARY_PATH:-/usr/lib/titan:/usr/ttcn3/lib}" +TTCN3_BIN_DIR="${TTCN3_DIR}/bin" +TITAN_LIBRARY_PATH="${TTCN3_DIR}/lib" LD_LIBRARY_PATH="$LD_LIBRARY_PATH:$SUITE_DIR:$TITAN_LIBRARY_PATH" "$TTCN3_BIN_DIR/ttcn3_start" $SUITE $CFG $TEST expected="$SUITE_DIR/expected-results.xml" diff --git a/stp/STP_Tests.ttcn b/stp/STP_Tests.ttcn index e2e5336..8c6a065 100644 --- a/stp/STP_Tests.ttcn +++ b/stp/STP_Tests.ttcn @@ -60,6 +60,34 @@ } } +/* Test routing of SCCP between an M3UA-o-SCTP and an M3UA-o-TCP */ +testcase TC_m3ua_tcp() runs on IPA_M3UA_CT { + var OCT4 rctx_sender := int2oct(1023, 4); + var OCT4 pc_sender := int2oct(23, 4); + var OCT4 pc_receiver := int2oct(5, 4); + + f_init_m3ua(); + f_init_ipa(); + + f_connect_ipa(3); + f_M3UA_asp_up_act(0, omit, omit); // TODO: rctx + + /* send a well-formed, encoded SCCP message via M3UA */ + var octetstring data := f_rnd_octstring_rnd_len(100); + var SCCP_PAR_Address called := valueof(ts_SccpAddr_GT('1234'H)); + var SCCP_PAR_Address calling := valueof(ts_SccpAddr_GT('5678'H)); + var PDU_SCCP sccp := valueof(ts_SCCP_UDT(called, calling, data)); + var octetstring sccp_enc := enc_PDU_SCCP(sccp); + var template (value) M3UA_Protocol_Data tx_pd; + tx_pd := ts_M3UA_protocol_data(pc_sender, pc_receiver, c_M3UA_SI_SCCP, '00'O, '00'O, '00'O, sccp_enc); + f_M3UA_send(0, ts_M3UA_DATA(rctx_sender, tx_pd), 1); + + /* expect to receive it via IPA */ + // f_IPA_exp(3, sccp_enc); + + f_clear_m3ua(); +} + /* Test routing of SCCP between an M3UA and an IPA ASP */ testcase TC_m3ua_to_ipa() runs on IPA_M3UA_CT { var OCT4 rctx_sender := int2oct(1023, 4); diff --git a/stp/STP_Tests_M3UA.ttcn b/stp/STP_Tests_M3UA.ttcn index 5af894a..8592d4a 100644 --- a/stp/STP_Tests_M3UA.ttcn +++ b/stp/STP_Tests_M3UA.ttcn @@ -45,41 +45,47 @@ M3uaConfigs mp_m3ua_configs := { /* as-sender: One ASP within AS */ { - remote_sctp_port := 2905, - local_sctp_port := 9999, + use_tcp := false, + remote_port := 2905, + local_port := 9999, point_code := 23, routing_ctx := 1023 }, /* as-receiver: Two ASP within AS */ { - remote_sctp_port := 2905, - local_sctp_port := 10000, + use_tcp := false, + remote_port := 2905, + local_port := 10000, point_code := 42, routing_ctx := 1042 }, { - remote_sctp_port := 2905, - local_sctp_port := 10001, + use_tcp := false, + remote_port := 2905, + local_port := 10001, point_code := 42, routing_ctx := 1042 }, /* as-client: One ASP within AS */ { - remote_sctp_port := 2906, - local_sctp_port := 10002, + use_tcp := false, + remote_port := 2906, + local_port := 10002, point_code := 55, routing_ctx := 1055 }, /* as-client60-norctx */ { - remote_sctp_port := 2907, - local_sctp_port := 11060, + use_tcp := false, + remote_port := 2907, + local_port := 11060, point_code := 60, routing_ctx := - }, /* as-client61-norctx */ { - remote_sctp_port := 2907, - local_sctp_port := 11061, + use_tcp := false, + remote_port := 2907, + local_port := 11061, point_code := 61, routing_ctx := - } @@ -89,10 +95,12 @@ } type record M3uaConfig { - /* STP-side SCTP port for M3UA */ - integer remote_sctp_port, + /* use TCP (true) or SCTP (false) */ + boolean use_tcp, + /* STP-side SCTP (or TCP) port for M3UA */ + integer remote_port, /* local M3UA base port on TTCN3 side */ - integer local_sctp_port, + integer local_port, /* point code routed via this M3U */ integer point_code, /* associated routing context */ @@ -119,7 +127,7 @@ sctpPeerAddrChange := ? } } -private template PortEvent tr_SctpConnOpened := { +private template PortEvent tr_ConnOpened := { connOpened := ? } @@ -137,9 +145,13 @@ } } -friend function f_M3UA_send(integer idx, template (present) PDU_M3UA msg, template integer stream := 0) +friend function f_M3UA_send(integer idx, template (present) PDU_M3UA msg, integer stream := 0) runs on RAW_M3UA_CT { - M3UA[idx].send(t_M3UA_Send(g_m3ua_conn_id[idx], msg, stream)); + if (mp_m3ua_configs[idx].use_tcp) { + M3UA[idx].send(t_M3UA_Send(g_m3ua_conn_id[idx], msg, omit)); + } else { + M3UA[idx].send(t_M3UA_Send(g_m3ua_conn_id[idx], msg, stream)); + } } friend function f_M3UA_exp(integer idx, template (present) PDU_M3UA msg) runs on RAW_M3UA_CT { @@ -192,7 +204,7 @@ assocId := omit }; -friend function f_M3UA_connect(integer i) runs on RAW_M3UA_CT { +friend function f_M3UA_connect_sctp(integer i) runs on RAW_M3UA_CT { var Result res; var Option opt_add_local_addrs; var OptionList opt_list := {}; @@ -213,15 +225,15 @@ if (lengthof(mp_stp_m3ua_ip) > 1) { for (var integer j := 1; j < lengthof(mp_stp_m3ua_ip); j := j + 1) { - var Socket sk := valueof(ts_Socket(mp_stp_m3ua_ip[j], m3cfg.remote_sctp_port)); + var Socket sk := valueof(ts_Socket(mp_stp_m3ua_ip[j], m3cfg.remote_port)); opt_add_remote_addrs[j - 1] := sk; } } else { opt_add_remote_addrs := omit; } - res := M3UA_CodecPort_CtrlFunct.f_IPL4_connect(M3UA[i], mp_stp_m3ua_ip[0], m3cfg.remote_sctp_port, - mp_local_m3ua_ip[0], m3cfg.local_sctp_port, 0, + res := M3UA_CodecPort_CtrlFunct.f_IPL4_connect(M3UA[i], mp_stp_m3ua_ip[0], m3cfg.remote_port, + mp_local_m3ua_ip[0], m3cfg.local_port, 0, {sctp:=valueof(ts_SCTP(3, 0, opt_add_remote_addrs))}, opt_list); if (not ispresent(res.connId)) { @@ -231,9 +243,34 @@ g_m3ua_conn_id[i] := res.connId; } +friend function f_M3UA_connect_tcp(integer i) runs on RAW_M3UA_CT { + var M3uaConfig m3cfg := mp_m3ua_configs[i]; + var Result res; + + if (lengthof(mp_local_m3ua_ip) == 0 or lengthof(mp_stp_m3ua_ip) == 0) { + setverdict(fail, "Empty local or remote address trying to connect TCP socket: ", + mp_local_m3ua_ip, " / ", mp_stp_m3ua_ip); + mtc.stop; + } + + res := M3UA_CodecPort_CtrlFunct.f_IPL4_connect(M3UA[i], mp_stp_m3ua_ip[0], m3cfg.remote_port, + mp_local_m3ua_ip[0], m3cfg.local_port, 0, + {tcp:={}}); + if (not ispresent(res.connId)) { + setverdict(fail, "Could not connect M3UA socket, check your configuration"); + mtc.stop; + } + g_m3ua_conn_id[i] := res.connId; + M3UA_CodecPort.f_set_tcp_segmentation(M3UA[i], res.connId); +} + friend function f_M3UA_close(integer i) runs on RAW_M3UA_CT { var Result res; - res := M3UA_CodecPort_CtrlFunct.f_IPL4_close(M3UA[i], g_m3ua_conn_id[i], {sctp:=valueof(ts_SCTP)}); + if (mp_m3ua_configs[i].use_tcp) { + res := M3UA_CodecPort_CtrlFunct.f_IPL4_close(M3UA[i], g_m3ua_conn_id[i], {tcp:={}}); + } else { + res := M3UA_CodecPort_CtrlFunct.f_IPL4_close(M3UA[i], g_m3ua_conn_id[i], {sctp:=valueof(ts_SCTP)}); + } g_m3ua_conn_id[i] := 0; } @@ -255,12 +292,20 @@ opt_list := {opt_add_local_addrs}; } - res := M3UA_CodecPort_CtrlFunct.f_IPL4_listen(M3UA[i], mp_local_m3ua_ip[0], m3cfg.local_sctp_port, - {sctp:=valueof(ts_SCTP)}, opt_list); + if (mp_m3ua_configs[i].use_tcp) { + res := M3UA_CodecPort_CtrlFunct.f_IPL4_listen(M3UA[i], mp_local_m3ua_ip[0], m3cfg.local_port, + {tcp:={}}); + } else { + res := M3UA_CodecPort_CtrlFunct.f_IPL4_listen(M3UA[i], mp_local_m3ua_ip[0], m3cfg.local_port, + {sctp:=valueof(ts_SCTP)}, opt_list); + } if (not ispresent(res.connId)) { setverdict(fail, "Could not bind M3UA socket, check your configuration"); mtc.stop; } + if (mp_m3ua_configs[i].use_tcp) { + M3UA_CodecPort.f_set_tcp_segmentation(M3UA[i], res.connId); + } } friend function f_init_m3ua(boolean ignore_ssnm := true) runs on RAW_M3UA_CT { @@ -275,7 +320,11 @@ for (i := 0; i < NR_M3UA; i:=i+1) { map(self:M3UA[i], system:M3UA_CODEC_PT); - f_M3UA_connect(i); + if (mp_m3ua_configs[i].use_tcp) { + f_M3UA_connect_tcp(i); + } else { + f_M3UA_connect_sctp(i); + } } } @@ -294,15 +343,15 @@ friend function f_init_m3ua_srv() runs on RAW_M3UA_CT { var integer i; - var PortEvent sctp_evt; + var PortEvent port_evt; for (i := NR_M3UA; i < NR_M3UA+NR_M3UA_SRV; i:=i+1) { map(self:M3UA[i], system:M3UA_CODEC_PT); /* bind+ listen */ f_M3UA_listen(i); /* wait for accept() */ - M3UA[i].receive(tr_SctpConnOpened) -> value sctp_evt { - g_m3ua_conn_id[i] := sctp_evt.connOpened.connId; + M3UA[i].receive(tr_ConnOpened) -> value port_evt { + g_m3ua_conn_id[i] := port_evt.connOpened.connId; } } } @@ -982,12 +1031,30 @@ f_M3UA_exp(0, tr_M3UA_SCON({adv_pc}, rctx0)); } +private function f_asp_cfg_str(charstring asp_name, in M3uaConfig cfg) +return charstring { + var charstring str; + + str := "asp " & asp_name; + str := str & " " & int2str(cfg.local_port); + str := str & " " & int2str(cfg.remote_port); + str := str & " m3ua"; + + if (cfg.use_tcp) { + str := str & " tcp"; + } + + return str; +} + private function f_quirk(charstring quirk) runs on RAW_M3UA_CT { - f_vty_config2(VTY, {"cs7 instance 0", "asp asp-client0 10002 2906 m3ua"}, "quirk " & quirk); + var charstring asp_cfg_str := f_asp_cfg_str("asp-client0", mp_m3ua_configs[3]); + f_vty_config2(VTY, {"cs7 instance 0", asp_cfg_str}, "quirk " & quirk); } private function f_no_quirk(charstring quirk) runs on RAW_M3UA_CT { - f_vty_config2(VTY, {"cs7 instance 0", "asp asp-client0 10002 2906 m3ua"}, "no quirk " & quirk); + var charstring asp_cfg_str := f_asp_cfg_str("asp-client0", mp_m3ua_configs[3]); + f_vty_config2(VTY, {"cs7 instance 0", asp_cfg_str}, "no quirk " & quirk); } /* quirk 'no_notify': Expect inbound connection from ASP/SCTP-client, followed by ASP-UP + ASP-ACT */ diff --git a/ttcn3-tcpdump-start.sh b/ttcn3-tcpdump-start.sh index c4905d9..003d439 100755 --- a/ttcn3-tcpdump-start.sh +++ b/ttcn3-tcpdump-start.sh @@ -36,6 +36,8 @@ TTCN3_PCAP_PATH=/tmp fi +exit + kill_rm_pidfile $PIDFILE_NETCAT kill_rm_pidfile $PIDFILE_PCAP diff --git a/ttcn3-tcpdump-stop.sh b/ttcn3-tcpdump-stop.sh index 82d3a4f..0a13841 100755 --- a/ttcn3-tcpdump-stop.sh +++ b/ttcn3-tcpdump-stop.sh @@ -54,6 +54,8 @@ fi fi +exit + # Wait for up to 2 seconds if we keep receiving traffinc from packet dumper, # otherwise we might lose last packets from test. i=0 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36099?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6dfed05adb332c29404997ea7dc93ec3dabfc43a Gerrit-Change-Number: 36099 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 4 months

1
0
0 0

[S] Change in libosmo-netif[master]: examples/stream-*: Support SCTP when called with "-s" argument

by laforge

Attention is currently required from: laforge, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35234?usp=email ) Change subject: examples/stream-*: Support SCTP when called with "-s" argument ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35234?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I4137cdf1e21cb669b632fe5c126ec27475d98400 Gerrit-Change-Number: 35234 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 Feb 2024 08:47:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in libosmo-netif[master]: examples/stream-*: Add options, to set local/remote peer

by laforge

Attention is currently required from: jolly, laforge. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35927?usp=email ) Change subject: examples/stream-*: Add options, to set local/remote peer ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35927?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ie6da55ef248436e521c5d8f21f8053356c46a114 Gerrit-Change-Number: 35927 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 28 Feb 2024 08:47:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: msc/MSC_Tests.cfg: remove commented out testcase list

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36096?usp=email ) Change subject: msc/MSC_Tests.cfg: remove commented out testcase list ...................................................................... msc/MSC_Tests.cfg: remove commented out testcase list Change-Id: I573b55e235ebb093b1166c1fe78feaa4f296ce8c --- M msc/MSC_Tests.cfg 1 file changed, 9 insertions(+), 48 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/msc/MSC_Tests.cfg b/msc/MSC_Tests.cfg index ee36336..1676e70 100644 --- a/msc/MSC_Tests.cfg +++ b/msc/MSC_Tests.cfg @@ -18,51 +18,3 @@ MSC_Tests.control MSC_Tests_Iu.control MSC_Tests_ASCI.control -#MSC_Tests.TC_cr_before_reset -#MSC_Tests.TC_lu_imsi_noauth_tmsi -#MSC_Tests.TC_lu_imsi_noauth_notmsi -#MSC_Tests.TC_lu_imsi_reject -#MSC_Tests.TC_lu_imsi_timeout_gsup -#MSC_Tests.TC_lu_imsi_auth_tmsi -#MSC_Tests.TC_cmserv_imsi_unknown -#MSC_Tests.TC_lu_and_mo_call -#MSC_Tests.TC_lu_auth_sai_timeout -#MSC_Tests.TC_lu_auth_sai_err -#MSC_Tests.TC_lu_clear_request -#MSC_Tests.TC_lu_disconnect -#MSC_Tests.TC_lu_by_imei -#MSC_Tests.TC_lu_by_tmsi_noauth_unknown -#MSC_Tests.TC_imsi_detach_by_imsi -#MSC_Tests.TC_imsi_detach_by_tmsi -#MSC_Tests.TC_imsi_detach_by_imei -#MSC_Tests.TC_emerg_call_imei_reject -#MSC_Tests.TC_emerg_call_imsi -#MSC_Tests.TC_cm_serv_req_vgcs_reject -#MSC_Tests.TC_cm_serv_req_vbs_reject -#MSC_Tests.TC_cm_serv_req_lcs_reject -#MSC_Tests.TC_cm_reest_req_reject -#MSC_Tests.TC_lu_auth_2G_fail -#MSC_Tests.TC_lu_imsi_auth_tmsi_encr_13_13 -#MSC_Tests.TC_cl3_no_payload -#MSC_Tests.TC_cl3_rnd_payload -#MSC_Tests.TC_establish_and_nothing -#MSC_Tests.TC_mo_setup_and_nothing -#MSC_Tests.TC_mo_crcx_ran_timeout -#MSC_Tests.TC_mo_crcx_ran_reject -#MSC_Tests.TC_mt_crcx_ran_reject -#MSC_Tests.TC_mt_t310 -#MSC_Tests.TC_gsup_cancel -#MSC_Tests.TC_lu_imsi_auth_tmsi_encr_1_13 -#MSC_Tests.TC_lu_imsi_auth_tmsi_encr_3_13 -#MSC_Tests.TC_lu_imsi_auth_tmsi_encr_3_1 -#MSC_Tests.TC_lu_imsi_auth_tmsi_encr_3_1_no_cm -#MSC_Tests.TC_lu_imsi_auth_tmsi_encr_13_2 -#MSC_Tests.TC_lu_imsi_auth_tmsi_encr_013_2 -#MSC_Tests.TC_mo_release_timeout -#MSC_Tests.TC_lu_and_mt_call_no_dlcx_resp -#MSC_Tests.TC_reset_two -#MSC_Tests.TC_lu_and_mt_call -#MSC_Tests.TC_cipher_complete_with_invalid_cipher -#MSC_Tests.TC_cipher_complete_1_without_cipher -#MSC_Tests.TC_cipher_complete_3_without_cipher -#MSC_Tests.TC_cipher_complete_13_without_cipher -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36096?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I573b55e235ebb093b1166c1fe78feaa4f296ce8c Gerrit-Change-Number: 36096 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 4 months

1
0
0 0

[S] Change in osmo-trx[master]: ms: update osmocom-bb submodule

by laforge

Attention is currently required from: Hoernchen. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36048?usp=email ) Change subject: ms: update osmocom-bb submodule ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36048?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I0140f0a5333469f356c85a95660e10bbdd67cd25 Gerrit-Change-Number: 36048 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 Feb 2024 08:44:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: msc/MSC_Tests.cfg: remove commented out testcase list

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36096?usp=email ) Change subject: msc/MSC_Tests.cfg: remove commented out testcase list ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36096?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I573b55e235ebb093b1166c1fe78feaa4f296ce8c Gerrit-Change-Number: 36096 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 Feb 2024 08:44:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in osmo-bts[master]: pcu_sock: forward PCU_VERSION only once

by laforge

Attention is currently required from: dexter, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/36018?usp=email ) Change subject: pcu_sock: forward PCU_VERSION only once ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/36018/comment/92061cdd_f175c317 PS1, Line 10: is not active the PCU even sends the version number in regular > I'm still not following @pmaier@sysmocom.de. […] This entire thread and patch are bizarre. Why would the PCU send that information multiple times? We are using a connected socket, so the information cannot change ever since the socket has first connected. A connected unix domain socket cannot loose messages, so retransmissions are not useful, they just queue up and (if not processed) clog the socket buffer. So if the PCU has a bug in that regard, it shall be addressed in the PCU, rather than the BTS plastering over / hiding a PCU bug from the BSC. I also don't understand why the PCU would do this any different than any of the other many unix domain sockets we use in osmocom, like MNCC or L1CTRL, or more recently the socket between libosmo-e1d and osmo-e1d. I'm not aware that any of the implementations of such protocols would ever re-transmit any message for reasons described above. The only valid situation where I could imagine the PCU "re-transmitting" is when the PCU re-spawns all the time while the BTS keeps running. Then each time the PCU connects, it says "hello" and indicates its version. But then we might want to look at why it's re-spawning all the time and whether that's the intended situation. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36018?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id82fe0504d0cbdf71473c1e7dfe6125a3471bd85 Gerrit-Change-Number: 36018 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 Feb 2024 08:42:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2024