February 2024 - gerrit-log - lists.osmocom.org

[S] Change in ...osmo_ss7[master]: ipa_proto: start_listen: use correct ok/error pattern

by pespin

Attention is currently required from: fixeria, laforge, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/36104?usp=email ) Change subject: ipa_proto: start_listen: use correct ok/error pattern ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I submitted these patches from @lynxis@fe80.eu which were in a lynxis/epdg branch, and which we seem to be using in osmo-epdg according to rebar.config. Let's them get merged in master... -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/36104?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_ss7 Gerrit-Branch: master Gerrit-Change-Id: I9b317c13089fae2406f401a1f420623de9a2dffa Gerrit-Change-Number: 36104 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 28 Feb 2024 13:25:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in ...osmo_ss7[master]: ipa_proto: start_listen: use correct ok/error pattern

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/36104?usp=email ) Change subject: ipa_proto: start_listen: use correct ok/error pattern ...................................................................... ipa_proto: start_listen: use correct ok/error pattern The ok path only returned the port without an "ok". Also path back the ListenSock. Change-Id: I9b317c13089fae2406f401a1f420623de9a2dffa --- M src/ipa_proto.erl 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_ss7 refs/changes/04/36104/1 diff --git a/src/ipa_proto.erl b/src/ipa_proto.erl index fcd594b..c96d6bb 100644 --- a/src/ipa_proto.erl +++ b/src/ipa_proto.erl @@ -367,7 +367,7 @@ {ok, ListenSock} -> start_servers(NumServers, ListenSock, self()), {ok, Port} = inet:port(ListenSock), - Port; + {ok, ListenSock, Port}; {error, Reason} -> {error, Reason} end. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/36104?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_ss7 Gerrit-Branch: master Gerrit-Change-Id: I9b317c13089fae2406f401a1f420623de9a2dffa Gerrit-Change-Number: 36104 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

1 year, 4 months

1
0
0 0

[S] Change in ...osmo_ss7[master]: ipa: fix empty IPA CCM ID Tags

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/36105?usp=email ) Change subject: ipa: fix empty IPA CCM ID Tags ...................................................................... ipa: fix empty IPA CCM ID Tags decode_ies() would crash because lists:lasts([]) tries to access an empty lists. Change-Id: I6f44561f83c84bac7e5c98747f969f5436617f90 --- M src/ipa_proto_ccm.erl 1 file changed, 18 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_ss7 refs/changes/05/36105/1 diff --git a/src/ipa_proto_ccm.erl b/src/ipa_proto_ccm.erl index 27ceba9..87eb15e 100644 --- a/src/ipa_proto_ccm.erl +++ b/src/ipa_proto_ccm.erl @@ -82,9 +82,12 @@ decode_ies(<<0:8, Len:8, TypeValue:Len/binary, Remain/binary>>, IeList) when is_list(IeList) -> <<Type:8, Value/binary>> = TypeValue, ValueList = binary_to_list(Value), - case lists:last(ValueList) of - 0 -> ValueStripped = lists:droplast(ValueList); - _ -> ValueStripped = ValueList + case ValueList of + [] -> ValueStripped = []; + _ -> case lists:last(ValueList) of + 0 -> ValueStripped = lists:droplast(ValueList); + _ -> ValueStripped = ValueList + end end, decode_ies(Remain, IeList ++ [{string, decode_idtag(Type), ValueStripped}]). -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_ss7/+/36105?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_ss7 Gerrit-Branch: master Gerrit-Change-Id: I6f44561f83c84bac7e5c98747f969f5436617f90 Gerrit-Change-Number: 36105 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

1 year, 4 months

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-pgw-test: Configure open5gs-smfd S2b/S6b/P-CSCF related bits

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36088?usp=email ) Change subject: ttcn3-pgw-test: Configure open5gs-smfd S2b/S6b/P-CSCF related bits ...................................................................... ttcn3-pgw-test: Configure open5gs-smfd S2b/S6b/P-CSCF related bits Depends: osmo-ttcn3-hacks.git Change-Id I38e469edf0e00feca5a648035b64645e2c905937 Change-Id: I3ff503990167f52ddb94a7719e2773db3f889a39 --- M ttcn3-pgw-test/PGW_Tests.cfg M ttcn3-pgw-test/freeDiameter-smf.conf M ttcn3-pgw-test/open5gs-smf-latest.yaml M ttcn3-pgw-test/open5gs-smf-master.yaml 4 files changed, 20 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/ttcn3-pgw-test/PGW_Tests.cfg b/ttcn3-pgw-test/PGW_Tests.cfg index d17e782..5d3ff45 100644 --- a/ttcn3-pgw-test/PGW_Tests.cfg +++ b/ttcn3-pgw-test/PGW_Tests.cfg @@ -17,6 +17,7 @@ PGW_Tests.mp_ping_hostname := "10.45.0.1" PGW_Tests.mp_pcrf_local_ip:= "172.18.18.202" PGW_Tests.mp_ocs_local_ip:= "172.18.18.202" +PGW_Tests.mp_aaa_local_ip:= "172.18.18.202" GTPv2_Emulation.mp_uecups_host := "172.18.18.20" [MAIN_CONTROLLER] diff --git a/ttcn3-pgw-test/freeDiameter-smf.conf b/ttcn3-pgw-test/freeDiameter-smf.conf index afa9298..207d1cc 100644 --- a/ttcn3-pgw-test/freeDiameter-smf.conf +++ b/ttcn3-pgw-test/freeDiameter-smf.conf @@ -261,5 +261,5 @@ #ConnectPeer = "old.diameter.serv" { TcTimer = 60; TLS_old_method; No_SCTP; Port=3868; } ; ConnectPeer = "pcrf.localdomain" { ConnectTo = "172.18.18.202"; No_TLS; TcTimer = 2; }; ConnectPeer = "ocs.localdomain" { ConnectTo = "172.18.18.202"; Port = 3869; No_TLS; TcTimer = 2; }; - +ConnectPeer = "aaa.localdomain" { ConnectTo = "172.18.18.202"; Port = 3870; No_TLS; TcTimer = 2; }; ############################################################## diff --git a/ttcn3-pgw-test/open5gs-smf-latest.yaml b/ttcn3-pgw-test/open5gs-smf-latest.yaml index 622618b..0f80467 100644 --- a/ttcn3-pgw-test/open5gs-smf-latest.yaml +++ b/ttcn3-pgw-test/open5gs-smf-latest.yaml @@ -1,7 +1,7 @@ # See https://github.com/open5gs/open5gs/blob/main/configs/open5gs/smf.yaml.in logger: - level: info + level: debug sbi: server: @@ -39,6 +39,9 @@ - 2001:4860:4860::8888 - 2001:4860:4860::8844 mtu: 1400 + p-cscf: + - 172.18.18.7 + - fd02:db8:18::7 ctf: enabled: auto freeDiameter: /data/freeDiameter-smf.conf diff --git a/ttcn3-pgw-test/open5gs-smf-master.yaml b/ttcn3-pgw-test/open5gs-smf-master.yaml index 3448aba..db91145 100644 --- a/ttcn3-pgw-test/open5gs-smf-master.yaml +++ b/ttcn3-pgw-test/open5gs-smf-master.yaml @@ -1,7 +1,7 @@ # See https://github.com/open5gs/open5gs/blob/main/configs/open5gs/smf.yaml.in logger: - level: info + level: debug global: max: @@ -56,6 +56,9 @@ - 2001:4860:4860::8888 - 2001:4860:4860::8844 mtu: 1400 + p-cscf: + - 172.18.18.7 + - fd02:db8:18::7 ctf: enabled: auto freeDiameter: /data/freeDiameter-smf.conf -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36088?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I3ff503990167f52ddb94a7719e2773db3f889a39 Gerrit-Change-Number: 36088 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 4 months

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-pgw-test: Configure open5gs-smfd S2b/S6b/P-CSCF related bits

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36088?usp=email ) Change subject: ttcn3-pgw-test: Configure open5gs-smfd S2b/S6b/P-CSCF related bits ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36088?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I3ff503990167f52ddb94a7719e2773db3f889a39 Gerrit-Change-Number: 36088 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 Feb 2024 13:11:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: sgsn: osmo-*.cfg: tune logging configuration

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36103?usp=email ) Change subject: sgsn: osmo-*.cfg: tune logging configuration ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36103?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2f2cc69a481709e862d569b0298561b61506dfa7 Gerrit-Change-Number: 36103 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 Feb 2024 13:05:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: sgsn/expected-results.xml: add missing testcases

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36102?usp=email ) Change subject: sgsn/expected-results.xml: add missing testcases ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36102?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I09cc32bffde9d9dec59befa181a995e88112b2d2 Gerrit-Change-Number: 36102 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 Feb 2024 13:05:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc/expected-results.xml: add missing testcases

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36101?usp=email ) Change subject: msc/expected-results.xml: add missing testcases ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36101?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1604bb955707d0e44bfd08ecd3a28a936731c166 Gerrit-Change-Number: 36101 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 Feb 2024 13:04:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in libosmo-abis[master]: input/ipaccess: fix regression in ipaccess_bts_handle_ccm()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/36100?usp=email ) Change subject: input/ipaccess: fix regression in ipaccess_bts_handle_ccm() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/input/ipaccess.c: https://gerrit.osmocom.org/c/libosmo-abis/+/36100/comment/78267d74_393e4395 PS1, Line 897: LOGP(DLINP, LOGL_NOTICE, "received ID_GET for unit ID %u/%u/%u\n", maybe printing information about the link instead would be welcome. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36100?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ic26181b580724a70c2af8a224155430902fe4101 Gerrit-Change-Number: 36100 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 Feb 2024 13:04:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in libosmocore[master]: osmo_io: Add osmo_io_get_ioops() function

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36076?usp=email ) Change subject: osmo_io: Add osmo_io_get_ioops() function ...................................................................... Patch Set 1: (1 comment) File include/osmocom/core/osmo_io.h: https://gerrit.osmocom.org/c/libosmocore/+/36076/comment/fb97b828_fd806e90 PS1, Line 112: void osmo_iofd_get_ioops(struct osmo_io_fd *iofd, struct osmo_io_ops *ioops); > If you want to make it generic, it would probably be best to decoupple the segmentation callback fro […] Yeah well you can even do address calculation to change stuff even if you don't get the pointer, but that's not the point :P Fine, let's keep it this way then if it's good enough for whoever is writing the API. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36076?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I03398c811b9534f50c6644b21eea89a04be29fb0 Gerrit-Change-Number: 36076 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 28 Feb 2024 13:02:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2024