February 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ggsn[master]: lib/gtp-kernel.c: initialize ret with 0

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36089?usp=email ) Change subject: lib/gtp-kernel.c: initialize ret with 0 ...................................................................... Patch Set 1: (1 comment) File lib/gtp-kernel.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/36089/comment/8f52442b_f1ac546b PS1, Line 117: ms_addr_count = in46a_from_eua(&pdp->eua, ms); > if in46a_from_eua returns negative, you are still returning 0. […] -> https://gerrit.osmocom.org/c/osmo-ggsn/+/36090 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36089?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I19067ebe561d4c067b9ace7f5b201e15af6b342e Gerrit-Change-Number: 36089 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Feb 2024 15:06:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in osmo-ggsn[master]: lib/gtp-kernel.c: check rc of in46a_from_eua

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36090?usp=email ) Change subject: lib/gtp-kernel.c: check rc of in46a_from_eua ...................................................................... lib/gtp-kernel.c: check rc of in46a_from_eua Fixes: b17fe7bf ("kernel-gtp: support IPv6 on inner layer") Change-Id: I40e4de1517de8871224a45c173208810b42312ff --- M lib/gtp-kernel.c 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/90/36090/1 diff --git a/lib/gtp-kernel.c b/lib/gtp-kernel.c index 3ad8424..6a14d78 100644 --- a/lib/gtp-kernel.c +++ b/lib/gtp-kernel.c @@ -115,6 +115,8 @@ in46a_from_gsna(&pdp->gsnrc, &sgsn); ms_addr_count = in46a_from_eua(&pdp->eua, ms); + if (ms_addr_count < 0) + return -1; for (int i = 0; i < ms_addr_count; i++) { t = gtp_tunnel_alloc(); @@ -169,6 +171,8 @@ pdp_debug(__func__, devname, pdp); ms_addr_count = in46a_from_eua(&pdp->eua, ms); + if (ms_addr_count < 0) + return -1; for (int i = 0; i < ms_addr_count; i++) { t = gtp_tunnel_alloc(); -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36090?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I40e4de1517de8871224a45c173208810b42312ff Gerrit-Change-Number: 36090 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 4 months

1
0
0 0

[S] Change in libosmocore[master]: gsup.h: define newly added PCO IE

by dexter

Attention is currently required from: fixeria, laforge, lynxis lazus, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36024?usp=email ) Change subject: gsup.h: define newly added PCO IE ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File src/gsm/gsup.c: https://gerrit.osmocom.org/c/libosmocore/+/36024/comment/1d3519b6_217b34ec PS3, Line 881: msgb_tlv_put(msg, OSMO_GSUP_PCO_IE, gsup_msg->pco_len, gsup_msg->pco); > Yeah I think we can check for pco_len <= 251 here. I think also that this makes sense. (I am not aware of this, in case the length is something the API user has to set consciously, then an OSMO_ASSERT might also make sense.) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36024?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0f9de90c7c67fe194b441a9d118eba70f09afb5e Gerrit-Change-Number: 36024 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 27 Feb 2024 15:01:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in osmo-ggsn[master]: lib/gtp-kernel.c: initialize ret with 0

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36089?usp=email ) Change subject: lib/gtp-kernel.c: initialize ret with 0 ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-ggsn/+/36089/comment/9727b7b9_786dfd94 PS1, Line 11: /home/pespin/dev/sysmocom/git/osmo-ggsn/lib/gtp-kernel.c: In function ‘gtp_kernel_tunnel_add’: I think you can get rid of these paths :) File lib/gtp-kernel.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/36089/comment/e4e99d1f_df17e878 PS1, Line 117: ms_addr_count = in46a_from_eua(&pdp->eua, ms); if in46a_from_eua returns negative, you are still returning 0. You need to do "ret = ms_addr_count;" or similar instead of ret = 0 at the start. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36089?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I19067ebe561d4c067b9ace7f5b201e15af6b342e Gerrit-Change-Number: 36089 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Feb 2024 14:59:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in osmo-ggsn[master]: lib/gtp-kernel.c: initialize ret with 0

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36089?usp=email ) Change subject: lib/gtp-kernel.c: initialize ret with 0 ...................................................................... lib/gtp-kernel.c: initialize ret with 0 Fix -Werror=maybe-uninitialize found in Pau's build env: /home/pespin/dev/sysmocom/git/osmo-ggsn/lib/gtp-kernel.c: In function ‘gtp_kernel_tunnel_add’: /home/pespin/dev/sysmocom/git/osmo-ggsn/lib/gtp-kernel.c:111:13: error: ‘ret’ may be used uninitialized [-Werror=maybe-uninitialize] 111 | int ret; | ^~~ /home/pespin/dev/sysmocom/git/osmo-ggsn/lib/gtp-kernel.c: In function ‘gtp_kernel_tunnel_del’: /home/pespin/dev/sysmocom/git/osmo-ggsn/lib/gtp-kernel.c:167:13: error: ‘ret’ may be used uninitialized [-Werror=maybe-uninitialize] 167 | int ret; | ^~~ Fixes: b17fe7bf ("kernel-gtp: support IPv6 on inner layer") Change-Id: I19067ebe561d4c067b9ace7f5b201e15af6b342e --- M lib/gtp-kernel.c 1 file changed, 23 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved diff --git a/lib/gtp-kernel.c b/lib/gtp-kernel.c index 9bfb380..3ad8424 100644 --- a/lib/gtp-kernel.c +++ b/lib/gtp-kernel.c @@ -108,7 +108,7 @@ struct in46_addr ms[2]; struct in46_addr sgsn; struct gtp_tunnel *t; - int ret; + int ret = 0; pdp_debug(__func__, devname, pdp); @@ -164,7 +164,7 @@ int ms_addr_count; struct in46_addr ms[2]; struct gtp_tunnel *t; - int ret; + int ret = 0; pdp_debug(__func__, devname, pdp); -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36089?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I19067ebe561d4c067b9ace7f5b201e15af6b342e Gerrit-Change-Number: 36089 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 4 months

1
0
0 0

[S] Change in osmo-ggsn[master]: lib/gtp-kernel.c: initialize ret with 0

by dexter

Attention is currently required from: osmith. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36089?usp=email ) Change subject: lib/gtp-kernel.c: initialize ret with 0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36089?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I19067ebe561d4c067b9ace7f5b201e15af6b342e Gerrit-Change-Number: 36089 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Feb 2024 14:56:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in osmo-ggsn[master]: lib/gtp-kernel.c: initialize ret with 0

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36089?usp=email ) Change subject: lib/gtp-kernel.c: initialize ret with 0 ...................................................................... lib/gtp-kernel.c: initialize ret with 0 Fix -Werror=maybe-uninitialize found in Pau's build env: /home/pespin/dev/sysmocom/git/osmo-ggsn/lib/gtp-kernel.c: In function ‘gtp_kernel_tunnel_add’: /home/pespin/dev/sysmocom/git/osmo-ggsn/lib/gtp-kernel.c:111:13: error: ‘ret’ may be used uninitialized [-Werror=maybe-uninitialize] 111 | int ret; | ^~~ /home/pespin/dev/sysmocom/git/osmo-ggsn/lib/gtp-kernel.c: In function ‘gtp_kernel_tunnel_del’: /home/pespin/dev/sysmocom/git/osmo-ggsn/lib/gtp-kernel.c:167:13: error: ‘ret’ may be used uninitialized [-Werror=maybe-uninitialize] 167 | int ret; | ^~~ Fixes: b17fe7bf ("kernel-gtp: support IPv6 on inner layer") Change-Id: I19067ebe561d4c067b9ace7f5b201e15af6b342e --- M lib/gtp-kernel.c 1 file changed, 23 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/89/36089/1 diff --git a/lib/gtp-kernel.c b/lib/gtp-kernel.c index 9bfb380..3ad8424 100644 --- a/lib/gtp-kernel.c +++ b/lib/gtp-kernel.c @@ -108,7 +108,7 @@ struct in46_addr ms[2]; struct in46_addr sgsn; struct gtp_tunnel *t; - int ret; + int ret = 0; pdp_debug(__func__, devname, pdp); @@ -164,7 +164,7 @@ int ms_addr_count; struct in46_addr ms[2]; struct gtp_tunnel *t; - int ret; + int ret = 0; pdp_debug(__func__, devname, pdp); -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36089?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I19067ebe561d4c067b9ace7f5b201e15af6b342e Gerrit-Change-Number: 36089 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 4 months

1
0
0 0

[S] Change in libosmocore[master]: gsup.h: define newly added PCO IE

by pespin

Attention is currently required from: fixeria, laforge, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36024?usp=email ) Change subject: gsup.h: define newly added PCO IE ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36024?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0f9de90c7c67fe194b441a9d118eba70f09afb5e Gerrit-Change-Number: 36024 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 27 Feb 2024 13:32:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in libosmocore[master]: gsup.h: define newly added PCO IE

by pespin

Hello Jenkins Builder, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/36024?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: gsup.h: define newly added PCO IE ...................................................................... gsup.h: define newly added PCO IE PCO - Protocol Configuration Options 3GPP TS 24.008 / 10.5.6.3. The PCO will be used by the osmo-epdg to pass PCO internally. The PCO will be passed towards to the PGW in the Session Request. Related: OS#6369 Related: osmo-gsm-manuals.git Change-Id Id912ead4e1205f84a40af6505a5ddf050d1e086d Change-Id: I0f9de90c7c67fe194b441a9d118eba70f09afb5e --- M TODO-RELEASE M include/osmocom/gsm/gsup.h M src/gsm/gsup.c 3 files changed, 34 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/24/36024/4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36024?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0f9de90c7c67fe194b441a9d118eba70f09afb5e Gerrit-Change-Number: 36024 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 year, 4 months

1
0
0 0

[S] Change in ...osmo-epdg[master]: WIP

by pespin

pespin has abandoned this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34859?usp=email ) Change subject: WIP ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34859?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I88cb82cc245da7da1c5f04fc20dc529110c34c51 Gerrit-Change-Number: 34859 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon

1 year, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2024