December 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-pcu[master]: gsm_rlcmac: fix EGPRS BEP Link Quality Measurements Type 2

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-pcu/+/39188?usp=email ) Change subject: gsm_rlcmac: fix EGPRS BEP Link Quality Measurements Type 2 ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > You may want to submit a patch prior to this one disabling linter for the relevant files? Ack, see https://gerrit.osmocom.org/c/osmo-pcu/+/39202. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/39188?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I061ac16df5e6413266de08884f791f0264791192 Gerrit-Change-Number: 39188 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Dec 2024 20:06:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

6 months

1
0
0 0

[S] Change in osmo-pcu[master]: gsm_rlcmac: fix EGPRS BEP Link Quality Measurements Type 2

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/39188?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: gsm_rlcmac: fix EGPRS BEP Link Quality Measurements Type 2 ...................................................................... gsm_rlcmac: fix EGPRS BEP Link Quality Measurements Type 2 This IE is defined in 3GPP TS 44.060 Table 12.5a.2.1. Each presence bit indicates presence of the next two entries, not one. This patch does affect the output of csn1_ts_44_060_test, though it does not fix decoding because it's caused by an unrelated problem. Related: libosmo-gprs.git Iac4de18ef25386f774bb409201b7a7996d1c8824 Change-Id: I061ac16df5e6413266de08884f791f0264791192 --- M src/gsm_rlcmac.c M tests/rlcmac/RLCMACTest.err 2 files changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/88/39188/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/39188?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I061ac16df5e6413266de08884f791f0264791192 Gerrit-Change-Number: 39188 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

6 months

1
0
0 0

[XS] Change in osmo-pcu[master]: Add .checkpatch.conf, ignore src/gsm_rlcmac.c

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/39202?usp=email ) Change subject: Add .checkpatch.conf, ignore src/gsm_rlcmac.c ...................................................................... Add .checkpatch.conf, ignore src/gsm_rlcmac.c This file comes from wireshark (originally from Ericsson) and does not follow the kernel coding style - ignore it. Change-Id: I91e05f9742aaac6ec61a1668ce3b63e8da52032d --- A .checkpatch.conf 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/02/39202/1 diff --git a/.checkpatch.conf b/.checkpatch.conf new file mode 100644 index 0000000..d808861 --- /dev/null +++ b/.checkpatch.conf @@ -0,0 +1 @@ +--exclude ^src/gsm_rlcmac.c$ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/39202?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I91e05f9742aaac6ec61a1668ce3b63e8da52032d Gerrit-Change-Number: 39202 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

6 months

1
0
0 0

[M] Change in osmo-msc[master]: Check for protocol extension bit in message type at a central location

by laforge

Attention is currently required from: fixeria, jolly. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/38579?usp=email ) Change subject: Check for protocol extension bit in message type at a central location ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38579?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iae41bc6a2e9fd85583509b6c6154dd5a935fb5df Gerrit-Change-Number: 38579 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Dec 2024 19:45:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months

1
0
0 0

[S] Change in osmo-msc[master]: Indicate error and release BSS connection when SMS transaction fails

by laforge

Attention is currently required from: fixeria, jolly, pespin. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/38514?usp=email ) Change subject: Indicate error and release BSS connection when SMS transaction fails ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Patchset: PS2: > This is something we cannot test, because the error cannot be triggered by the BSC end. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38514?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I82da9c283205c69b19ceb4ba40ac5aa7f37d159b Gerrit-Change-Number: 38514 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Dec 2024 19:44:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

6 months

1
0
0 0

[XS] Change in osmo-msc[master]: Release BSS connection when CC transaction fails

by laforge

Attention is currently required from: fixeria, jolly, pespin. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/38513?usp=email ) Change subject: Release BSS connection when CC transaction fails ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38513?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Icb893d5c1ce4c77a29259ce66189576dcaa5a44a Gerrit-Change-Number: 38513 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Dec 2024 19:43:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months

1
0
0 0

[S] Change in osmo-upf[master]: upf_gtp: automatically delete old gtp devices

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/39161?usp=email ) Change subject: upf_gtp: automatically delete old gtp devices ...................................................................... upf_gtp: automatically delete old gtp devices If osmo-upf crashes without running the destructor, we may have a leftover gtp device. This can be simulated with "killall -9 osmo-upf". Clean it up automatically. Related: SYS#7240 Depends: libgtpnl Ib99bd8eed854014a5c9118c23e4058a41f3145f2 Change-Id: I7bb5c1ed51f4e05964688ee77b8de77fd3c0f345 --- M src/osmo-upf/upf_gtp.c 1 file changed, 14 insertions(+), 4 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/src/osmo-upf/upf_gtp.c b/src/osmo-upf/upf_gtp.c index e2c6d07..528937b 100644 --- a/src/osmo-upf/upf_gtp.c +++ b/src/osmo-upf/upf_gtp.c @@ -178,6 +178,13 @@ return 0; } +static int upf_gtp_dev_create(struct upf_gtp_dev *dev, int gtp0_fd, int gtp1_fd) +{ + if (dev->sgsn_mode) + return gtp_dev_create_sgsn(-1, dev->name, gtp0_fd, gtp1_fd); + return gtp_dev_create(-1, dev->name, gtp0_fd, gtp1_fd); +} + int upf_gtp_dev_open(const char *name, bool create_gtp_dev, const char *local_addr, bool listen_for_gtpv0, bool sgsn_mode) { const struct osmo_sockaddr any = { @@ -235,10 +242,13 @@ if (create_gtp_dev) { int gtp0_fd = listen_for_gtpv0 ? dev->gtpv0.ofd.fd : -1; int gtp1_fd = dev->gtpv1.ofd.fd; - if (dev->sgsn_mode) - rc = gtp_dev_create_sgsn(-1, dev->name, gtp0_fd, gtp1_fd); - else - rc = gtp_dev_create(-1, dev->name, gtp0_fd, gtp1_fd); + + rc = upf_gtp_dev_create(dev, gtp0_fd, gtp1_fd); + if (rc == -EEXIST && gtp_dev_destroy(dev->name) == 0) { + LOG_GTP_DEV(dev, LOGL_ERROR, "deleted GTP device from unclean shutdown\n"); + rc = upf_gtp_dev_create(dev, gtp0_fd, gtp1_fd); + } + if (rc < 0) { LOG_GTP_DEV(dev, LOGL_ERROR, "Cannot create GTP device: rc=%d\n", rc); /* name = NULL: signal to the destructor that it does not need to delete the device */ -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39161?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I7bb5c1ed51f4e05964688ee77b8de77fd3c0f345 Gerrit-Change-Number: 39161 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months

1
0
0 0

[S] Change in osmo-upf[master]: upf_gtp: automatically delete old gtp devices

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-upf/+/39161?usp=email ) Change subject: upf_gtp: automatically delete old gtp devices ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39161?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I7bb5c1ed51f4e05964688ee77b8de77fd3c0f345 Gerrit-Change-Number: 39161 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Dec 2024 19:41:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months

1
0
0 0

[S] Change in osmo-upf[master]: upf_gtp: automatically delete old gtp devices

by laforge

Attention is currently required from: osmith, pespin. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-upf/+/39161?usp=email ) Change subject: upf_gtp: automatically delete old gtp devices ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39161?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I7bb5c1ed51f4e05964688ee77b8de77fd3c0f345 Gerrit-Change-Number: 39161 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Dec 2024 19:41:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months

1
0
0 0

[XS] Change in osmo-mgw[master]: cosmetic: mgw: Fix indentation whitespace

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39182?usp=email ) Change subject: cosmetic: mgw: Fix indentation whitespace ...................................................................... cosmetic: mgw: Fix indentation whitespace Change-Id: Ic5b267108b5c5cba064ddddbe688705f9dc29ac8 --- M src/libosmo-mgcp/mgcp_protocol.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index 2f16794..47fa30b 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -1147,7 +1147,7 @@ const char *local_options = NULL; const char *mode = NULL; struct mgcp_conn_rtp *conn = NULL; - const char *conn_id = NULL; + const char *conn_id = NULL; int remote_osmux_cid = -2; int rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39182?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic5b267108b5c5cba064ddddbe688705f9dc29ac8 Gerrit-Change-Number: 39182 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2024