December 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-mgw[master]: mgcp_endp: Add helpers accessing endp connections

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39206?usp=email ) Change subject: mgcp_endp: Add helpers accessing endp connections ...................................................................... mgcp_endp: Add helpers accessing endp connections This has several benefits: * easily improving/changing the impelemntation later on (eg. by storing a count instead of iterating the whole list). * Remove code complexity from mgcp_protocol.c. Change-Id: I77c298abf0a1488b91f58c9e76507ef8add0168e --- M include/osmocom/mgcp/mgcp_endp.h M src/libosmo-mgcp/mgcp_endp.c M src/libosmo-mgcp/mgcp_protocol.c 3 files changed, 25 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/06/39206/1 diff --git a/include/osmocom/mgcp/mgcp_endp.h b/include/osmocom/mgcp/mgcp_endp.h index 5ecebda..fbe0850 100644 --- a/include/osmocom/mgcp/mgcp_endp.h +++ b/include/osmocom/mgcp/mgcp_endp.h @@ -139,6 +139,8 @@ struct mgcp_endpoint *mgcp_endp_by_name(int *cause, const char *epname, struct mgcp_config *cfg); bool mgcp_endp_avail(const struct mgcp_endpoint *endp); +unsigned int mgcp_endp_num_conns(const struct mgcp_endpoint *endp); +bool mgcp_endp_is_full(const struct mgcp_endpoint *endp); void mgcp_endp_add_conn(struct mgcp_endpoint *endp, struct mgcp_conn *conn); void mgcp_endp_remove_conn(struct mgcp_endpoint *endp, struct mgcp_conn *conn); void mgcp_endp_free_conn_oldest(struct mgcp_endpoint *endp); diff --git a/src/libosmo-mgcp/mgcp_endp.c b/src/libosmo-mgcp/mgcp_endp.c index 4c51266..5653168 100644 --- a/src/libosmo-mgcp/mgcp_endp.c +++ b/src/libosmo-mgcp/mgcp_endp.c @@ -569,6 +569,24 @@ return false; } +/*! Get number of conns in an endpoint. + * \param[in] endp endpoint to check. + * \returns Number of connections present in the endpoint. */ +unsigned int mgcp_endp_num_conns(const struct mgcp_endpoint *endp) +{ + return llist_count(&endp->conns); +} + +/*! check if an endpoint can in current state allocate new conns. + * \param[in] endp endpoint to check. + * \returns true if more connections can be allowed on endpoint, false if it is already busy. */ +bool mgcp_endp_is_full(const struct mgcp_endpoint *endp) +{ + if (endp->type->max_conns == 0) + return false; + return mgcp_endp_num_conns(endp) >= endp->type->max_conns; +} + /*! claim endpoint, sets callid and activates endpoint, should be called at the * beginning of the CRCX procedure when it is clear that a new call should be * created. diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index 4e63e4d..4c8f47c 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -967,7 +967,7 @@ } /* Check if we are able to accept the creation of another connection */ - if (endp->type->max_conns > 0 && llist_count(&endp->conns) >= endp->type->max_conns) { + if (mgcp_endp_is_full(endp)) { LOGPENDP(endp, DLMGCP, LOGL_ERROR, "CRCX: endpoint full, max. %i connections allowed!\n", endp->type->max_conns); @@ -1173,7 +1173,7 @@ LOGPENDP(endp, DLMGCP, LOGL_ERROR, "MDCX: selected endpoint not available!\n"); return create_err_response(rq->trunk, NULL, 501, "MDCX", pdata->trans); } - if (llist_count(&endp->conns) <= 0) { + if (mgcp_endp_num_conns(endp) <= 0) { LOGPENDP(endp, DLMGCP, LOGL_ERROR, "MDCX: endpoint is not holding a connection.\n"); rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_NO_CONN)); @@ -1396,7 +1396,7 @@ if (rq->wildcarded) { int num_conns = 0; for (i = 0; i < trunk->number_endpoints; i++) { - num_conns += llist_count(&trunk->endpoints[i]->conns); + num_conns += mgcp_endp_num_conns(trunk->endpoints[i]); mgcp_endp_release(trunk->endpoints[i]); } rate_ctr_add(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_SUCCESS), num_conns); @@ -1458,7 +1458,7 @@ * that we drop all connections on that specific endpoint at once. * (See also RFC3435 Section F.7) */ if (!conn_id) { - int num_conns = llist_count(&endp->conns); + int num_conns = mgcp_endp_num_conns(endp); LOGPENDP(endp, DLMGCP, LOGL_NOTICE, "DLCX: missing ci (connectionIdentifier), will remove all connections (%d total) at once\n", num_conns); @@ -1492,7 +1492,7 @@ /* When all connections are closed, the endpoint will be released * in order to be ready to be used by another call. */ - if (llist_count(&endp->conns) <= 0) { + if (mgcp_endp_num_conns(endp) <= 0) { mgcp_endp_release(endp); LOGPENDP(endp, DLMGCP, LOGL_DEBUG, "DLCX: endpoint released\n"); } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39206?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I77c298abf0a1488b91f58c9e76507ef8add0168e Gerrit-Change-Number: 39206 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

6 months

1
0
0 0

[XS] Change in osmo-mgw[master]: mgw: constify mgcp_endp_avail() param

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39205?usp=email ) Change subject: mgw: constify mgcp_endp_avail() param ...................................................................... mgw: constify mgcp_endp_avail() param Change-Id: I31ed2f3abbcf024ee44f62e130dd4ec01611ae97 --- M include/osmocom/mgcp/mgcp_endp.h M src/libosmo-mgcp/mgcp_endp.c 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/05/39205/1 diff --git a/include/osmocom/mgcp/mgcp_endp.h b/include/osmocom/mgcp/mgcp_endp.h index 4f41818..5ecebda 100644 --- a/include/osmocom/mgcp/mgcp_endp.h +++ b/include/osmocom/mgcp/mgcp_endp.h @@ -138,7 +138,7 @@ const struct mgcp_trunk *trunk); struct mgcp_endpoint *mgcp_endp_by_name(int *cause, const char *epname, struct mgcp_config *cfg); -bool mgcp_endp_avail(struct mgcp_endpoint *endp); +bool mgcp_endp_avail(const struct mgcp_endpoint *endp); void mgcp_endp_add_conn(struct mgcp_endpoint *endp, struct mgcp_conn *conn); void mgcp_endp_remove_conn(struct mgcp_endpoint *endp, struct mgcp_conn *conn); void mgcp_endp_free_conn_oldest(struct mgcp_endpoint *endp); diff --git a/src/libosmo-mgcp/mgcp_endp.c b/src/libosmo-mgcp/mgcp_endp.c index c91a00d..4c51266 100644 --- a/src/libosmo-mgcp/mgcp_endp.c +++ b/src/libosmo-mgcp/mgcp_endp.c @@ -446,7 +446,7 @@ /* Check if the selected E1 endpoint is avalable, which means that none of * the overlapping endpoints are currently serving a call. (if the system * is properly configured such a situation should never ocurr!) */ -static bool endp_avail_e1(struct mgcp_endpoint *endp) +static bool endp_avail_e1(const struct mgcp_endpoint *endp) { /* The following map shows the overlapping of the subslots and their * respective rates. The numbers on the right running from top to bottom @@ -522,7 +522,7 @@ break; /* Pick overlapping endpoint to check */ - epname_check = gen_e1_epname(endp, endp->trunk->cfg->domain, + epname_check = gen_e1_epname(NULL, endp->trunk->cfg->domain, endp->trunk->trunk_nr, ts_nr, interlock[i]); endp_check = mgcp_endp_find_specific(epname_check, endp->trunk); @@ -552,7 +552,7 @@ /*! check if an endpoint is available for any kind of operation. * \param[in] endp endpoint to check. * \returns true if endpoint is avalable, false it is blocked for any reason. */ -bool mgcp_endp_avail(struct mgcp_endpoint *endp) +bool mgcp_endp_avail(const struct mgcp_endpoint *endp) { switch (endp->trunk->trunk_type) { case MGCP_TRUNK_VIRTUAL: -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39205?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I31ed2f3abbcf024ee44f62e130dd4ec01611ae97 Gerrit-Change-Number: 39205 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

6 months

1
0
0 0

[XS] Change in osmo-mgw[master]: cosmetic: mgw: iuup: Update comment

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39204?usp=email ) Change subject: cosmetic: mgw: iuup: Update comment ...................................................................... cosmetic: mgw: iuup: Update comment Change-Id: I6e1448bf7e3bb7454754147e2b2e01844c157500 --- M src/libosmo-mgcp/mgcp_iuup.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/04/39204/1 diff --git a/src/libosmo-mgcp/mgcp_iuup.c b/src/libosmo-mgcp/mgcp_iuup.c index 4832ddc..a284070 100644 --- a/src/libosmo-mgcp/mgcp_iuup.c +++ b/src/libosmo-mgcp/mgcp_iuup.c @@ -544,7 +544,7 @@ msgb_pull_to_l2(msg); rtph = (struct rtp_hdr *)msgb_push(msg, sizeof(*rtph)); - /* TODO: fill rtph properly: */ + /* rtph is further filled in mgcp_send_iuup() below. */ *rtph = (struct rtp_hdr){ .csrc_count = 0, .extension = 0, -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39204?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6e1448bf7e3bb7454754147e2b2e01844c157500 Gerrit-Change-Number: 39204 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

6 months

1
0
0 0

[XS] Change in osmo-mgw[master]: mgcp-client: Fix regression checking null ptr

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39203?usp=email ) Change subject: mgcp-client: Fix regression checking null ptr ...................................................................... mgcp-client: Fix regression checking null ptr A recent patch introduced a bug checking incorrectly for null ptr. Related: Coverity CID#445417 Related: Coverity CID#445418 Fixes: e6ef4e7484a132cce812396c776f7ab2a291cf8e Change-Id: I1a458a34376851aec73c14a658cccd6132a5eb6c --- M src/libosmo-mgcp-client/mgcp_client.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c index 8a7c1f6..ab8ba9f 100644 --- a/src/libosmo-mgcp-client/mgcp_client.c +++ b/src/libosmo-mgcp-client/mgcp_client.c @@ -864,7 +864,7 @@ }; osmo_strlcpy(mgcp_msg_dlcx.endpoint, epname, sizeof(mgcp_msg_dlcx.endpoint)); msgb_dlcx = mgcp_msg_gen(mgcp, &mgcp_msg_dlcx); - if (msgb_dlcx) { + if (!msgb_dlcx) { LOGPMGW(mgcp, LOGL_ERROR, "Failed generating MGCP DLCX %s\n", epname); return; } @@ -881,7 +881,7 @@ }; OSMO_STRLCPY_ARRAY(mgcp_msg_auep.endpoint, epname); msgb_auep = mgcp_msg_gen(mgcp, &mgcp_msg_auep); - if (msgb_auep) { + if (!msgb_auep) { LOGPMGW(mgcp, LOGL_ERROR, "Failed generating MGCP AUEP %s\n", epname); return; } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39203?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I1a458a34376851aec73c14a658cccd6132a5eb6c Gerrit-Change-Number: 39203 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months

1
0
0 0

[XS] Change in osmo-mgw[master]: mgcp-client: Fix regression checking null ptr

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39203?usp=email ) Change subject: mgcp-client: Fix regression checking null ptr ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Merging this myself since it's an obvious bug I introduced myself. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39203?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I1a458a34376851aec73c14a658cccd6132a5eb6c Gerrit-Change-Number: 39203 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 23 Dec 2024 10:39:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

6 months

1
0
0 0

[XS] Change in osmo-mgw[master]: mgcp-client: Fix regression checking null ptr

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39203?usp=email ) Change subject: mgcp-client: Fix regression checking null ptr ...................................................................... mgcp-client: Fix regression checking null ptr A recent patch introduced a bug checking incorrectly for null ptr. Related: Coverity CID#445417 Related: Coverity CID#445418 Fixes: e6ef4e7484a132cce812396c776f7ab2a291cf8e Change-Id: I1a458a34376851aec73c14a658cccd6132a5eb6c --- M src/libosmo-mgcp-client/mgcp_client.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/03/39203/1 diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c index 8a7c1f6..ab8ba9f 100644 --- a/src/libosmo-mgcp-client/mgcp_client.c +++ b/src/libosmo-mgcp-client/mgcp_client.c @@ -864,7 +864,7 @@ }; osmo_strlcpy(mgcp_msg_dlcx.endpoint, epname, sizeof(mgcp_msg_dlcx.endpoint)); msgb_dlcx = mgcp_msg_gen(mgcp, &mgcp_msg_dlcx); - if (msgb_dlcx) { + if (!msgb_dlcx) { LOGPMGW(mgcp, LOGL_ERROR, "Failed generating MGCP DLCX %s\n", epname); return; } @@ -881,7 +881,7 @@ }; OSMO_STRLCPY_ARRAY(mgcp_msg_auep.endpoint, epname); msgb_auep = mgcp_msg_gen(mgcp, &mgcp_msg_auep); - if (msgb_auep) { + if (!msgb_auep) { LOGPMGW(mgcp, LOGL_ERROR, "Failed generating MGCP AUEP %s\n", epname); return; } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39203?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I1a458a34376851aec73c14a658cccd6132a5eb6c Gerrit-Change-Number: 39203 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

6 months

1
0
0 0

[S] Change in libosmo-gprs[master]: rlcmac: fix EGPRS BEP Link Quality Measurements Type 2

by laforge

Attention is currently required from: fixeria, laforge. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/39187?usp=email ) Change subject: rlcmac: fix EGPRS BEP Link Quality Measurements Type 2 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-gprs/+/39187/comment/60817bd2_126d9974… : PS1, Line 9: is IE is defined in 3GPP TS 44.060 Table 12.5a.2.1. might manke sense to add the spec reference directly above the struct definition? -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/39187?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Iac4de18ef25386f774bb409201b7a7996d1c8824 Gerrit-Change-Number: 39187 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 21 Dec 2024 13:31:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

6 months

1
0
0 0

[S] Change in osmo-pcu[master]: gsm_rlcmac: fix EGPRS BEP Link Quality Measurements Type 2

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-pcu/+/39188?usp=email ) Change subject: gsm_rlcmac: fix EGPRS BEP Link Quality Measurements Type 2 ...................................................................... Patch Set 2: (1 comment) File tests/rlcmac/RLCMACTest.err: https://gerrit.osmocom.org/c/osmo-pcu/+/39188/comment/f15c9f8b_b1e1d212?usp… : PS2, Line 42: DCSN1 INFO csnStreamDecoder (type: Pkt Resource Req (5)): PayloadType = 1 | spare = 0 | R = 0 | MESSAGE_TYPE = 5 | Exist_ACCESS_TYPE = 1 | ACCESS_TYPE = 3 | : ID | Choice PacketResourceRequestID = 1 | u.TLLI = 0x96cb3568 | : End ID | Exist_MS_Radio_Access_capability2 = 1 | : MS_Radio_Access_capability2 | MS_RA_capability_value { | Choice MS_RA_capability_value_Choice = 7 | u.Content length = 50 | offset = 1 | RF_Power_Capability = 4 | Exist_A5_bits = 1 | A5_bits = 80 | ES_IND = 1 | PS = 1 | VGCS = 0 | VBS = 0 | Exist_Multislot_capability = 1 | : Multislot_capability | Exist_HSCSD_multislot_class = 0 | Exist_GPRS_multislot_class = 1 | GPRS_multislot_class = 11 | GPRS_Extended_Dynamic_Allocation_Capability = 1 | Exist_SM = 1 | SMS_VALUE = 2 | SM_VALUE = 2 | Exist_ECSD_multislot_class = 0 | Exist_EGPRS_multislot_class = 1 | EGPRS_multislot_class = 11 | EGPRS_Extended_Dynamic_Allocation_Capability = 1 | Exist_DTM_GPRS_multislot_class = 0 | : End Multislot_capability | Exist_Eight_PSK_Power_Capability = 1 | Eight_PSK_Power_Capability = 2 | COMPACT_Interference_Measurement_Capability = 0 | Revision_Level_Indicator = 1 | UMTS_FDD_Radio_Access_Technology_Capability = 0 | UMTS_384_TDD_Radio_Access_Technology_Capability = 0 | CDMA2000_Radio_Access_Technology_Capability = 0 | UMTS_128_TDD_Radio_Access_Technology_Capability = NULL | GERAN_Feature_Package_1 = NULL | Modulation_based_multislot_class_support = NULL | GMSK_MultislotPowerProfile = NULL | EightPSK_MultislotProfile = NULL | MultipleTBF_Capability = NULL | DownlinkAdvancedReceiverPerformance = NULL | ExtendedRLC_MAC_ControlMessageSegmentionsCapability = NULL | DTM_EnhancementsCapability = NULL | PS_HandoverCapability = NULL | DTM_Handover_Capability = NULL | FlexibleTimeslotAssignment = NULL | GAN_PS_HandoverCapability = NULL | RLC_Non_persistentMode = NULL | ReducedLatencyCapability = NULL | UplinkEGPRS2 = NULL | DownlinkEGPRS2 = NULL | EUTRA_FDD_Support = NULL | EUTRA_TDD_Support = NULL | GERAN_To_EUTRAN_supportInGERAN_PTM = NULL | PriorityBasedReselectionSupport = NULL | MS_RA_capability_value } | : End MS_Radio_Access_capability2 | : Channel_Request_Description | PEAK_THROUGHPUT_CLASS = 9 | RADIO_PRIORITY = 0 | RLC_MODE = 0 | LLC_PDU_TYPE = 1 | RLC_OCTET_COUNT = 39 | : End Channel_Request_Description | Exist_CHANGE_MARK = 0 | C_VALUE = 19 | Exist_SIGN_VAR = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | Exist_AdditionsR99 = 1 | : AdditionsR99 | Exist_EGPRS_BEP_LinkQualityMeasurements = 0 | Exist_EGPRS_TimeslotLinkQualityMeasurements = 0 | Exist_PFI = 0 | MS_RAC_AdditionalInformationAvailable = 0 | RetransmissionOfPRR = 0 | Exist_AdditionsR5 = 1 | : AdditionsR5 | Exist_Iu_Mode_ChRequestDesk = 0 | Exist_HFN_LSB = 0 | Exist_AdditionsR6 = 1 | : AdditionsR6 | Exist_Ext_Channel_Request_desc = 0 | Exist_AdditionsR7 = 1 | : AdditionsR7 | EARLY_TBF_ESTABLISHMENT = 0 | Exist_EGPRS_BEP_LinkQualityMeasurements_type2 = 1 | : EGPRS_BEP_LinkQualityMeasurements_type2 | Exist_GMSK_MEAN_BEP = 1 | GMSK_MEAN_BEP = 5 | GMSK_CV_BEP = 3 | Exist_8PSK_MEAN_BEP = 0 | Exist_QPSK_MEAN_BEP = 0 | Exist_16QAM_NSR_MEAN_BEP = 1 | p16QAM_NSR_MEAN_BEP = 11 | DCSN1 ERROR csnStreamDecoder: error NEED_MORE BITS TO UNPACK (-5) at p16QAM_NSR_CV_BEP (idx 184): End EGPRS_BEP_LinkQualityMeasurements_type2 | : End AdditionsR7 | : End AdditionsR6 | : End AdditionsR5 | : End AdditionsR99 | > I wonder why we still get an error here. As I said, it's an unrelated problem. Early versions of 3GPP TS 44.060 required to use the standard 2b-padding. Later versions added release extensions and say that `0 **` (zero padding) shall be used. This does not take backwards compatibility into account, and makes it hard to parse RLC/MAC PDUs originated by old phones. In this case the PDU has `2b2b2b` at the end, but we implement the recent version of 3GPP, so we try to parse padding and run into problems... -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/39188?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I061ac16df5e6413266de08884f791f0264791192 Gerrit-Change-Number: 39188 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Dec 2024 21:15:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

6 months

1
0
0 0

[S] Change in osmo-pcu[master]: gsm_rlcmac: fix EGPRS BEP Link Quality Measurements Type 2

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-pcu/+/39188?usp=email ) Change subject: gsm_rlcmac: fix EGPRS BEP Link Quality Measurements Type 2 ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File tests/rlcmac/RLCMACTest.err: https://gerrit.osmocom.org/c/osmo-pcu/+/39188/comment/04cae85b_785a7337?usp… : PS2, Line 42: DCSN1 INFO csnStreamDecoder (type: Pkt Resource Req (5)): PayloadType = 1 | spare = 0 | R = 0 | MESSAGE_TYPE = 5 | Exist_ACCESS_TYPE = 1 | ACCESS_TYPE = 3 | : ID | Choice PacketResourceRequestID = 1 | u.TLLI = 0x96cb3568 | : End ID | Exist_MS_Radio_Access_capability2 = 1 | : MS_Radio_Access_capability2 | MS_RA_capability_value { | Choice MS_RA_capability_value_Choice = 7 | u.Content length = 50 | offset = 1 | RF_Power_Capability = 4 | Exist_A5_bits = 1 | A5_bits = 80 | ES_IND = 1 | PS = 1 | VGCS = 0 | VBS = 0 | Exist_Multislot_capability = 1 | : Multislot_capability | Exist_HSCSD_multislot_class = 0 | Exist_GPRS_multislot_class = 1 | GPRS_multislot_class = 11 | GPRS_Extended_Dynamic_Allocation_Capability = 1 | Exist_SM = 1 | SMS_VALUE = 2 | SM_VALUE = 2 | Exist_ECSD_multislot_class = 0 | Exist_EGPRS_multislot_class = 1 | EGPRS_multislot_class = 11 | EGPRS_Extended_Dynamic_Allocation_Capability = 1 | Exist_DTM_GPRS_multislot_class = 0 | : End Multislot_capability | Exist_Eight_PSK_Power_Capability = 1 | Eight_PSK_Power_Capability = 2 | COMPACT_Interference_Measurement_Capability = 0 | Revision_Level_Indicator = 1 | UMTS_FDD_Radio_Access_Technology_Capability = 0 | UMTS_384_TDD_Radio_Access_Technology_Capability = 0 | CDMA2000_Radio_Access_Technology_Capability = 0 | UMTS_128_TDD_Radio_Access_Technology_Capability = NULL | GERAN_Feature_Package_1 = NULL | Modulation_based_multislot_class_support = NULL | GMSK_MultislotPowerProfile = NULL | EightPSK_MultislotProfile = NULL | MultipleTBF_Capability = NULL | DownlinkAdvancedReceiverPerformance = NULL | ExtendedRLC_MAC_ControlMessageSegmentionsCapability = NULL | DTM_EnhancementsCapability = NULL | PS_HandoverCapability = NULL | DTM_Handover_Capability = NULL | FlexibleTimeslotAssignment = NULL | GAN_PS_HandoverCapability = NULL | RLC_Non_persistentMode = NULL | ReducedLatencyCapability = NULL | UplinkEGPRS2 = NULL | DownlinkEGPRS2 = NULL | EUTRA_FDD_Support = NULL | EUTRA_TDD_Support = NULL | GERAN_To_EUTRAN_supportInGERAN_PTM = NULL | PriorityBasedReselectionSupport = NULL | MS_RA_capability_value } | : End MS_Radio_Access_capability2 | : Channel_Request_Description | PEAK_THROUGHPUT_CLASS = 9 | RADIO_PRIORITY = 0 | RLC_MODE = 0 | LLC_PDU_TYPE = 1 | RLC_OCTET_COUNT = 39 | : End Channel_Request_Description | Exist_CHANGE_MARK = 0 | C_VALUE = 19 | Exist_SIGN_VAR = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | Exist_AdditionsR99 = 1 | : AdditionsR99 | Exist_EGPRS_BEP_LinkQualityMeasurements = 0 | Exist_EGPRS_TimeslotLinkQualityMeasurements = 0 | Exist_PFI = 0 | MS_RAC_AdditionalInformationAvailable = 0 | RetransmissionOfPRR = 0 | Exist_AdditionsR5 = 1 | : AdditionsR5 | Exist_Iu_Mode_ChRequestDesk = 0 | Exist_HFN_LSB = 0 | Exist_AdditionsR6 = 1 | : AdditionsR6 | Exist_Ext_Channel_Request_desc = 0 | Exist_AdditionsR7 = 1 | : AdditionsR7 | EARLY_TBF_ESTABLISHMENT = 0 | Exist_EGPRS_BEP_LinkQualityMeasurements_type2 = 1 | : EGPRS_BEP_LinkQualityMeasurements_type2 | Exist_GMSK_MEAN_BEP = 1 | GMSK_MEAN_BEP = 5 | GMSK_CV_BEP = 3 | Exist_8PSK_MEAN_BEP = 0 | Exist_QPSK_MEAN_BEP = 0 | Exist_16QAM_NSR_MEAN_BEP = 1 | p16QAM_NSR_MEAN_BEP = 11 | DCSN1 ERROR csnStreamDecoder: error NEED_MORE BITS TO UNPACK (-5) at p16QAM_NSR_CV_BEP (idx 184): End EGPRS_BEP_LinkQualityMeasurements_type2 | : End AdditionsR7 | : End AdditionsR6 | : End AdditionsR5 | : End AdditionsR99 | I wonder why we still get an error here. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/39188?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I061ac16df5e6413266de08884f791f0264791192 Gerrit-Change-Number: 39188 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Dec 2024 21:09:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

6 months

1
0
0 0

[XS] Change in osmo-pcu[master]: Add .checkpatch.conf, ignore src/gsm_rlcmac.c

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-pcu/+/39202?usp=email ) Change subject: Add .checkpatch.conf, ignore src/gsm_rlcmac.c ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/39202?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I91e05f9742aaac6ec61a1668ce3b63e8da52032d Gerrit-Change-Number: 39202 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Dec 2024 21:08:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2024