December 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-pcap[master]: pcap-client: Improve conn logging

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39172?usp=email ) Change subject: pcap-client: Improve conn logging ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39172?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I078557144a2604e343ed0b44f72035a4eda8a674 Gerrit-Change-Number: 39172 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Dec 2024 17:35:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months

1
0
0 0

[S] Change in osmo-pcap[master]: pcap-client: Improve pcap_handle logging

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39171?usp=email ) Change subject: pcap-client: Improve pcap_handle logging ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39171?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I917091fa993e903493ede39cd7164a830716250f Gerrit-Change-Number: 39171 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Dec 2024 17:35:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months

1
0
0 0

[L] Change in osmo-pcap[master]: pcap-client: Decouple dev capture handling from client

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39170?usp=email ) Change subject: pcap-client: Decouple dev capture handling from client ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39170?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I02f33f11cbcb7ed5ff6475df9442741618178379 Gerrit-Change-Number: 39170 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Dec 2024 17:35:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months

1
0
0 0

[M] Change in pysim[master]: global_platform: add new command "install_cap"

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39199?usp=email ) Change subject: global_platform: add new command "install_cap" ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6cbd37f0fad5579b20e83c27349bd5acc129e6d0 Gerrit-Change-Number: 39199 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Dec 2024 17:24:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months

1
0
0 0

[M] Change in pysim[master]: global_platform: LOAD and INSTALL [for load] support

by laforge

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37454?usp=email ) Change subject: global_platform: LOAD and INSTALL [for load] support ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37454?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I924aaeecbb3a72bdb65eefbff6135e4e9570579e Gerrit-Change-Number: 37454 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 20 Dec 2024 17:23:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

6 months

1
0
0 0

[M] Change in pysim[master]: javacard: add parser for JAVA-card CAP file format

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39198?usp=email ) Change subject: javacard: add parser for JAVA-card CAP file format ...................................................................... Patch Set 1: (4 comments) File pySim/javacard.py: https://gerrit.osmocom.org/c/pysim/+/39198/comment/e3f8a363_d43eb964?usp=em… : PS1, Line 45: can we somehow check easily if a file is extended and in that case print a meaningful error message? https://gerrit.osmocom.org/c/pysim/+/39198/comment/2b0437ce_47f40f21?usp=em… : PS1, Line 47: __component_header = None : __component_directory = None : __component_applet = None #optional : __component_import = None : __component_constantPool = None : __component_class = None : __component_method = None : __component_staticField = None : __component_referenceLocation = None : __component_export = None #optional : __component_descriptor = None : __component_debug = None #optional, since CAP format 2.2 doesn't it make sense to use a dict here, indexed by the component type? Just a thought. https://gerrit.osmocom.org/c/pysim/+/39198/comment/a3afdc52_db227642?usp=em… : PS1, Line 86: if filename.lower().endswith('header.cap'): : self.__component_header = cap.read(filename) : elif filename.lower().endswith('directory.cap'): : self.__component_directory = cap.read(filename) : elif filename.lower().endswith('applet.cap'): : self.__component_applet = cap.read(filename) : elif filename.lower().endswith('import.cap'): : self.__component_import = cap.read(filename) : elif filename.lower().endswith('constantpool.cap'): : self.__component_constantPool = cap.read(filename) : elif filename.lower().endswith('class.cap'): : self.__component_class = cap.read(filename) : elif filename.lower().endswith('method.cap'): : self.__component_method = cap.read(filename) : elif filename.lower().endswith('staticfield.cap'): : self.__component_staticField = cap.read(filename) : elif filename.lower().endswith('reflocation.cap'): : self.__component_referenceLocation = cap.read(filename) : elif filename.lower().endswith('export.cap'): : self.__component_export = cap.read(filename) : elif filename.lower().endswith('descriptor.cap'): : self.__component_descriptor = cap.read(filename) : elif filename.lower().endswith('debug.cap'): : self.__component_debug = cap.read(filename) IMHO, this looks like a lot of copy+paste / typing work in something that can be implemented more elegantly and programmatically: ``` if not filename.lower().endswith('.cap') continue setattr(self, '__component_' + filename.removesuffix(.cap), cap.read(filename)) ``` https://gerrit.osmocom.org/c/pysim/+/39198/comment/af30a855_e085077b?usp=em… : PS1, Line 113: if self.__component_header is None: : raise ValueError("invalid cap file, COMPONENT_Header missing!") : if self.__component_directory is None: : raise ValueError("invalid cap file, COMPONENT_Directory missing!") : if self.__component_import is None: : raise ValueError("invalid cap file, COMPONENT_Import missing!") : if self.__component_constantPool is None: : raise ValueError("invalid cap file, COMPONENT_ConstantPool missing!") : if self.__component_class is None: : raise ValueError("invalid cap file, COMPONENT_Class missing!") : if self.__component_method is None: : raise ValueError("invalid cap file, COMPONENT_Method missing!") : if self.__component_staticField is None: : raise ValueError("invalid cap file, COMPONENT_StaticField missing!") : if self.__component_referenceLocation is None: : raise ValueError("invalid cap file, COMPONENT_ReferenceLocation missing!") : if self.__component_descriptor is None: : raise ValueError("invalid cap file, COMPONENT_Descriptor missing!") likewise here, that's a lot of code to write. Why not simply have a ``` required_components = ['header', 'directory', ...] for comp in required_components: ... ``` -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I581483ccb9d8a254fcecc995fec3c811c5cf38eb Gerrit-Change-Number: 39198 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Dec 2024 17:23:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

6 months

1
0
0 0

[M] Change in osmo-pcap[master]: pcap-server: Move stats to its own file

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39157?usp=email ) Change subject: pcap-server: Move stats to its own file ...................................................................... pcap-server: Move stats to its own file This will allow easily including the .o file in a unit tests which will be added soon testing code from osmo_server_network.c, which requires the pcap_server_group_desc symbol. Change-Id: I71734a4c78e4d3109947ff5e69c3a382a7908218 --- M include/osmo-pcap/osmo_pcap_server.h M src/Makefile.am M src/osmo_server_main.c A src/osmo_server_stats.c 4 files changed, 70 insertions(+), 32 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmo-pcap/osmo_pcap_server.h b/include/osmo-pcap/osmo_pcap_server.h index 5fe6d11..622daa7 100644 --- a/include/osmo-pcap/osmo_pcap_server.h +++ b/include/osmo-pcap/osmo_pcap_server.h @@ -140,6 +140,7 @@ extern struct osmo_pcap_server *pcap_server; extern const struct rate_ctr_group_desc pcap_peer_group_desc; +extern const struct rate_ctr_group_desc pcap_server_group_desc; void osmo_pcap_server_reopen(struct osmo_pcap_server *server); int osmo_pcap_server_listen(struct osmo_pcap_server *server); diff --git a/src/Makefile.am b/src/Makefile.am index a86b578..8c2c968 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -35,6 +35,7 @@ osmo_common.c \ osmo_server_vty.c \ osmo_server_network.c \ + osmo_server_stats.c \ osmo_tls.c \ $(NULL) diff --git a/src/osmo_server_main.c b/src/osmo_server_main.c index 85f4290..8924b86 100644 --- a/src/osmo_server_main.c +++ b/src/osmo_server_main.c @@ -1,6 +1,7 @@ /* * osmo-pcap-server code * + * (C) 2024 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> * (C) 2011-2016 by Holger Hans Peter Freyther <holger(a)moiji-mobile.com> * (C) 2011 by On-Waves * All Rights Reserved @@ -53,38 +54,6 @@ void *tall_srv_ctx; struct osmo_pcap_server *pcap_server; - -static const struct rate_ctr_desc pcap_peer_ctr_desc[] = { - [PEER_CTR_CONNECT] = { "peer:connect", "Connect of a peer " }, - [PEER_CTR_BYTES] = { "peer:bytes", "Received bytes " }, - [PEER_CTR_PKTS] = { "peer:pkts", "Received packets " }, - [PEER_CTR_PROTATE] = { "peer:file_rotated","Capture file rotated" }, -}; - -static const struct rate_ctr_desc pcap_server_ctr_desc[] = { - [SERVER_CTR_CONNECT] = { "server:connect", "Connect of a peer " }, - [SERVER_CTR_BYTES] = { "server:bytes", "Received bytes " }, - [SERVER_CTR_PKTS] = { "server:pkts", "Received packets " }, - [SERVER_CTR_PROTATE] = { "server:file_rotated", "Capture file rotated" }, - [SERVER_CTR_NOCLIENT] = { "server:no_client", "Unknown connected " }, -}; - -const struct rate_ctr_group_desc pcap_peer_group_desc = { - .group_name_prefix = NULL, /* will be dynamically patched */ - .group_description = "PCAP peer statistics", - .num_ctr = ARRAY_SIZE(pcap_peer_ctr_desc), - .ctr_desc = pcap_peer_ctr_desc, - .class_id = OSMO_STATS_CLASS_PEER, -}; - -static const struct rate_ctr_group_desc pcap_server_group_desc = { - .group_name_prefix = "pcap:server", - .group_description = "PCAP Server global statistics", - .num_ctr = ARRAY_SIZE(pcap_server_ctr_desc), - .ctr_desc = pcap_server_ctr_desc, - .class_id = OSMO_STATS_CLASS_GLOBAL, -}; - static struct vty_app_info vty_info = { .name = "OsmoPCAPServer", .version = PACKAGE_VERSION, diff --git a/src/osmo_server_stats.c b/src/osmo_server_stats.c new file mode 100644 index 0000000..b2a4527 --- /dev/null +++ b/src/osmo_server_stats.c @@ -0,0 +1,67 @@ +/* + * osmo-pcap-server code + * + * (C) 2024 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> + * (C) 2011-2016 by Holger Hans Peter Freyther <holger(a)moiji-mobile.com> + * (C) 2011 by On-Waves + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + * + */ + +#include <osmocom/core/rate_ctr.h> +#include <osmocom/core/stats.h> +#include <osmocom/core/talloc.h> +#include <osmocom/core/utils.h> + +#include <osmocom/vty/logging.h> +#include <osmocom/vty/telnet_interface.h> +#include <osmocom/vty/stats.h> +#include <osmocom/vty/misc.h> + +#include <osmo-pcap/common.h> +#include <osmo-pcap/osmo_pcap_server.h> +#include <osmo-pcap/osmo_tls.h> + +static const struct rate_ctr_desc pcap_peer_ctr_desc[] = { + [PEER_CTR_CONNECT] = { "peer:connect", "Connect of a peer " }, + [PEER_CTR_BYTES] = { "peer:bytes", "Received bytes " }, + [PEER_CTR_PKTS] = { "peer:pkts", "Received packets " }, + [PEER_CTR_PROTATE] = { "peer:file_rotated", "Capture file rotated" }, +}; + +static const struct rate_ctr_desc pcap_server_ctr_desc[] = { + [SERVER_CTR_CONNECT] = { "server:connect", "Connect of a peer " }, + [SERVER_CTR_BYTES] = { "server:bytes", "Received bytes " }, + [SERVER_CTR_PKTS] = { "server:pkts", "Received packets " }, + [SERVER_CTR_PROTATE] = { "server:file_rotated", "Capture file rotated" }, + [SERVER_CTR_NOCLIENT] = { "server:no_client", "Unknown connected " }, +}; + +const struct rate_ctr_group_desc pcap_peer_group_desc = { + .group_name_prefix = NULL, /* will be dynamically patched */ + .group_description = "PCAP peer statistics", + .num_ctr = ARRAY_SIZE(pcap_peer_ctr_desc), + .ctr_desc = pcap_peer_ctr_desc, + .class_id = OSMO_STATS_CLASS_PEER, +}; + +const struct rate_ctr_group_desc pcap_server_group_desc = { + .group_name_prefix = "pcap:server", + .group_description = "PCAP Server global statistics", + .num_ctr = ARRAY_SIZE(pcap_server_ctr_desc), + .ctr_desc = pcap_server_ctr_desc, + .class_id = OSMO_STATS_CLASS_GLOBAL, +}; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39157?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I71734a4c78e4d3109947ff5e69c3a382a7908218 Gerrit-Change-Number: 39157 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months

1
0
0 0

[XS] Change in osmo-pcap[master]: pcap-server: Improve log error opening pcap file

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39163?usp=email ) Change subject: pcap-server: Improve log error opening pcap file ...................................................................... pcap-server: Improve log error opening pcap file Change-Id: Id7ff71f2259cd1e0401937ffcd51b8bb0be56e3e --- M src/osmo_server_network.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo_server_network.c b/src/osmo_server_network.c index d8d1867..6b70ef8 100644 --- a/src/osmo_server_network.c +++ b/src/osmo_server_network.c @@ -174,7 +174,8 @@ conn->local_fd = creat(conn->curr_filename, conn->server->permission_mask); if (conn->local_fd < 0) { - LOGP(DSERVER, LOGL_ERROR, "Failed to file: '%s'\n", conn->curr_filename); + LOGP(DSERVER, LOGL_ERROR, "Failed to create file '%s': %s\n", + conn->curr_filename, strerror(errno)); return; } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39163?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Id7ff71f2259cd1e0401937ffcd51b8bb0be56e3e Gerrit-Change-Number: 39163 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months

1
0
0 0

[XL] Change in osmo-pcap[master]: pcap-server: Make rotate-localtime feature configurable through VTY

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39158?usp=email ) Change subject: pcap-server: Make rotate-localtime feature configurable through VTY ...................................................................... pcap-server: Make rotate-localtime feature configurable through VTY Related: SYS#7100 Change-Id: Idf17a161c17050bb62793a82e39179a093b35f73 --- M .gitignore M configure.ac M doc/manuals/chapters/server.adoc M include/osmo-pcap/osmo_pcap_server.h M src/osmo_server_main.c M src/osmo_server_network.c M src/osmo_server_vty.c M tests/Makefile.am A tests/rotate_localtime/Makefile.am A tests/rotate_localtime/rotate_localtime_test.c A tests/rotate_localtime/rotate_localtime_test.err A tests/rotate_localtime/rotate_localtime_test.ok M tests/testsuite.at 13 files changed, 1,754 insertions(+), 9 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/.gitignore b/.gitignore index 274543c..affbe30 100644 --- a/.gitignore +++ b/.gitignore @@ -10,11 +10,11 @@ #configure aclocal.m4 autom4te.cache/ -config.log -config.status +config.* configure depcomp install-sh +ltmain.sh missing stamp-h1 compile diff --git a/configure.ac b/configure.ac index 72f1385..35892e6 100644 --- a/configure.ac +++ b/configure.ac @@ -60,6 +60,12 @@ AC_PROG_CC AC_PROG_INSTALL AC_PROG_RANLIB +LT_INIT + +dnl patching ${archive_cmds} to affect generation of file "libtool" to fix linking with clang +AS_CASE(["$LD"],[*clang*], + [AS_CASE(["${host_os}"], + [*linux*],[archive_cmds='$CC -shared $pic_flag $libobjs $deplibs $compiler_flags $wl-soname $wl$soname -o $lib'])]) dnl check for pkg-config (explained in detail in libosmocore/configure.ac) AC_PATH_PROG(PKG_CONFIG_INSTALLED, pkg-config, no) @@ -194,4 +200,5 @@ doc/examples/Makefile doc/manuals/Makefile tests/Makefile + tests/rotate_localtime/Makefile Makefile) diff --git a/doc/manuals/chapters/server.adoc b/doc/manuals/chapters/server.adoc index 4f60880..f67f451 100644 --- a/doc/manuals/chapters/server.adoc +++ b/doc/manuals/chapters/server.adoc @@ -39,14 +39,12 @@ base-path /var/lib/osmo-pcap-server <1> server ip 192.168.11.20 <2> server port 54321 <3> - max-file-size 100000000 <4> - max-snaplen 100000 <5> + max-snaplen 100000 <4> ---- <1> directory to which the pcap files are stored <2> IP address to which to bind/listen <3> TCP port number to which to bind/listen -<4> maximum size for pcap files; create a new file once max-file-size is reached -<5> maximum pcap snapshot length (per packet, in bytes; default: 9000) +<4> maximum pcap snapshot length (per packet, in bytes; default: 9000) The received packets are stored to a pcap file below the `base-path` using a filename encoding both the client name and the date/time at time of file creation. @@ -88,3 +86,42 @@ <3> file containing the certificate revocation list <4> file containing the server certificate <5> file containing the private key for the server certificate + +=== PCAP file rotation + +`osmo-pcap-server` can be configured to rotate the pcap file it writes to based +on multiple thresholds. Once such a threshold occurs, usually at the time where +a packet to be recorded into the pcap file is received. +`osmo-pcap-server` will decide whether to keep using the previous file or create +a new file and start writing to it instead. + +Current rotation thresholds are based on: + +* `max-file-size`: Rotate writing to a new file once the configured maximum file size is reached. +* `rotate-localtime`: Rotate writing a new file based on local time wall-clock +configuration + +.Example: configuring pcap file rotation +---- +server + ... + max-file-size 100000000 <1> + rotate-localtime hour <2> +---- +<1> Rotate to a new file once file reaches 100 MBytes. +<2> Rotate to a new file once the local time wall clock elapses to next hour (00:XY, 01:XY, 02:XY, ..., 23:XY) + +The `rotate-localtime` VTY option also allows triggering the pcap file rotation +every N units of time, using the `rotate-localtime TIME_UNIT mod N` variant. For +instance, `rotate-localtime minute mod 21` will trigger rotation of pcap file at +minutes XY:00, XY:21, XY:42 every hour. + +NOTE:: osmo-pcap-server rotates the pcap file when new traffic to be recorded is +received. That means, for instance following the example above, that if if no +traffic is received during XY:21 and XY:42, only 2 pcap wills be generated +instead of 3 during that hour. + +WARNING:: If wall clock goes backward (eg. due to drift correction or Daylight +Saving procedure) and `rotate-localtime` is enabled, osmo-pcap-server may end up +recreating (and truncating) a previous pcap file if it is generated with the +same localtime timestamp. diff --git a/include/osmo-pcap/osmo_pcap_server.h b/include/osmo-pcap/osmo_pcap_server.h index 622daa7..0a43a69 100644 --- a/include/osmo-pcap/osmo_pcap_server.h +++ b/include/osmo-pcap/osmo_pcap_server.h @@ -48,6 +48,16 @@ #define STATE_INITIAL 0 #define STATE_DATA 1 +/*! Rate counter interval */ +enum time_interval { + TIME_INTERVAL_SEC, /*!< second */ + TIME_INTERVAL_MIN, /*!< minute */ + TIME_INTERVAL_HOUR, /*!< hour */ + TIME_INTERVAL_DAY, /*!< day */ + TIME_INTERVAL_MONTH, /*!< month */ + TIME_INTERVAL_YEAR, /*!< year */ +}; + enum { PEER_CTR_CONNECT, PEER_CTR_BYTES, @@ -134,6 +144,12 @@ bool max_size_enabled; int max_snaplen; + struct { + bool enabled; + enum time_interval intv; + unsigned int modulus; + } rotate_localtime; + /* statistics */ struct rate_ctr_group *ctrg; }; diff --git a/src/osmo_server_main.c b/src/osmo_server_main.c index 8924b86..a04de9b 100644 --- a/src/osmo_server_main.c +++ b/src/osmo_server_main.c @@ -253,6 +253,10 @@ pcap_server->max_size = 1073741824; /* 1024^3, 1GB **/ pcap_server->max_size_enabled = true; pcap_server->max_snaplen = DEFAULT_SNAPLEN; + /* By default rotate daily: */ + pcap_server->rotate_localtime.enabled = true; + pcap_server->rotate_localtime.intv = TIME_INTERVAL_DAY; + pcap_server->rotate_localtime.modulus = 1; if (vty_read_config_file(config_file, NULL) < 0) { LOGP(DSERVER, LOGL_ERROR, diff --git a/src/osmo_server_network.c b/src/osmo_server_network.c index 63f026c..d8d1867 100644 --- a/src/osmo_server_network.c +++ b/src/osmo_server_network.c @@ -1,6 +1,7 @@ /* * osmo-pcap-server code * + * (C) 2024 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> * (C) 2011-2016 by Holger Hans Peter Freyther <holger(a)moiji-mobile.com> * (C) 2011 by On-Waves * All Rights Reserved @@ -227,11 +228,120 @@ return true; } +/* Checks if we are in a new record period since last time we wrote to a pcap, to know (return true) + * whether a new pcap file needs to be opened. It calculates period based on intv and mod. + * NOTE: Kept non-static to be able to validate it with unit tests. */ +bool check_localtime(const struct tm *last_write, const struct tm *tm, enum time_interval intv, unsigned int mod) +{ + unsigned long long last_start, current_start; + + switch (intv) { + case TIME_INTERVAL_SEC: + if (last_write->tm_sec == tm->tm_sec && + last_write->tm_min == tm->tm_min && + last_write->tm_hour == tm->tm_hour && + last_write->tm_mday == tm->tm_mday && + last_write->tm_mon == tm->tm_mon && + last_write->tm_year == tm->tm_year) + return false; + /* If minute/hour/day/month/year changed (passed through second 0), always rotate: */ + if (last_write->tm_min < tm->tm_min || + last_write->tm_hour < tm->tm_hour || + last_write->tm_mday < tm->tm_mday || + last_write->tm_mon < tm->tm_mon || + last_write->tm_year < tm->tm_year) + return true; + /* Same minute/hour/day/month/year, second changed. Check if we are still in same period: */ + last_start = last_write->tm_sec - (last_write->tm_sec % mod); + current_start = tm->tm_sec - (tm->tm_sec % mod); + if (current_start <= last_start) + return false; + return true; + case TIME_INTERVAL_MIN: + if (last_write->tm_min == tm->tm_min && + last_write->tm_hour == tm->tm_hour && + last_write->tm_mday == tm->tm_mday && + last_write->tm_mon == tm->tm_mon && + last_write->tm_year == tm->tm_year) + return false; + /* If hour/day/month/year changed (passed through minute 0), always rotate: */ + if (last_write->tm_hour < tm->tm_hour || + last_write->tm_mday < tm->tm_mday || + last_write->tm_mon < tm->tm_mon || + last_write->tm_year < tm->tm_year) + return true; + /* Same hour/day/month/year, minute changed. Check if we are still in same period: */ + last_start = last_write->tm_min - (last_write->tm_min % mod); + current_start = tm->tm_min - (tm->tm_min % mod); + if (current_start <= last_start) + return false; + return true; + case TIME_INTERVAL_HOUR: + if (last_write->tm_hour == tm->tm_hour && + last_write->tm_mday == tm->tm_mday && + last_write->tm_mon == tm->tm_mon && + last_write->tm_year == tm->tm_year) + return false; + /* If day/month/year changed (passed through hour 0), always rotate: */ + if (last_write->tm_mday < tm->tm_mday || + last_write->tm_mon < tm->tm_mon || + last_write->tm_year < tm->tm_year) + return true; + /* Same day/month/year, hour changed. Check if we are still in same period: */ + last_start = last_write->tm_hour - (last_write->tm_hour % mod); + current_start = tm->tm_hour - (tm->tm_hour % mod); + if (current_start <= last_start) + return false; + return true; + case TIME_INTERVAL_DAY: + if (last_write->tm_mday == tm->tm_mday && + last_write->tm_mon == tm->tm_mon && + last_write->tm_year == tm->tm_year) + return false; + /* If month/year changed (passed through day 1), always rotate: */ + if (last_write->tm_mon < tm->tm_mon || + last_write->tm_year < tm->tm_year) + return true; + /* Same month/year, day changed. Check if we are still in same period: */ + /* Note: tm_mday is [1, 31], hence the -1 below: */ + last_start = (last_write->tm_mday - 1) - ((last_write->tm_mday - 1) % mod); + current_start = (tm->tm_mday - 1) - ((tm->tm_mday - 1) % mod); + if (current_start <= last_start) + return false; + return true; + case TIME_INTERVAL_MONTH: + if (last_write->tm_mon == tm->tm_mon && + last_write->tm_year == tm->tm_year) + return false; + /* If year changed (passed through month 1), always rotate: */ + if (last_write->tm_year < tm->tm_year) + return true; + /* Same year, month changed. Check if we are still in same period: */ + last_start = last_write->tm_mon - (last_write->tm_mon % mod); + current_start = tm->tm_mon - (tm->tm_mon % mod); + if (current_start <= last_start) + return false; + return true; + case TIME_INTERVAL_YEAR: + /* Year changed. Check if we are still in same period: */ + last_start = last_write->tm_year - (last_write->tm_year % mod); + current_start = tm->tm_year - (tm->tm_year % mod); + if (current_start <= last_start) + return false; + return true; + default: + OSMO_ASSERT(false); + } +} + static bool check_restart_pcap_localtime(struct osmo_pcap_conn *conn, const struct tm *tm) { - if (conn->last_write.tm_mday == tm->tm_mday && - conn->last_write.tm_mon == tm->tm_mon && - conn->last_write.tm_year == tm->tm_year) + if (!pcap_server->rotate_localtime.enabled) + return false; + + if (!check_localtime(&conn->last_write, tm, + pcap_server->rotate_localtime.intv, + pcap_server->rotate_localtime.modulus)) return false; LOGP(DSERVER, LOGL_NOTICE, "Rolling over file for %s (localtime)\n", conn->name); restart_pcap(conn); diff --git a/src/osmo_server_vty.c b/src/osmo_server_vty.c index 507a477..3191cda 100644 --- a/src/osmo_server_vty.c +++ b/src/osmo_server_vty.c @@ -41,6 +41,16 @@ 1, }; +static const struct value_string time_interval_names[] = { + { TIME_INTERVAL_SEC, "second" }, + { TIME_INTERVAL_MIN, "minute" }, + { TIME_INTERVAL_HOUR, "hour" }, + { TIME_INTERVAL_DAY, "day" }, + { TIME_INTERVAL_MONTH, "month" }, + { TIME_INTERVAL_YEAR, "year" }, + { 0, NULL } +}; + static void write_tls(struct vty *vty, struct osmo_pcap_server *pcap_server) { if (!pcap_server->tls_on) @@ -93,6 +103,15 @@ vty_out(vty, " server ip %s%s", pcap_server->addr, VTY_NEWLINE); if (pcap_server->port > 0) vty_out(vty, " server port %d%s", pcap_server->port, VTY_NEWLINE); + if (pcap_server->rotate_localtime.enabled) { + const char *name = get_value_string(time_interval_names, pcap_server->rotate_localtime.intv); + if (pcap_server->rotate_localtime.modulus == 1) + vty_out(vty, " rotate-localtime %s%s", name, VTY_NEWLINE); + else + vty_out(vty, " rotate-localtime %s mod %u%s", name, pcap_server->rotate_localtime.modulus, VTY_NEWLINE); + } else { + vty_out(vty, " no rotate-localtime%s", VTY_NEWLINE); + } if (pcap_server->max_size_enabled) vty_out(vty, " max-file-size %llu%s", (unsigned long long)pcap_server->max_size, VTY_NEWLINE); else @@ -194,6 +213,81 @@ return CMD_SUCCESS; } +DEFUN(cfg_server_no_rotate_localtime, + cfg_server_no_rotate_localtime_cmd, + "no rotate-localtime", + NO_STR "Rotate pcap based on local time clock-wall frequency\n") +{ + pcap_server->rotate_localtime.enabled = false; + return CMD_SUCCESS; +} + + +static int apply_rotate_localtime(struct vty *vty, enum time_interval intv, unsigned int modulus) +{ + unsigned int max_mod = 0; + switch (pcap_server->rotate_localtime.intv) { + case TIME_INTERVAL_SEC: + max_mod = 60; + break; + case TIME_INTERVAL_MIN: + max_mod = 60; + break; + case TIME_INTERVAL_HOUR: + max_mod = 24; + break; + case TIME_INTERVAL_DAY: + max_mod = 31; + break; + case TIME_INTERVAL_MONTH: + max_mod = 12; + break; + case TIME_INTERVAL_YEAR: + max_mod = 4294967295; + break; + default: + return CMD_WARNING; + } + + if (modulus > max_mod) { + vty_out(vty, "%%Modulus %u too big for interval %s, maximum value is %u%s", + modulus, get_value_string(time_interval_names, intv), max_mod, VTY_NEWLINE); + return CMD_WARNING; + } + + pcap_server->rotate_localtime.enabled = true; + pcap_server->rotate_localtime.intv = intv; + pcap_server->rotate_localtime.modulus = modulus; + return CMD_SUCCESS; +} + +DEFUN(cfg_server_rotate_localtime, + cfg_server_rotate_localtime_cmd, + "rotate-localtime (second|minute|hour|day|month|year)", + "Rotate pcap based on local time clock-wall periodicity\n" + "Rotate every Second\n" + "Rotate every Minute\n" + "Rotate every Hour\n" + "Rotate every Day\n") +{ + return apply_rotate_localtime(vty, get_string_value(time_interval_names, argv[0]), 1); +} + +DEFUN(cfg_server_rotate_localtime_mod_n, + cfg_server_rotate_localtime_mod_n_cmd, + "rotate-localtime (second|minute|hour|day|month|year) mod <1-4294967295>", + "Rotate pcap based on local time clock-wall periodicity\n" + "Rotate every Second\n" + "Rotate every Minute\n" + "Rotate every Hour\n" + "Rotate every Day\n" + "Rotate every Nth second/minute/hour/day/month/year" + "Nth second/minute/hour/day/month/year") +{ + unsigned long long modulus = strtoull(argv[1], NULL, 10); + return apply_rotate_localtime(vty, get_string_value(time_interval_names, argv[0]), modulus); +} + DEFUN(cfg_server_max_size, cfg_server_max_size_cmd, "max-file-size NR", @@ -575,6 +669,9 @@ install_element(SERVER_NODE, &cfg_server_file_permission_mask_cmd); install_element(SERVER_NODE, &cfg_server_ip_cmd); install_element(SERVER_NODE, &cfg_server_port_cmd); + install_element(SERVER_NODE, &cfg_server_no_rotate_localtime_cmd); + install_element(SERVER_NODE, &cfg_server_rotate_localtime_cmd); + install_element(SERVER_NODE, &cfg_server_rotate_localtime_mod_n_cmd); install_element(SERVER_NODE, &cfg_server_max_size_cmd); install_element(SERVER_NODE, &cfg_server_no_max_size_cmd); install_element(SERVER_NODE, &cfg_server_max_snaplen_cmd); diff --git a/tests/Makefile.am b/tests/Makefile.am index 2098927..456e162 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -1,3 +1,7 @@ +SUBDIRS = \ + rotate_localtime \ + $(NULL) + # The `:;' works around a Bash 3.2 bug when the output is not writeable. $(srcdir)/package.m4: $(top_srcdir)/configure.ac :;{ \ diff --git a/tests/rotate_localtime/Makefile.am b/tests/rotate_localtime/Makefile.am new file mode 100644 index 0000000..fca9ff8 --- /dev/null +++ b/tests/rotate_localtime/Makefile.am @@ -0,0 +1,43 @@ +AM_CPPFLAGS = \ + -I$(top_srcdir)/include \ + $(NULL) + +AM_CFLAGS = \ + -Wall \ + $(LIBOSMOGSM_CFLAGS) \ + $(LIBOSMOGB_CFLAGS) \ + $(LIBOSMOVTY_CFLAGS) \ + $(LIBOSMOCORE_CFLAGS) \ + $(PCAP_CFLAGS) \ + $(LIBGNUTLS_CFLAGS) \ + $(NULL) + +AM_LDFLAGS = -no-install + +EXTRA_DIST = \ + rotate_localtime_test.ok \ + rotate_localtime_test.err \ + $(NULL) + +check_PROGRAMS = \ + rotate_localtime_test \ + $(NULL) + +rotate_localtime_test_SOURCES = \ + rotate_localtime_test.c \ + $(NULL) + +rotate_localtime_test_LDADD = \ + $(top_builddir)/src/osmo_server_network.o \ + $(top_builddir)/src/osmo_server_stats.o \ + $(top_builddir)/src/osmo_tls.o \ + $(LIBOSMOCORE_LIBS) \ + $(LIBOSMOVTY_LIBS) \ + $(LIBGNUTLS_LIBS) \ + $(LIBZMQ_LIBS) \ + $(NULL) + + +.PHONY: update_exp +update_exp: + $(builddir)/rotate_localtime_test >$(srcdir)/rotate_localtime_test.ok 2>$(srcdir)/rotate_localtime_test.err diff --git a/tests/rotate_localtime/rotate_localtime_test.c b/tests/rotate_localtime/rotate_localtime_test.c new file mode 100644 index 0000000..8ab7dc6 --- /dev/null +++ b/tests/rotate_localtime/rotate_localtime_test.c @@ -0,0 +1,1056 @@ +/* (C) 2024 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> + * + * All Rights Reserved + * + * SPDX-License-Identifier: AGPL-3.0+ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + * + */ + +#include <stdint.h> +#include <stdio.h> +#include <unistd.h> +#include <stdbool.h> +#include <getopt.h> +#include <time.h> + +#include <osmocom/core/logging.h> +#include <osmocom/core/application.h> + +#include <osmo-pcap/osmo_pcap_server.h> + +struct osmo_pcap_server *pcap_server; + +extern bool check_localtime(const struct tm *last_write, const struct tm *tm, enum time_interval intv, unsigned int mod); + +static void init_tm(struct tm *tm, int year, int month, int day, int hour, int min, int sec) +{ + memset(tm, 0, sizeof(*tm)); + tm->tm_sec = sec; + tm->tm_min = min; + tm->tm_hour = hour; + tm->tm_mday = day; + tm->tm_mon = month; + tm->tm_year = year - 1900; +} + +static enum time_interval test_intv; +static unsigned int test_mod; + +static void _run_test(struct tm *last_write, const struct tm *now, bool exp_ret, const char *file, int line) +{ + char buf1[128], buf2[128]; + strftime(buf1, sizeof(buf1), "%Y-%m-%d_%H:%M:%S", last_write); + strftime(buf2, sizeof(buf2), "%Y-%m-%d_%H:%M:%S", now); + + bool ret = check_localtime(last_write, now, test_intv, test_mod); + fprintf(stderr, "{%s} check_localtime(last_write=%s, intv=%u, mod=%u) -> %s\n", + buf2, buf1, test_intv, test_mod, + ret ? "REOPEN" : "KEEP"); + *last_write = *now; + if (ret != exp_ret) + osmo_panic("%s:%d: ret (%d) != exp_ret (%d)", file, line, ret, exp_ret); +} +#define run_test(last_write, now, exp_ret) _run_test(last_write, now, exp_ret, __FILE__, __LINE__) + + +static void test_check_localtime_second_mod_1(void) +{ + fprintf(stderr, "%s start\n", __func__); + + struct tm now, last_write; + memset(&last_write, 0, sizeof(last_write)); + test_intv = TIME_INTERVAL_SEC; + test_mod = 1; + + init_tm(&now, 2010, 2, 3, 4, 5, 6); + + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + run_test(&last_write, &now, false); + + now.tm_sec++; + run_test(&last_write, &now, true); + now.tm_sec++; + run_test(&last_write, &now, true); + now.tm_sec = 0; + run_test(&last_write, &now, false); + + now.tm_min += 1; + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + + now.tm_min += 1; + now.tm_sec += 23; + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + + now.tm_hour += 3; + now.tm_min += 0; + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + + now.tm_year += 3; + now.tm_mon += 2; + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + + fprintf(stderr, "%s end\n", __func__); +} + +static void test_check_localtime_second_mod_40(void) +{ + fprintf(stderr, "%s start\n", __func__); + + struct tm now, last_write; + memset(&last_write, 0, sizeof(last_write)); + test_intv = TIME_INTERVAL_SEC; + test_mod = 40; + + init_tm(&now, 2010, 2, 3, 4, 5, 0); + + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + run_test(&last_write, &now, false); + + now.tm_sec = 1; + run_test(&last_write, &now, false); + now.tm_sec = 30; + run_test(&last_write, &now, false); + now.tm_sec = 39; + run_test(&last_write, &now, false); + now.tm_sec = 41; + run_test(&last_write, &now, true); + + now.tm_min += 1; + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + + now.tm_min += 1; + now.tm_sec += 23; + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + + now.tm_hour += 3; + now.tm_min += 0; + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + + now.tm_year += 3; + now.tm_mon += 2; + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + + fprintf(stderr, "%s end\n", __func__); +} + +static void test_check_localtime_minute_mod_1(void) +{ + fprintf(stderr, "%s start\n", __func__); + + struct tm now, last_write; + memset(&last_write, 0, sizeof(last_write)); + test_intv = TIME_INTERVAL_MIN; + test_mod = 1; + + init_tm(&now, 2010, 2, 3, 4, 5, 6); + + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + run_test(&last_write, &now, false); + + now.tm_sec++; + run_test(&last_write, &now, false); + now.tm_sec++; + run_test(&last_write, &now, false); + now.tm_sec = 0; + run_test(&last_write, &now, false); + + now.tm_min++; + run_test(&last_write, &now, true); + now.tm_min++; + run_test(&last_write, &now, true); + now.tm_sec += 40; + run_test(&last_write, &now, false); + + now.tm_min += 2; + now.tm_sec = 20; + run_test(&last_write, &now, true); + + now.tm_min++; + now.tm_sec = 0; + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + + now.tm_hour++; + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + + now.tm_min += 48; + now.tm_sec += 3; + run_test(&last_write, &now, true); + + now.tm_min = 59; + run_test(&last_write, &now, true); + now.tm_hour++; + now.tm_min = 0; + run_test(&last_write, &now, true); + + now.tm_mday++; + run_test(&last_write, &now, true); + now.tm_mday += 20; + run_test(&last_write, &now, true); + now.tm_mon += 6; + run_test(&last_write, &now, true); + now.tm_year += 6; + run_test(&last_write, &now, true); + now.tm_sec += 6; + run_test(&last_write, &now, false); + now.tm_min++; + run_test(&last_write, &now, true); + + fprintf(stderr, "%s end\n", __func__); +} + +static void test_check_localtime_minute_mod_2(void) +{ + fprintf(stderr, "%s start\n", __func__); + + struct tm now, last_write; + memset(&last_write, 0, sizeof(last_write)); + test_intv = TIME_INTERVAL_MIN; + test_mod = 2; + + init_tm(&now, 2013, 2, 3, 4, 4, 6); + + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + run_test(&last_write, &now, false); + + now.tm_sec++; + run_test(&last_write, &now, false); + now.tm_sec++; + run_test(&last_write, &now, false); + now.tm_sec = 0; + run_test(&last_write, &now, false); + + now.tm_min++; + run_test(&last_write, &now, false); + now.tm_min++; + run_test(&last_write, &now, true); + now.tm_sec += 40; + run_test(&last_write, &now, false); + + now.tm_min += 2; + now.tm_sec = 20; + run_test(&last_write, &now, true); + + now.tm_min++; + now.tm_sec = 0; + run_test(&last_write, &now, false); + run_test(&last_write, &now, false); + + now.tm_hour++; + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + + now.tm_min += 48; + now.tm_sec += 3; + run_test(&last_write, &now, true); + + now.tm_min = 59; + run_test(&last_write, &now, true); + now.tm_hour++; + now.tm_min = 0; + run_test(&last_write, &now, true); + + now.tm_mday++; + run_test(&last_write, &now, true); + now.tm_mday += 20; + run_test(&last_write, &now, true); + now.tm_mon += 6; + run_test(&last_write, &now, true); + now.tm_year += 6; + run_test(&last_write, &now, true); + now.tm_sec += 6; + run_test(&last_write, &now, false); + now.tm_min++; + run_test(&last_write, &now, false); + now.tm_min++; + run_test(&last_write, &now, true); + now.tm_min++; + run_test(&last_write, &now, false); + now.tm_min++; + run_test(&last_write, &now, true); + now.tm_min += 2; + run_test(&last_write, &now, true); + + fprintf(stderr, "%s end\n", __func__); +} + +static void test_check_localtime_minute_mod_15(void) +{ + fprintf(stderr, "%s start\n", __func__); + + struct tm now, last_write; + memset(&last_write, 0, sizeof(last_write)); + test_intv = TIME_INTERVAL_MIN; + test_mod = 15; + + init_tm(&now, 2025, 2, 3, 4, 2, 6); + + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + run_test(&last_write, &now, false); + + now.tm_sec++; + run_test(&last_write, &now, false); + now.tm_sec++; + run_test(&last_write, &now, false); + now.tm_sec = 0; + run_test(&last_write, &now, false); + + now.tm_min = 8; + run_test(&last_write, &now, false); + now.tm_min = 10; + run_test(&last_write, &now, false); + now.tm_min = 13; + run_test(&last_write, &now, false); + now.tm_min = 15; + run_test(&last_write, &now, true); + now.tm_min = 18; + run_test(&last_write, &now, false); + now.tm_min = 29; + run_test(&last_write, &now, false); + now.tm_min = 30; + run_test(&last_write, &now, true); + now.tm_min = 45; + run_test(&last_write, &now, true); + now.tm_sec += 40; + run_test(&last_write, &now, false); + now.tm_hour += 1; + now.tm_min = 0; + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + now.tm_hour += 1; + now.tm_min += 45; + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + now.tm_min += 45; + run_test(&last_write, &now, true); + now.tm_min += 12; + run_test(&last_write, &now, false); + + now.tm_min++; + now.tm_sec = 0; + run_test(&last_write, &now, false); + run_test(&last_write, &now, false); + + now.tm_min += 48; + now.tm_sec += 3; + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + + now.tm_mday++; + run_test(&last_write, &now, true); + now.tm_mday += 20; + run_test(&last_write, &now, true); + now.tm_mon += 6; + run_test(&last_write, &now, true); + now.tm_year += 6; + run_test(&last_write, &now, true); + now.tm_sec += 6; + run_test(&last_write, &now, false); + now.tm_min = 2; + run_test(&last_write, &now, false); + + fprintf(stderr, "%s end\n", __func__); +} + +static void test_check_localtime_hour_mod_1(void) +{ + fprintf(stderr, "%s start\n", __func__); + + struct tm now, last_write; + memset(&last_write, 0, sizeof(last_write)); + test_intv = TIME_INTERVAL_HOUR; + test_mod = 1; + + init_tm(&now, 2010, 2, 3, 4, 5, 6); + + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + run_test(&last_write, &now, false); + + now.tm_sec++; + run_test(&last_write, &now, false); + now.tm_sec++; + run_test(&last_write, &now, false); + now.tm_sec = 0; + run_test(&last_write, &now, false); + now.tm_min++; + run_test(&last_write, &now, false); + now.tm_min++; + run_test(&last_write, &now, false); + now.tm_min = 0; + run_test(&last_write, &now, false); + + now.tm_hour++; + run_test(&last_write, &now, true); + now.tm_hour++; + run_test(&last_write, &now, true); + now.tm_min += 40; + run_test(&last_write, &now, false); + + now.tm_hour += 2; + now.tm_sec = 20; + run_test(&last_write, &now, true); + + now.tm_hour++; + now.tm_min = 0; + now.tm_sec = 0; + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + + now.tm_hour++; + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + + now.tm_hour += 22; + now.tm_min += 3; + run_test(&last_write, &now, true); + + now.tm_hour = 59; + now.tm_min = 59; + run_test(&last_write, &now, true); + now.tm_mday++; + now.tm_hour = 0; + run_test(&last_write, &now, true); + + now.tm_mday++; + run_test(&last_write, &now, true); + now.tm_mday += 20; + run_test(&last_write, &now, true); + now.tm_mon += 6; + run_test(&last_write, &now, true); + now.tm_year += 6; + run_test(&last_write, &now, true); + now.tm_sec += 6; + run_test(&last_write, &now, false); + now.tm_hour++; + run_test(&last_write, &now, true); + + fprintf(stderr, "%s end\n", __func__); +} + +static void test_check_localtime_hour_mod_12(void) +{ + fprintf(stderr, "%s start\n", __func__); + + struct tm now, last_write; + memset(&last_write, 0, sizeof(last_write)); + test_intv = TIME_INTERVAL_HOUR; + test_mod = 12; + + init_tm(&now, 2025, 2, 3, 4, 2, 6); + + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + run_test(&last_write, &now, false); + + now.tm_min++; + run_test(&last_write, &now, false); + now.tm_min++; + now.tm_sec++; + run_test(&last_write, &now, false); + now.tm_min = 0; + run_test(&last_write, &now, false); + + now.tm_hour = 8; + run_test(&last_write, &now, false); + now.tm_hour = 10; + run_test(&last_write, &now, false); + now.tm_hour = 13; + run_test(&last_write, &now, true); + now.tm_hour = 15; + run_test(&last_write, &now, false); + now.tm_hour = 18; + run_test(&last_write, &now, false); + now.tm_hour = 23; + run_test(&last_write, &now, false); + now.tm_sec += 40; + run_test(&last_write, &now, false); + now.tm_mday += 1; + now.tm_hour = 0; + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + now.tm_mday += 1; + now.tm_hour += 15; + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + + now.tm_min++; + now.tm_sec = 0; + run_test(&last_write, &now, false); + run_test(&last_write, &now, false); + + now.tm_min += 48; + now.tm_sec += 3; + run_test(&last_write, &now, false); + run_test(&last_write, &now, false); + + now.tm_mday++; + run_test(&last_write, &now, true); + now.tm_mday += 20; + run_test(&last_write, &now, true); + now.tm_mon += 6; + run_test(&last_write, &now, true); + now.tm_year += 6; + run_test(&last_write, &now, true); + now.tm_sec += 6; + run_test(&last_write, &now, false); + now.tm_min = 2; + run_test(&last_write, &now, false); + + fprintf(stderr, "%s end\n", __func__); +} + +static void test_check_localtime_day_mod_1(void) +{ + fprintf(stderr, "%s start\n", __func__); + + struct tm now, last_write; + memset(&last_write, 0, sizeof(last_write)); + test_intv = TIME_INTERVAL_DAY; + test_mod = 1; + + init_tm(&now, 2010, 2, 3, 4, 5, 6); + + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + run_test(&last_write, &now, false); + + now.tm_sec++; + run_test(&last_write, &now, false); + now.tm_sec++; + run_test(&last_write, &now, false); + now.tm_sec = 0; + run_test(&last_write, &now, false); + now.tm_min++; + run_test(&last_write, &now, false); + now.tm_min++; + run_test(&last_write, &now, false); + now.tm_min = 0; + run_test(&last_write, &now, false); + now.tm_hour++; + run_test(&last_write, &now, false); + now.tm_hour++; + run_test(&last_write, &now, false); + now.tm_hour = 0; + run_test(&last_write, &now, false); + + now.tm_mday++; + run_test(&last_write, &now, true); + now.tm_mday++; + run_test(&last_write, &now, true); + now.tm_hour += 3; + run_test(&last_write, &now, false); + + now.tm_mday += 2; + now.tm_sec = 20; + run_test(&last_write, &now, true); + + now.tm_mday++; + now.tm_min = 0; + now.tm_sec = 0; + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + + now.tm_mday++; + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + + now.tm_mday += 3; + now.tm_min += 3; + run_test(&last_write, &now, true); + + now.tm_hour = 59; + now.tm_min = 59; + run_test(&last_write, &now, false); + now.tm_mday++; + now.tm_hour = 0; + run_test(&last_write, &now, true); + + now.tm_mon += 6; + run_test(&last_write, &now, true); + now.tm_year += 6; + run_test(&last_write, &now, true); + now.tm_sec += 6; + run_test(&last_write, &now, false); + now.tm_mday++; + run_test(&last_write, &now, true); + + fprintf(stderr, "%s end\n", __func__); +} + +static void test_check_localtime_day_mod_10(void) +{ + fprintf(stderr, "%s start\n", __func__); + + struct tm now, last_write; + memset(&last_write, 0, sizeof(last_write)); + test_intv = TIME_INTERVAL_DAY; + test_mod = 10; + + init_tm(&now, 2025, 2, 3, 4, 2, 6); + + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + run_test(&last_write, &now, false); + + now.tm_hour++; + run_test(&last_write, &now, false); + now.tm_hour++; + now.tm_min++; + now.tm_sec++; + run_test(&last_write, &now, false); + now.tm_hour = 0; + run_test(&last_write, &now, false); + + now.tm_mday = 6; + run_test(&last_write, &now, false); + now.tm_mday = 10; + run_test(&last_write, &now, false); + now.tm_mday = 11; + run_test(&last_write, &now, true); + now.tm_mday = 15; + run_test(&last_write, &now, false); + now.tm_mday = 18; + run_test(&last_write, &now, false); + now.tm_mday = 23; + run_test(&last_write, &now, true); + now.tm_sec += 40; + run_test(&last_write, &now, false); + now.tm_mday += 1; + now.tm_hour = 0; + run_test(&last_write, &now, false); + run_test(&last_write, &now, false); + now.tm_mon += 1; + now.tm_mday += 1; + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + + now.tm_hour++; + now.tm_min = 0; + now.tm_sec = 0; + run_test(&last_write, &now, false); + run_test(&last_write, &now, false); + + now.tm_hour += 12; + now.tm_min += 48; + now.tm_sec += 3; + run_test(&last_write, &now, false); + run_test(&last_write, &now, false); + + now.tm_mon++; + run_test(&last_write, &now, true); + now.tm_mon += 2; + run_test(&last_write, &now, true); + now.tm_year += 4; + run_test(&last_write, &now, true); + now.tm_year += 6; + run_test(&last_write, &now, true); + now.tm_sec += 6; + run_test(&last_write, &now, false); + now.tm_min = 2; + run_test(&last_write, &now, false); + + fprintf(stderr, "%s end\n", __func__); +} + +static void test_check_localtime_month_mod_1(void) +{ + fprintf(stderr, "%s start\n", __func__); + + struct tm now, last_write; + memset(&last_write, 0, sizeof(last_write)); + test_intv = TIME_INTERVAL_MONTH; + test_mod = 1; + + init_tm(&now, 2010, 2, 3, 4, 5, 6); + + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + run_test(&last_write, &now, false); + + now.tm_sec++; + run_test(&last_write, &now, false); + now.tm_sec++; + run_test(&last_write, &now, false); + now.tm_sec = 0; + run_test(&last_write, &now, false); + now.tm_min++; + run_test(&last_write, &now, false); + now.tm_min++; + run_test(&last_write, &now, false); + now.tm_min = 0; + run_test(&last_write, &now, false); + now.tm_hour++; + run_test(&last_write, &now, false); + now.tm_hour++; + run_test(&last_write, &now, false); + now.tm_hour = 0; + run_test(&last_write, &now, false); + now.tm_mday++; + run_test(&last_write, &now, false); + now.tm_mday++; + run_test(&last_write, &now, false); + now.tm_mday = 0; + run_test(&last_write, &now, false); + + now.tm_mon++; + run_test(&last_write, &now, true); + now.tm_mon++; + run_test(&last_write, &now, true); + now.tm_mday += 3; + run_test(&last_write, &now, false); + + now.tm_mon += 2; + now.tm_sec = 20; + run_test(&last_write, &now, true); + + now.tm_mon++; + now.tm_mday = 0; + now.tm_hour = 0; + now.tm_min = 0; + now.tm_sec = 0; + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + + now.tm_mon++; + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + + now.tm_mon += 3; + now.tm_mday += 3; + now.tm_min += 3; + run_test(&last_write, &now, true); + + now.tm_mday = 27; + now.tm_hour = 59; + now.tm_min = 59; + run_test(&last_write, &now, false); + now.tm_mon++; + now.tm_hour = 0; + run_test(&last_write, &now, true); + + now.tm_year += 6; + run_test(&last_write, &now, true); + now.tm_sec += 6; + run_test(&last_write, &now, false); + now.tm_mon++; + run_test(&last_write, &now, true); + + fprintf(stderr, "%s end\n", __func__); +} + +static void test_check_localtime_month_mod_3(void) +{ + fprintf(stderr, "%s start\n", __func__); + + struct tm now, last_write; + memset(&last_write, 0, sizeof(last_write)); + test_intv = TIME_INTERVAL_MONTH; + test_mod = 3; + + init_tm(&now, 2025, 1, 3, 4, 2, 6); + + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + run_test(&last_write, &now, false); + + now.tm_mday++; + run_test(&last_write, &now, false); + now.tm_mday++; + now.tm_min++; + now.tm_sec++; + run_test(&last_write, &now, false); + now.tm_hour = 0; + run_test(&last_write, &now, false); + + now.tm_mon = 3; + run_test(&last_write, &now, true); + now.tm_mon = 4; + run_test(&last_write, &now, false); + now.tm_mon = 6; + run_test(&last_write, &now, true); + now.tm_mon = 8; + run_test(&last_write, &now, false); + now.tm_mon = 9; + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + now.tm_sec += 40; + run_test(&last_write, &now, false); + now.tm_mday += 1; + now.tm_hour = 0; + run_test(&last_write, &now, false); + run_test(&last_write, &now, false); + now.tm_mon += 3; + now.tm_mday += 1; + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + + now.tm_hour++; + now.tm_min = 0; + now.tm_sec = 0; + run_test(&last_write, &now, false); + run_test(&last_write, &now, false); + + now.tm_hour += 12; + now.tm_min += 48; + now.tm_sec += 3; + run_test(&last_write, &now, false); + run_test(&last_write, &now, false); + + now.tm_year += 4; + run_test(&last_write, &now, true); + now.tm_year += 6; + run_test(&last_write, &now, true); + now.tm_sec += 6; + run_test(&last_write, &now, false); + now.tm_min = 2; + run_test(&last_write, &now, false); + + fprintf(stderr, "%s end\n", __func__); +} + +static void test_check_localtime_year_mod_1(void) +{ + fprintf(stderr, "%s start\n", __func__); + + struct tm now, last_write; + memset(&last_write, 0, sizeof(last_write)); + test_intv = TIME_INTERVAL_YEAR; + test_mod = 1; + + init_tm(&now, 2010, 2, 3, 4, 5, 6); + + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + run_test(&last_write, &now, false); + + now.tm_sec++; + run_test(&last_write, &now, false); + now.tm_sec++; + run_test(&last_write, &now, false); + now.tm_sec = 0; + run_test(&last_write, &now, false); + now.tm_min++; + run_test(&last_write, &now, false); + now.tm_min++; + run_test(&last_write, &now, false); + now.tm_min = 0; + run_test(&last_write, &now, false); + now.tm_hour++; + run_test(&last_write, &now, false); + now.tm_hour++; + run_test(&last_write, &now, false); + now.tm_hour = 0; + run_test(&last_write, &now, false); + now.tm_mday++; + run_test(&last_write, &now, false); + now.tm_mday++; + run_test(&last_write, &now, false); + now.tm_mday = 0; + run_test(&last_write, &now, false); + now.tm_mon++; + run_test(&last_write, &now, false); + now.tm_mon++; + run_test(&last_write, &now, false); + now.tm_mon = 0; + run_test(&last_write, &now, false); + + now.tm_year++; + run_test(&last_write, &now, true); + now.tm_year++; + run_test(&last_write, &now, true); + now.tm_mon += 3; + run_test(&last_write, &now, false); + + now.tm_year += 2; + now.tm_sec = 20; + run_test(&last_write, &now, true); + + now.tm_year++; + now.tm_mday = 0; + now.tm_hour = 0; + now.tm_min = 0; + now.tm_sec = 0; + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + + now.tm_year++; + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + + now.tm_year += 3; + now.tm_mday += 3; + now.tm_min += 3; + run_test(&last_write, &now, true); + + now.tm_mon = 3; + now.tm_mday = 27; + now.tm_hour = 59; + now.tm_min = 59; + run_test(&last_write, &now, false); + now.tm_year++; + now.tm_hour = 0; + run_test(&last_write, &now, true); + + now.tm_year += 6; + run_test(&last_write, &now, true); + now.tm_sec += 6; + run_test(&last_write, &now, false); + now.tm_year++; + run_test(&last_write, &now, true); + + fprintf(stderr, "%s end\n", __func__); +} + +static void test_check_localtime_year_mod_2(void) +{ + fprintf(stderr, "%s start\n", __func__); + + struct tm now, last_write; + memset(&last_write, 0, sizeof(last_write)); + test_intv = TIME_INTERVAL_YEAR; + test_mod = 2; + + init_tm(&now, 2025, 1, 3, 4, 2, 6); + + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + run_test(&last_write, &now, false); + + now.tm_mday++; + run_test(&last_write, &now, false); + now.tm_mon++; + now.tm_mday++; + now.tm_min++; + now.tm_sec++; + run_test(&last_write, &now, false); + now.tm_hour = 0; + run_test(&last_write, &now, false); + + now.tm_year = 2026; + run_test(&last_write, &now, true); + now.tm_year = 2027; + run_test(&last_write, &now, false); + now.tm_year = 2028; + run_test(&last_write, &now, true); + now.tm_year = 2029; + run_test(&last_write, &now, false); + run_test(&last_write, &now, false); + now.tm_year = 9; + run_test(&last_write, &now, false); + run_test(&last_write, &now, false); + now.tm_sec += 40; + run_test(&last_write, &now, false); + now.tm_mday += 1; + now.tm_hour = 0; + run_test(&last_write, &now, false); + run_test(&last_write, &now, false); + now.tm_year += 3; + now.tm_mday += 1; + run_test(&last_write, &now, true); + run_test(&last_write, &now, false); + + now.tm_hour++; + now.tm_min = 0; + now.tm_sec = 0; + run_test(&last_write, &now, false); + run_test(&last_write, &now, false); + + now.tm_hour += 12; + now.tm_min += 48; + now.tm_sec += 3; + run_test(&last_write, &now, false); + run_test(&last_write, &now, false); + + now.tm_year += 4; + run_test(&last_write, &now, true); + now.tm_year += 6; + run_test(&last_write, &now, true); + now.tm_sec += 6; + run_test(&last_write, &now, false); + now.tm_min = 2; + run_test(&last_write, &now, false); + + fprintf(stderr, "%s end\n", __func__); +} + +static void test_check_localtime_dst_europe(void) +{ + fprintf(stderr, "%s start\n", __func__); + + struct tm now, last_write; + memset(&last_write, 0, sizeof(last_write)); + test_intv = TIME_INTERVAL_MIN; + test_mod = 2; + + init_tm(&now, 2025, 10, 27, 2, 56, 0); + + run_test(&last_write, &now, true); + now.tm_min++; // 02:57.00 + run_test(&last_write, &now, false); + now.tm_min++; // 02:58.00 + run_test(&last_write, &now, true); + now.tm_min++; // 02:59.00 + run_test(&last_write, &now, false); + now.tm_sec = 60; // 02:59.60 + run_test(&last_write, &now, false); + + // 02:00:00 again: + init_tm(&now, 2025, 10, 27, 2, 0, 0); + run_test(&last_write, &now, false); + + now.tm_min++; // 02:01.00 + run_test(&last_write, &now, false); + now.tm_min++; // 02:02.00 + run_test(&last_write, &now, true); + + fprintf(stderr, "%s end\n", __func__); +} + +int main(int argc, char **argv) +{ + /* actual tests */ + test_check_localtime_second_mod_1(); + test_check_localtime_second_mod_40(); + test_check_localtime_minute_mod_1(); + test_check_localtime_minute_mod_2(); + test_check_localtime_minute_mod_15(); + test_check_localtime_hour_mod_1(); + test_check_localtime_hour_mod_12(); + test_check_localtime_day_mod_1(); + test_check_localtime_day_mod_10(); + test_check_localtime_month_mod_1(); + test_check_localtime_month_mod_3(); + test_check_localtime_year_mod_1(); + test_check_localtime_year_mod_2(); + test_check_localtime_dst_europe(); + return 0; +} + diff --git a/tests/rotate_localtime/rotate_localtime_test.err b/tests/rotate_localtime/rotate_localtime_test.err new file mode 100644 index 0000000..10d7ef4 --- /dev/null +++ b/tests/rotate_localtime/rotate_localtime_test.err @@ -0,0 +1,365 @@ +test_check_localtime_second_mod_1 start +{2010-03-03_04:05:06} check_localtime(last_write=1900-01-00_00:00:00, intv=0, mod=1) -> REOPEN +{2010-03-03_04:05:06} check_localtime(last_write=2010-03-03_04:05:06, intv=0, mod=1) -> KEEP +{2010-03-03_04:05:06} check_localtime(last_write=2010-03-03_04:05:06, intv=0, mod=1) -> KEEP +{2010-03-03_04:05:07} check_localtime(last_write=2010-03-03_04:05:06, intv=0, mod=1) -> REOPEN +{2010-03-03_04:05:08} check_localtime(last_write=2010-03-03_04:05:07, intv=0, mod=1) -> REOPEN +{2010-03-03_04:05:00} check_localtime(last_write=2010-03-03_04:05:08, intv=0, mod=1) -> KEEP +{2010-03-03_04:06:00} check_localtime(last_write=2010-03-03_04:05:00, intv=0, mod=1) -> REOPEN +{2010-03-03_04:06:00} check_localtime(last_write=2010-03-03_04:06:00, intv=0, mod=1) -> KEEP +{2010-03-03_04:07:23} check_localtime(last_write=2010-03-03_04:06:00, intv=0, mod=1) -> REOPEN +{2010-03-03_04:07:23} check_localtime(last_write=2010-03-03_04:07:23, intv=0, mod=1) -> KEEP +{2010-03-03_07:07:23} check_localtime(last_write=2010-03-03_04:07:23, intv=0, mod=1) -> REOPEN +{2010-03-03_07:07:23} check_localtime(last_write=2010-03-03_07:07:23, intv=0, mod=1) -> KEEP +{2013-05-03_07:07:23} check_localtime(last_write=2010-03-03_07:07:23, intv=0, mod=1) -> REOPEN +{2013-05-03_07:07:23} check_localtime(last_write=2013-05-03_07:07:23, intv=0, mod=1) -> KEEP +test_check_localtime_second_mod_1 end +test_check_localtime_second_mod_40 start +{2010-03-03_04:05:00} check_localtime(last_write=1900-01-00_00:00:00, intv=0, mod=40) -> REOPEN +{2010-03-03_04:05:00} check_localtime(last_write=2010-03-03_04:05:00, intv=0, mod=40) -> KEEP +{2010-03-03_04:05:00} check_localtime(last_write=2010-03-03_04:05:00, intv=0, mod=40) -> KEEP +{2010-03-03_04:05:01} check_localtime(last_write=2010-03-03_04:05:00, intv=0, mod=40) -> KEEP +{2010-03-03_04:05:30} check_localtime(last_write=2010-03-03_04:05:01, intv=0, mod=40) -> KEEP +{2010-03-03_04:05:39} check_localtime(last_write=2010-03-03_04:05:30, intv=0, mod=40) -> KEEP +{2010-03-03_04:05:41} check_localtime(last_write=2010-03-03_04:05:39, intv=0, mod=40) -> REOPEN +{2010-03-03_04:06:41} check_localtime(last_write=2010-03-03_04:05:41, intv=0, mod=40) -> REOPEN +{2010-03-03_04:06:41} check_localtime(last_write=2010-03-03_04:06:41, intv=0, mod=40) -> KEEP +{2010-03-03_04:07:64} check_localtime(last_write=2010-03-03_04:06:41, intv=0, mod=40) -> REOPEN +{2010-03-03_04:07:64} check_localtime(last_write=2010-03-03_04:07:64, intv=0, mod=40) -> KEEP +{2010-03-03_07:07:64} check_localtime(last_write=2010-03-03_04:07:64, intv=0, mod=40) -> REOPEN +{2010-03-03_07:07:64} check_localtime(last_write=2010-03-03_07:07:64, intv=0, mod=40) -> KEEP +{2013-05-03_07:07:64} check_localtime(last_write=2010-03-03_07:07:64, intv=0, mod=40) -> REOPEN +{2013-05-03_07:07:64} check_localtime(last_write=2013-05-03_07:07:64, intv=0, mod=40) -> KEEP +test_check_localtime_second_mod_40 end +test_check_localtime_minute_mod_1 start +{2010-03-03_04:05:06} check_localtime(last_write=1900-01-00_00:00:00, intv=1, mod=1) -> REOPEN +{2010-03-03_04:05:06} check_localtime(last_write=2010-03-03_04:05:06, intv=1, mod=1) -> KEEP +{2010-03-03_04:05:06} check_localtime(last_write=2010-03-03_04:05:06, intv=1, mod=1) -> KEEP +{2010-03-03_04:05:07} check_localtime(last_write=2010-03-03_04:05:06, intv=1, mod=1) -> KEEP +{2010-03-03_04:05:08} check_localtime(last_write=2010-03-03_04:05:07, intv=1, mod=1) -> KEEP +{2010-03-03_04:05:00} check_localtime(last_write=2010-03-03_04:05:08, intv=1, mod=1) -> KEEP +{2010-03-03_04:06:00} check_localtime(last_write=2010-03-03_04:05:00, intv=1, mod=1) -> REOPEN +{2010-03-03_04:07:00} check_localtime(last_write=2010-03-03_04:06:00, intv=1, mod=1) -> REOPEN +{2010-03-03_04:07:40} check_localtime(last_write=2010-03-03_04:07:00, intv=1, mod=1) -> KEEP +{2010-03-03_04:09:20} check_localtime(last_write=2010-03-03_04:07:40, intv=1, mod=1) -> REOPEN +{2010-03-03_04:10:00} check_localtime(last_write=2010-03-03_04:09:20, intv=1, mod=1) -> REOPEN +{2010-03-03_04:10:00} check_localtime(last_write=2010-03-03_04:10:00, intv=1, mod=1) -> KEEP +{2010-03-03_05:10:00} check_localtime(last_write=2010-03-03_04:10:00, intv=1, mod=1) -> REOPEN +{2010-03-03_05:10:00} check_localtime(last_write=2010-03-03_05:10:00, intv=1, mod=1) -> KEEP +{2010-03-03_05:58:03} check_localtime(last_write=2010-03-03_05:10:00, intv=1, mod=1) -> REOPEN +{2010-03-03_05:59:03} check_localtime(last_write=2010-03-03_05:58:03, intv=1, mod=1) -> REOPEN +{2010-03-03_06:00:03} check_localtime(last_write=2010-03-03_05:59:03, intv=1, mod=1) -> REOPEN +{2010-03-04_06:00:03} check_localtime(last_write=2010-03-03_06:00:03, intv=1, mod=1) -> REOPEN +{2010-03-24_06:00:03} check_localtime(last_write=2010-03-04_06:00:03, intv=1, mod=1) -> REOPEN +{2010-09-24_06:00:03} check_localtime(last_write=2010-03-24_06:00:03, intv=1, mod=1) -> REOPEN +{2016-09-24_06:00:03} check_localtime(last_write=2010-09-24_06:00:03, intv=1, mod=1) -> REOPEN +{2016-09-24_06:00:09} check_localtime(last_write=2016-09-24_06:00:03, intv=1, mod=1) -> KEEP +{2016-09-24_06:01:09} check_localtime(last_write=2016-09-24_06:00:09, intv=1, mod=1) -> REOPEN +test_check_localtime_minute_mod_1 end +test_check_localtime_minute_mod_2 start +{2013-03-03_04:04:06} check_localtime(last_write=1900-01-00_00:00:00, intv=1, mod=2) -> REOPEN +{2013-03-03_04:04:06} check_localtime(last_write=2013-03-03_04:04:06, intv=1, mod=2) -> KEEP +{2013-03-03_04:04:06} check_localtime(last_write=2013-03-03_04:04:06, intv=1, mod=2) -> KEEP +{2013-03-03_04:04:07} check_localtime(last_write=2013-03-03_04:04:06, intv=1, mod=2) -> KEEP +{2013-03-03_04:04:08} check_localtime(last_write=2013-03-03_04:04:07, intv=1, mod=2) -> KEEP +{2013-03-03_04:04:00} check_localtime(last_write=2013-03-03_04:04:08, intv=1, mod=2) -> KEEP +{2013-03-03_04:05:00} check_localtime(last_write=2013-03-03_04:04:00, intv=1, mod=2) -> KEEP +{2013-03-03_04:06:00} check_localtime(last_write=2013-03-03_04:05:00, intv=1, mod=2) -> REOPEN +{2013-03-03_04:06:40} check_localtime(last_write=2013-03-03_04:06:00, intv=1, mod=2) -> KEEP +{2013-03-03_04:08:20} check_localtime(last_write=2013-03-03_04:06:40, intv=1, mod=2) -> REOPEN +{2013-03-03_04:09:00} check_localtime(last_write=2013-03-03_04:08:20, intv=1, mod=2) -> KEEP +{2013-03-03_04:09:00} check_localtime(last_write=2013-03-03_04:09:00, intv=1, mod=2) -> KEEP +{2013-03-03_05:09:00} check_localtime(last_write=2013-03-03_04:09:00, intv=1, mod=2) -> REOPEN +{2013-03-03_05:09:00} check_localtime(last_write=2013-03-03_05:09:00, intv=1, mod=2) -> KEEP +{2013-03-03_05:57:03} check_localtime(last_write=2013-03-03_05:09:00, intv=1, mod=2) -> REOPEN +{2013-03-03_05:59:03} check_localtime(last_write=2013-03-03_05:57:03, intv=1, mod=2) -> REOPEN +{2013-03-03_06:00:03} check_localtime(last_write=2013-03-03_05:59:03, intv=1, mod=2) -> REOPEN +{2013-03-04_06:00:03} check_localtime(last_write=2013-03-03_06:00:03, intv=1, mod=2) -> REOPEN +{2013-03-24_06:00:03} check_localtime(last_write=2013-03-04_06:00:03, intv=1, mod=2) -> REOPEN +{2013-09-24_06:00:03} check_localtime(last_write=2013-03-24_06:00:03, intv=1, mod=2) -> REOPEN +{2019-09-24_06:00:03} check_localtime(last_write=2013-09-24_06:00:03, intv=1, mod=2) -> REOPEN +{2019-09-24_06:00:09} check_localtime(last_write=2019-09-24_06:00:03, intv=1, mod=2) -> KEEP +{2019-09-24_06:01:09} check_localtime(last_write=2019-09-24_06:00:09, intv=1, mod=2) -> KEEP +{2019-09-24_06:02:09} check_localtime(last_write=2019-09-24_06:01:09, intv=1, mod=2) -> REOPEN +{2019-09-24_06:03:09} check_localtime(last_write=2019-09-24_06:02:09, intv=1, mod=2) -> KEEP +{2019-09-24_06:04:09} check_localtime(last_write=2019-09-24_06:03:09, intv=1, mod=2) -> REOPEN +{2019-09-24_06:06:09} check_localtime(last_write=2019-09-24_06:04:09, intv=1, mod=2) -> REOPEN +test_check_localtime_minute_mod_2 end +test_check_localtime_minute_mod_15 start +{2025-03-03_04:02:06} check_localtime(last_write=1900-01-00_00:00:00, intv=1, mod=15) -> REOPEN +{2025-03-03_04:02:06} check_localtime(last_write=2025-03-03_04:02:06, intv=1, mod=15) -> KEEP +{2025-03-03_04:02:06} check_localtime(last_write=2025-03-03_04:02:06, intv=1, mod=15) -> KEEP +{2025-03-03_04:02:07} check_localtime(last_write=2025-03-03_04:02:06, intv=1, mod=15) -> KEEP +{2025-03-03_04:02:08} check_localtime(last_write=2025-03-03_04:02:07, intv=1, mod=15) -> KEEP +{2025-03-03_04:02:00} check_localtime(last_write=2025-03-03_04:02:08, intv=1, mod=15) -> KEEP +{2025-03-03_04:08:00} check_localtime(last_write=2025-03-03_04:02:00, intv=1, mod=15) -> KEEP +{2025-03-03_04:10:00} check_localtime(last_write=2025-03-03_04:08:00, intv=1, mod=15) -> KEEP +{2025-03-03_04:13:00} check_localtime(last_write=2025-03-03_04:10:00, intv=1, mod=15) -> KEEP +{2025-03-03_04:15:00} check_localtime(last_write=2025-03-03_04:13:00, intv=1, mod=15) -> REOPEN +{2025-03-03_04:18:00} check_localtime(last_write=2025-03-03_04:15:00, intv=1, mod=15) -> KEEP +{2025-03-03_04:29:00} check_localtime(last_write=2025-03-03_04:18:00, intv=1, mod=15) -> KEEP +{2025-03-03_04:30:00} check_localtime(last_write=2025-03-03_04:29:00, intv=1, mod=15) -> REOPEN +{2025-03-03_04:45:00} check_localtime(last_write=2025-03-03_04:30:00, intv=1, mod=15) -> REOPEN +{2025-03-03_04:45:40} check_localtime(last_write=2025-03-03_04:45:00, intv=1, mod=15) -> KEEP +{2025-03-03_05:00:40} check_localtime(last_write=2025-03-03_04:45:40, intv=1, mod=15) -> REOPEN +{2025-03-03_05:00:40} check_localtime(last_write=2025-03-03_05:00:40, intv=1, mod=15) -> KEEP +{2025-03-03_06:45:40} check_localtime(last_write=2025-03-03_05:00:40, intv=1, mod=15) -> REOPEN +{2025-03-03_06:45:40} check_localtime(last_write=2025-03-03_06:45:40, intv=1, mod=15) -> KEEP +{2025-03-03_06:90:40} check_localtime(last_write=2025-03-03_06:45:40, intv=1, mod=15) -> REOPEN +{2025-03-03_06:102:40} check_localtime(last_write=2025-03-03_06:90:40, intv=1, mod=15) -> KEEP +{2025-03-03_06:103:00} check_localtime(last_write=2025-03-03_06:102:40, intv=1, mod=15) -> KEEP +{2025-03-03_06:103:00} check_localtime(last_write=2025-03-03_06:103:00, intv=1, mod=15) -> KEEP +{2025-03-03_06:151:03} check_localtime(last_write=2025-03-03_06:103:00, intv=1, mod=15) -> REOPEN +{2025-03-03_06:151:03} check_localtime(last_write=2025-03-03_06:151:03, intv=1, mod=15) -> KEEP +{2025-03-04_06:151:03} check_localtime(last_write=2025-03-03_06:151:03, intv=1, mod=15) -> REOPEN +{2025-03-24_06:151:03} check_localtime(last_write=2025-03-04_06:151:03, intv=1, mod=15) -> REOPEN +{2025-09-24_06:151:03} check_localtime(last_write=2025-03-24_06:151:03, intv=1, mod=15) -> REOPEN +{2031-09-24_06:151:03} check_localtime(last_write=2025-09-24_06:151:03, intv=1, mod=15) -> REOPEN +{2031-09-24_06:151:09} check_localtime(last_write=2031-09-24_06:151:03, intv=1, mod=15) -> KEEP +{2031-09-24_06:02:09} check_localtime(last_write=2031-09-24_06:151:09, intv=1, mod=15) -> KEEP +test_check_localtime_minute_mod_15 end +test_check_localtime_hour_mod_1 start +{2010-03-03_04:05:06} check_localtime(last_write=1900-01-00_00:00:00, intv=2, mod=1) -> REOPEN +{2010-03-03_04:05:06} check_localtime(last_write=2010-03-03_04:05:06, intv=2, mod=1) -> KEEP +{2010-03-03_04:05:06} check_localtime(last_write=2010-03-03_04:05:06, intv=2, mod=1) -> KEEP +{2010-03-03_04:05:07} check_localtime(last_write=2010-03-03_04:05:06, intv=2, mod=1) -> KEEP +{2010-03-03_04:05:08} check_localtime(last_write=2010-03-03_04:05:07, intv=2, mod=1) -> KEEP +{2010-03-03_04:05:00} check_localtime(last_write=2010-03-03_04:05:08, intv=2, mod=1) -> KEEP +{2010-03-03_04:06:00} check_localtime(last_write=2010-03-03_04:05:00, intv=2, mod=1) -> KEEP +{2010-03-03_04:07:00} check_localtime(last_write=2010-03-03_04:06:00, intv=2, mod=1) -> KEEP +{2010-03-03_04:00:00} check_localtime(last_write=2010-03-03_04:07:00, intv=2, mod=1) -> KEEP +{2010-03-03_05:00:00} check_localtime(last_write=2010-03-03_04:00:00, intv=2, mod=1) -> REOPEN +{2010-03-03_06:00:00} check_localtime(last_write=2010-03-03_05:00:00, intv=2, mod=1) -> REOPEN +{2010-03-03_06:40:00} check_localtime(last_write=2010-03-03_06:00:00, intv=2, mod=1) -> KEEP +{2010-03-03_08:40:20} check_localtime(last_write=2010-03-03_06:40:00, intv=2, mod=1) -> REOPEN +{2010-03-03_09:00:00} check_localtime(last_write=2010-03-03_08:40:20, intv=2, mod=1) -> REOPEN +{2010-03-03_09:00:00} check_localtime(last_write=2010-03-03_09:00:00, intv=2, mod=1) -> KEEP +{2010-03-03_10:00:00} check_localtime(last_write=2010-03-03_09:00:00, intv=2, mod=1) -> REOPEN +{2010-03-03_10:00:00} check_localtime(last_write=2010-03-03_10:00:00, intv=2, mod=1) -> KEEP +{2010-03-03_32:03:00} check_localtime(last_write=2010-03-03_10:00:00, intv=2, mod=1) -> REOPEN +{2010-03-03_59:59:00} check_localtime(last_write=2010-03-03_32:03:00, intv=2, mod=1) -> REOPEN +{2010-03-04_00:59:00} check_localtime(last_write=2010-03-03_59:59:00, intv=2, mod=1) -> REOPEN +{2010-03-05_00:59:00} check_localtime(last_write=2010-03-04_00:59:00, intv=2, mod=1) -> REOPEN +{2010-03-25_00:59:00} check_localtime(last_write=2010-03-05_00:59:00, intv=2, mod=1) -> REOPEN +{2010-09-25_00:59:00} check_localtime(last_write=2010-03-25_00:59:00, intv=2, mod=1) -> REOPEN +{2016-09-25_00:59:00} check_localtime(last_write=2010-09-25_00:59:00, intv=2, mod=1) -> REOPEN +{2016-09-25_00:59:06} check_localtime(last_write=2016-09-25_00:59:00, intv=2, mod=1) -> KEEP +{2016-09-25_01:59:06} check_localtime(last_write=2016-09-25_00:59:06, intv=2, mod=1) -> REOPEN +test_check_localtime_hour_mod_1 end +test_check_localtime_hour_mod_12 start +{2025-03-03_04:02:06} check_localtime(last_write=1900-01-00_00:00:00, intv=2, mod=12) -> REOPEN +{2025-03-03_04:02:06} check_localtime(last_write=2025-03-03_04:02:06, intv=2, mod=12) -> KEEP +{2025-03-03_04:02:06} check_localtime(last_write=2025-03-03_04:02:06, intv=2, mod=12) -> KEEP +{2025-03-03_04:03:06} check_localtime(last_write=2025-03-03_04:02:06, intv=2, mod=12) -> KEEP +{2025-03-03_04:04:07} check_localtime(last_write=2025-03-03_04:03:06, intv=2, mod=12) -> KEEP +{2025-03-03_04:00:07} check_localtime(last_write=2025-03-03_04:04:07, intv=2, mod=12) -> KEEP +{2025-03-03_08:00:07} check_localtime(last_write=2025-03-03_04:00:07, intv=2, mod=12) -> KEEP +{2025-03-03_10:00:07} check_localtime(last_write=2025-03-03_08:00:07, intv=2, mod=12) -> KEEP +{2025-03-03_13:00:07} check_localtime(last_write=2025-03-03_10:00:07, intv=2, mod=12) -> REOPEN +{2025-03-03_15:00:07} check_localtime(last_write=2025-03-03_13:00:07, intv=2, mod=12) -> KEEP +{2025-03-03_18:00:07} check_localtime(last_write=2025-03-03_15:00:07, intv=2, mod=12) -> KEEP +{2025-03-03_23:00:07} check_localtime(last_write=2025-03-03_18:00:07, intv=2, mod=12) -> KEEP +{2025-03-03_23:00:47} check_localtime(last_write=2025-03-03_23:00:07, intv=2, mod=12) -> KEEP +{2025-03-04_00:00:47} check_localtime(last_write=2025-03-03_23:00:47, intv=2, mod=12) -> REOPEN +{2025-03-04_00:00:47} check_localtime(last_write=2025-03-04_00:00:47, intv=2, mod=12) -> KEEP +{2025-03-05_15:00:47} check_localtime(last_write=2025-03-04_00:00:47, intv=2, mod=12) -> REOPEN +{2025-03-05_15:00:47} check_localtime(last_write=2025-03-05_15:00:47, intv=2, mod=12) -> KEEP +{2025-03-05_15:01:00} check_localtime(last_write=2025-03-05_15:00:47, intv=2, mod=12) -> KEEP +{2025-03-05_15:01:00} check_localtime(last_write=2025-03-05_15:01:00, intv=2, mod=12) -> KEEP +{2025-03-05_15:49:03} check_localtime(last_write=2025-03-05_15:01:00, intv=2, mod=12) -> KEEP +{2025-03-05_15:49:03} check_localtime(last_write=2025-03-05_15:49:03, intv=2, mod=12) -> KEEP +{2025-03-06_15:49:03} check_localtime(last_write=2025-03-05_15:49:03, intv=2, mod=12) -> REOPEN +{2025-03-26_15:49:03} check_localtime(last_write=2025-03-06_15:49:03, intv=2, mod=12) -> REOPEN +{2025-09-26_15:49:03} check_localtime(last_write=2025-03-26_15:49:03, intv=2, mod=12) -> REOPEN +{2031-09-26_15:49:03} check_localtime(last_write=2025-09-26_15:49:03, intv=2, mod=12) -> REOPEN +{2031-09-26_15:49:09} check_localtime(last_write=2031-09-26_15:49:03, intv=2, mod=12) -> KEEP +{2031-09-26_15:02:09} check_localtime(last_write=2031-09-26_15:49:09, intv=2, mod=12) -> KEEP +test_check_localtime_hour_mod_12 end +test_check_localtime_day_mod_1 start +{2010-03-03_04:05:06} check_localtime(last_write=1900-01-00_00:00:00, intv=3, mod=1) -> REOPEN +{2010-03-03_04:05:06} check_localtime(last_write=2010-03-03_04:05:06, intv=3, mod=1) -> KEEP +{2010-03-03_04:05:06} check_localtime(last_write=2010-03-03_04:05:06, intv=3, mod=1) -> KEEP +{2010-03-03_04:05:07} check_localtime(last_write=2010-03-03_04:05:06, intv=3, mod=1) -> KEEP +{2010-03-03_04:05:08} check_localtime(last_write=2010-03-03_04:05:07, intv=3, mod=1) -> KEEP +{2010-03-03_04:05:00} check_localtime(last_write=2010-03-03_04:05:08, intv=3, mod=1) -> KEEP +{2010-03-03_04:06:00} check_localtime(last_write=2010-03-03_04:05:00, intv=3, mod=1) -> KEEP +{2010-03-03_04:07:00} check_localtime(last_write=2010-03-03_04:06:00, intv=3, mod=1) -> KEEP +{2010-03-03_04:00:00} check_localtime(last_write=2010-03-03_04:07:00, intv=3, mod=1) -> KEEP +{2010-03-03_05:00:00} check_localtime(last_write=2010-03-03_04:00:00, intv=3, mod=1) -> KEEP +{2010-03-03_06:00:00} check_localtime(last_write=2010-03-03_05:00:00, intv=3, mod=1) -> KEEP +{2010-03-03_00:00:00} check_localtime(last_write=2010-03-03_06:00:00, intv=3, mod=1) -> KEEP +{2010-03-04_00:00:00} check_localtime(last_write=2010-03-03_00:00:00, intv=3, mod=1) -> REOPEN +{2010-03-05_00:00:00} check_localtime(last_write=2010-03-04_00:00:00, intv=3, mod=1) -> REOPEN +{2010-03-05_03:00:00} check_localtime(last_write=2010-03-05_00:00:00, intv=3, mod=1) -> KEEP +{2010-03-07_03:00:20} check_localtime(last_write=2010-03-05_03:00:00, intv=3, mod=1) -> REOPEN +{2010-03-08_03:00:00} check_localtime(last_write=2010-03-07_03:00:20, intv=3, mod=1) -> REOPEN +{2010-03-08_03:00:00} check_localtime(last_write=2010-03-08_03:00:00, intv=3, mod=1) -> KEEP +{2010-03-09_03:00:00} check_localtime(last_write=2010-03-08_03:00:00, intv=3, mod=1) -> REOPEN +{2010-03-09_03:00:00} check_localtime(last_write=2010-03-09_03:00:00, intv=3, mod=1) -> KEEP +{2010-03-12_03:03:00} check_localtime(last_write=2010-03-09_03:00:00, intv=3, mod=1) -> REOPEN +{2010-03-12_59:59:00} check_localtime(last_write=2010-03-12_03:03:00, intv=3, mod=1) -> KEEP +{2010-03-13_00:59:00} check_localtime(last_write=2010-03-12_59:59:00, intv=3, mod=1) -> REOPEN +{2010-09-13_00:59:00} check_localtime(last_write=2010-03-13_00:59:00, intv=3, mod=1) -> REOPEN +{2016-09-13_00:59:00} check_localtime(last_write=2010-09-13_00:59:00, intv=3, mod=1) -> REOPEN +{2016-09-13_00:59:06} check_localtime(last_write=2016-09-13_00:59:00, intv=3, mod=1) -> KEEP +{2016-09-14_00:59:06} check_localtime(last_write=2016-09-13_00:59:06, intv=3, mod=1) -> REOPEN +test_check_localtime_day_mod_1 end +test_check_localtime_day_mod_10 start +{2025-03-03_04:02:06} check_localtime(last_write=1900-01-00_00:00:00, intv=3, mod=10) -> REOPEN +{2025-03-03_04:02:06} check_localtime(last_write=2025-03-03_04:02:06, intv=3, mod=10) -> KEEP +{2025-03-03_04:02:06} check_localtime(last_write=2025-03-03_04:02:06, intv=3, mod=10) -> KEEP +{2025-03-03_05:02:06} check_localtime(last_write=2025-03-03_04:02:06, intv=3, mod=10) -> KEEP +{2025-03-03_06:03:07} check_localtime(last_write=2025-03-03_05:02:06, intv=3, mod=10) -> KEEP +{2025-03-03_00:03:07} check_localtime(last_write=2025-03-03_06:03:07, intv=3, mod=10) -> KEEP +{2025-03-06_00:03:07} check_localtime(last_write=2025-03-03_00:03:07, intv=3, mod=10) -> KEEP +{2025-03-10_00:03:07} check_localtime(last_write=2025-03-06_00:03:07, intv=3, mod=10) -> KEEP +{2025-03-11_00:03:07} check_localtime(last_write=2025-03-10_00:03:07, intv=3, mod=10) -> REOPEN +{2025-03-15_00:03:07} check_localtime(last_write=2025-03-11_00:03:07, intv=3, mod=10) -> KEEP +{2025-03-18_00:03:07} check_localtime(last_write=2025-03-15_00:03:07, intv=3, mod=10) -> KEEP +{2025-03-23_00:03:07} check_localtime(last_write=2025-03-18_00:03:07, intv=3, mod=10) -> REOPEN +{2025-03-23_00:03:47} check_localtime(last_write=2025-03-23_00:03:07, intv=3, mod=10) -> KEEP +{2025-03-24_00:03:47} check_localtime(last_write=2025-03-23_00:03:47, intv=3, mod=10) -> KEEP +{2025-03-24_00:03:47} check_localtime(last_write=2025-03-24_00:03:47, intv=3, mod=10) -> KEEP +{2025-04-25_00:03:47} check_localtime(last_write=2025-03-24_00:03:47, intv=3, mod=10) -> REOPEN +{2025-04-25_00:03:47} check_localtime(last_write=2025-04-25_00:03:47, intv=3, mod=10) -> KEEP +{2025-04-25_01:00:00} check_localtime(last_write=2025-04-25_00:03:47, intv=3, mod=10) -> KEEP +{2025-04-25_01:00:00} check_localtime(last_write=2025-04-25_01:00:00, intv=3, mod=10) -> KEEP +{2025-04-25_13:48:03} check_localtime(last_write=2025-04-25_01:00:00, intv=3, mod=10) -> KEEP +{2025-04-25_13:48:03} check_localtime(last_write=2025-04-25_13:48:03, intv=3, mod=10) -> KEEP +{2025-05-25_13:48:03} check_localtime(last_write=2025-04-25_13:48:03, intv=3, mod=10) -> REOPEN +{2025-07-25_13:48:03} check_localtime(last_write=2025-05-25_13:48:03, intv=3, mod=10) -> REOPEN +{2029-07-25_13:48:03} check_localtime(last_write=2025-07-25_13:48:03, intv=3, mod=10) -> REOPEN +{2035-07-25_13:48:03} check_localtime(last_write=2029-07-25_13:48:03, intv=3, mod=10) -> REOPEN +{2035-07-25_13:48:09} check_localtime(last_write=2035-07-25_13:48:03, intv=3, mod=10) -> KEEP +{2035-07-25_13:02:09} check_localtime(last_write=2035-07-25_13:48:09, intv=3, mod=10) -> KEEP +test_check_localtime_day_mod_10 end +test_check_localtime_month_mod_1 start +{2010-03-03_04:05:06} check_localtime(last_write=1900-01-00_00:00:00, intv=4, mod=1) -> REOPEN +{2010-03-03_04:05:06} check_localtime(last_write=2010-03-03_04:05:06, intv=4, mod=1) -> KEEP +{2010-03-03_04:05:06} check_localtime(last_write=2010-03-03_04:05:06, intv=4, mod=1) -> KEEP +{2010-03-03_04:05:07} check_localtime(last_write=2010-03-03_04:05:06, intv=4, mod=1) -> KEEP +{2010-03-03_04:05:08} check_localtime(last_write=2010-03-03_04:05:07, intv=4, mod=1) -> KEEP +{2010-03-03_04:05:00} check_localtime(last_write=2010-03-03_04:05:08, intv=4, mod=1) -> KEEP +{2010-03-03_04:06:00} check_localtime(last_write=2010-03-03_04:05:00, intv=4, mod=1) -> KEEP +{2010-03-03_04:07:00} check_localtime(last_write=2010-03-03_04:06:00, intv=4, mod=1) -> KEEP +{2010-03-03_04:00:00} check_localtime(last_write=2010-03-03_04:07:00, intv=4, mod=1) -> KEEP +{2010-03-03_05:00:00} check_localtime(last_write=2010-03-03_04:00:00, intv=4, mod=1) -> KEEP +{2010-03-03_06:00:00} check_localtime(last_write=2010-03-03_05:00:00, intv=4, mod=1) -> KEEP +{2010-03-03_00:00:00} check_localtime(last_write=2010-03-03_06:00:00, intv=4, mod=1) -> KEEP +{2010-03-04_00:00:00} check_localtime(last_write=2010-03-03_00:00:00, intv=4, mod=1) -> KEEP +{2010-03-05_00:00:00} check_localtime(last_write=2010-03-04_00:00:00, intv=4, mod=1) -> KEEP +{2010-03-00_00:00:00} check_localtime(last_write=2010-03-05_00:00:00, intv=4, mod=1) -> KEEP +{2010-04-00_00:00:00} check_localtime(last_write=2010-03-00_00:00:00, intv=4, mod=1) -> REOPEN +{2010-05-00_00:00:00} check_localtime(last_write=2010-04-00_00:00:00, intv=4, mod=1) -> REOPEN +{2010-05-03_00:00:00} check_localtime(last_write=2010-05-00_00:00:00, intv=4, mod=1) -> KEEP +{2010-07-03_00:00:20} check_localtime(last_write=2010-05-03_00:00:00, intv=4, mod=1) -> REOPEN +{2010-08-00_00:00:00} check_localtime(last_write=2010-07-03_00:00:20, intv=4, mod=1) -> REOPEN +{2010-08-00_00:00:00} check_localtime(last_write=2010-08-00_00:00:00, intv=4, mod=1) -> KEEP +{2010-09-00_00:00:00} check_localtime(last_write=2010-08-00_00:00:00, intv=4, mod=1) -> REOPEN +{2010-09-00_00:00:00} check_localtime(last_write=2010-09-00_00:00:00, intv=4, mod=1) -> KEEP +{2010-12-03_00:03:00} check_localtime(last_write=2010-09-00_00:00:00, intv=4, mod=1) -> REOPEN +{2010-12-27_59:59:00} check_localtime(last_write=2010-12-03_00:03:00, intv=4, mod=1) -> KEEP +{2010-13-27_00:59:00} check_localtime(last_write=2010-12-27_59:59:00, intv=4, mod=1) -> REOPEN +{2016-13-27_00:59:00} check_localtime(last_write=2010-13-27_00:59:00, intv=4, mod=1) -> REOPEN +{2016-13-27_00:59:06} check_localtime(last_write=2016-13-27_00:59:00, intv=4, mod=1) -> KEEP +{2016-14-27_00:59:06} check_localtime(last_write=2016-13-27_00:59:06, intv=4, mod=1) -> REOPEN +test_check_localtime_month_mod_1 end +test_check_localtime_month_mod_3 start +{2025-02-03_04:02:06} check_localtime(last_write=1900-01-00_00:00:00, intv=4, mod=3) -> REOPEN +{2025-02-03_04:02:06} check_localtime(last_write=2025-02-03_04:02:06, intv=4, mod=3) -> KEEP +{2025-02-03_04:02:06} check_localtime(last_write=2025-02-03_04:02:06, intv=4, mod=3) -> KEEP +{2025-02-04_04:02:06} check_localtime(last_write=2025-02-03_04:02:06, intv=4, mod=3) -> KEEP +{2025-02-05_04:03:07} check_localtime(last_write=2025-02-04_04:02:06, intv=4, mod=3) -> KEEP +{2025-02-05_00:03:07} check_localtime(last_write=2025-02-05_04:03:07, intv=4, mod=3) -> KEEP +{2025-04-05_00:03:07} check_localtime(last_write=2025-02-05_00:03:07, intv=4, mod=3) -> REOPEN +{2025-05-05_00:03:07} check_localtime(last_write=2025-04-05_00:03:07, intv=4, mod=3) -> KEEP +{2025-07-05_00:03:07} check_localtime(last_write=2025-05-05_00:03:07, intv=4, mod=3) -> REOPEN +{2025-09-05_00:03:07} check_localtime(last_write=2025-07-05_00:03:07, intv=4, mod=3) -> KEEP +{2025-10-05_00:03:07} check_localtime(last_write=2025-09-05_00:03:07, intv=4, mod=3) -> REOPEN +{2025-10-05_00:03:07} check_localtime(last_write=2025-10-05_00:03:07, intv=4, mod=3) -> KEEP +{2025-10-05_00:03:47} check_localtime(last_write=2025-10-05_00:03:07, intv=4, mod=3) -> KEEP +{2025-10-06_00:03:47} check_localtime(last_write=2025-10-05_00:03:47, intv=4, mod=3) -> KEEP +{2025-10-06_00:03:47} check_localtime(last_write=2025-10-06_00:03:47, intv=4, mod=3) -> KEEP +{2025-13-07_00:03:47} check_localtime(last_write=2025-10-06_00:03:47, intv=4, mod=3) -> REOPEN +{2025-13-07_00:03:47} check_localtime(last_write=2025-13-07_00:03:47, intv=4, mod=3) -> KEEP +{2025-13-07_01:00:00} check_localtime(last_write=2025-13-07_00:03:47, intv=4, mod=3) -> KEEP +{2025-13-07_01:00:00} check_localtime(last_write=2025-13-07_01:00:00, intv=4, mod=3) -> KEEP +{2025-13-07_13:48:03} check_localtime(last_write=2025-13-07_01:00:00, intv=4, mod=3) -> KEEP +{2025-13-07_13:48:03} check_localtime(last_write=2025-13-07_13:48:03, intv=4, mod=3) -> KEEP +{2029-13-07_13:48:03} check_localtime(last_write=2025-13-07_13:48:03, intv=4, mod=3) -> REOPEN +{2035-13-07_13:48:03} check_localtime(last_write=2029-13-07_13:48:03, intv=4, mod=3) -> REOPEN +{2035-13-07_13:48:09} check_localtime(last_write=2035-13-07_13:48:03, intv=4, mod=3) -> KEEP +{2035-13-07_13:02:09} check_localtime(last_write=2035-13-07_13:48:09, intv=4, mod=3) -> KEEP +test_check_localtime_month_mod_3 end +test_check_localtime_year_mod_1 start +{2010-03-03_04:05:06} check_localtime(last_write=1900-01-00_00:00:00, intv=5, mod=1) -> REOPEN +{2010-03-03_04:05:06} check_localtime(last_write=2010-03-03_04:05:06, intv=5, mod=1) -> KEEP +{2010-03-03_04:05:06} check_localtime(last_write=2010-03-03_04:05:06, intv=5, mod=1) -> KEEP +{2010-03-03_04:05:07} check_localtime(last_write=2010-03-03_04:05:06, intv=5, mod=1) -> KEEP +{2010-03-03_04:05:08} check_localtime(last_write=2010-03-03_04:05:07, intv=5, mod=1) -> KEEP +{2010-03-03_04:05:00} check_localtime(last_write=2010-03-03_04:05:08, intv=5, mod=1) -> KEEP +{2010-03-03_04:06:00} check_localtime(last_write=2010-03-03_04:05:00, intv=5, mod=1) -> KEEP +{2010-03-03_04:07:00} check_localtime(last_write=2010-03-03_04:06:00, intv=5, mod=1) -> KEEP +{2010-03-03_04:00:00} check_localtime(last_write=2010-03-03_04:07:00, intv=5, mod=1) -> KEEP +{2010-03-03_05:00:00} check_localtime(last_write=2010-03-03_04:00:00, intv=5, mod=1) -> KEEP +{2010-03-03_06:00:00} check_localtime(last_write=2010-03-03_05:00:00, intv=5, mod=1) -> KEEP +{2010-03-03_00:00:00} check_localtime(last_write=2010-03-03_06:00:00, intv=5, mod=1) -> KEEP +{2010-03-04_00:00:00} check_localtime(last_write=2010-03-03_00:00:00, intv=5, mod=1) -> KEEP +{2010-03-05_00:00:00} check_localtime(last_write=2010-03-04_00:00:00, intv=5, mod=1) -> KEEP +{2010-03-00_00:00:00} check_localtime(last_write=2010-03-05_00:00:00, intv=5, mod=1) -> KEEP +{2010-04-00_00:00:00} check_localtime(last_write=2010-03-00_00:00:00, intv=5, mod=1) -> KEEP +{2010-05-00_00:00:00} check_localtime(last_write=2010-04-00_00:00:00, intv=5, mod=1) -> KEEP +{2010-01-00_00:00:00} check_localtime(last_write=2010-05-00_00:00:00, intv=5, mod=1) -> KEEP +{2011-01-00_00:00:00} check_localtime(last_write=2010-01-00_00:00:00, intv=5, mod=1) -> REOPEN +{2012-01-00_00:00:00} check_localtime(last_write=2011-01-00_00:00:00, intv=5, mod=1) -> REOPEN +{2012-04-00_00:00:00} check_localtime(last_write=2012-01-00_00:00:00, intv=5, mod=1) -> KEEP +{2014-04-00_00:00:20} check_localtime(last_write=2012-04-00_00:00:00, intv=5, mod=1) -> REOPEN +{2015-04-00_00:00:00} check_localtime(last_write=2014-04-00_00:00:20, intv=5, mod=1) -> REOPEN +{2015-04-00_00:00:00} check_localtime(last_write=2015-04-00_00:00:00, intv=5, mod=1) -> KEEP +{2016-04-00_00:00:00} check_localtime(last_write=2015-04-00_00:00:00, intv=5, mod=1) -> REOPEN +{2016-04-00_00:00:00} check_localtime(last_write=2016-04-00_00:00:00, intv=5, mod=1) -> KEEP +{2019-04-03_00:03:00} check_localtime(last_write=2016-04-00_00:00:00, intv=5, mod=1) -> REOPEN +{2019-04-27_59:59:00} check_localtime(last_write=2019-04-03_00:03:00, intv=5, mod=1) -> KEEP +{2020-04-27_00:59:00} check_localtime(last_write=2019-04-27_59:59:00, intv=5, mod=1) -> REOPEN +{2026-04-27_00:59:00} check_localtime(last_write=2020-04-27_00:59:00, intv=5, mod=1) -> REOPEN +{2026-04-27_00:59:06} check_localtime(last_write=2026-04-27_00:59:00, intv=5, mod=1) -> KEEP +{2027-04-27_00:59:06} check_localtime(last_write=2026-04-27_00:59:06, intv=5, mod=1) -> REOPEN +test_check_localtime_year_mod_1 end +test_check_localtime_year_mod_2 start +{2025-02-03_04:02:06} check_localtime(last_write=1900-01-00_00:00:00, intv=5, mod=2) -> REOPEN +{2025-02-03_04:02:06} check_localtime(last_write=2025-02-03_04:02:06, intv=5, mod=2) -> KEEP +{2025-02-03_04:02:06} check_localtime(last_write=2025-02-03_04:02:06, intv=5, mod=2) -> KEEP +{2025-02-04_04:02:06} check_localtime(last_write=2025-02-03_04:02:06, intv=5, mod=2) -> KEEP +{2025-03-05_04:03:07} check_localtime(last_write=2025-02-04_04:02:06, intv=5, mod=2) -> KEEP +{2025-03-05_00:03:07} check_localtime(last_write=2025-03-05_04:03:07, intv=5, mod=2) -> KEEP +{3926-03-05_00:03:07} check_localtime(last_write=2025-03-05_00:03:07, intv=5, mod=2) -> REOPEN +{3927-03-05_00:03:07} check_localtime(last_write=3926-03-05_00:03:07, intv=5, mod=2) -> KEEP +{3928-03-05_00:03:07} check_localtime(last_write=3927-03-05_00:03:07, intv=5, mod=2) -> REOPEN +{3929-03-05_00:03:07} check_localtime(last_write=3928-03-05_00:03:07, intv=5, mod=2) -> KEEP +{3929-03-05_00:03:07} check_localtime(last_write=3929-03-05_00:03:07, intv=5, mod=2) -> KEEP +{1909-03-05_00:03:07} check_localtime(last_write=3929-03-05_00:03:07, intv=5, mod=2) -> KEEP +{1909-03-05_00:03:07} check_localtime(last_write=1909-03-05_00:03:07, intv=5, mod=2) -> KEEP +{1909-03-05_00:03:47} check_localtime(last_write=1909-03-05_00:03:07, intv=5, mod=2) -> KEEP +{1909-03-06_00:03:47} check_localtime(last_write=1909-03-05_00:03:47, intv=5, mod=2) -> KEEP +{1909-03-06_00:03:47} check_localtime(last_write=1909-03-06_00:03:47, intv=5, mod=2) -> KEEP +{1912-03-07_00:03:47} check_localtime(last_write=1909-03-06_00:03:47, intv=5, mod=2) -> REOPEN +{1912-03-07_00:03:47} check_localtime(last_write=1912-03-07_00:03:47, intv=5, mod=2) -> KEEP +{1912-03-07_01:00:00} check_localtime(last_write=1912-03-07_00:03:47, intv=5, mod=2) -> KEEP +{1912-03-07_01:00:00} check_localtime(last_write=1912-03-07_01:00:00, intv=5, mod=2) -> KEEP +{1912-03-07_13:48:03} check_localtime(last_write=1912-03-07_01:00:00, intv=5, mod=2) -> KEEP +{1912-03-07_13:48:03} check_localtime(last_write=1912-03-07_13:48:03, intv=5, mod=2) -> KEEP +{1916-03-07_13:48:03} check_localtime(last_write=1912-03-07_13:48:03, intv=5, mod=2) -> REOPEN +{1922-03-07_13:48:03} check_localtime(last_write=1916-03-07_13:48:03, intv=5, mod=2) -> REOPEN +{1922-03-07_13:48:09} check_localtime(last_write=1922-03-07_13:48:03, intv=5, mod=2) -> KEEP +{1922-03-07_13:02:09} check_localtime(last_write=1922-03-07_13:48:09, intv=5, mod=2) -> KEEP +test_check_localtime_year_mod_2 end +test_check_localtime_dst_europe start +{2025-11-27_02:56:00} check_localtime(last_write=1900-01-00_00:00:00, intv=1, mod=2) -> REOPEN +{2025-11-27_02:57:00} check_localtime(last_write=2025-11-27_02:56:00, intv=1, mod=2) -> KEEP +{2025-11-27_02:58:00} check_localtime(last_write=2025-11-27_02:57:00, intv=1, mod=2) -> REOPEN +{2025-11-27_02:59:00} check_localtime(last_write=2025-11-27_02:58:00, intv=1, mod=2) -> KEEP +{2025-11-27_02:59:60} check_localtime(last_write=2025-11-27_02:59:00, intv=1, mod=2) -> KEEP +{2025-11-27_02:00:00} check_localtime(last_write=2025-11-27_02:59:60, intv=1, mod=2) -> KEEP +{2025-11-27_02:01:00} check_localtime(last_write=2025-11-27_02:00:00, intv=1, mod=2) -> KEEP +{2025-11-27_02:02:00} check_localtime(last_write=2025-11-27_02:01:00, intv=1, mod=2) -> REOPEN +test_check_localtime_dst_europe end diff --git a/tests/rotate_localtime/rotate_localtime_test.ok b/tests/rotate_localtime/rotate_localtime_test.ok new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/tests/rotate_localtime/rotate_localtime_test.ok diff --git a/tests/testsuite.at b/tests/testsuite.at index d928bb6..a1ff910 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -1,3 +1,9 @@ AT_INIT AT_BANNER([Regression tests.]) +AT_SETUP([rotate_localtime_test]) +AT_KEYWORDS([rotate_localtime_test]) +cat $abs_srcdir/rotate_localtime/rotate_localtime_test.ok > expout +cat $abs_srcdir/rotate_localtime/rotate_localtime_test.err > experr +AT_CHECK([$abs_top_builddir/tests/rotate_localtime/rotate_localtime_test], [], [expout], [experr]) +AT_CLEANUP -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Idf17a161c17050bb62793a82e39179a093b35f73 Gerrit-Change-Number: 39158 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months

1
0
0 0

[XL] Change in osmo-pcap[master]: pcap-server: Make rotate-localtime feature configurable through VTY

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39158?usp=email ) Change subject: pcap-server: Make rotate-localtime feature configurable through VTY ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Idf17a161c17050bb62793a82e39179a093b35f73 Gerrit-Change-Number: 39158 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Dec 2024 17:17:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2024