November 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-hlr[master]: change default reject cause to plmn-not-allowed

by falconia

falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-hlr/+/38794?usp=email ) Change subject: change default reject cause to plmn-not-allowed ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/38794?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Icff1d19670c398b119ec68b1d5f0fad87b605702 Gerrit-Change-Number: 38794 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Nov 2024 03:31:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

[XS] Change in osmo-hlr[master]: change default no-proxy reject cause to net-fail

by keith

Attention is currently required from: falconia. keith has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-hlr/+/38819?usp=email ) Change subject: change default no-proxy reject cause to net-fail ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/38819?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I557ae1d3291066a87228b5db4f2e207ea721329c Gerrit-Change-Number: 38819 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Thu, 21 Nov 2024 01:42:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

[XS] Change in osmo-hlr[master]: change default reject cause to plmn-not-allowed

by keith

Attention is currently required from: falconia. keith has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-hlr/+/38794?usp=email ) Change subject: change default reject cause to plmn-not-allowed ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/38794?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Icff1d19670c398b119ec68b1d5f0fad87b605702 Gerrit-Change-Number: 38794 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Thu, 21 Nov 2024 01:41:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

[S] Change in osmo-dev[master]: libosmo-abis now depends on libosmo-netif

by pespin

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-dev/+/38846?usp=email ) Change subject: libosmo-abis now depends on libosmo-netif ...................................................................... libosmo-abis now depends on libosmo-netif Change-Id: I6eb05e856c096a146fce8c22409def564ec77fdc Depends: libosmo-abis.git Change-Id I079dc3999de508301dd37ed03e399356a58d3cab Depends: libosmo-netif.git Change-Id I13d6e88158f6d9ce017986283183ee9c2cc68c --- M all.deps 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/46/38846/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/38846?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I6eb05e856c096a146fce8c22409def564ec77fdc Gerrit-Change-Number: 38846 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 1 week

1
0
0 0

[M] Change in libosmo-abis[master]: ipaccess: Replace ipa_bts_id_resp() with libosmocore ipa_ccm_make_id_...

by pespin

Attention is currently required from: daniel, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38813?usp=email ) Change subject: ipaccess: Replace ipa_bts_id_resp() with libosmocore ipa_ccm_make_id_resp_from_req() ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: I'll probably leave it until tomorrow and then merge it. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I7f32231bff792b01e33f604bbb8b68fe22876abb Gerrit-Change-Number: 38813 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Nov 2024 18:59:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

7 months, 1 week

1
0
0 0

[XS] Change in osmo-hlr[master]: gsup: Replace deprecated ipa_msg_push_header()

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/38823?usp=email ) Change subject: gsup: Replace deprecated ipa_msg_push_header() ...................................................................... gsup: Replace deprecated ipa_msg_push_header() Use the libosmocore API, which does the same except setting the l2h pointer, which we don't really need here. Change-Id: I7a4d05a0b09032d8133d8775fb4707a4da8f0cf3 --- M src/gsup_server.c M src/gsupclient/gsup_client.c 2 files changed, 5 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/gsup_server.c b/src/gsup_server.c index 20ea162..1510bd0 100644 --- a/src/gsup_server.c +++ b/src/gsup_server.c @@ -26,6 +26,7 @@ #include <osmocom/core/linuxlist.h> #include <osmocom/abis/ipa.h> #include <osmocom/abis/ipaccess.h> +#include <osmocom/gsm/ipa.h> #include <osmocom/gsm/gsm48_ie.h> #include <osmocom/gsm/apn.h> #include <osmocom/gsm/gsm23003.h> @@ -49,7 +50,7 @@ int proto_ext, struct msgb *msg_tx) { ipa_prepend_header_ext(msg_tx, proto_ext); - ipa_msg_push_header(msg_tx, IPAC_PROTO_OSMO); + ipa_prepend_header(msg_tx, IPAC_PROTO_OSMO); ipa_server_conn_send(conn->conn, msg_tx); } diff --git a/src/gsupclient/gsup_client.c b/src/gsupclient/gsup_client.c index 3329361..e7d03f2 100644 --- a/src/gsupclient/gsup_client.c +++ b/src/gsupclient/gsup_client.c @@ -26,6 +26,7 @@ #include <osmocom/gsupclient/gsup_client.h> #include <osmocom/abis/ipa.h> +#include <osmocom/gsm/ipa.h> #include <osmocom/gsm/oap_client.h> #include <osmocom/gsm/protocol/ipaccess.h> #include <osmocom/core/msgb.h> @@ -44,7 +45,7 @@ msg->l2h = msgb_put(msg, 1); msg->l2h[0] = IPAC_MSGT_PING; - ipa_msg_push_header(msg, IPAC_PROTO_IPACCESS); + ipa_prepend_header(msg, IPAC_PROTO_IPACCESS); ipa_client_conn_send(gsupc->link, msg); } @@ -114,7 +115,7 @@ struct msgb *msg_tx) { ipa_prepend_header_ext(msg_tx, proto_ext); - ipa_msg_push_header(msg_tx, IPAC_PROTO_OSMO); + ipa_prepend_header(msg_tx, IPAC_PROTO_OSMO); ipa_client_conn_send(gsupc->link, msg_tx); /* msg_tx is now queued and will be freed. */ } -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/38823?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I7a4d05a0b09032d8133d8775fb4707a4da8f0cf3 Gerrit-Change-Number: 38823 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months, 1 week

1
0
0 0

[L] Change in libosmo-netif[master]: Drop libosmo-abis cond dep together with examples/lapd-over-datagram

by pespin

Attention is currently required from: daniel, fixeria, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38841?usp=email ) Change subject: Drop libosmo-abis cond dep together with examples/lapd-over-datagram ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > * osmo-ci.git (job dependencies) https://gerrit.osmocom.org/c/osmo-ci/+/38845 > * osmo-dev.git (https://cgit.osmocom.org/osmo-dev/tree/all.deps#n5) https://gerrit.osmocom.org/c/osmo-dev/+/38846 > * https://osmocom.org/projects/cellular-infrastructure/wiki/Make_a_new_releas… https://osmocom.org/projects/cellular-infrastructure/wiki/Make_a_new_releas… -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38841?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I13d6e88158f6d9ce017986283183ee9c2cc68cae Gerrit-Change-Number: 38841 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Nov 2024 18:52:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 1 week

1
0
0 0

[XS] Change in osmo-dev[master]: libosmo-abis now depends on libosmo-netif

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/38846?usp=email ) Change subject: libosmo-abis now depends on libosmo-netif ...................................................................... libosmo-abis now depends on libosmo-netif Change-Id: I6eb05e856c096a146fce8c22409def564ec77fdc Depends: libosmo-abis.git Change-Id I079dc3999de508301dd37ed03e399356a58d3cab Depends: libosmo-netif.git Change-Id I13d6e88158f6d9ce017986283183ee9c2cc68c --- M all.deps 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/46/38846/1 diff --git a/all.deps b/all.deps index 99086f2..77cca12 100644 --- a/all.deps +++ b/all.deps @@ -1,8 +1,8 @@ # project build these first libosmocore -libosmo-abis libosmocore +libosmo-netif libosmocore +libosmo-abis libosmocore libosmo-netif libosmo-gprs libosmocore -libosmo-netif libosmo-abis libosmo-sigtran libosmo-netif libsmpp34 libasn1c -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/38846?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I6eb05e856c096a146fce8c22409def564ec77fdc Gerrit-Change-Number: 38846 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 1 week

1
0
0 0

[S] Change in osmo-ci[master]: libosmo-abis now depends on libosmo-netif

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ci/+/38845?usp=email ) Change subject: libosmo-abis now depends on libosmo-netif ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This was not yet deployed using jenkins-job-builder. Better do it only after it is merged. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38845?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I27b3a2d4fa8d72924967ea7bf893322b9bfc16f9 Gerrit-Change-Number: 38845 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Nov 2024 18:44:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

7 months, 1 week

1
0
0 0

[S] Change in osmo-ci[master]: libosmo-abis now depends on libosmo-netif

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/38845?usp=email ) Change subject: libosmo-abis now depends on libosmo-netif ...................................................................... libosmo-abis now depends on libosmo-netif Depends: libosmo-abis.git Change-Id I079dc3999de508301dd37ed03e399356a58d3cab Depends: libosmo-netif.git Change-Id I13d6e88158f6d9ce017986283183ee9c2cc68c Change-Id: I27b3a2d4fa8d72924967ea7bf893322b9bfc16f9 --- M coverity/build_Osmocom.sh M jobs/master-builds.yml 2 files changed, 25 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/45/38845/1 diff --git a/coverity/build_Osmocom.sh b/coverity/build_Osmocom.sh index 22ca629..4e2b8db 100755 --- a/coverity/build_Osmocom.sh +++ b/coverity/build_Osmocom.sh @@ -73,9 +73,9 @@ build_default libosmocore build_libasn1c build_libusrp +build_default libosmo-netif build_default libosmo-abis build_default libosmo-gprs -build_default libosmo-netif build_default libosmo-pfcp build_default libosmo-sigtran build_default libsmpp34 diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index f15386b..6f255fd 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -111,12 +111,15 @@ - libosmo-abis: # Full triggers would be: # trigger: > - # master-libosmo-netif, master-osmo-bsc, master-osmo-bts, master-osmo-hlr, - # master-osmo-msc, master-osmo-sgsn + # master-osmo-bsc, master-osmo-bts, master-osmo-hlr, + # master-osmo-mgw, master-osmo-sgsn # Optimized: # (see comment at libosmocore) trigger: > - master-libosmo-netif, master-osmo-bts + master-osmo-bts, + master-osmo-hlr, + master-osmo-mgw, + master-osmo-sgsn - libosmo-dsp: repos_url: '{gitea_url}/sdr/{repos}' @@ -142,16 +145,14 @@ - libosmo-netif: # Full triggers would be: # trigger: > - # master-libosmo-sigtran, mastere-osmo-hlr, master-osmo-iuh, - # master-osmo-mgw, master-osmo-msc, master-osmo-sgsn, master-osmo-hnodeb, - # master-osmo-hnbgw + # master-libosmo-abis, master-libosmo-sigtran, mastere-osmo-hlr, + # master-osmo-iuh, master-osmo-mgw, master-osmo-msc, master-osmo-sgsn, + # master-osmo-hnodeb, master-osmo-hnbgw # Optimized: # (see comment at libosmocore) trigger: > - master-libosmo-sigtran, - master-osmo-hlr, - master-osmo-mgw, - master-osmo-sgsn + master-libosmo-abis + master-libosmo-sigtran - libosmo-pfcp: # Full triggers would be: @@ -185,27 +186,27 @@ cmd: '{docker_run_ccache} {docker_img} {timeout_cmd} /build/contrib/jenkins_arch.sh "$arch"' # Full triggers would be: # trigger: > - # master-libosmo-abis, master-libosmo-netif, master-libosmo-sigtran, + # master-libosmo-netif, master-libosmo-abis, master-libosmo-sigtran, # master-osmo-bsc, master-osmo-bts, master-osmo-ggsn, master-osmo-gmr, master-osmo-hlr, # master-osmo-iuh, master-osmo-mgw, master-osmo-msc, master-osmo-pcap, master-osmo-pcu, # master-osmo-sgsn, master-osmo-sip-connector, master-osmo-tetra, master-osmo-hnodeb # master-osmocom-bb, master-simtrace, master-xgoldmon # Optimized: # libosmocore - # -> master-libosmo-abis - # -> master-libosmo-netif - # -> master-libosmo-sigtran - # -> master-osmo-bsc - # -> master-osmo-bsc-nat - # -> master-osmo-iuh - # -> master-osmo-msc - # -> master-osmo-sgsn - # -> master-osmo-hnodeb + # -> master-libosmo-netif + # -> master-libosmo-abis + # -> master-libosmo-sigtran + # -> master-osmo-bsc + # -> master-osmo-bsc-nat + # -> master-osmo-iuh # -> master-osmo-msc # -> master-osmo-sgsn - # -> master-osmo-hlr - # -> master-osmo-mgw + # -> master-osmo-hnodeb + # -> master-osmo-msc # -> master-osmo-sgsn + # -> master-osmo-hlr + # -> master-osmo-mgw + # -> master-osmo-sgsn # -> master-osmo-bts # -> master-libosmo-gprs # -> master-osmo-pcu @@ -216,7 +217,7 @@ # -> master-osmo-sgsn # [...] trigger: > - master-libosmo-abis, + master-libosmo-netif, master-libosmo-pfcp, master-osmo-gbproxy, master-osmo-ggsn, -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38845?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I27b3a2d4fa8d72924967ea7bf893322b9bfc16f9 Gerrit-Change-Number: 38845 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024