Attention is currently required from: daniel, fixeria, laforge, osmith, pespin.
Hello Jenkins Builder, daniel, fixeria, laforge, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-abis/+/38842?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Verified+1 by Jenkins Builder
Change subject: libosmo-abis depends on libosmo-netif
......................................................................
libosmo-abis depends on libosmo-netif
Move the lapd-over-datagram-*.c examples from libosmo-netif to
libosmo-abis, since those examples requrie code provided by
libosmo-abis.
libosmo-abis will be soon making use of libosmo-netif APIs such as those
available in stream.h
Depends: libosmo-netif.git Change-Id I13d6e88158f6d9ce017986283183ee9c2cc68cae
Change-Id: I079dc3999de508301dd37ed03e399356a58d3cab
---
M Makefile.am
M TODO-RELEASE
M configure.ac
M contrib/jenkins.sh
M debian/control
A doc/Makefile.am
A doc/examples/Makefile.am
A doc/examples/lapd-over-datagram/lapd-over-datagram-network.c
A doc/examples/lapd-over-datagram/lapd-over-datagram-user.c
9 files changed, 458 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/42/38842/4
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38842?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I079dc3999de508301dd37ed03e399356a58d3cab
Gerrit-Change-Number: 38842
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Attention is currently required from: daniel, laforge, osmith, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38841?usp=email )
Change subject: Drop libosmo-abis cond dep together with examples/lapd-over-datagram
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38841?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I13d6e88158f6d9ce017986283183ee9c2cc68cae
Gerrit-Change-Number: 38841
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 20 Nov 2024 18:09:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38843?usp=email )
Change subject: libosmo-sigtran.pc.in: Add missing Requires.private libosmo*
......................................................................
libosmo-sigtran.pc.in: Add missing Requires.private libosmo*
libosmo-sigtran uses those libraries but it was not specifying them.
This is needed in case somebody wants to static-link against it.
Change-Id: I17c026e9489bfd583a10e74fa94cc3f6dfb1f938
---
M libosmo-sigtran.pc.in
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/43/38843/1
diff --git a/libosmo-sigtran.pc.in b/libosmo-sigtran.pc.in
index d735797..afdbce5 100644
--- a/libosmo-sigtran.pc.in
+++ b/libosmo-sigtran.pc.in
@@ -8,3 +8,4 @@
Version: @VERSION@
Libs: -L${libdir} -losmo-sigtran
Cflags: -I${includedir}/
+Requires.private: libosmo-netif libosmocore
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38843?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I17c026e9489bfd583a10e74fa94cc3f6dfb1f938
Gerrit-Change-Number: 38843
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Attention is currently required from: daniel, fixeria, laforge, osmith, pespin.
Hello Jenkins Builder, daniel, fixeria, laforge, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-abis/+/38842?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: libosmo-abis depends on libosmo-netif
......................................................................
libosmo-abis depends on libosmo-netif
Move the lapd-over-datagram-*.c examples from libosmo-netif to
libosmo-abis, since those examples requrie code provided by
libosmo-abis.
libosmo-abis will be soon making use of libosmo-netif APIs such as those
available in stream.h
Depends: libosmo-netif.git Change-Id I13d6e88158f6d9ce017986283183ee9c2cc68cae
Change-Id: I079dc3999de508301dd37ed03e399356a58d3cab
---
M Makefile.am
M TODO-RELEASE
M configure.ac
M contrib/jenkins.sh
M debian/control
A doc/Makefile.am
A doc/examples/Makefile.am
A doc/examples/lapd-over-datagram/lapd-over-datagram-network.c
A doc/examples/lapd-over-datagram/lapd-over-datagram-user.c
9 files changed, 458 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/42/38842/3
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38842?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I079dc3999de508301dd37ed03e399356a58d3cab
Gerrit-Change-Number: 38842
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Attention is currently required from: daniel, fixeria, laforge, osmith, pespin.
Hello Jenkins Builder, daniel, fixeria, laforge, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-abis/+/38842?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: libosmo-abis depends on libosmo-netif
......................................................................
libosmo-abis depends on libosmo-netif
Move the lapd-over-datagram-*.c examples from libosmo-netif to
libosmo-abis, since those examples requrie code provided by
libosmo-abis.
libosmo-abis will be soon making use of libosmo-netif APIs such as those
available in stream.h
Depends: libosmo-netif.git Change-Id I13d6e88158f6d9ce017986283183ee9c2cc68cae
Change-Id: I079dc3999de508301dd37ed03e399356a58d3cab
---
M Makefile.am
M TODO-RELEASE
M configure.ac
M contrib/jenkins.sh
A doc/Makefile.am
A doc/examples/Makefile.am
A doc/examples/lapd-over-datagram/lapd-over-datagram-network.c
A doc/examples/lapd-over-datagram/lapd-over-datagram-user.c
8 files changed, 457 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/42/38842/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38842?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I079dc3999de508301dd37ed03e399356a58d3cab
Gerrit-Change-Number: 38842
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>