November 2024 - gerrit-log - lists.osmocom.org

[XS] Change in libosmo-netif[master]: Use timeout in jenkins job

by osmith

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/12851?usp=email ) Change subject: Use timeout in jenkins job ...................................................................... Abandoned this is obsolete, gerrit-verifications and master-builds jenkins jobs have timeouts for all projects now -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/12851?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I815d65f31eec4e0c758478471a553ec2afb59a8d Gerrit-Change-Number: 12851 Gerrit-PatchSet: 2 Gerrit-Owner: Max <suraev(a)alumni.ntnu.no> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <suraev(a)alumni.ntnu.no> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de>

7 months, 1 week

1
0
0 0

[S] Change in osmo-dev[master]: libosmo-abis now depends on libosmo-netif

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-dev/+/38846?usp=email ) Change subject: libosmo-abis now depends on libosmo-netif ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/38846?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I6eb05e856c096a146fce8c22409def564ec77fdc Gerrit-Change-Number: 38846 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Nov 2024 08:18:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

[S] Change in osmo-dev[master]: libosmo-abis now depends on libosmo-netif

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-dev/+/38846?usp=email ) Change subject: libosmo-abis now depends on libosmo-netif ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/38846?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I6eb05e856c096a146fce8c22409def564ec77fdc Gerrit-Change-Number: 38846 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Nov 2024 08:18:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

[S] Change in osmo-ci[master]: libosmo-abis now depends on libosmo-netif

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ci/+/38845?usp=email ) Change subject: libosmo-abis now depends on libosmo-netif ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38845?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I27b3a2d4fa8d72924967ea7bf893322b9bfc16f9 Gerrit-Change-Number: 38845 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Nov 2024 08:16:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

[L] Change in libosmo-abis[master]: libosmo-abis depends on libosmo-netif

by osmith

Attention is currently required from: daniel, fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38842?usp=email ) Change subject: libosmo-abis depends on libosmo-netif ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File doc/examples/Makefile.am: https://gerrit.osmocom.org/c/libosmo-abis/+/38842/comment/b52a9bfa_f83ec34e… : PS3, Line 24: $(NULL) > "No newline at end of right file." -- please fix. Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38842?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I079dc3999de508301dd37ed03e399356a58d3cab Gerrit-Change-Number: 38842 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Nov 2024 08:14:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 1 week

1
0
0 0

[L] Change in libosmo-netif[master]: Drop libosmo-abis cond dep together with examples/lapd-over-datagram

by osmith

Attention is currently required from: daniel, fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38841?usp=email ) Change subject: Drop libosmo-abis cond dep together with examples/lapd-over-datagram ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38841?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I13d6e88158f6d9ce017986283183ee9c2cc68cae Gerrit-Change-Number: 38841 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Nov 2024 08:11:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

[S] Change in osmo-hlr[master]: vty: always emit reject-cause lines in saved config

by falconia

falconia has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/38818?usp=email ) Change subject: vty: always emit reject-cause lines in saved config ...................................................................... vty: always emit reject-cause lines in saved config When reject-cause (not-found|no-proxy) setting was added, it was implemented such that the new setting is not written into saved config files if it equals the default of 'imsi-unknown'. Change this behavior to always write out the current setting for each of not-found and no-proxy, whether or not they match compiled-in defaults. Change-Id: I18708fc1c08a85e98582c97ec59dd3822a0767fb --- M src/hlr_vty.c M tests/test_nodes.vty 2 files changed, 8 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/hlr_vty.c b/src/hlr_vty.c index 2c7cd5b..4694c44 100644 --- a/src/hlr_vty.c +++ b/src/hlr_vty.c @@ -320,14 +320,12 @@ { vty_out(vty, "hlr%s", VTY_NEWLINE); - if (g_hlr->reject_cause != GMM_CAUSE_IMSI_UNKNOWN) - vty_out(vty, " reject-cause not-found %s%s", - get_value_string_or_null(gsm48_gmm_cause_vty_names, - (uint32_t) g_hlr->reject_cause), VTY_NEWLINE); - if (g_hlr->no_proxy_reject_cause != GMM_CAUSE_IMSI_UNKNOWN) - vty_out(vty, " reject-cause no-proxy %s%s", - get_value_string_or_null(gsm48_gmm_cause_vty_names, - (uint32_t) g_hlr->no_proxy_reject_cause), VTY_NEWLINE); + vty_out(vty, " reject-cause not-found %s%s", + get_value_string_or_null(gsm48_gmm_cause_vty_names, + (uint32_t) g_hlr->reject_cause), VTY_NEWLINE); + vty_out(vty, " reject-cause no-proxy %s%s", + get_value_string_or_null(gsm48_gmm_cause_vty_names, + (uint32_t) g_hlr->no_proxy_reject_cause), VTY_NEWLINE); if (g_hlr->store_imei) vty_out(vty, " store-imei%s", VTY_NEWLINE); if (g_hlr->db_file_path && strcmp(g_hlr->db_file_path, HLR_DEFAULT_DB_FILE_PATH)) diff --git a/tests/test_nodes.vty b/tests/test_nodes.vty index 6875416..516360f 100644 --- a/tests/test_nodes.vty +++ b/tests/test_nodes.vty @@ -113,6 +113,8 @@ logging level dgsm notice ... hlr + reject-cause not-found imsi-unknown + reject-cause no-proxy imsi-unknown store-imei database hlr_vty_test.db no subscriber-create-on-demand -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/38818?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I18708fc1c08a85e98582c97ec59dd3822a0767fb Gerrit-Change-Number: 38818 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

7 months, 1 week

1
0
0 0

[XS] Change in osmo-hlr[master]: change default reject cause to plmn-not-allowed

by falconia

falconia has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/38794?usp=email ) Change subject: change default reject cause to plmn-not-allowed ...................................................................... change default reject cause to plmn-not-allowed Unless the Osmocom-based network operator has very carefully considered what they are doing, returning MM/GMM reject cause #2 (IMSI unknown in HLR) to LU requests from bystander phones is a very bad idea. Here is what typically happens when someone sets up an Osmocom-based GSM network for development, testing or research, without roaming interconnection with any commercial operators: * Even when the private network operates its BTS at very low power levels, bystander phones in close proximity (e.g., in directly adjacent neighbor apartments or office suites) will receive a much stronger signal from the private/test network BTS than from any commercial operator, i.e., the private/test network will be the strongest signal. * Many phones will attempt to "jump ship" to this strongest signal even if it broadcasts a completely unknown PLMN ID that is not in the preferred operator list, and even when they were previously not roaming at all, registered to their most preferred home operator with perfectly good reception quality. * If these wayward phones receive reject cause #2 in response to their LU attempt, the spec effectively requires them to go into a "black hole" where they no longer attempt to register to any operator, including their own legitimate one. Returning reject cause #11 instead (PLMN not allowed) solves this problem: wayward phones that erroneously attempted to register to the private/test network go back to their own legitimate commercial operator, and everyone is happy. This bug should be considered critical: when the reject cause is set to #2 by default, any private Osmocom-based network, no matter how low-power, will effectively cause service disruption to all nearby commercially-served phones even when there is no clash in terms of used radio frequencies. Change-Id: Icff1d19670c398b119ec68b1d5f0fad87b605702 --- M src/hlr.c M tests/test_nodes.vty 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: keith: Looks good to me, but someone else must approve falconia: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve diff --git a/src/hlr.c b/src/hlr.c index 6f444aa..3d020d6 100644 --- a/src/hlr.c +++ b/src/hlr.c @@ -779,7 +779,7 @@ g_hlr->db_file_path = talloc_strdup(g_hlr, HLR_DEFAULT_DB_FILE_PATH); g_hlr->mslookup.server.mdns.domain_suffix = talloc_strdup(g_hlr, OSMO_MDNS_DOMAIN_SUFFIX_DEFAULT); g_hlr->mslookup.client.mdns.domain_suffix = talloc_strdup(g_hlr, OSMO_MDNS_DOMAIN_SUFFIX_DEFAULT); - g_hlr->reject_cause = GMM_CAUSE_IMSI_UNKNOWN; + g_hlr->reject_cause = GMM_CAUSE_PLMN_NOTALLOWED; g_hlr->no_proxy_reject_cause = GMM_CAUSE_IMSI_UNKNOWN; /* Init default (call independent) SS session guard timeout value */ diff --git a/tests/test_nodes.vty b/tests/test_nodes.vty index 516360f..a9203b7 100644 --- a/tests/test_nodes.vty +++ b/tests/test_nodes.vty @@ -113,7 +113,7 @@ logging level dgsm notice ... hlr - reject-cause not-found imsi-unknown + reject-cause not-found plmn-not-allowed reject-cause no-proxy imsi-unknown store-imei database hlr_vty_test.db -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/38794?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Icff1d19670c398b119ec68b1d5f0fad87b605702 Gerrit-Change-Number: 38794 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de>

7 months, 1 week

1
0
0 0

[XS] Change in osmo-hlr[master]: change default no-proxy reject cause to net-fail

by falconia

falconia has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/38819?usp=email ) Change subject: change default no-proxy reject cause to net-fail ...................................................................... change default no-proxy reject cause to net-fail If LU has to be rejected because DGSM mechanism cannot reach the needed HLR, then returning reject cause #17 (Network Failure) is the most accurate and truthful description of what is actually happening. Reject cause #2 (IMSI unknown in HLR) is unlikely to be a good choice: in areas where regular commercial cell services are present alongside with experimental/adventurous Osmocom-based GSM networks, this reject cause is acutely dangerous as described in the previous commit, and even in areas where no regular commercial cell services are present (the presumed intended use case for DGSM), the behavior of commanding LU-failing phones "please don't ever again try to connect to ANY network until the user power-cycles you" is unlikely to be correct/desirable. If that behavior _is_ desired, it should be configured explicitly, not by default. Change-Id: I557ae1d3291066a87228b5db4f2e207ea721329c --- M src/hlr.c M tests/test_nodes.vty 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve keith: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve falconia: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/hlr.c b/src/hlr.c index 3d020d6..a900e23 100644 --- a/src/hlr.c +++ b/src/hlr.c @@ -780,7 +780,7 @@ g_hlr->mslookup.server.mdns.domain_suffix = talloc_strdup(g_hlr, OSMO_MDNS_DOMAIN_SUFFIX_DEFAULT); g_hlr->mslookup.client.mdns.domain_suffix = talloc_strdup(g_hlr, OSMO_MDNS_DOMAIN_SUFFIX_DEFAULT); g_hlr->reject_cause = GMM_CAUSE_PLMN_NOTALLOWED; - g_hlr->no_proxy_reject_cause = GMM_CAUSE_IMSI_UNKNOWN; + g_hlr->no_proxy_reject_cause = GMM_CAUSE_NET_FAIL; /* Init default (call independent) SS session guard timeout value */ g_hlr->ncss_guard_timeout = NCSS_GUARD_TIMEOUT_DEFAULT; diff --git a/tests/test_nodes.vty b/tests/test_nodes.vty index a9203b7..b7e7214 100644 --- a/tests/test_nodes.vty +++ b/tests/test_nodes.vty @@ -114,7 +114,7 @@ ... hlr reject-cause not-found plmn-not-allowed - reject-cause no-proxy imsi-unknown + reject-cause no-proxy net-fail store-imei database hlr_vty_test.db no subscriber-create-on-demand -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/38819?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I557ae1d3291066a87228b5db4f2e207ea721329c Gerrit-Change-Number: 38819 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de>

7 months, 1 week

1
0
0 0

[XS] Change in osmo-hlr[master]: change default no-proxy reject cause to net-fail

by falconia

falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-hlr/+/38819?usp=email ) Change subject: change default no-proxy reject cause to net-fail ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/38819?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I557ae1d3291066a87228b5db4f2e207ea721329c Gerrit-Change-Number: 38819 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Nov 2024 03:33:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024