Attention is currently required from: osmith.
fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38848?usp=email )
Change subject: testenv: print backtrace on startup fail too
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38848?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I66a55dcfdab17d035ce6425220763a85b5b6dc90
Gerrit-Change-Number: 38848
Gerrit-PatchSet: 4
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Nov 2024 17:37:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/38870?usp=email )
Change subject: jenkins.sh: libosmo-netif no longer depends on libosmo-abis
......................................................................
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/38870?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: Ic7bed0798f9b437db6ffe716981d2772a36dfb68
Gerrit-Change-Number: 38870
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Nov 2024 17:10:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851?usp=email )
Change subject: testenv: build virtphy from src with --binary-repo
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851/comment/32b810f7_93fb… :
PS1, Line 9: Add logic to build virtphy from source when running with --binary-repo.
> > There are no libraries inside osmocom-bb.git, so that should not be a concern? […]
We can also make osmocom-bb tags and still keep it as "not officially released".
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I37bac8509b2601286e4feab099782f82c8338dca
Gerrit-Change-Number: 38851
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Nov 2024 17:03:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851?usp=email )
Change subject: testenv: build virtphy from src with --binary-repo
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851/comment/fd588193_1c52… :
PS1, Line 9: Add logic to build virtphy from source when running with --binary-repo.
> There are no libraries inside osmocom-bb.git, so that should not be a concern?
But it uses libraries. Start doing releases and then you enter the game of "this API is available in latest but not in master", "this API is used by osmocom-bb so it cannot be dropped", etc.
I'd say we build master osmocom-bb for "latest" repo, using "latest" libosmocore, and if it fails because it needs newer libosmocore, then simply we stick to a given commit hash for a while until a new libosmocore is released.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I37bac8509b2601286e4feab099782f82c8338dca
Gerrit-Change-Number: 38851
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Nov 2024 17:02:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: daniel, lynxis lazus.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/38834?usp=email )
Change subject: gmm: Fix reject small size RAU request
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
After talking with @lynxis@fe80.eu, leaving this patch for him to resubmit since he wants to add some comments explaining that we want to be relaxed accepting 14 bytes despite table in specs saying it should be 16.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38834?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I49210a04b16e6e2fc9d799b99c2fa415f28ddbba
Gerrit-Change-Number: 38834
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 21 Nov 2024 16:57:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38867?usp=email )
Change subject: jenkins.sh: libosmo-netif no longer depends on libosmo-abis
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38867?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I27a938f2a178a5ff59f371ec4d19b4405737eb51
Gerrit-Change-Number: 38867
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Nov 2024 16:12:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes