November 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-netif[master]: stream_cli: Allow setting nodelay sockopt after opening sock

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38826?usp=email ) Change subject: stream_cli: Allow setting nodelay sockopt after opening sock ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38826?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ic178d924da03968de1f140bfc8805c972b849e7b Gerrit-Change-Number: 38826 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Nov 2024 18:15:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

[S] Change in osmo-bts[master]: bts-omldummy: Support configuring logging through cmdline

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/38871?usp=email ) Change subject: bts-omldummy: Support configuring logging through cmdline ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38871?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0b33919d71bacefe60be192810518fd927625127 Gerrit-Change-Number: 38871 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Nov 2024 18:14:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: bts: add initial testenv.cfg

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38852?usp=email ) Change subject: bts: add initial testenv.cfg ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: Ehh, no more lively `Makefile` magic... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38852?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id9ed3780d166c5f6736a006f466dc5f0dded6279 Gerrit-Change-Number: 38852 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Nov 2024 18:13:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

[S] Change in libosmo-netif[master]: stream_cli: Allow setting nodelay sockopt after opening sock

by pespin

Attention is currently required from: laforge, pespin. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38826?usp=email ) Change subject: stream_cli: Allow setting nodelay sockopt after opening sock ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38826?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ic178d924da03968de1f140bfc8805c972b849e7b Gerrit-Change-Number: 38826 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Nov 2024 18:12:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

7 months, 1 week

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: build virtphy from src with --binary-repo

by pespin

Attention is currently required from: laforge, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851?usp=email ) Change subject: testenv: build virtphy from src with --binary-repo ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I37bac8509b2601286e4feab099782f82c8338dca Gerrit-Change-Number: 38851 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 21 Nov 2024 18:11:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

[S] Change in osmo-bts[master]: bts-omldummy: Support configuring logging through cmdline

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/38871?usp=email ) Change subject: bts-omldummy: Support configuring logging through cmdline ...................................................................... bts-omldummy: Support configuring logging through cmdline Add cmdline args to control logging, as already present in other more usual bts models. This is extremely important here since there's no VTY at all to configure them. Change-Id: I0b33919d71bacefe60be192810518fd927625127 --- M src/osmo-bts-omldummy/main.c 1 file changed, 20 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/71/38871/1 diff --git a/src/osmo-bts-omldummy/main.c b/src/osmo-bts-omldummy/main.c index 167d43a..088fa52 100644 --- a/src/osmo-bts-omldummy/main.c +++ b/src/osmo-bts-omldummy/main.c @@ -7,6 +7,7 @@ #include <osmocom/core/talloc.h> #include <osmocom/core/application.h> +#include <osmocom/core/logging.h> #include <osmo-bts/logging.h> #include <osmo-bts/abis.h> #include <osmo-bts/bts.h> @@ -44,10 +45,14 @@ static struct option long_options[] = { {"help", 0, 0, 'h'}, {"features", 1, 0, 'f'}, + { "debug", 1, 0, 'd' }, + { "disable-color", 0, 0, 's' }, + { "timestamp", 0, 0, 'T' }, + { "log-level", 1, 0, 'e' }, {0} }; - c = getopt_long(argc, argv, "hf:", long_options, &option_index); + c = getopt_long(argc, argv, "hf:d:sTe:", long_options, &option_index); if (c == -1) break; @@ -58,6 +63,18 @@ case 'f': cmdline.features = optarg; break; + case 's': + log_set_use_color(osmo_stderr_target, 0); + break; + case 'd': + log_parse_category_mask(osmo_stderr_target, optarg); + break; + case 'T': + log_set_print_timestamp(osmo_stderr_target, 1); + break; + case 'e': + log_set_log_level(osmo_stderr_target, atoi(optarg)); + break; default: /* catch unknown options *as well as* missing arguments. */ fprintf(stderr, "Error in command line options. Exiting.\n"); @@ -111,13 +128,13 @@ struct bsc_oml_host *bsc_oml_host; int i; - parse_cmdline(argc, argv); - tall_bts_ctx = talloc_named_const(NULL, 1, "OsmoBTS context"); msgb_talloc_ctx_init(tall_bts_ctx, 10*1024); osmo_init_logging2(tall_bts_ctx, &bts_log_info); + parse_cmdline(argc, argv); + g_bts_sm = gsm_bts_sm_alloc(tall_bts_ctx); if (!g_bts_sm) exit(1); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38871?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0b33919d71bacefe60be192810518fd927625127 Gerrit-Change-Number: 38871 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 1 week

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: respawn.sh: don't respawn on segfault

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38847?usp=email ) Change subject: testenv: respawn.sh: don't respawn on segfault ...................................................................... testenv: respawn.sh: don't respawn on segfault Do not respawn the process if it segfaulted or aborted abnormally in another way (exit code >= 128). Change-Id: I6f3f6218095643609a8b8869b57dde6b6bdb77a0 --- M _testenv/data/scripts/respawn.sh 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/_testenv/data/scripts/respawn.sh b/_testenv/data/scripts/respawn.sh index 3b079c7..1036569 100755 --- a/_testenv/data/scripts/respawn.sh +++ b/_testenv/data/scripts/respawn.sh @@ -12,7 +12,12 @@ $* & LAST_PID=$! wait $LAST_PID - echo "respawn: $i: stopped pid $LAST_PID with status $?" + LAST_STATUS=$? + echo "respawn: $i: stopped pid $LAST_PID with status $LAST_STATUS" + if [ $LAST_STATUS -ge 128 ]; then + echo "respawn: process was terminated abnormally, not respawning" + exit $LAST_STATUS + fi if [ $SLEEP_BEFORE_RESPAWN -gt 0 ]; then echo "respawn: sleeping $SLEEP_BEFORE_RESPAWN seconds..." sleep $SLEEP_BEFORE_RESPAWN -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38847?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6f3f6218095643609a8b8869b57dde6b6bdb77a0 Gerrit-Change-Number: 38847 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months, 1 week

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: print backtrace on startup fail too

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38848?usp=email ) Change subject: testenv: print backtrace on startup fail too ...................................................................... testenv: print backtrace on startup fail too When a program fails to start up, look for the coredump and print a backtrace if it was found (instead of only doing it if a program crashes later on). Change-Id: I66a55dcfdab17d035ce6425220763a85b5b6dc90 --- M _testenv/testenv/daemons.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/_testenv/testenv/daemons.py b/_testenv/testenv/daemons.py index 0c9c0dd..86f3979 100644 --- a/_testenv/testenv/daemons.py +++ b/_testenv/testenv/daemons.py @@ -68,6 +68,7 @@ # Wait 200ms and check if it is still running time.sleep(0.2) if daemons[section].poll() is not None: + testenv.coredump.get_from_coredumpctl() raise testenv.NoTraceException(f"program failed to start: {program}") # Run setup script -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38848?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I66a55dcfdab17d035ce6425220763a85b5b6dc90 Gerrit-Change-Number: 38848 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months, 1 week

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: print backtrace on startup fail too

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38848?usp=email ) Change subject: testenv: print backtrace on startup fail too ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: I confirm these patchset makes my use case show the backtrace now, merging. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38848?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I66a55dcfdab17d035ce6425220763a85b5b6dc90 Gerrit-Change-Number: 38848 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Nov 2024 17:55:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

7 months, 1 week

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: build virtphy from src with --binary-repo

by fixeria

Attention is currently required from: laforge, osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851?usp=email ) Change subject: testenv: build virtphy from src with --binary-repo ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I37bac8509b2601286e4feab099782f82c8338dca Gerrit-Change-Number: 38851 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 21 Nov 2024 17:44:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024