November 2024 - gerrit-log - lists.osmocom.org

[L] Change in osmo-ttcn3-hacks[master]: bts: add initial testenv.cfg

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38852?usp=email ) Change subject: bts: add initial testenv.cfg ...................................................................... Patch Set 3: Code-Review+2 (1 comment) File bts/run_fake_trx.sh: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38852/comment/a86c6ba4_3bba… : PS3, Line 7: FAKE_TRX_DIR="$TESTENV_GIT_DIR"/osmocom-bb/src/target/trx_toolkit > let's discuss this in one place: https://gerrit.osmocom. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38852?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id9ed3780d166c5f6736a006f466dc5f0dded6279 Gerrit-Change-Number: 38852 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Nov 2024 08:34:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

7 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: build virtphy from src with --binary-repo

by osmith

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851?usp=email ) Change subject: testenv: build virtphy from src with --binary-repo ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I37bac8509b2601286e4feab099782f82c8338dca Gerrit-Change-Number: 38851 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Nov 2024 08:34:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: build virtphy from src with --binary-repo

by osmith

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851?usp=email ) Change subject: testenv: build virtphy from src with --binary-repo ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851/comment/2948f4bf_d3a1… : PS1, Line 9: Add logic to build virtphy from source when running with --binary-repo. > > We can also make osmocom-bb tags and still keep it as "not officially released". […] I don't think the patch here needs to block on this, I can make a follow-up patch to switch to the binary package for virtphy later on. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I37bac8509b2601286e4feab099782f82c8338dca Gerrit-Change-Number: 38851 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Nov 2024 08:34:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

7 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: build virtphy from src with --binary-repo

by osmith

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851?usp=email ) Change subject: testenv: build virtphy from src with --binary-repo ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851/comment/f3c56cfb_30b6… : PS1, Line 9: Add logic to build virtphy from source when running with --binary-repo. > We can also make osmocom-bb tags and still keep it as "not officially released". This sounds like a good solution. I'll package the programs we are using, and once merged I'll make a tag that is "not officially released". -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38851?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I37bac8509b2601286e4feab099782f82c8338dca Gerrit-Change-Number: 38851 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Nov 2024 08:32:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

7 months

1
0
0 0

[XS] Change in libosmo-netif[master]: examples/ipa-stream-client: Fix wrong call to osmo_ipa_process_msg()

by fixeria

Attention is currently required from: daniel, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38872?usp=email ) Change subject: examples/ipa-stream-client: Fix wrong call to osmo_ipa_process_msg() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38872?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Idec574f59587c681dd059266c9a9cf244bf41dc3 Gerrit-Change-Number: 38872 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Nov 2024 19:58:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

[XS] Change in libosmo-netif[master]: examples/ipa-stream-client: Fix wrong call to osmo_ipa_process_msg()

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38872?usp=email ) Change subject: examples/ipa-stream-client: Fix wrong call to osmo_ipa_process_msg() ...................................................................... examples/ipa-stream-client: Fix wrong call to osmo_ipa_process_msg() The function osmo_ipa_process_msg() is already called internally by the segmentation callback osmo_ipa_segmentation_cb(), which calls ipa_check_pull_headers() which in turn calls osmo_ipa_process_msg(). The program was still working because it was using msg->data which isn't modified by osmo_ipa_process_msg(), but the l2h pointer was incorrectly modified. Change-Id: Idec574f59587c681dd059266c9a9cf244bf41dc3 --- M examples/ipa-stream-client.c 1 file changed, 1 insertion(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/72/38872/1 diff --git a/examples/ipa-stream-client.c b/examples/ipa-stream-client.c index b58370e..2604266 100644 --- a/examples/ipa-stream-client.c +++ b/examples/ipa-stream-client.c @@ -115,13 +115,7 @@ return 0; } - if (osmo_ipa_process_msg(msg) < 0) { - LOGP(DIPATEST, LOGL_ERROR, "bad IPA message\n"); - msgb_free(msg); - return 0; - } - - num = osmo_load32be(msg->data); + num = osmo_load32be(msgb_l2(msg)); LOGP(DLINP, LOGL_DEBUG, "received msg number %d\n", num); llist_for_each_entry_safe(cur, tmp, &msg_sent_list, head) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38872?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Idec574f59587c681dd059266c9a9cf244bf41dc3 Gerrit-Change-Number: 38872 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 1 week

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN: BSSGP_ConnHdlr: GMM Service Request: add support to expect auth...

by fixeria

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email ) Change subject: SGSN: BSSGP_ConnHdlr: GMM Service Request: add support to expect authentication ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: All my comments marked Done, but nothing changed? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9ed08160bf5413e3a30d6e90eb947d4d799e1058 Gerrit-Change-Number: 38396 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 21 Nov 2024 18:39:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

7 months, 1 week

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: bts: add initial testenv.cfg

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38852?usp=email ) Change subject: bts: add initial testenv.cfg ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38852?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id9ed3780d166c5f6736a006f466dc5f0dded6279 Gerrit-Change-Number: 38852 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Nov 2024 18:23:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

[S] Change in libosmo-netif[master]: stream_cli: Allow setting nodelay sockopt after opening sock

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38826?usp=email ) Change subject: stream_cli: Allow setting nodelay sockopt after opening sock ...................................................................... stream_cli: Allow setting nodelay sockopt after opening sock This allows users who wish to first open the socket and set the nodelay option at a later point. This has also a use case according to man 7 tcp: """ setting this option forces an explicit flush of pending output, even if TCP_CORK is currently set. """ Change-Id: Ic178d924da03968de1f140bfc8805c972b849e7b --- M src/stream_cli.c 1 file changed, 24 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/stream_cli.c b/src/stream_cli.c index d4067d6..5d8a2c2 100644 --- a/src/stream_cli.c +++ b/src/stream_cli.c @@ -148,6 +148,17 @@ return cli->state == STREAM_CLI_STATE_CONNECTED; } +/*! Check if Osmocom Stream Client is opened (has an FD available) according to + * its current state. + * \param[in] cli Osmocom Stream Client + * \return true if fd is available (osmo_stream_cli_get_fd()), false otherwise + */ +static bool stream_cli_is_opened(const struct osmo_stream_cli *cli) +{ + return cli->state == STREAM_CLI_STATE_CONNECTING || + cli->state == STREAM_CLI_STATE_CONNECTED; +} + static void osmo_stream_cli_close_iofd(struct osmo_stream_cli *cli) { if (!cli->iofd) @@ -911,17 +922,29 @@ /*! Set the NODELAY socket option to avoid Nagle-like behavior. * Setting this to nodelay=true will automatically set the NODELAY * socket option on any socket established via \ref osmo_stream_cli_open - * or any re-connect. You have to set this _before_ opening the + * or any re-connect. This can be set either before or after opening the * socket. * \param[in] cli Stream client whose sockets are to be configured * \param[in] nodelay whether to set (true) NODELAY before connect() */ void osmo_stream_cli_set_nodelay(struct osmo_stream_cli *cli, bool nodelay) { + int fd; if (nodelay) cli->flags |= OSMO_STREAM_CLI_F_NODELAY; else cli->flags &= ~OSMO_STREAM_CLI_F_NODELAY; + + if (!stream_cli_is_opened(cli)) + return; /* Config will be applied upon open() time */ + + if ((fd = osmo_stream_cli_get_fd(cli)) < 0) { + LOGSCLI(cli, LOGL_ERROR, "set_nodelay(%u): failed obtaining socket\n", nodelay); + return; + } + if (stream_setsockopt_nodelay(fd, cli->proto, nodelay ? 1 : 0) < 0) + LOGSCLI(cli, LOGL_ERROR, "set_nodelay(%u): failed setsockopt err=%d\n", + nodelay, errno); } /*! Open connection of an Osmocom stream client. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38826?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ic178d924da03968de1f140bfc8805c972b849e7b Gerrit-Change-Number: 38826 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months, 1 week

1
0
0 0

[XS] Change in android-apdu-proxy[master]: README.md: order compatible devices alphabetically

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/38869?usp=email ) Change subject: README.md: order compatible devices alphabetically ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/38869?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: android-apdu-proxy Gerrit-Branch: master Gerrit-Change-Id: I51ef8b8e23bc12598cebc848a91c359769f744e5 Gerrit-Change-Number: 38869 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 21 Nov 2024 18:15:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024