November 2024 - gerrit-log - lists.osmocom.org

[XS] Change in pysim[master]: esim.saip: Compute number of records from efFileSize and record_len

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38897?usp=email ) Change subject: esim.saip: Compute number of records from efFileSize and record_len ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38897?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0cc8e7241e37ee23df00c2622422904e7ccdca77 Gerrit-Change-Number: 38897 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Nov 2024 15:47:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months

1
0
0 0

[S] Change in pysim[master]: pySim.esim.saip: Treat "Readable and Updateable when deactivated" flag

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38896?usp=email ) Change subject: pySim.esim.saip: Treat "Readable and Updateable when deactivated" flag ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38896?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7644d265f746c662b64f7156b3be08a01e3a97aa Gerrit-Change-Number: 38896 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Nov 2024 15:47:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months

1
0
0 0

[S] Change in pysim[master]: esim.saip: Fix parsing/generating fillPattern + repeatPattern

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38895?usp=email ) Change subject: esim.saip: Fix parsing/generating fillPattern + repeatPattern ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38895?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iff339cbe841112a01c9c617f43b0e69df2521b51 Gerrit-Change-Number: 38895 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Nov 2024 15:47:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months

1
0
0 0

[XS] Change in pysim[master]: esim.saip.FsProfileElement: Add create_file() method

by laforge

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38909?usp=email ) Change subject: esim.saip.FsProfileElement: Add create_file() method ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38909?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0817819af40f3d0dc0c3d2b91039c5748dd31ee2 Gerrit-Change-Number: 38909 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 25 Nov 2024 15:47:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp_new(): use talloc instead of calloc/free

by lynxis lazus

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38930?usp=email ) Change subject: gtp_new(): use talloc instead of calloc/free ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Is there a better way than using init/deinit? -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38930?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I7c4a29c4bb1ef3c7bf506e59e99b3a804cabe34b Gerrit-Change-Number: 38930 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 25 Nov 2024 15:41:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

7 months

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp_new(): use talloc instead of calloc/free

by lynxis lazus

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38930?usp=email ) Change subject: gtp_new(): use talloc instead of calloc/free ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38930?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I7c4a29c4bb1ef3c7bf506e59e99b3a804cabe34b Gerrit-Change-Number: 38930 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 25 Nov 2024 15:40:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

7 months

1
0
0 0

[M] Change in osmo-msc[master]: vlr: Add support for CS and PS timers

by daniel

Attention is currently required from: lynxis lazus, pespin. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38486?usp=email ) Change subject: vlr: Add support for CS and PS timers ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: I don't really like the fact that you have to pass both timer values everywhere in `vlr_time_secs()`, but I don't know how to do it better. You could add the offset (100) to Txxxx if `vlr_is_ps()` inside of that function and exclusively use the CS timer numbers, but not sure if that's any clearer File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/3829a234_e08ac7c0?usp… : PS2, Line 1052: T3212 "%s", vlr_is_cs(vsub->vlr) ? "T3212" : "T3312" -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38486?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I364973b8d9e277ec5963343c0a83061e81a5baba Gerrit-Change-Number: 38486 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 25 Nov 2024 15:36:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

7 months

1
0
0 0

[XS] Change in osmo-ggsn[master]: gtpie: fix comment

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38932?usp=email ) Change subject: gtpie: fix comment ...................................................................... gtpie: fix comment Change-Id: I5aed6a7a2ae4138567944988bc81cebdbf129276 --- M gtp/gtpie.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/32/38932/1 diff --git a/gtp/gtpie.c b/gtp/gtpie.c index 3212a8a..b3f2ff7 100644 --- a/gtp/gtpie.c +++ b/gtp/gtpie.c @@ -770,7 +770,7 @@ /*! Encode GTP packet payload from Array of Information Elements. * \param[out] ie Input Array of GTPIE - * \param[in] size Size of ? + * \param[in] size Size of ie * \param[out] pack Pointer to caller-allocated buffer for raw GTP packet (GTPIE_MAX length) * \param[out] len Encoded length of \a pack in bytes * \returns 0 on sucess; 2 for out-of-space */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38932?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I5aed6a7a2ae4138567944988bc81cebdbf129276 Gerrit-Change-Number: 38932 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

7 months

1
0
0 0

[XS] Change in osmo-ggsn[master]: gtp_internal.h: add missing include to <stdint.h>

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38931?usp=email ) Change subject: gtp_internal.h: add missing include to <stdint.h> ...................................................................... gtp_internal.h: add missing include to <stdint.h> Change-Id: I4b9a9b582854368b3492cb7438b3acb1a9652f9e --- M gtp/gtp_internal.h 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/31/38931/1 diff --git a/gtp/gtp_internal.h b/gtp/gtp_internal.h index c8f22dc..f04b220 100644 --- a/gtp/gtp_internal.h +++ b/gtp/gtp_internal.h @@ -1,3 +1,5 @@ #pragma once +#include <stdint.h> + uint64_t gtp_imsi_str2gtp(const char *str); -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38931?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I4b9a9b582854368b3492cb7438b3acb1a9652f9e Gerrit-Change-Number: 38931 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

7 months

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp.h: add more GTP cause code from 29.060 v15.3.30

by daniel

Attention is currently required from: lynxis lazus. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38929?usp=email ) Change subject: gtp.h: add more GTP cause code from 29.060 v15.3.30 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38929?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I1571286f01a24adf10243c9551ca81bacc12f8f9 Gerrit-Change-Number: 38929 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 25 Nov 2024 15:15:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024