November 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: SGSN_Tests: assign random TEID-C to Context Req/Resp/Ack messages

by daniel

Attention is currently required from: lynxis lazus. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38921?usp=email ) Change subject: SGSN_Tests: assign random TEID-C to Context Req/Resp/Ack messages ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38921?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icac28280a810e8d24eeeaaae1fb1a15278fde8da Gerrit-Change-Number: 38921 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 25 Nov 2024 14:55:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months

1
0
0 0

[S] Change in libosmocore[master]: gsm_utils: add gprs_tlli2tmsi()

by daniel

Attention is currently required from: lynxis lazus. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/38764?usp=email ) Change subject: gsm_utils: add gprs_tlli2tmsi() ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38764?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9d3464922c89383099a5f3cdd1458c0ecc28ee18 Gerrit-Change-Number: 38764 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 25 Nov 2024 14:53:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: L3_Templates: RAU Request: add support for MS Network Capability

by lynxis lazus

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38916?usp=email ) Change subject: L3_Templates: RAU Request: add support for MS Network Capability ...................................................................... L3_Templates: RAU Request: add support for MS Network Capability The MS Network Capability is important to determine the UMTS auth capability as well the R99 support. Change-Id: Id750c84ae1673ac33c98cecea035805e8cb92bcb --- M library/L3_Templates.ttcn 1 file changed, 19 insertions(+), 2 deletions(-) Approvals: daniel: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn index 52b1f72..fd68fcd 100644 --- a/library/L3_Templates.ttcn +++ b/library/L3_Templates.ttcn @@ -171,6 +171,22 @@ } } +function ts_GMM_MsNetCapTLV(template (omit) MSNetworkCapabilityV ms_network_cap) return template (omit) MSNetworkCapabilityTLV { + var template (omit) MSNetworkCapabilityTLV ret; + if (istemplatekind(ms_network_cap, "omit")) { + return omit; + } else { + ret := { + elementIdentifier := '31'O, + mSNetworkCapabilityLV := { + lengthIndicator := 0, /* overwritten */ + msNetworkCapabilityV := ms_network_cap + } + } + return ret; + } +} + /* send template for Mobile Identity (TMSI) */ function ts_MI_TMSI_TLV(template (omit) OCT4 tmsi) return template (omit) MobileIdentityTLV { var template (omit) MobileIdentityTLV ret; @@ -2620,7 +2636,8 @@ template (omit) P_TMSISignatureTV p_tmsi_sig := omit, template (omit) P_TMSI_TypeTV p_tmsi_type := omit, template (omit) MobileIdentityTLV add_p_tmsi := omit, - template (omit) RoutingAreaIdentification2TLV add_rai := omit + template (omit) RoutingAreaIdentification2TLV add_rai := omit, + template (omit) MSNetworkCapabilityV ms_network_cap := omit ) := { discriminator := '0000'B, /* overwritten */ tiOrSkip := { @@ -2639,7 +2656,7 @@ drxParameter := omit, tmsiStatus := omit, ptmsi := ts_MI_TMSI_TLV(p_tmsi), - mSNetworkCapability := omit, + mSNetworkCapability := ts_GMM_MsNetCapTLV(ms_network_cap), pdpContextStatus := omit, /* TODO */ pC_LCSCapability := omit, mBMS_ContextStatus := omit, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38916?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id750c84ae1673ac33c98cecea035805e8cb92bcb Gerrit-Change-Number: 38916 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: L3_Templates: set R99 indicator

by lynxis lazus

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38917?usp=email ) Change subject: L3_Templates: set R99 indicator ...................................................................... L3_Templates: set R99 indicator To support UMTS AKA auth, set the R99 indicator Change-Id: I80035c68bd43fac336ef74ca9377a21f1061167f --- M library/L3_Templates.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: daniel: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn index fd68fcd..6b7baae 100644 --- a/library/L3_Templates.ttcn +++ b/library/L3_Templates.ttcn @@ -2344,7 +2344,7 @@ ucs2Support := '1'B, ssScreeningIndicator := '01'B, solSACapability := '0'B, - revisionLevelIndicatior := omit, + revisionLevelIndicatior := '1'B, pFCFeatureMode := omit, extendedGEAbits := omit, lcsVAcapability := omit, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38917?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I80035c68bd43fac336ef74ca9377a21f1061167f Gerrit-Change-Number: 38917 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: L3_Templates: Add required TLVs for RA Request when moving from 4G to 2G

by lynxis lazus

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38918?usp=email ) Change subject: L3_Templates: Add required TLVs for RA Request when moving from 4G to 2G ...................................................................... L3_Templates: Add required TLVs for RA Request when moving from 4G to 2G Add ts_PtmsiTypeTV and ts_RoutingAreaIdentification2TLV Change-Id: I6d735be76aab0b5228502e3e19804bcc98864829 --- M library/L3_Templates.ttcn 1 file changed, 33 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified daniel: Looks good to me, approved diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn index 6b7baae..181fde4 100644 --- a/library/L3_Templates.ttcn +++ b/library/L3_Templates.ttcn @@ -2935,6 +2935,39 @@ } } + +const BIT1 c_GMM_PMTSI_TYPE_NATIVE := '0'B; +const BIT1 c_GMM_PMTSI_TYPE_MAPPED := '1'B; + +function ts_PtmsiTypeTV(template (omit) BIT1 val) return template (omit) P_TMSI_TypeTV { + var template (omit) P_TMSI_TypeTV ret; + if (istemplatekind(val, "omit")) { + return omit; + } else { + ret := { + pTMSI_TypeValue := valueof(val), + spare := '000'B, + elementIdentifier := '1110'B + } + return ret; + } +} + +function ts_RoutingAreaIdentification2TLV(template (omit) OCT6 val) return template (omit) RoutingAreaIdentification2TLV { + var template (omit) RoutingAreaIdentification2TLV ret; + if (istemplatekind(val, "omit")) { + return omit; + } else { + ret := { + elementIdentifier := '1B'O, + lengthIndicator := 6, + routingAreaIdentification2 := valueof(val) + } + return ret; + } +} + + template (value) PDU_L3_MS_SGSN ts_GMM_DET_REQ_MO(BIT3 dtt := c_GMM_DTT_MO_GPRS, boolean power_off := false, template (omit) OCT4 p_tmsi := omit, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38918?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6d735be76aab0b5228502e3e19804bcc98864829 Gerrit-Change-Number: 38918 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: L3_Templates: correct set a5 bits to A1 + A5

by lynxis lazus

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38919?usp=email ) Change subject: L3_Templates: correct set a5 bits to A1 + A5 ...................................................................... L3_Templates: correct set a5 bits to A1 + A5 The MS Radio Capabilities must include A5 bits to inform the network of supported encryption capabilities. The a5bits of the first access network must be present, later ones can be omited, meaning the ones of the first one also applies. Change-Id: I5256c1a2c57761589ec51de4fba47fa48b1f3fbb --- M library/L3_Templates.ttcn 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve daniel: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn index 181fde4..9551845 100644 --- a/library/L3_Templates.ttcn +++ b/library/L3_Templates.ttcn @@ -2414,6 +2414,17 @@ } return '1'B; } + +template (value) A5BITS ts_a5bits_a51a53 := { + a51 := '1'B, + a52 := '0'B, + a53 := '1'B, + a54 := '0'B, + a55 := '0'B, + a56 := '0'B, + a57 := '0'B +}; + template (value) MSRACapabilityValuesRecord ts_RaCapRec(BIT4 att := '0001'B /* E-GSM */, template (omit) MultislotCap_GPRS mscap_gprs := omit, template (omit) MultislotCap_EGPRS mscap_egprs := omit) := { mSRACapabilityValues := { mSRACapabilityValuesExclude1111 := { @@ -2423,7 +2434,7 @@ accessCapabilities := { rfPowerCapability := '001'B, /* FIXME */ presenceBitA5 := '0'B, - a5bits := omit, + a5bits := ts_a5bits_a51a53, esind := '1'B, psbit := '0'B, vgcs := '0'B, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38919?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5256c1a2c57761589ec51de4fba47fa48b1f3fbb Gerrit-Change-Number: 38919 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: L3_Templates: GMM: Attach Req/RAU Req: add TLVs required for 4G -> 2G...

by lynxis lazus

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38915?usp=email ) Change subject: L3_Templates: GMM: Attach Req/RAU Req: add TLVs required for 4G -> 2G mobility tests ...................................................................... L3_Templates: GMM: Attach Req/RAU Req: add TLVs required for 4G -> 2G mobility tests Change-Id: I0a37b75f6b1a522868cdbff43d99d4b953a4e952 --- M library/L3_Templates.ttcn 1 file changed, 18 insertions(+), 10 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn index f4de9a3..52b1f72 100644 --- a/library/L3_Templates.ttcn +++ b/library/L3_Templates.ttcn @@ -2461,7 +2461,11 @@ boolean combined := false, boolean follow_on_pending := false, template (omit) MobileStationClassmark2_TLV cm2_tlv := omit, template (omit) MobileStationClassmark3_TLV cm3_tlv := omit, - template (omit) NetworkResourceIdentifierContainerTLV nri := omit + template (omit) NetworkResourceIdentifierContainerTLV nri := omit, + template (omit) P_TMSISignatureTV p_tmsi_sig := omit, + template (omit) P_TMSI_TypeTV p_tmsi_type := omit, + template (omit) MobileIdentityTLV add_p_tmsi := omit, + template (omit) RoutingAreaIdentification2TLV add_rai := omit ) := { discriminator := '0000'B, /* overwritten */ tiOrSkip := { @@ -2478,7 +2482,7 @@ mobileIdentity := mi_lv, oldRoutingAreaID := old_ra, msRACap := ts_MS_RaCapa, - ptmsiSignature := omit, /* TODO */ + ptmsiSignature := p_tmsi_sig, reqGPRStimer := omit, tmsiStatus := omit, pC_LCSCapability := omit, @@ -2486,11 +2490,11 @@ mobileStationClassmark3 := cm3_tlv, supportedCodecs := omit, uENetworkCapability := omit, - additionalMobileIdentity := omit, - routingAreaIdentification2 := omit, + additionalMobileIdentity := add_p_tmsi, + routingAreaIdentification2 := add_rai, voiceDomainandUEsUsageSetting := omit, deviceProperties := omit, - p_TMSI_Type := omit, + p_TMSI_Type := p_tmsi_type, mS_NetworkFeatureSupport := omit, oldLocationAreaIdentification := omit, additionalUpdateType := omit, @@ -2612,7 +2616,11 @@ template (omit) MobileStationClassmark2_TLV cm2_tlv := omit, template (omit) MobileStationClassmark3_TLV cm3_tlv := omit, template (omit) OCT4 p_tmsi := omit, - template (omit) NetworkResourceIdentifierContainerTLV nri := omit + template (omit) NetworkResourceIdentifierContainerTLV nri := omit, + template (omit) P_TMSISignatureTV p_tmsi_sig := omit, + template (omit) P_TMSI_TypeTV p_tmsi_type := omit, + template (omit) MobileIdentityTLV add_p_tmsi := omit, + template (omit) RoutingAreaIdentification2TLV add_rai := omit ) := { discriminator := '0000'B, /* overwritten */ tiOrSkip := { @@ -2626,7 +2634,7 @@ gprsCKSN := { '111'B, '0'B }, oldRoutingAreaId := old_ra, msRACap := ts_MS_RaCapa, - oldPTMSISignature := omit, /* TODO */ + oldPTMSISignature := p_tmsi_sig, readyTimerValue := omit, drxParameter := omit, tmsiStatus := omit, @@ -2636,13 +2644,13 @@ pC_LCSCapability := omit, mBMS_ContextStatus := omit, uENetworkCapability := omit, - additionalMobileIdentity := omit, - oldRoutingAreaIdentification2 := omit, + additionalMobileIdentity := add_p_tmsi, + oldRoutingAreaIdentification2 := add_rai, mobileStationClassmark2 := cm2_tlv, mobileStationClassmark3 := cm3_tlv, supportedCodecs := omit, voiceDomainUEUsageSetting := omit, - p_TMSI_Type := omit, + p_TMSI_Type := p_tmsi_type, deviceProperties := omit, mS_NetworkFeatureSupport := omit, oldLocationAreaIdentification := omit, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38915?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0a37b75f6b1a522868cdbff43d99d4b953a4e952 Gerrit-Change-Number: 38915 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: tr_GTPC_SGSNContextReq: use the same template as MsgType

by daniel

Attention is currently required from: lynxis lazus. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38923?usp=email ) Change subject: tr_GTPC_SGSNContextReq: use the same template as MsgType ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38923?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idd546c3ec387e9c3ea8f1b1a61cf8ca8230db46a Gerrit-Change-Number: 38923 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 25 Nov 2024 14:50:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: L3_Templates: correct set a5 bits to A1 + A5

by daniel

Attention is currently required from: lynxis lazus. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38919?usp=email ) Change subject: L3_Templates: correct set a5 bits to A1 + A5 ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: This should fix the TTCN3 SGSN tests -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38919?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5256c1a2c57761589ec51de4fba47fa48b1f3fbb Gerrit-Change-Number: 38919 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 25 Nov 2024 14:49:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

7 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: L3_Templates: Add required TLVs for RA Request when moving from 4G to 2G

by daniel

Attention is currently required from: lynxis lazus. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38918?usp=email ) Change subject: L3_Templates: Add required TLVs for RA Request when moving from 4G to 2G ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38918?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6d735be76aab0b5228502e3e19804bcc98864829 Gerrit-Change-Number: 38918 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 25 Nov 2024 14:48:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024