Attention is currently required from: lynxis lazus, pespin. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38486?usp=email ) Change subject: vlr: Add support for CS and PS timers ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: I don't really like the fact that you have to pass both timer values everywhere in `vlr_time_secs()`, but I don't know how to do it better. You could add the offset (100) to Txxxx if `vlr_is_ps()` inside of that function and exclusively use the CS timer numbers, but not sure if that's any clearer File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/3829a234_e08ac7c0?usp=... : PS2, Line 1052: T3212 "%s", vlr_is_cs(vsub->vlr) ? "T3212" : "T3312" -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38486?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I364973b8d9e277ec5963343c0a83061e81a5baba Gerrit-Change-Number: 38486 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann@sysmocom.de> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Mon, 25 Nov 2024 15:36:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No