November 2024 - gerrit-log - lists.osmocom.org

[XS] Change in ...osmo-s1gw[master]: s1ap_proxy: do not expose {en,de}code_pdu() API

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38682?usp=email ) Change subject: s1ap_proxy: do not expose {en,de}code_pdu() API ...................................................................... s1ap_proxy: do not expose {en,de}code_pdu() API Change-Id: Ifb9f5c1991c31b5383c46e149286f8eb99a778a5 --- M src/s1ap_proxy.erl 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/s1ap_proxy.erl b/src/s1ap_proxy.erl index 17ae7d4..62c3bf2 100644 --- a/src/s1ap_proxy.erl +++ b/src/s1ap_proxy.erl @@ -37,9 +37,7 @@ -export([init/0, deinit/1, process_pdu/2, - handle_exit/2, - encode_pdu/1, - decode_pdu/1]). + handle_exit/2]). -include_lib("kernel/include/logger.hrl"). -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38682?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ifb9f5c1991c31b5383c46e149286f8eb99a778a5 Gerrit-Change-Number: 38682 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[L] Change in ...osmo-s1gw[master]: s1ap_proxy: turn this module into a gen_server

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38683?usp=email ) Change subject: s1ap_proxy: turn this module into a gen_server ...................................................................... s1ap_proxy: turn this module into a gen_server This patch makes the s1ap_proxy module self-contained, so API users no longer need to initialize, maintain, or deinitialize its internal state, and also no longer need to trap 'EXIT' signals from the child erab_fsm processes. These improvements in maintainability and ease of use come at the cost of an additional process per SCTP connection, which is manageable. Change-Id: Id6e4c7ee29ae31edca658e1293601d38e5f43e63 --- M src/s1ap_proxy.erl M src/sctp_proxy.erl M test/s1ap_proxy_test.erl 3 files changed, 137 insertions(+), 120 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/s1ap_proxy.erl b/src/s1ap_proxy.erl index 62c3bf2..4452269 100644 --- a/src/s1ap_proxy.erl +++ b/src/s1ap_proxy.erl @@ -33,11 +33,16 @@ %% that of the covered work. -module(s1ap_proxy). +-behaviour(gen_server). --export([init/0, - deinit/1, +-export([init/1, + handle_info/2, + handle_call/3, + handle_cast/2, + terminate/2]). +-export([start_link/0, process_pdu/2, - handle_exit/2]). + shutdown/1]). -include_lib("kernel/include/logger.hrl"). @@ -71,26 +76,95 @@ -export_type([proxy_action/0]). + %% ------------------------------------------------------------------ %% public API %% ------------------------------------------------------------------ -%% Initialize per-connection data --spec init() -> proxy_state(). -init() -> - #proxy_state{erabs = dict:new()}. +-spec start_link() -> gen_server:start_ret(). +start_link() -> + gen_server:start_link(?MODULE, [], []). -%% De-initialize per-connection data --spec deinit(proxy_state()) -> ok. -deinit(_S) -> +-type process_pdu_result() :: {proxy_action(), binary()}. +-spec process_pdu(pid(), binary()) -> process_pdu_result(). +process_pdu(Pid, PDU) -> + gen_server:call(Pid, {?FUNCTION_NAME, PDU}). + + +-spec shutdown(pid()) -> ok. +shutdown(Pid) -> + gen_server:stop(Pid). + + +%% ------------------------------------------------------------------ +%% gen_server API +%% ------------------------------------------------------------------ + +init([]) -> + process_flag(trap_exit, true), + {ok, #proxy_state{erabs = dict:new()}}. + + +handle_call({process_pdu, OrigData}, _From, + #proxy_state{} = S0) -> + {Reply, S1} = handle_pdu_bin(OrigData, S0), + {reply, Reply, S1}; + +handle_call(Info, From, + #proxy_state{} = S) -> + ?LOG_ERROR("unknown ~p() from ~p: ~p", [?FUNCTION_NAME, From, Info]), + {reply, {error, not_implemented}, S}. + + +handle_cast(Info, #proxy_state{} = S) -> + ?LOG_ERROR("unknown ~p(): ~p", [?FUNCTION_NAME, Info]), + {noreply, S}. + + +handle_info({'EXIT', Pid, Reason}, + #proxy_state{erabs = ERABs} = S) -> + ?LOG_DEBUG("Child process ~p terminated with reason ~p", [Pid, Reason]), + Fun = fun(_Key, Val) -> Val =/= Pid end, + {noreply, S#proxy_state{erabs = dict:filter(Fun, ERABs)}}; + +handle_info(Info, #proxy_state{} = S) -> + ?LOG_ERROR("unknown ~p(): ~p", [?FUNCTION_NAME, Info]), + {noreply, S}. + + +terminate(Reason, #proxy_state{}) -> + ?LOG_NOTICE("Terminating, reason ~p", [Reason]), ok. -%% Process an S1AP PDU --type process_pdu_result() :: {{proxy_action(), binary()}, proxy_state()}. --spec process_pdu(binary(), proxy_state()) -> process_pdu_result(). -process_pdu(OrigData, S0) -> +%% ------------------------------------------------------------------ +%% private API +%% ------------------------------------------------------------------ + +-spec erab_uid(erab_id(), proxy_state()) -> erab_uid(). +erab_uid(ERABId, #proxy_state{mme_ue_id = MmeUeId, + enb_ue_id = EnbUeId}) -> + {MmeUeId, EnbUeId, ERABId}. + + +%% Encode an S1AP PDU +-spec encode_pdu(s1ap_pdu()) -> {ok, binary()} | + {error, {asn1, tuple()}}. +encode_pdu(Pdu) -> + 'S1AP-PDU-Descriptions':encode('S1AP-PDU', Pdu). + + +%% Decode an S1AP PDU +-spec decode_pdu(binary()) -> {ok, s1ap_pdu()} | + {error, {asn1, tuple()}}. +decode_pdu(Data) -> + 'S1AP-PDU-Descriptions':decode('S1AP-PDU', Data). + + +%% Process an S1AP PDU (binary) +-spec handle_pdu_bin(binary(), proxy_state()) -> {process_pdu_result(), proxy_state()}. +handle_pdu_bin(OrigData, S0) -> s1gw_metrics:ctr_inc(?S1GW_CTR_S1AP_PROXY_IN_PKT_ALL), try decode_pdu(OrigData) of {ok, PDU} -> @@ -127,38 +201,7 @@ end. -%% Handle an exit event --spec handle_exit(pid(), proxy_state()) -> proxy_state(). -handle_exit(Pid, #proxy_state{erabs = ERABs} = S) -> - Fun = fun(_Key, Val) -> Val =/= Pid end, - S#proxy_state{erabs = dict:filter(Fun, ERABs)}. - - -%% ------------------------------------------------------------------ -%% private API -%% ------------------------------------------------------------------ - --spec erab_uid(erab_id(), proxy_state()) -> erab_uid(). -erab_uid(ERABId, #proxy_state{mme_ue_id = MmeUeId, - enb_ue_id = EnbUeId}) -> - {MmeUeId, EnbUeId, ERABId}. - - -%% Encode an S1AP PDU --spec encode_pdu(s1ap_pdu()) -> {ok, binary()} | - {error, {asn1, tuple()}}. -encode_pdu(Pdu) -> - 'S1AP-PDU-Descriptions':encode('S1AP-PDU', Pdu). - - -%% Decode an S1AP PDU --spec decode_pdu(binary()) -> {ok, s1ap_pdu()} | - {error, {asn1, tuple()}}. -decode_pdu(Data) -> - 'S1AP-PDU-Descriptions':decode('S1AP-PDU', Data). - - -%% Process an S1AP PDU +%% Process an S1AP PDU (decoded) -spec handle_pdu(s1ap_pdu(), proxy_state()) -> {{proxy_action(), s1ap_pdu()}, proxy_state()} | {forward, proxy_state()}. diff --git a/src/sctp_proxy.erl b/src/sctp_proxy.erl index d0bdf08..6503a9e 100644 --- a/src/sctp_proxy.erl +++ b/src/sctp_proxy.erl @@ -77,13 +77,13 @@ %% ------------------------------------------------------------------ init([Aid, MmeAddr, MmePort]) -> - process_flag(trap_exit, true), + {ok, Pid} = s1ap_proxy:start_link(), {ok, connecting, #{enb_aid => Aid, mme_addr => MmeAddr, mme_port => MmePort, tx_queue => [], - priv => s1ap_proxy:init()}}. + handler => Pid}}. callback_mode() -> @@ -145,8 +145,8 @@ %% Handle an eNB -> MME data forwarding request (forward) connected(cast, {send_data, Data}, S0) -> - S1 = sctp_send(Data, S0), - {keep_state, S1}; + sctp_send(Data, S0), + {keep_state, S0}; %% Handle an #sctp_assoc_change event (MME connection state) connected(info, {sctp, _Socket, MmeAddr, MmePort, @@ -168,24 +168,16 @@ #{sock := Sock, enb_aid := EnbAid, mme_aid := Aid, - priv := Priv} = S) -> + handler := Pid} = S) -> ?LOG_DEBUG("MME connection (id=~p, ~p:~p) -> eNB: ~p", [Aid, MmeAddr, MmePort, Data]), - {Action, NewPriv} = s1ap_proxy:process_pdu(Data, Priv), - case Action of + case s1ap_proxy:process_pdu(Pid, Data) of {forward, FwdData} -> sctp_server:send_data(EnbAid, FwdData); {reply, ReData} -> ok = sctp_client:send_data({Sock, Aid}, ReData) end, - {keep_state, S#{priv := NewPriv}}; - -%% Handle termination events of the child processes -connected(info, {'EXIT', Pid, Reason}, - #{priv := Priv} = S) -> - ?LOG_DEBUG("Child process ~p terminated with reason ~p", [Pid, Reason]), - NewPriv = s1ap_proxy:handle_exit(Pid, Priv), - {keep_state, S#{priv := NewPriv}}; + {keep_state, S}; %% Catch-all for other kinds of SCTP events connected(info, {sctp, _Socket, MmeAddr, MmePort, @@ -205,13 +197,12 @@ {ok, State, S}. -terminate(Reason, State, S) -> +terminate(Reason, State, #{handler := Pid} = S) -> ?LOG_NOTICE("Terminating in state ~p, reason ~p", [State, Reason]), + s1ap_proxy:shutdown(Pid), case S of #{sock := Sock, - mme_aid := Aid, - priv := Priv} -> - s1ap_proxy:deinit(Priv), + mme_aid := Aid} -> sctp_client:disconnect({Sock, Aid}), gen_sctp:close(Sock); #{sock := Sock} -> @@ -229,25 +220,23 @@ #{sock := Sock, enb_aid := EnbAid, mme_aid := Aid, - priv := Priv} = S) -> - {Action, NewPriv} = s1ap_proxy:process_pdu(Data, Priv), - case Action of + handler := Pid}) -> + case s1ap_proxy:process_pdu(Pid, Data) of {forward, FwdData} -> ok = sctp_client:send_data({Sock, Aid}, FwdData); {reply, ReData} -> sctp_server:send_data(EnbAid, ReData) - end, - S#{priv := NewPriv}. + end. %% Send pending messages to the MME sctp_send_pending(#{tx_queue := Pending} = S) -> sctp_send_pending(lists:reverse(Pending), S). -sctp_send_pending([Data | Pending], S0) -> - S1 = sctp_send(Data, S0), +sctp_send_pending([Data | Pending], S) -> + sctp_send(Data, S), s1gw_metrics:gauge_dec(?S1GW_GAUGE_S1AP_PROXY_UPLINK_PACKETS_QUEUED), - sctp_send_pending(Pending, S1); + sctp_send_pending(Pending, S); sctp_send_pending([], S) -> S#{tx_queue := []}. diff --git a/test/s1ap_proxy_test.erl b/test/s1ap_proxy_test.erl index 28fe209..cb562a2 100644 --- a/test/s1ap_proxy_test.erl +++ b/test/s1ap_proxy_test.erl @@ -3,6 +3,7 @@ -include_lib("eunit/include/eunit.hrl"). -include("pfcp_mock.hrl"). + %% ------------------------------------------------------------------ %% setup functions %% ------------------------------------------------------------------ @@ -16,13 +17,14 @@ start() -> pfcp_mock:mock_all(), exometer_mock:mock_all(), - s1ap_proxy:init(). + {ok, Pid} = s1ap_proxy:start_link(), + #{handler => Pid}. -stop(S) -> +stop(#{handler := Pid}) -> + s1ap_proxy:shutdown(Pid), exometer_mock:unmock_all(), - pfcp_mock:unmock_all(), - s1ap_proxy:deinit(S). + pfcp_mock:unmock_all(). %% ------------------------------------------------------------------ @@ -50,107 +52,90 @@ %% actual testcases %% ------------------------------------------------------------------ -test_s1_setup_req(S0) -> +test_s1_setup_req(#{handler := Pid}) -> SetupReq = s1_setup_req_pdu(), %% Expect the PDU to be proxied unmodified - [?_assertEqual({{forward, SetupReq}, S0}, s1ap_proxy:process_pdu(SetupReq, S0))]. + [?_assertEqual({forward, SetupReq}, s1ap_proxy:process_pdu(Pid, SetupReq))]. -test_e_rab_setup(S0) -> +test_e_rab_setup(#{handler := Pid}) -> %% [eNB <- MME] E-RAB SETUP REQUEST SetupReqIn = e_rab_setup_req_pdu(?ADDR_U2C, ?TEID_U2C), SetupReqExp = e_rab_setup_req_pdu(?ADDR_A2U, ?TEID_A2U), - {{forward, SetupReqOut}, S1} = s1ap_proxy:process_pdu(SetupReqIn, S0), - %% [eNB -> MME] E-RAB SETUP RESPONSE SetupRspIn = e_rab_setup_rsp_pdu(?ADDR_U2A, ?TEID_U2A), SetupRspExp = e_rab_setup_rsp_pdu(?ADDR_C2U, ?TEID_C2U), - {{forward, SetupRspOut}, _S2} = s1ap_proxy:process_pdu(SetupRspIn, S1), - [?_assertEqual(SetupReqExp, SetupReqOut), - ?_assertEqual(SetupRspExp, SetupRspOut)]. + [?_assertEqual({forward, SetupReqExp}, s1ap_proxy:process_pdu(Pid, SetupReqIn)), + ?_assertEqual({forward, SetupRspExp}, s1ap_proxy:process_pdu(Pid, SetupRspIn))]. -test_e_rab_setup_req_fail(S0) -> +test_e_rab_setup_req_fail(#{handler := Pid}) -> %% pfcp_peer:session_establish_req/3 responds with a reject PDU = pfcp_mock:pdu_rsp_reject(session_establishment_response, ?SEID_Loc), pfcp_mock:mock_req(session_establish_req, PDU), - %% the linked erab_fsm will terminate abnormally, so trap this - process_flag(trap_exit, true), %% eNB <- [S1GW <- MME] E-RAB SETUP REQUEST %% eNB -- [S1GW -> MME] E-RAB SETUP RESPONSE (failure) SetupReqIn = e_rab_setup_req_pdu(?ADDR_U2C, ?TEID_U2C), SetupRspExp = e_rab_setup_rsp_fail_pdu(), - {{reply, SetupRspOut}, _S1} = s1ap_proxy:process_pdu(SetupReqIn, S0), %% TODO: make sure that the E-RAB FSM has been terminated - [?_assertEqual(SetupRspExp, SetupRspOut)]. + [?_assertEqual({reply, SetupRspExp}, s1ap_proxy:process_pdu(Pid, SetupReqIn))]. -test_e_rab_release_cmd(S0) -> +test_e_rab_release_cmd(#{handler := Pid}) -> %% [eNB <- MME] E-RAB SETUP REQUEST - SetupReqIn = e_rab_setup_req_pdu(?ADDR_U2C, ?TEID_U2C), - {_, S1} = s1ap_proxy:process_pdu(SetupReqIn, S0), - + SetupReq = e_rab_setup_req_pdu(?ADDR_U2C, ?TEID_U2C), %% [eNB -> MME] E-RAB SETUP RESPONSE - SetupRspIn = e_rab_setup_rsp_pdu(?ADDR_U2A, ?TEID_U2A), - {_, S2} = s1ap_proxy:process_pdu(SetupRspIn, S1), - + SetupRsp = e_rab_setup_rsp_pdu(?ADDR_U2A, ?TEID_U2A), %% [eNB <- MME] E-RAB RELEASE COMMAND ReleaseCmd = e_rab_release_cmd_pdu(), - {{forward, ReleaseCmdOut}, S3} = s1ap_proxy:process_pdu(ReleaseCmd, S2), - %% [eNB -> MME] E-RAB RELEASE RESPONSE ReleaseRsp = e_rab_release_rsp_pdu(), - {{forward, ReleaseRspOut}, _S4} = s1ap_proxy:process_pdu(ReleaseRsp, S3), %% TODO: make sure that the E-RAB FSM has been terminated - [?_assertEqual(ReleaseCmd, ReleaseCmdOut), - ?_assertEqual(ReleaseRsp, ReleaseRspOut)]. + [?_assertMatch({forward, _}, s1ap_proxy:process_pdu(Pid, SetupReq)), + ?_assertMatch({forward, _}, s1ap_proxy:process_pdu(Pid, SetupRsp)), + ?_assertEqual({forward, ReleaseCmd}, s1ap_proxy:process_pdu(Pid, ReleaseCmd)), + ?_assertEqual({forward, ReleaseRsp}, s1ap_proxy:process_pdu(Pid, ReleaseRsp))]. -test_e_rab_release_ind(S0) -> +test_e_rab_release_ind(#{handler := Pid}) -> %% [eNB <- MME] E-RAB SETUP REQUEST - SetupReqIn = e_rab_setup_req_pdu(?ADDR_U2C, ?TEID_U2C), - {_, S1} = s1ap_proxy:process_pdu(SetupReqIn, S0), - + SetupReq = e_rab_setup_req_pdu(?ADDR_U2C, ?TEID_U2C), %% [eNB -> MME] E-RAB SETUP RESPONSE - SetupRspIn = e_rab_setup_rsp_pdu(?ADDR_U2A, ?TEID_U2A), - {_, S2} = s1ap_proxy:process_pdu(SetupRspIn, S1), - + SetupRsp = e_rab_setup_rsp_pdu(?ADDR_U2A, ?TEID_U2A), %% [eNB -> MME] E-RAB RELEASE INDICATION ReleaseInd = e_rab_release_ind_pdu(), - {{forward, ReleaseIndOut}, _S3} = s1ap_proxy:process_pdu(ReleaseInd, S2), %% TODO: make sure that the E-RAB FSM has been terminated - [?_assertEqual(ReleaseInd, ReleaseIndOut)]. + [?_assertMatch({forward, _}, s1ap_proxy:process_pdu(Pid, SetupReq)), + ?_assertMatch({forward, _}, s1ap_proxy:process_pdu(Pid, SetupRsp)), + ?_assertEqual({forward, ReleaseInd}, s1ap_proxy:process_pdu(Pid, ReleaseInd))]. -test_e_rab_modify_ind(S0) -> +test_e_rab_modify_ind(#{handler := Pid}) -> %% [eNB -> MME] E-RAB MODIFICATION INDICATION ModifyIndIn = e_rab_modify_ind_pdu(?ADDR_U2A, ?TEID_U2A), %% XXX: not implemented, we should actually expect ?ADDR_C2U, ?TEID_C2U ModifyIndExp = e_rab_modify_ind_pdu(?ADDR_U2A, ?TEID_U2A), - {{forward, ModifyIndOut}, _S1} = s1ap_proxy:process_pdu(ModifyIndIn, S0), - [?_assertEqual(ModifyIndExp, ModifyIndOut)]. + [?_assertEqual({forward, ModifyIndExp}, s1ap_proxy:process_pdu(Pid, ModifyIndIn))]. -test_initial_context_setup(S0) -> + +test_initial_context_setup(#{handler := Pid}) -> %% [eNB <- MME] INITIAL CONTEXT SETUP REQUEST InitCtxSetupReqIn = initial_context_setup_req_pdu(?ADDR_U2C, ?TEID_U2C), InitCtxSetupReqExp = initial_context_setup_req_pdu(?ADDR_A2U, ?TEID_A2U), - {{forward, InitCtxSetupReqOut}, S1} = s1ap_proxy:process_pdu(InitCtxSetupReqIn, S0), - %% [eNB -> MME] INITIAL CONTEXT SETUP RESPONSE InitCtxSetupRspIn = initial_context_setup_rsp_pdu(?ADDR_U2A, ?TEID_U2A), InitCtxSetupRspExp = initial_context_setup_rsp_pdu(?ADDR_C2U, ?TEID_C2U), - {{forward, InitCtxSetupRspOut}, _S2} = s1ap_proxy:process_pdu(InitCtxSetupRspIn, S1), - [?_assertEqual(InitCtxSetupReqExp, InitCtxSetupReqOut), - ?_assertEqual(InitCtxSetupRspExp, InitCtxSetupRspOut)]. + [?_assertEqual({forward, InitCtxSetupReqExp}, s1ap_proxy:process_pdu(Pid, InitCtxSetupReqIn)), + ?_assertEqual({forward, InitCtxSetupRspExp}, s1ap_proxy:process_pdu(Pid, InitCtxSetupRspIn))]. %% ------------------------------------------------------------------ -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38683?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Id6e4c7ee29ae31edca658e1293601d38e5f43e63 Gerrit-Change-Number: 38683 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[S] Change in ...osmo-s1gw[master]: s1ap_proxy: add E-RAB introspection API

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38684?usp=email ) Change subject: s1ap_proxy: add E-RAB introspection API ...................................................................... s1ap_proxy: add E-RAB introspection API This API will be used by the upcoming interactive VTY interface. Let's also use it unit tests to check persence/absence of E-RAB FSMs. Change-Id: I43dcfa613a4ee0de5b2f6619911fd92b1675acd6 --- M src/s1ap_proxy.erl M test/s1ap_proxy_test.erl 2 files changed, 33 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/s1ap_proxy.erl b/src/s1ap_proxy.erl index 4452269..ea20106 100644 --- a/src/s1ap_proxy.erl +++ b/src/s1ap_proxy.erl @@ -42,6 +42,8 @@ terminate/2]). -export([start_link/0, process_pdu/2, + fetch_erab/2, + fetch_erab_list/1, shutdown/1]). -include_lib("kernel/include/logger.hrl"). @@ -92,6 +94,18 @@ gen_server:call(Pid, {?FUNCTION_NAME, PDU}). +%% Fetch a single E-RAB from the registry (by UID) +-spec fetch_erab(pid(), erab_uid()) -> {ok, pid()} | error. +fetch_erab(Pid, UID) -> + gen_server:call(Pid, {?FUNCTION_NAME, UID}). + + +%% Fetch all E-RABs from the registry in form of a list +-spec fetch_erab_list(pid()) -> [{erab_uid(), pid()}]. +fetch_erab_list(Pid) -> + gen_server:call(Pid, ?FUNCTION_NAME). + + -spec shutdown(pid()) -> ok. shutdown(Pid) -> gen_server:stop(Pid). @@ -111,6 +125,14 @@ {Reply, S1} = handle_pdu_bin(OrigData, S0), {reply, Reply, S1}; +handle_call({fetch_erab, UID}, _From, + #proxy_state{erabs = ERABs} = S) -> + {reply, dict:find(UID, ERABs), S}; + +handle_call(fetch_erab_list, _From, + #proxy_state{erabs = ERABs} = S) -> + {reply, dict:to_list(ERABs), S}; + handle_call(Info, From, #proxy_state{} = S) -> ?LOG_ERROR("unknown ~p() from ~p: ~p", [?FUNCTION_NAME, From, Info]), diff --git a/test/s1ap_proxy_test.erl b/test/s1ap_proxy_test.erl index cb562a2..9e94716 100644 --- a/test/s1ap_proxy_test.erl +++ b/test/s1ap_proxy_test.erl @@ -67,7 +67,9 @@ SetupRspExp = e_rab_setup_rsp_pdu(?ADDR_C2U, ?TEID_C2U), [?_assertEqual({forward, SetupReqExp}, s1ap_proxy:process_pdu(Pid, SetupReqIn)), - ?_assertEqual({forward, SetupRspExp}, s1ap_proxy:process_pdu(Pid, SetupRspIn))]. + ?_assertEqual({forward, SetupRspExp}, s1ap_proxy:process_pdu(Pid, SetupRspIn)), + ?_assertMatch({ok, _}, s1ap_proxy:fetch_erab(Pid, {7, 9, 6})), + ?_assertMatch([_], s1ap_proxy:fetch_erab_list(Pid))]. test_e_rab_setup_req_fail(#{handler := Pid}) -> @@ -79,9 +81,8 @@ SetupReqIn = e_rab_setup_req_pdu(?ADDR_U2C, ?TEID_U2C), SetupRspExp = e_rab_setup_rsp_fail_pdu(), - %% TODO: make sure that the E-RAB FSM has been terminated - - [?_assertEqual({reply, SetupRspExp}, s1ap_proxy:process_pdu(Pid, SetupReqIn))]. + [?_assertEqual({reply, SetupRspExp}, s1ap_proxy:process_pdu(Pid, SetupReqIn)), + ?_assertEqual([], s1ap_proxy:fetch_erab_list(Pid))]. test_e_rab_release_cmd(#{handler := Pid}) -> @@ -94,12 +95,12 @@ %% [eNB -> MME] E-RAB RELEASE RESPONSE ReleaseRsp = e_rab_release_rsp_pdu(), - %% TODO: make sure that the E-RAB FSM has been terminated - [?_assertMatch({forward, _}, s1ap_proxy:process_pdu(Pid, SetupReq)), ?_assertMatch({forward, _}, s1ap_proxy:process_pdu(Pid, SetupRsp)), + ?_assertMatch([_], s1ap_proxy:fetch_erab_list(Pid)), ?_assertEqual({forward, ReleaseCmd}, s1ap_proxy:process_pdu(Pid, ReleaseCmd)), - ?_assertEqual({forward, ReleaseRsp}, s1ap_proxy:process_pdu(Pid, ReleaseRsp))]. + ?_assertEqual({forward, ReleaseRsp}, s1ap_proxy:process_pdu(Pid, ReleaseRsp)), + ?_assertEqual([], s1ap_proxy:fetch_erab_list(Pid))]. test_e_rab_release_ind(#{handler := Pid}) -> @@ -111,6 +112,7 @@ ReleaseInd = e_rab_release_ind_pdu(), %% TODO: make sure that the E-RAB FSM has been terminated + %% FIXME: erab_fsm does not tear down immediately, but after a timeout [?_assertMatch({forward, _}, s1ap_proxy:process_pdu(Pid, SetupReq)), ?_assertMatch({forward, _}, s1ap_proxy:process_pdu(Pid, SetupRsp)), @@ -135,7 +137,8 @@ InitCtxSetupRspExp = initial_context_setup_rsp_pdu(?ADDR_C2U, ?TEID_C2U), [?_assertEqual({forward, InitCtxSetupReqExp}, s1ap_proxy:process_pdu(Pid, InitCtxSetupReqIn)), - ?_assertEqual({forward, InitCtxSetupRspExp}, s1ap_proxy:process_pdu(Pid, InitCtxSetupRspIn))]. + ?_assertEqual({forward, InitCtxSetupRspExp}, s1ap_proxy:process_pdu(Pid, InitCtxSetupRspIn)), + ?_assertMatch([_], s1ap_proxy:fetch_erab_list(Pid))]. %% ------------------------------------------------------------------ -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38684?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I43dcfa613a4ee0de5b2f6619911fd92b1675acd6 Gerrit-Change-Number: 38684 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[L] Change in ...osmo-s1gw[master]: s1ap_proxy: turn this module into a gen_server

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38683?usp=email ) Change subject: s1ap_proxy: turn this module into a gen_server ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38683?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Id6e4c7ee29ae31edca658e1293601d38e5f43e63 Gerrit-Change-Number: 38683 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 12:55:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[S] Change in ...osmo-s1gw[master]: s1ap_proxy: add E-RAB introspection API

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38684?usp=email ) Change subject: s1ap_proxy: add E-RAB introspection API ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38684?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I43dcfa613a4ee0de5b2f6619911fd92b1675acd6 Gerrit-Change-Number: 38684 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 12:55:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[S] Change in ...pyosmocom[master]: Fixing 3-digit MNC PlmnAdapter encoding & decoding, and related tests.

by laforge

Attention is currently required from: JPM, dexter, fixeria. laforge has posted comments on this change by JPM. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email ) Change subject: Fixing 3-digit MNC PlmnAdapter encoding & decoding, and related tests. ...................................................................... Patch Set 5: Code-Review+1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/python/pyosmocom/+/38687/comment/c5fd01f3_3ad0… : PS1, Line 8: Adding test_plmn_adapter. > Commit summary should be one line followed by an empty line. I would remove this one. Done https://gerrit.osmocom.org/c/python/pyosmocom/+/38687/comment/edea6269_a362… : PS1, Line 10: Change-Id: I3811b227d629bd4e051a480c9622967e31f8a376 > Add `Related: pysim. […] Done -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I3811b227d629bd4e051a480c9622967e31f8a376 Gerrit-Change-Number: 38687 Gerrit-PatchSet: 5 Gerrit-Owner: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 12:54:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[XS] Change in pysim[master]: Fixing 3-digit MNC PLMN Encoding/Decoding tests expected values for E...

by laforge

Attention is currently required from: JPM, dexter, fixeria. laforge has posted comments on this change by JPM. ( https://gerrit.osmocom.org/c/pysim/+/38688?usp=email ) Change subject: Fixing 3-digit MNC PLMN Encoding/Decoding tests expected values for EF_OPL and EF_ePDGSelection. ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/pysim/+/38688/comment/7acee07f_89869c4c?usp=em… : PS1, Line 9: Change-Id: Ib2b586cb570dbe74a617c45c0fca276b08bb075e > Add `Related: pyosmocom. […] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38688?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib2b586cb570dbe74a617c45c0fca276b08bb075e Gerrit-Change-Number: 38688 Gerrit-PatchSet: 3 Gerrit-Owner: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 12:53:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[S] Change in ...pyosmocom[master]: Fixing 3-digit MNC PlmnAdapter encoding & decoding, and related tests.

by laforge

Attention is currently required from: JPM, dexter. laforge has posted comments on this change by JPM. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email ) Change subject: Fixing 3-digit MNC PlmnAdapter encoding & decoding, and related tests. ...................................................................... Patch Set 5: (1 comment) Patchset: PS1: > The failing tests are from project (pysim) using pyosmocom. Those test are wrong as 3GPP TS 24. […] Agreed; we can manually override the V+1 once the code review has reached 2. -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I3811b227d629bd4e051a480c9622967e31f8a376 Gerrit-Change-Number: 38687 Gerrit-PatchSet: 5 Gerrit-Owner: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 12:53:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca>

7 months, 2 weeks

1
0
0 0

[M] Change in libosmo-sigtran[master]: sigtran: Add API osmo_ss7_as_select_asp()

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38719?usp=email ) Change subject: sigtran: Add API osmo_ss7_as_select_asp() ...................................................................... sigtran: Add API osmo_ss7_as_select_asp() This API is required by osmo-bsc, since when in SCCPLite configuration, it needs to access the IPA conn of the AS towards the MSC in order to inject MGCP and CTRL protocols over the IPA multiplex. This API may need to be revisited (i.e. deprecated and a new one created) once we want to fully support loadshare, where message contents such as OPC,DPC,SLS need to be taken into account internally in libosmo-sigtran. That new version may well be kept private though, since the API here presented is good enough for osmo-bsc IPA multiplex injection. This is anyway kind of chicken-and-egg problem, because we want to have an API osmo-bsc can use in first place before moving the whole osmo_ss7_as struct as private so that we can modify it to implement proper AS loadsharing. Related: SYS#6602 Change-Id: I8b866b45ac4a24238c55171d25e11b9625e8f50c --- M TODO-RELEASE M include/osmocom/sigtran/osmo_ss7.h M src/osmo_ss7_as.c M src/xua_as_fsm.c 4 files changed, 91 insertions(+), 39 deletions(-) Approvals: laforge: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/TODO-RELEASE b/TODO-RELEASE index 261567c..08978d4 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -13,4 +13,4 @@ libosmo-sigtran Make private osmo_ss7_route libosmo-sigtran add API osmo_ss7_instance_get_id(), osmo_ss7_instance_get_name(), osmo_ss7_instance_get_pc_fmt(), osmo_ss7_instance_get_primary_pc(), osmo_ss7_get_sccp() libosmo-sigtran add API osmo_ss7_instances_llist_entry() -libosmo-sigtran add API osmo_ss7_as_get_asp_protocol() +libosmo-sigtran add API osmo_ss7_as_get_asp_protocol(), osmo_ss7_as_select_asp() diff --git a/include/osmocom/sigtran/osmo_ss7.h b/include/osmocom/sigtran/osmo_ss7.h index 83956d8..361e715 100644 --- a/include/osmocom/sigtran/osmo_ss7.h +++ b/include/osmocom/sigtran/osmo_ss7.h @@ -274,6 +274,7 @@ void osmo_ss7_as_destroy(struct osmo_ss7_as *as); bool osmo_ss7_as_has_asp(const struct osmo_ss7_as *as, const struct osmo_ss7_asp *asp); +struct osmo_ss7_asp *osmo_ss7_as_select_asp(struct osmo_ss7_as *as); bool osmo_ss7_as_down(const struct osmo_ss7_as *as); bool osmo_ss7_as_active(const struct osmo_ss7_as *as); bool osmo_ss7_as_tmode_compatible_xua(struct osmo_ss7_as *as, uint32_t m3ua_tmt); diff --git a/src/osmo_ss7_as.c b/src/osmo_ss7_as.c index 5af7098..9451f2d 100644 --- a/src/osmo_ss7_as.c +++ b/src/osmo_ss7_as.c @@ -222,3 +222,88 @@ return true; return as->fi->state == XUA_AS_S_DOWN; } + +static struct osmo_ss7_asp *ss7_as_select_asp_override(struct osmo_ss7_as *as) +{ + struct osmo_ss7_asp *asp; + unsigned int i; + + /* FIXME: proper selection of the ASP based on the SLS! */ + for (i = 0; i < ARRAY_SIZE(as->cfg.asps); i++) { + asp = as->cfg.asps[i]; + if (asp && osmo_ss7_asp_active(asp)) + break; + } + return asp; +} + +static struct osmo_ss7_asp *ss7_as_select_asp_roundrobin(struct osmo_ss7_as *as) +{ + struct osmo_ss7_asp *asp; + unsigned int i; + unsigned int first_idx; + + first_idx = (as->cfg.last_asp_idx_sent + 1) % ARRAY_SIZE(as->cfg.asps); + i = first_idx; + do { + asp = as->cfg.asps[i]; + if (asp && osmo_ss7_asp_active(asp)) + break; + i = (i + 1) % ARRAY_SIZE(as->cfg.asps); + } while (i != first_idx); + as->cfg.last_asp_idx_sent = i; + + return asp; +} + +/* returns NULL if multiple ASPs would need to be selected. */ +static struct osmo_ss7_asp *ss7_as_select_asp_broadcast(struct osmo_ss7_as *as) +{ + struct osmo_ss7_asp *asp; + struct osmo_ss7_asp *asp_found = NULL; + + for (unsigned int i = 0; i < ARRAY_SIZE(as->cfg.asps); i++) { + asp = as->cfg.asps[i]; + if (!asp || !osmo_ss7_asp_active(asp)) + continue; + if (asp_found) /* >1 ASPs selected, early return */ + return NULL; + asp_found = asp; + } + return asp_found; +} + +/*! Select an AS to transmit a message, according to AS configuration and ASP availability. + * \param[in] as Application Server. + * \returns asp to send the message to, NULL if no possible asp found + * + * This function returns NULL too if multiple ASPs would be selected, ie. AS is + * configured in broadcast mode and more than one ASP is configured. + */ +struct osmo_ss7_asp *osmo_ss7_as_select_asp(struct osmo_ss7_as *as) +{ + struct osmo_ss7_asp *asp = NULL; + + switch (as->cfg.mode) { + case OSMO_SS7_AS_TMOD_OVERRIDE: + asp = ss7_as_select_asp_override(as); + break; + case OSMO_SS7_AS_TMOD_LOADSHARE: + /* TODO: actually use the SLS value to ensure same SLS goes + * through same ASP. Not strictly required by M3UA RFC, but + * would fit the overall principle. */ + case OSMO_SS7_AS_TMOD_ROUNDROBIN: + asp = ss7_as_select_asp_roundrobin(as); + break; + case OSMO_SS7_AS_TMOD_BCAST: + return ss7_as_select_asp_broadcast(as); + case _NUM_OSMO_SS7_ASP_TMOD: + OSMO_ASSERT(false); + } + + if (!asp) { + LOGPFSM(as->fi, "No selectable ASP in AS\n"); + return NULL; + } + return asp; +} diff --git a/src/xua_as_fsm.c b/src/xua_as_fsm.c index dff0d06..29d31a9 100644 --- a/src/xua_as_fsm.c +++ b/src/xua_as_fsm.c @@ -97,39 +97,6 @@ return -1; } -static struct osmo_ss7_asp *xua_as_select_asp_override(struct osmo_ss7_as *as) -{ - struct osmo_ss7_asp *asp; - unsigned int i; - - /* FIXME: proper selection of the ASP based on the SLS! */ - for (i = 0; i < ARRAY_SIZE(as->cfg.asps); i++) { - asp = as->cfg.asps[i]; - if (asp && osmo_ss7_asp_active(asp)) - break; - } - return asp; -} - -static struct osmo_ss7_asp *xua_as_select_asp_roundrobin(struct osmo_ss7_as *as) -{ - struct osmo_ss7_asp *asp; - unsigned int i; - unsigned int first_idx; - - first_idx = (as->cfg.last_asp_idx_sent + 1) % ARRAY_SIZE(as->cfg.asps); - i = first_idx; - do { - asp = as->cfg.asps[i]; - if (asp && osmo_ss7_asp_active(asp)) - break; - i = (i + 1) % ARRAY_SIZE(as->cfg.asps); - } while (i != first_idx); - as->cfg.last_asp_idx_sent = i; - - return asp; -} - int xua_as_transmit_msg_broadcast(struct osmo_ss7_as *as, struct msgb *msg) { struct osmo_ss7_asp *asp; @@ -157,13 +124,12 @@ switch (as->cfg.mode) { case OSMO_SS7_AS_TMOD_OVERRIDE: - asp = xua_as_select_asp_override(as); - break; case OSMO_SS7_AS_TMOD_LOADSHARE: - /* TODO: actually use the SLS value to ensure same SLS goes through same ASP. Not - * strictly required by M3UA RFC, but would fit the overall principle. */ + /* TODO: OSMO_SS7_AS_TMOD_LOADSHARE: actually use the SLS value + * to ensure same SLS goes through same ASP. Not strictly + * required by M3UA RFC, but would fit the overall principle. */ case OSMO_SS7_AS_TMOD_ROUNDROBIN: - asp = xua_as_select_asp_roundrobin(as); + asp = osmo_ss7_as_select_asp(as); break; case OSMO_SS7_AS_TMOD_BCAST: return xua_as_transmit_msg_broadcast(as, msg); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38719?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8b866b45ac4a24238c55171d25e11b9625e8f50c Gerrit-Change-Number: 38719 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[M] Change in libosmo-sigtran[master]: sigtran: Add API osmo_ss7_as_select_asp()

by laforge

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38719?usp=email ) Change subject: sigtran: Add API osmo_ss7_as_select_asp() ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38719?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8b866b45ac4a24238c55171d25e11b9625e8f50c Gerrit-Change-Number: 38719 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 12:50:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024