November 2024 - gerrit-log - lists.osmocom.org

[S] Change in ...pyosmocom[master]: Fixing 3-digit MNC PlmnAdapter encoding & decoding, and related tests.

by fixeria

Attention is currently required from: JPM, dexter. fixeria has posted comments on this change by JPM. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email ) Change subject: Fixing 3-digit MNC PlmnAdapter encoding & decoding, and related tests. ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I3811b227d629bd4e051a480c9622967e31f8a376 Gerrit-Change-Number: 38687 Gerrit-PatchSet: 5 Gerrit-Owner: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 13:19:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[XS] Change in pysim[master]: Fixing 3-digit MNC PLMN Encoding/Decoding tests expected values for E...

by fixeria

Attention is currently required from: JPM, dexter. fixeria has posted comments on this change by JPM. ( https://gerrit.osmocom.org/c/pysim/+/38688?usp=email ) Change subject: Fixing 3-digit MNC PLMN Encoding/Decoding tests expected values for EF_OPL and EF_ePDGSelection. ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38688?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib2b586cb570dbe74a617c45c0fca276b08bb075e Gerrit-Change-Number: 38688 Gerrit-PatchSet: 3 Gerrit-Owner: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 13:18:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[M] Change in libosmo-sigtran[master]: sigtran: Make osmo_ss7_user struct private

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38640?usp=email ) Change subject: sigtran: Make osmo_ss7_user struct private ...................................................................... Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38640?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I59d8f70aa81ba396159af40ffd7e8cc6c27cb864 Gerrit-Change-Number: 38640 Gerrit-PatchSet: 10 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 13:15:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[M] Change in libosmo-sigtran[master]: sigtran: Add public APIs to manage struct osmo_ss7_user

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38727?usp=email ) Change subject: sigtran: Add public APIs to manage struct osmo_ss7_user ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38727?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I81b424239e9f7d4dc84bf167053f784ad2e8ca49 Gerrit-Change-Number: 38727 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 13:14:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[XS] Change in upf-benchmark[master]: testsuites: Document manual route setup required

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/upf-benchmark/+/38732?usp=email ) Change subject: testsuites: Document manual route setup required ...................................................................... testsuites: Document manual route setup required Change-Id: Ia946c65d9de3af00c438f0178acd0e644fe95b5e --- M testsuites/gtplab-sysmo2017/tunend/upf/osmo-upf/run.sh 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/upf-benchmark refs/changes/32/38732/1 diff --git a/testsuites/gtplab-sysmo2017/tunend/upf/osmo-upf/run.sh b/testsuites/gtplab-sysmo2017/tunend/upf/osmo-upf/run.sh index 41f4616..a4951e9 100755 --- a/testsuites/gtplab-sysmo2017/tunend/upf/osmo-upf/run.sh +++ b/testsuites/gtplab-sysmo2017/tunend/upf/osmo-upf/run.sh @@ -3,3 +3,7 @@ SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd ) sudo osmo-upf -c "$SCRIPT_DIR/osmo-upf.cfg" + +# TODO: Route needs to be set up manually on the tun iface once it becomes created, since osmo-upf is not yet doing it (OS#6585). +# For now, run this manually after starting osmo-upf with the current run.sh script: +# ip route add 192.168.0.0/16 dev apn-flood -- To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/38732?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: upf-benchmark Gerrit-Branch: master Gerrit-Change-Id: Ia946c65d9de3af00c438f0178acd0e644fe95b5e Gerrit-Change-Number: 38732 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: Use new libosmo-sigtran API osmo_ss7_as_select_asp()

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38722?usp=email ) Change subject: Use new libosmo-sigtran API osmo_ss7_as_select_asp() ...................................................................... Use new libosmo-sigtran API osmo_ss7_as_select_asp() Depends: libosmo-sigtran.git Change-Id b9f6b542bbae925e23ca7c4de27cdff59021ccb9 Change-Id: I0f2e3d6cbdf443c0194b61df7479aecf4073e19c --- M src/osmo-bsc/bsc_ctrl.c 1 file changed, 8 insertions(+), 18 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved pespin: Looks good to me, approved; Verified diff --git a/src/osmo-bsc/bsc_ctrl.c b/src/osmo-bsc/bsc_ctrl.c index ff917ce..931a8ae 100644 --- a/src/osmo-bsc/bsc_ctrl.c +++ b/src/osmo-bsc/bsc_ctrl.c @@ -643,26 +643,10 @@ return as; } -static int _ss7_as_send(struct osmo_ss7_as *as, struct msgb *msg) -{ - struct osmo_ss7_asp *asp; - unsigned int i; - - /* FIXME: unify with xua_as_transmit_msg() and perform proper ASP lookup */ - for (i = 0; i < ARRAY_SIZE(as->cfg.asps); i++) { - asp = as->cfg.asps[i]; - if (!asp) - continue; - /* FIXME: deal with multiple ASPs per AS */ - return osmo_ss7_asp_send(asp, msg); - } - msgb_free(msg); - return -1; -} - int bsc_sccplite_msc_send(struct bsc_msc_data *msc, struct msgb *msg) { struct osmo_ss7_as *as; + struct osmo_ss7_asp *asp; as = msc_get_ss7_as(msc); if (!as) { @@ -676,7 +660,13 @@ return 0; } - return _ss7_as_send(as, msg); + asp = osmo_ss7_as_select_asp(as); + if (!asp) { + LOGP(DCTRL, LOGL_NOTICE, "No ASP found for AS, dropping message\n"); + msgb_free(msg); + return -1; + } + return osmo_ss7_asp_send(asp, msg); } /* Encode a CTRL command and send it to the given ASP -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38722?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0f2e3d6cbdf443c0194b61df7479aecf4073e19c Gerrit-Change-Number: 38722 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: Use new libosmo-sigtran API osmo_ss7_as_select_asp()

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38722?usp=email ) Change subject: Use new libosmo-sigtran API osmo_ss7_as_select_asp() ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38722?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0f2e3d6cbdf443c0194b61df7479aecf4073e19c Gerrit-Change-Number: 38722 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 13:01:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: Use new libosmo-sigtran API osmo_ss7_as_select_asp()

by pespin

pespin has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38722?usp=email ) Change subject: Use new libosmo-sigtran API osmo_ss7_as_select_asp() ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38722?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: deleteVote Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0f2e3d6cbdf443c0194b61df7479aecf4073e19c Gerrit-Change-Number: 38722 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: Use new libosmo-sigtran API osmo_ss7_as_select_asp()

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38722?usp=email ) Change subject: Use new libosmo-sigtran API osmo_ss7_as_select_asp() ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: debian10 and debian12 are failing because newest libosmo-sigtran is not built there yet. Merging now anyway. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38722?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0f2e3d6cbdf443c0194b61df7479aecf4073e19c Gerrit-Change-Number: 38722 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 13:01:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[S] Change in ...osmo-s1gw[master]: s1ap_proxy: merge process_pdu_safe() with process_pdu()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38681?usp=email ) Change subject: s1ap_proxy: merge process_pdu_safe() with process_pdu() ...................................................................... s1ap_proxy: merge process_pdu_safe() with process_pdu() We always use the _safe() variant, so it makes no sense to expose the "unsafe" variant as public API. Change-Id: I91092625ae577d17a1f96db79804c813b878abfc --- M src/s1ap_proxy.erl M src/sctp_proxy.erl 2 files changed, 4 insertions(+), 13 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/s1ap_proxy.erl b/src/s1ap_proxy.erl index 6ec3d10..17ae7d4 100644 --- a/src/s1ap_proxy.erl +++ b/src/s1ap_proxy.erl @@ -37,7 +37,6 @@ -export([init/0, deinit/1, process_pdu/2, - process_pdu_safe/2, handle_exit/2, encode_pdu/1, decode_pdu/1]). @@ -95,7 +94,7 @@ -spec process_pdu(binary(), proxy_state()) -> process_pdu_result(). process_pdu(OrigData, S0) -> s1gw_metrics:ctr_inc(?S1GW_CTR_S1AP_PROXY_IN_PKT_ALL), - case decode_pdu(OrigData) of + try decode_pdu(OrigData) of {ok, PDU} -> ?LOG_DEBUG("Rx S1AP PDU: ~p", [PDU]), case handle_pdu(PDU, S0) of @@ -121,20 +120,12 @@ s1gw_metrics:ctr_inc(?S1GW_CTR_S1AP_PROXY_IN_PKT_DECODE_ERROR), s1gw_metrics:ctr_inc(?S1GW_CTR_S1AP_PROXY_OUT_PKT_FWD_UNMODIFIED), {{forward, OrigData}, S0} %% XXX: forward as-is or drop? - end. - - -%% A safe wrapper for proc/2 --spec process_pdu_safe(binary(), proxy_state()) -> process_pdu_result(). -process_pdu_safe(OrigData, S) -> - try process_pdu(OrigData, S) of - Result -> Result catch Exception:Reason:StackTrace -> ?LOG_ERROR("An exception occurred: ~p, ~p, ~p", [Exception, Reason, StackTrace]), s1gw_metrics:ctr_inc(?S1GW_CTR_S1AP_PROXY_EXCEPTION), s1gw_metrics:ctr_inc(?S1GW_CTR_S1AP_PROXY_OUT_PKT_FWD_UNMODIFIED), - {{forward, OrigData}, S} %% XXX: proxy as-is or drop? + {{forward, OrigData}, S0} %% XXX: proxy as-is or drop? end. diff --git a/src/sctp_proxy.erl b/src/sctp_proxy.erl index 9bec272..d0bdf08 100644 --- a/src/sctp_proxy.erl +++ b/src/sctp_proxy.erl @@ -171,7 +171,7 @@ priv := Priv} = S) -> ?LOG_DEBUG("MME connection (id=~p, ~p:~p) -> eNB: ~p", [Aid, MmeAddr, MmePort, Data]), - {Action, NewPriv} = s1ap_proxy:process_pdu_safe(Data, Priv), + {Action, NewPriv} = s1ap_proxy:process_pdu(Data, Priv), case Action of {forward, FwdData} -> sctp_server:send_data(EnbAid, FwdData); @@ -230,7 +230,7 @@ enb_aid := EnbAid, mme_aid := Aid, priv := Priv} = S) -> - {Action, NewPriv} = s1ap_proxy:process_pdu_safe(Data, Priv), + {Action, NewPriv} = s1ap_proxy:process_pdu(Data, Priv), case Action of {forward, FwdData} -> ok = sctp_client:send_data({Sock, Aid}, FwdData); -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38681?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I91092625ae577d17a1f96db79804c813b878abfc Gerrit-Change-Number: 38681 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024