November 2024 - gerrit-log - lists.osmocom.org

[L] Change in pysim[master]: pySim/transport add support for T=1 protocol and fix APDU/TPDU layer ...

by dexter

Attention is currently required from: laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38657?usp=email ) Change subject: pySim/transport add support for T=1 protocol and fix APDU/TPDU layer conflicts ...................................................................... Patch Set 2: (2 comments) File pySim/transport/__init__.py: https://gerrit.osmocom.org/c/pysim/+/38657/comment/2193af2f_e7b49cf0?usp=em… : PS1, Line 243: cl > I find the use of multiple inheritance here a bit confusing. Can we not simply have […] Sure we can do that. Then let's have a LinkBase base class and a class LinkBaseTpdu that inherits from it. We inherit LinkBase directly in cases where the transport layer implementation works on APDU level. In cases where the transport layer implementation requires TPDUs, would inherit a class LinkBaseTpdu. https://gerrit.osmocom.org/c/pysim/+/38657/comment/9f95ca15_28441478?usp=em… : PS1, Line 320: __send_apdu_T1 > I'm not actually sure there is anything T=1 specific here. It is just sending an APDU. […] Yes, this is true, there is no T=1 specific stuff happening in the method. It just passes the APDUs as TPDUs transparently. we may call this method differently so that it is more generic. So should we add T15 support one day, we won't have to add a __send_apdu_T15 method which would be just a copy of __send_apdu_T1 then. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38657?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8b56d7804a2b4c392f43f8540e0b6e70001a8970 Gerrit-Change-Number: 38657 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 12 Nov 2024 15:26:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

7 months, 2 weeks

1
0
0 0

[L] Change in pysim[master]: pySim/transport add support for T=1 protocol and fix APDU/TPDU layer ...

by dexter

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/38657?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: pySim/transport add support for T=1 protocol and fix APDU/TPDU layer conflicts ...................................................................... pySim/transport add support for T=1 protocol and fix APDU/TPDU layer conflicts ETSI TS 102 221, section 7.3 specifies that UICCs (and eUICCs) may support two different transport protocols: T=0 or T=1 or both. The spec also says that the terminal must support both protocols. This patch adds the necessary functionality to support the T=1 protocol alongside the T=0 protocol. However, this also means that we have to sharpen the lines between APDUs and TPDUs. Change-Id: I8b56d7804a2b4c392f43f8540e0b6e70001a8970 --- M pySim-read.py M pySim-shell.py M pySim-trace.py M pySim/commands.py M pySim/euicc.py M pySim/global_platform/__init__.py M pySim/global_platform/scp.py M pySim/transport/__init__.py M pySim/transport/calypso.py M pySim/transport/modem_atcmd.py M pySim/transport/pcsc.py M pySim/transport/serial.py M pySim/utils.py A tests/pySim-shell_test/apdu/__init__.py A tests/pySim-shell_test/apdu/test.py A tests/pySim-shell_test/apdu/test_apdu.script A tests/pySim-shell_test/apdu/test_apdu_legacy.script A tests/pySim-shell_test/apdu/test_apdu_legacy_scp02.template A tests/pySim-shell_test/apdu/test_apdu_legacy_scp03.template A tests/pySim-shell_test/apdu/test_apdu_scp02.template A tests/pySim-shell_test/apdu/test_apdu_scp03.template M tests/pySim-shell_test/config.yaml M tests/pySim-shell_test/lchan/test.ok M tests/unittests/test_globalplatform.py M tests/unittests/test_utils.py 25 files changed, 604 insertions(+), 144 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/57/38657/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38657?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8b56d7804a2b4c392f43f8540e0b6e70001a8970 Gerrit-Change-Number: 38657 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

7 months, 2 weeks

1
0
0 0

[XS] Change in osmo-hnbgw[osmith/1.6.2]: Bump version: 1.6.1.2-8c49 → 1.6.2

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38737?usp=email ) Change subject: Bump version: 1.6.1.2-8c49 → 1.6.2 ...................................................................... Bump version: 1.6.1.2-8c49 → 1.6.2 Change-Id: Ib471306b4ff201f790c2a17a849da408ad62d6b5 --- M debian/changelog 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/37/38737/1 diff --git a/debian/changelog b/debian/changelog index 1e98786..33b9646 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +osmo-hnbgw (1.6.2) unstable; urgency=medium + + * Make compatible with private pfcp structs + * Make compatible with private sigtran structs + + -- Oliver Smith <osmith(a)sysmocom.de> Tue, 12 Nov 2024 15:43:49 +0100 + osmo-hnbgw (1.6.1) unstable; urgency=medium [ Neels Janosch Hofmeyr ] -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38737?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hnbgw Gerrit-Branch: osmith/1.6.2 Gerrit-Change-Id: Ib471306b4ff201f790c2a17a849da408ad62d6b5 Gerrit-Change-Number: 38737 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[M] Change in osmo-hnbgw[osmith/1.6.2]: Make compatible with private sigtran structs

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38736?usp=email ) Change subject: Make compatible with private sigtran structs ...................................................................... Make compatible with private sigtran structs Adjust OsmoHNBGW to build with newer versions of libosmo-sigtran, where several structs were made private. This is based on Pau's patch a3c0a005 ("Use new libosmo-sigtran APIs to access osmo_ss7_instance"). Related: OS#6617 Change-Id: I9e53953bc56fc5920eefb0a39dbf1e0b9843e00e --- M configure.ac M include/osmocom/hnbgw/hnbgw.h M src/osmo-hnbgw/context_map.c M src/osmo-hnbgw/hnbgw_cn.c 4 files changed, 68 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/36/38736/1 diff --git a/configure.ac b/configure.ac index ac1fc0f..8275ec9 100644 --- a/configure.ac +++ b/configure.ac @@ -233,6 +233,10 @@ [AC_DEFINE(PFCP_PRIVATE_STRUCTS, [1], ["OS#6617"])], [], [[#include <osmocom/pfcp/pfcp_cp_peer.h>]]) +AC_CHECK_DECL([osmo_ss7_instance_get_primary_pc], + [AC_DEFINE(SIGTRAN_PRIVATE_STRUCTS, [1], ["OS#6617"])], + [], + [[#include <osmocom/sigtran/osmo_ss7.h>]]) dnl Generate the output AM_CONFIG_HEADER(config.h) diff --git a/include/osmocom/hnbgw/hnbgw.h b/include/osmocom/hnbgw/hnbgw.h index caaff5f..48f4536 100644 --- a/include/osmocom/hnbgw/hnbgw.h +++ b/include/osmocom/hnbgw/hnbgw.h @@ -1,5 +1,8 @@ #pragma once +/* This is fine because hnbgw.h is in noinst_HEADERS in Makefile.am */ +#include "config.h" + #include <osmocom/core/select.h> #include <osmocom/core/linuxlist.h> #include <osmocom/core/hashtable.h> @@ -333,7 +336,11 @@ return NULL; if (!cnlink->hnbgw_sccp_user->ss7) return NULL; +#ifdef SIGTRAN_PRIVATE_STRUCTS + return osmo_ss7_get_sccp(cnlink->hnbgw_sccp_user->ss7); +#else return cnlink->hnbgw_sccp_user->ss7->sccp; +#endif } /* The lifecycle of the hnb_context object is the same as its conn */ diff --git a/src/osmo-hnbgw/context_map.c b/src/osmo-hnbgw/context_map.c index 08d6a39..8bfe844 100644 --- a/src/osmo-hnbgw/context_map.c +++ b/src/osmo-hnbgw/context_map.c @@ -111,7 +111,11 @@ return -EIO; } +#ifdef SIGTRAN_PRIVATE_STRUCTS + new_scu_conn_id = osmo_sccp_instance_next_conn_id(osmo_ss7_get_sccp(hsu->ss7)); +#else new_scu_conn_id = osmo_sccp_instance_next_conn_id(hsu->ss7->sccp); +#endif if (new_scu_conn_id < 0) { LOG_MAP(map, DCN, LOGL_ERROR, "Unable to allocate SCCP conn ID on %s\n", hsu->name); return new_scu_conn_id; diff --git a/src/osmo-hnbgw/hnbgw_cn.c b/src/osmo-hnbgw/hnbgw_cn.c index 7bfe526..259ca77 100644 --- a/src/osmo-hnbgw/hnbgw_cn.c +++ b/src/osmo-hnbgw/hnbgw_cn.c @@ -435,7 +435,11 @@ cnlink = hnbgw_cnlink_find_by_addr(hsu, calling_addr); if (!cnlink) { LOG_HSI(hsu, DRANAP, LOGL_ERROR, "Rx from unknown SCCP peer: %s: %s\n", +#ifdef SIGTRAN_PRIVATE_STRUCTS + osmo_sccp_inst_addr_name(osmo_ss7_get_sccp(hsu->ss7), calling_addr), +#else osmo_sccp_inst_addr_name(hsu->ss7->sccp, calling_addr), +#endif osmo_scu_prim_hdr_name_c(OTC_SELECT, oph)); return NULL; } @@ -795,7 +799,11 @@ { struct osmo_ss7_instance *ss7 = cnlink->hnbgw_sccp_user->ss7; LOG_CNLINK(cnlink, DCN, LOGL_NOTICE, "using: cs7-%u %s <-> %s %s %s\n", +#ifdef SIGTRAN_PRIVATE_STRUCTS + osmo_ss7_instance_get_id(ss7), +#else ss7->cfg.id, +#endif /* printing the entire SCCP address is quite long, rather just print the point-code */ osmo_ss7_pointcode_print(ss7, cnlink->hnbgw_sccp_user->local_addr.pc), osmo_ss7_pointcode_print2(ss7, cnlink->remote_addr.pc), @@ -841,7 +849,11 @@ } LOG_CNLINK(cnlink, DCN, LOGL_DEBUG, "remote-addr is '%s', using cs7 instance %u\n", +#ifdef SIGTRAN_PRIVATE_STRUCTS + cnlink->use.remote_addr_name, osmo_ss7_instance_get_id(ss7)); +#else cnlink->use.remote_addr_name, ss7->cfg.id); +#endif } else { /* If no address is configured, use the default remote CN address, according to legacy behavior. */ osmo_sccp_make_addr_pc_ssn(&cnlink->remote_addr, cnlink->pool->default_remote_pc, OSMO_SCCP_SSN_RANAP); @@ -861,35 +873,72 @@ continue; cnlink->hnbgw_sccp_user = hsu; LOG_CNLINK(cnlink, DCN, LOGL_DEBUG, "using existing SCCP instance %s on cs7 instance %u\n", +#ifdef SIGTRAN_PRIVATE_STRUCTS + hsu->name, osmo_ss7_instance_get_id(ss7)); +#else hsu->name, ss7->cfg.id); +#endif hnbgw_cnlink_log_self(cnlink); return 0; } /* else cnlink->hnbgw_sccp_user stays NULL and is set up below. */ +#ifdef SIGTRAN_PRIVATE_STRUCTS + LOG_CNLINK(cnlink, DCN, LOGL_DEBUG, "cs7 instance %u has no configured SCCP instance yet\n", osmo_ss7_instance_get_id(ss7)); +#else LOG_CNLINK(cnlink, DCN, LOGL_DEBUG, "cs7 instance %u has no configured SCCP instance yet\n", ss7->cfg.id); +#endif } /* No SCCP instance yet for this ss7. Create it. If no address name is given that resolves to a * particular cs7 instance above, use 'cs7 instance 0'. */ +#ifdef SIGTRAN_PRIVATE_STRUCTS + sccp = osmo_sccp_simple_client_on_ss7_id(g_hnbgw, + ss7 ? osmo_ss7_instance_get_id(ss7) : 0, + cnlink->name, + DEFAULT_PC_HNBGW, + OSMO_SS7_ASP_PROT_M3UA, + 0, + "localhost", + -1, + "localhost"); +#else sccp = osmo_sccp_simple_client_on_ss7_id(g_hnbgw, ss7 ? ss7->cfg.id : 0, cnlink->name, DEFAULT_PC_HNBGW, OSMO_SS7_ASP_PROT_M3UA, 0, "localhost", -1, "localhost"); +#endif if (!sccp) { LOG_CNLINK(cnlink, DCN, LOGL_ERROR, "Failed to configure SCCP on 'cs7 instance %u'\n", +#ifdef SIGTRAN_PRIVATE_STRUCTS + ss7 ? osmo_ss7_instance_get_id(ss7) : 0); +#else ss7 ? ss7->cfg.id : 0); +#endif return -1; } ss7 = osmo_sccp_get_ss7(sccp); +#ifdef SIGTRAN_PRIVATE_STRUCTS + LOG_CNLINK(cnlink, DCN, LOGL_NOTICE, "created SCCP instance on cs7 instance %u\n", osmo_ss7_instance_get_id(ss7)); +#else LOG_CNLINK(cnlink, DCN, LOGL_NOTICE, "created SCCP instance on cs7 instance %u\n", ss7->cfg.id); +#endif /* Bind the SCCP user, using the cs7 instance's default point-code if one is configured, or osmo-hnbgw's default * local PC. */ +#ifdef SIGTRAN_PRIVATE_STRUCTS + local_pc = osmo_ss7_instance_get_primary_pc(ss7); + if (!osmo_ss7_pc_is_valid(local_pc)) +#else if (osmo_ss7_pc_is_valid(ss7->cfg.primary_pc)) local_pc = ss7->cfg.primary_pc; else +#endif local_pc = DEFAULT_PC_HNBGW; LOG_CNLINK(cnlink, DCN, LOGL_DEBUG, "binding OsmoHNBGW user to cs7 instance %u, local PC %u = %s\n", +#ifdef SIGTRAN_PRIVATE_STRUCTS + osmo_ss7_instance_get_id(ss7), local_pc, osmo_ss7_pointcode_print(ss7, local_pc)); +#else ss7->cfg.id, local_pc, osmo_ss7_pointcode_print(ss7, local_pc)); +#endif sccp_user = osmo_sccp_user_bind_pc(sccp, "OsmoHNBGW", sccp_sap_up, OSMO_SCCP_SSN_RANAP, local_pc); if (!sccp_user) { @@ -899,7 +948,11 @@ hsu = talloc_zero(cnlink, struct hnbgw_sccp_user); *hsu = (struct hnbgw_sccp_user){ +#ifdef SIGTRAN_PRIVATE_STRUCTS + .name = talloc_asprintf(hsu, "cs7-%u.sccp", osmo_ss7_instance_get_id(ss7)), +#else .name = talloc_asprintf(hsu, "cs7-%u.sccp", ss7->cfg.id), +#endif .ss7 = ss7, .sccp_user = sccp_user, }; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38736?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hnbgw Gerrit-Branch: osmith/1.6.2 Gerrit-Change-Id: I9e53953bc56fc5920eefb0a39dbf1e0b9843e00e Gerrit-Change-Number: 38736 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-hnbgw[osmith/1.6.2]: Make compatible with private pfcp structs

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38735?usp=email ) Change subject: Make compatible with private pfcp structs ...................................................................... Make compatible with private pfcp structs Adjust OsmoHNBGW to build with newer versions of libosmo-pfcp, where osmo_pfcp_cp_peer was made private. This based on Pau's patch 1ac1d127 ("hnbgw: Avoid using struct osmo_pfcp_cp_peer fields directly"). Related: OS#6617 Change-Id: I188e76307deadd9328430afff54dc287eda51370 --- M configure.ac M src/osmo-hnbgw/context_map_sccp.c M src/osmo-hnbgw/ps_rab_fsm.c 3 files changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/35/38735/1 diff --git a/configure.ac b/configure.ac index b6f013e..ac1fc0f 100644 --- a/configure.ac +++ b/configure.ac @@ -228,6 +228,12 @@ AC_MSG_RESULT([CFLAGS="$CFLAGS"]) AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"]) +# OS#6617 +AC_CHECK_DECL([osmo_pfcp_cp_peer_next_seid], + [AC_DEFINE(PFCP_PRIVATE_STRUCTS, [1], ["OS#6617"])], + [], + [[#include <osmocom/pfcp/pfcp_cp_peer.h>]]) + dnl Generate the output AM_CONFIG_HEADER(config.h) diff --git a/src/osmo-hnbgw/context_map_sccp.c b/src/osmo-hnbgw/context_map_sccp.c index 511577c..a92b3d6 100644 --- a/src/osmo-hnbgw/context_map_sccp.c +++ b/src/osmo-hnbgw/context_map_sccp.c @@ -241,7 +241,11 @@ if (hnb_gw_is_gtp_mapping_enabled()) { LOGP(DMAIN, LOGL_DEBUG, "RAB Assignment: setting up GTP tunnel mapping via UPF %s\n", +#ifdef PFCP_PRIVATE_STRUCTS + osmo_sockaddr_to_str_c(OTC_SELECT, osmo_pfcp_cp_peer_get_remote_addr(g_hnbgw->pfcp.cp_peer))); +#else osmo_sockaddr_to_str_c(OTC_SELECT, &g_hnbgw->pfcp.cp_peer->remote_addr)); +#endif return hnbgw_gtpmap_rx_rab_ass_req(map, ranap_msg, message); } /* If no UPF is configured, directly forward the message as-is (no GTP mapping). */ diff --git a/src/osmo-hnbgw/ps_rab_fsm.c b/src/osmo-hnbgw/ps_rab_fsm.c index 8905540..bc85e2f 100644 --- a/src/osmo-hnbgw/ps_rab_fsm.c +++ b/src/osmo-hnbgw/ps_rab_fsm.c @@ -17,6 +17,8 @@ #include <errno.h> +#include "config.h" + #include <osmocom/core/tdef.h> #include <osmocom/pfcp/pfcp_endpoint.h> @@ -320,7 +322,11 @@ m->h.seid = 0; /* Make a new CP-SEID, our local reference for the PFCP session. */ +#ifdef PFCP_PRIVATE_STRUCTS + rab->cp_seid = osmo_pfcp_cp_peer_next_seid(g_hnbgw->pfcp.cp_peer); +#else rab->cp_seid = osmo_pfcp_next_seid(&g_hnbgw->pfcp.cp_peer->next_seid_state); +#endif cp_f_seid = (struct osmo_pfcp_ie_f_seid){ .seid = rab->cp_seid, }; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38735?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hnbgw Gerrit-Branch: osmith/1.6.2 Gerrit-Change-Id: I188e76307deadd9328430afff54dc287eda51370 Gerrit-Change-Number: 38735 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-sgsn[master]: GTP: CreatePDPContext: only use IMEISV IE when IMEISV is known

by fixeria

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/38444?usp=email ) Change subject: GTP: CreatePDPContext: only use IMEISV IE when IMEISV is known ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/38444?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I812af1e702e77214244f32ae65663c1a03b23962 Gerrit-Change-Number: 38444 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 12 Nov 2024 13:52:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[XS] Change in osmo-msc[osmith/1.12.2]: Bump version: 1.12.1.1-38bf4 → 1.12.2

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/38734?usp=email ) Change subject: Bump version: 1.12.1.1-38bf4 → 1.12.2 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38734?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: osmith/1.12.2 Gerrit-Change-Id: I50a9f201563d5f708a67e14967ed15742fb58847 Gerrit-Change-Number: 38734 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 13:48:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-msc[osmith/1.12.2]: Make compatible with private sigtran structs

by laforge

Attention is currently required from: osmith, pespin. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/38733?usp=email ) Change subject: Make compatible with private sigtran structs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38733?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: osmith/1.12.2 Gerrit-Change-Id: I6c7d5119174de8d37d1ebe2b47793f9b89cc903c Gerrit-Change-Number: 38733 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 13:48:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[S] Change in libosmo-sigtran[master]: Move code to delete routes by as/linkset to helper functions

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38730?usp=email ) Change subject: Move code to delete routes by as/linkset to helper functions ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38730?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic36fd6a0466cc0338132f2e34eb7c916115c9d4a Gerrit-Change-Number: 38730 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 13:47:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[S] Change in libosmo-sigtran[master]: route_table: Split allocation code to its own function

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38729?usp=email ) Change subject: route_table: Split allocation code to its own function ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38729?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id081d6de14be84b05ed38f3f8211ba91e675cff0 Gerrit-Change-Number: 38729 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Nov 2024 13:47:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024