November 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-hlr[master]: change default reject cause to plmn-not-allowed

by falconia

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/38794?usp=email ) Change subject: change default reject cause to plmn-not-allowed ...................................................................... change default reject cause to plmn-not-allowed Unless the Osmocom-based network operator has very carefully considered what they are doing, returning MM/GMM reject cause #2 (IMSI unknown in HLR) to LU requests from bystander phones is a very bad idea. Here is what typically happens when someone sets up an Osmocom-based GSM network for development, testing or research, without roaming interconnection with any commercial operators: * Even when the private network operates its BTS at very low power levels, bystander phones in close proximity (e.g., in directly adjacent neighbor apartments or office suites) will receive a much stronger signal from the private/test network BTS than from any commercial operator, i.e., the private/test network will be the strongest signal. * Many phones will attempt to "jump ship" to this strongest signal even if it broadcasts a completely unknown PLMN ID that is not in the preferred operator list, and even when they were previously not roaming at all, registered to their most preferred home operator with perfectly good reception quality. * If these wayward phones receive reject cause #2 in response to their LU attempt, the spec effectively requires them to go into a "black hole" where they no longer attempt to register to any operator, including their own legitimate one. Returning reject cause #11 instead (PLMN not allowed) solves this problem: wayward phones that erroneously attempted to register to the private/test network go back to their own legitimate commercial operator, and everyone is happy. This bug should be considered critical: when the reject cause is set to #2 by default, any private Osmocom-based network, no matter how low-power, will effectively cause service disruption to all nearby commercially-served phones even when there is no clash in terms of used radio frequencies. Change-Id: Icff1d19670c398b119ec68b1d5f0fad87b605702 --- M src/hlr.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/94/38794/1 diff --git a/src/hlr.c b/src/hlr.c index 6f444aa..3d020d6 100644 --- a/src/hlr.c +++ b/src/hlr.c @@ -779,7 +779,7 @@ g_hlr->db_file_path = talloc_strdup(g_hlr, HLR_DEFAULT_DB_FILE_PATH); g_hlr->mslookup.server.mdns.domain_suffix = talloc_strdup(g_hlr, OSMO_MDNS_DOMAIN_SUFFIX_DEFAULT); g_hlr->mslookup.client.mdns.domain_suffix = talloc_strdup(g_hlr, OSMO_MDNS_DOMAIN_SUFFIX_DEFAULT); - g_hlr->reject_cause = GMM_CAUSE_IMSI_UNKNOWN; + g_hlr->reject_cause = GMM_CAUSE_PLMN_NOTALLOWED; g_hlr->no_proxy_reject_cause = GMM_CAUSE_IMSI_UNKNOWN; /* Init default (call independent) SS session guard timeout value */ -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/38794?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Icff1d19670c398b119ec68b1d5f0fad87b605702 Gerrit-Change-Number: 38794 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org>

7 months, 1 week

1
0
0 0

[S] Change in ...osmo-s1gw[master]: s1ap_proxy: properly handle E-RAB RELEASE IND

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38767?usp=email ) Change subject: s1ap_proxy: properly handle E-RAB RELEASE IND ...................................................................... s1ap_proxy: properly handle E-RAB RELEASE IND Use the right release kind in the case of E-RAB RELEASE IND, so that the E-RAB FSM can be terminated immediately. Change-Id: Id1b77ef59818d6416326477a25e9866ab636b3ad --- M src/s1ap_proxy.erl M test/s1ap_proxy_test.erl 2 files changed, 9 insertions(+), 8 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/s1ap_proxy.erl b/src/s1ap_proxy.erl index 5f7775e..ec729d0 100644 --- a/src/s1ap_proxy.erl +++ b/src/s1ap_proxy.erl @@ -70,7 +70,8 @@ -record(proxy_state, {erabs :: dict:dict(), mme_ue_id :: undefined | mme_ue_id(), - enb_ue_id :: undefined | enb_ue_id() + enb_ue_id :: undefined | enb_ue_id(), + rel_kind :: undefined | cmd | ind }). -type proxy_state() :: #proxy_state{}. @@ -274,7 +275,8 @@ ?LOG_DEBUG("Processing E-RAB RELEASE COMMAND"), s1gw_metrics:ctr_inc(?S1GW_CTR_S1AP_PROXY_IN_PKT_ERAB_RELEASE_CMD), case handle_ies(C0#'E-RABReleaseCommand'.protocolIEs, - ?'id-E-RABToBeReleasedList', S0) of + ?'id-E-RABToBeReleasedList', + S0#proxy_state{rel_kind = cmd}) of {{ok, IEs}, S1} -> C1 = C0#'E-RABReleaseCommand'{protocolIEs = IEs}, PDU = {Outcome, Msg#'InitiatingMessage'{value = C1}}, @@ -310,7 +312,8 @@ ?LOG_DEBUG("Processing E-RAB RELEASE INDICATION"), s1gw_metrics:ctr_inc(?S1GW_CTR_S1AP_PROXY_IN_PKT_ERAB_RELEASE_IND), case handle_ies(C0#'E-RABReleaseIndication'.protocolIEs, - ?'id-E-RABReleasedList', S0) of + ?'id-E-RABReleasedList', + S0#proxy_state{rel_kind = ind}) of {{ok, IEs}, S1} -> C1 = C0#'E-RABReleaseIndication'{protocolIEs = IEs}, PDU = {Outcome, Msg#'InitiatingMessage'{value = C1}}, @@ -451,7 +454,7 @@ #'E-RABItem'{'e-RAB-ID' = ERABId} = C, case erab_fsm_find(ERABId, S) of {ok, Pid} -> - ok = erab_fsm:erab_release_cmd(Pid), + ok = erab_fsm:erab_release(Pid, S#proxy_state.rel_kind), {{ok, C}, S}; error -> ?LOG_ERROR("E-RAB ~p is not registered", [erab_uid(ERABId, S)]), diff --git a/test/s1ap_proxy_test.erl b/test/s1ap_proxy_test.erl index 9e94716..917b63e 100644 --- a/test/s1ap_proxy_test.erl +++ b/test/s1ap_proxy_test.erl @@ -111,12 +111,10 @@ %% [eNB -> MME] E-RAB RELEASE INDICATION ReleaseInd = e_rab_release_ind_pdu(), - %% TODO: make sure that the E-RAB FSM has been terminated - %% FIXME: erab_fsm does not tear down immediately, but after a timeout - [?_assertMatch({forward, _}, s1ap_proxy:process_pdu(Pid, SetupReq)), ?_assertMatch({forward, _}, s1ap_proxy:process_pdu(Pid, SetupRsp)), - ?_assertEqual({forward, ReleaseInd}, s1ap_proxy:process_pdu(Pid, ReleaseInd))]. + ?_assertEqual({forward, ReleaseInd}, s1ap_proxy:process_pdu(Pid, ReleaseInd)), + ?_assertEqual([], s1ap_proxy:fetch_erab_list(Pid))]. test_e_rab_modify_ind(#{handler := Pid}) -> -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38767?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Id1b77ef59818d6416326477a25e9866ab636b3ad Gerrit-Change-Number: 38767 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months, 1 week

1
0
0 0

[S] Change in ...osmo-s1gw[master]: erab_fsm: rename erab_release_req/1 -> erab_release_cmd/1

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38765?usp=email ) Change subject: erab_fsm: rename erab_release_req/1 -> erab_release_cmd/1 ...................................................................... erab_fsm: rename erab_release_req/1 -> erab_release_cmd/1 The respective S1AP PDU is COMMAND, not REQUEST. Change-Id: I2f19d2c9bad52b89327f68f7dc6a2f6347a00ba0 --- M src/erab_fsm.erl M src/s1ap_proxy.erl M test/erab_fsm_test.erl 3 files changed, 8 insertions(+), 8 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/erab_fsm.erl b/src/erab_fsm.erl index ae17a6e..585fc0a 100644 --- a/src/erab_fsm.erl +++ b/src/erab_fsm.erl @@ -49,7 +49,7 @@ -export([start_link/1, erab_setup_req/2, erab_setup_rsp/2, - erab_release_req/1, + erab_release_cmd/1, erab_release_rsp/1, shutdown/1]). @@ -120,8 +120,8 @@ gen_statem:call(Pid, {?FUNCTION_NAME, F_TEID}). --spec erab_release_req(pid()) -> ok. -erab_release_req(Pid) -> +-spec erab_release_cmd(pid()) -> ok. +erab_release_cmd(Pid) -> gen_statem:call(Pid, ?FUNCTION_NAME). @@ -286,9 +286,9 @@ {keep_state, S}; erab_setup({call, From}, - erab_release_req, + erab_release_cmd, #erab_state{} = S) -> - ?LOG_DEBUG("Rx E-RAB RELEASE Req"), + ?LOG_DEBUG("Rx E-RAB RELEASE Cmd"), {next_state, session_delete, S#erab_state{from = From}}; diff --git a/src/s1ap_proxy.erl b/src/s1ap_proxy.erl index ea20106..5f7775e 100644 --- a/src/s1ap_proxy.erl +++ b/src/s1ap_proxy.erl @@ -451,7 +451,7 @@ #'E-RABItem'{'e-RAB-ID' = ERABId} = C, case erab_fsm_find(ERABId, S) of {ok, Pid} -> - ok = erab_fsm:erab_release_req(Pid), + ok = erab_fsm:erab_release_cmd(Pid), {{ok, C}, S}; error -> ?LOG_ERROR("E-RAB ~p is not registered", [erab_uid(ERABId, S)]), diff --git a/test/erab_fsm_test.erl b/test/erab_fsm_test.erl index 1722b3c..e4b036e 100644 --- a/test/erab_fsm_test.erl +++ b/test/erab_fsm_test.erl @@ -94,7 +94,7 @@ test_erab_release_success(Pid) -> [?_assertEqual({ok, ?A2U}, erab_fsm:erab_setup_req(Pid, ?U2C)), ?_assertEqual({ok, ?C2U}, erab_fsm:erab_setup_rsp(Pid, ?U2A)), - ?_assertEqual(ok, erab_fsm:erab_release_req(Pid)), + ?_assertEqual(ok, erab_fsm:erab_release_cmd(Pid)), ?_assertEqual(ok, erab_fsm:erab_release_rsp(Pid)), ?_assertNot(erlang:is_process_alive(Pid))]. @@ -107,7 +107,7 @@ Error = {unexp_pdu, session_delete}, [?_assertEqual({ok, ?A2U}, erab_fsm:erab_setup_req(Pid, ?U2C)), ?_assertEqual({ok, ?C2U}, erab_fsm:erab_setup_rsp(Pid, ?U2A)), - ?_assertEqual({error, Error}, erab_fsm:erab_release_req(Pid)), + ?_assertEqual({error, Error}, erab_fsm:erab_release_cmd(Pid)), ?_assertNot(erlang:is_process_alive(Pid))]. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38765?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I2f19d2c9bad52b89327f68f7dc6a2f6347a00ba0 Gerrit-Change-Number: 38765 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months, 1 week

1
0
0 0

[M] Change in ...osmo-s1gw[master]: erab_fsm: add erab_release/2 and erab_release_ind/1

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38766?usp=email ) Change subject: erab_fsm: add erab_release/2 and erab_release_ind/1 ...................................................................... erab_fsm: add erab_release/2 and erab_release_ind/1 The E-RAB RELEASE INDICATION message is used by the eNB to indicate termination of one or several E-RAB(s). Unlike with the RELEASE COMMAND, there is no response to that message. Thus, we shall not wait for it (by entering state erab_wait_release_rsp) but terminate the E-RAB FSM immediately instead. Change-Id: Icc9c0f6a1aef327e9585942b3c9d2302feda393a --- M src/erab_fsm.erl M test/erab_fsm_test.erl 2 files changed, 51 insertions(+), 9 deletions(-) Approvals: pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/erab_fsm.erl b/src/erab_fsm.erl index 585fc0a..ae661a1 100644 --- a/src/erab_fsm.erl +++ b/src/erab_fsm.erl @@ -49,8 +49,10 @@ -export([start_link/1, erab_setup_req/2, erab_setup_rsp/2, + erab_release/2, erab_release_cmd/1, erab_release_rsp/1, + erab_release_ind/1, shutdown/1]). -include_lib("kernel/include/logger.hrl"). @@ -70,13 +72,16 @@ addr() %% GTP-U Transport Layer Address }. +-type rel_kind() :: cmd | ind. + -record(erab_state, {from :: undefined | gen_statem:from(), %% destination to use when replying u2c :: undefined | teid_addr(), %% GTP-U params for UPF -> Core c2u :: undefined | teid_addr(), %% GTP-U params for UPF <- Core a2u :: undefined | teid_addr(), %% GTP-U params for UPF <- Access u2a :: undefined | teid_addr(), %% GTP-U params for UPF -> Access seid_loc :: undefined | pfcp_peer:pfcp_seid(), %% local SEID, chosen by us - seid_rem :: undefined | pfcp_peer:pfcp_seid() %% remote SEID, chosen by the UPF + seid_rem :: undefined | pfcp_peer:pfcp_seid(), %% remote SEID, chosen by the UPF + rel_kind :: undefined | rel_kind() %% E-RAB RELEASE kind }). -type erab_state() :: #erab_state{}. @@ -120,6 +125,13 @@ gen_statem:call(Pid, {?FUNCTION_NAME, F_TEID}). +-spec erab_release(pid(), rel_kind()) -> ok. +erab_release(Pid, cmd) -> + erab_release_cmd(Pid); +erab_release(Pid, ind) -> + erab_release_ind(Pid). + + -spec erab_release_cmd(pid()) -> ok. erab_release_cmd(Pid) -> gen_statem:call(Pid, ?FUNCTION_NAME). @@ -130,6 +142,11 @@ gen_statem:cast(Pid, ?FUNCTION_NAME). +-spec erab_release_ind(pid()) -> ok. +erab_release_ind(Pid) -> + gen_statem:call(Pid, ?FUNCTION_NAME). + + -spec shutdown(pid()) -> ok. shutdown(Pid) -> gen_statem:stop(Pid). @@ -290,7 +307,16 @@ #erab_state{} = S) -> ?LOG_DEBUG("Rx E-RAB RELEASE Cmd"), {next_state, session_delete, - S#erab_state{from = From}}; + S#erab_state{from = From, + rel_kind = cmd}}; + +erab_setup({call, From}, + erab_release_ind, + #erab_state{} = S) -> + ?LOG_DEBUG("Rx E-RAB RELEASE Ind"), + {next_state, session_delete, + S#erab_state{from = From, + rel_kind = ind}}; %% Catch-all handler for this state erab_setup(Event, EventData, S) -> @@ -317,15 +343,22 @@ session_delete(info, #pfcp{} = PDU, #erab_state{from = From, - seid_loc = SEID_Rsp} = S) -> + seid_loc = SEID_Rsp, + rel_kind = RelKind} = S) -> case PDU of #pfcp{type = session_deletion_response, seid = SEID_Rsp, %% matches F-SEID we sent in the ESTABLISH Req ie = #{pfcp_cause := 'Request accepted'}} -> ?LOG_DEBUG("PFCP session deleted"), - {next_state, erab_wait_release_rsp, - S#erab_state{from = undefined}, - [{reply, From, ok}]}; + Reply = {reply, From, ok}, + case RelKind of + cmd -> %% E-RAB RELEASE CMD => wait for the RSP + {next_state, erab_wait_release_rsp, + S#erab_state{from = undefined}, + [Reply]}; + ind -> %% E-RAB RELEASE IND => terminate immediately + {stop_and_reply, normal, [Reply]} + end; _ -> ?LOG_ERROR("Rx unexpected PFCP PDU: ~p", [PDU]), {stop_and_reply, diff --git a/test/erab_fsm_test.erl b/test/erab_fsm_test.erl index e4b036e..0bd6b8b 100644 --- a/test/erab_fsm_test.erl +++ b/test/erab_fsm_test.erl @@ -44,8 +44,10 @@ erab_release_test_() -> - [{"E-RAB release :: success", - ?TC(fun test_erab_release_success/1)}, + [{"E-RAB RELEASE CMD :: success", + ?TC(fun test_erab_release_cmd_success/1)}, + {"E-RAB RELEASE IND :: success", + ?TC(fun test_erab_release_ind_success/1)}, {"E-RAB release :: PFCP session deletion error", ?TC(fun test_erab_release_pfcp_delete_error/1)}]. @@ -91,7 +93,7 @@ ?_assertNot(erlang:is_process_alive(Pid))]. -test_erab_release_success(Pid) -> +test_erab_release_cmd_success(Pid) -> [?_assertEqual({ok, ?A2U}, erab_fsm:erab_setup_req(Pid, ?U2C)), ?_assertEqual({ok, ?C2U}, erab_fsm:erab_setup_rsp(Pid, ?U2A)), ?_assertEqual(ok, erab_fsm:erab_release_cmd(Pid)), @@ -99,6 +101,13 @@ ?_assertNot(erlang:is_process_alive(Pid))]. +test_erab_release_ind_success(Pid) -> + [?_assertEqual({ok, ?A2U}, erab_fsm:erab_setup_req(Pid, ?U2C)), + ?_assertEqual({ok, ?C2U}, erab_fsm:erab_setup_rsp(Pid, ?U2A)), + ?_assertEqual(ok, erab_fsm:erab_release_ind(Pid)), + ?_assertNot(erlang:is_process_alive(Pid))]. + + test_erab_release_pfcp_delete_error(Pid) -> %% pfcp_peer:session_delete_req/1 responds with a reject PDU = pfcp_mock:pdu_rsp_reject(session_deletion_response, ?SEID_Loc), -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38766?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Icc9c0f6a1aef327e9585942b3c9d2302feda393a Gerrit-Change-Number: 38766 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months, 1 week

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: sctp_server: cosmetic: use ?FUNCTION_NAME in send_data/2

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38785?usp=email ) Change subject: sctp_server: cosmetic: use ?FUNCTION_NAME in send_data/2 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38785?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ifd646ba1383840f656df5a798299a5ed116731ae Gerrit-Change-Number: 38785 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 17 Nov 2024 17:33:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

[S] Change in ...osmo-s1gw[master]: sctp_server: add type hints

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38784?usp=email ) Change subject: sctp_server: add type hints ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38784?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I0ddeccb81c52f1769fa0754c5628b53b1c9feb81 Gerrit-Change-Number: 38784 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 17 Nov 2024 17:32:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

[S] Change in ...osmo-s1gw[master]: erab_fsm: add all-state event handler

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38780?usp=email ) Change subject: erab_fsm: add all-state event handler ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38780?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I2673f18ddee0f1eee27bb0ed71ca9073d6dea3f2 Gerrit-Change-Number: 38780 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 17 Nov 2024 17:32:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

[S] Change in ...osmo-s1gw[master]: s1ap_proxy: properly handle E-RAB RELEASE IND

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38767?usp=email ) Change subject: s1ap_proxy: properly handle E-RAB RELEASE IND ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38767?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Id1b77ef59818d6416326477a25e9866ab636b3ad Gerrit-Change-Number: 38767 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 17 Nov 2024 17:31:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

[M] Change in ...osmo-s1gw[master]: erab_fsm: add erab_release/2 and erab_release_ind/1

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38766?usp=email ) Change subject: erab_fsm: add erab_release/2 and erab_release_ind/1 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38766?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Icc9c0f6a1aef327e9585942b3c9d2302feda393a Gerrit-Change-Number: 38766 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 17 Nov 2024 17:30:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

[S] Change in ...osmo-s1gw[master]: erab_fsm: rename erab_release_req/1 -> erab_release_cmd/1

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38765?usp=email ) Change subject: erab_fsm: rename erab_release_req/1 -> erab_release_cmd/1 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38765?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I2f19d2c9bad52b89327f68f7dc6a2f6347a00ba0 Gerrit-Change-Number: 38765 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 17 Nov 2024 17:30:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024