November 2024 - gerrit-log - lists.osmocom.org

[XS] Change in libosmo-abis[master]: ipaccess: Fix wrong pointer passed in sign_link_up user callback

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38805?usp=email ) Change subject: ipaccess: Fix wrong pointer passed in sign_link_up user callback ...................................................................... ipaccess: Fix wrong pointer passed in sign_link_up user callback This bug was introduced in Jun 2011, 13 years ago, so probably this code path is not (usually) used at all. The commit introducing the regression changed sign_link_up() first param from msgb to struct ipaccess_unit, but compiler didn't catch it because it's being passed as a void pointer. Fixes: c9c4fd39055ab02c0af59d5519e62edc456e3d0b Change-Id: I8e514360d5ed1c311af97f8fa728a2ff0a027522 --- M src/input/ipaccess.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/05/38805/1 diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index da2f04d..f89db15 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -955,9 +955,9 @@ if (ret == 1 && hh->proto == IPAC_PROTO_IPACCESS) { if (msg_type == IPAC_MSGT_ID_GET) { - sign_link = link->line->ops->sign_link_up(msg, - link->line, - link->ofd->priv_nr); + sign_link = link->line->ops->sign_link_up(link->line->ops->cfg.ipa.dev, + link->line, + link->ofd->priv_nr); if (sign_link == NULL) { LOGP(DLINP, LOGL_ERROR, "Unable to set signal link, " -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38805?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I8e514360d5ed1c311af97f8fa728a2ff0a027522 Gerrit-Change-Number: 38805 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 1 week

1
0
0 0

[XS] Change in libosmocore[master]: cosmetic: ipa: fix typo in documentation

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/38804?usp=email ) Change subject: cosmetic: ipa: fix typo in documentation ...................................................................... cosmetic: ipa: fix typo in documentation Change-Id: I6da9516ebc5df41205326843a1d7c56fce01618a --- M src/gsm/ipa.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/04/38804/1 diff --git a/src/gsm/ipa.c b/src/gsm/ipa.c index 6e41fd9..963f97d 100644 --- a/src/gsm/ipa.c +++ b/src/gsm/ipa.c @@ -404,7 +404,7 @@ return msg; } -/*! Generate IPA CCM ID RESP based on requets payload +/*! Generate IPA CCM ID RESP based on request payload * \param[in] dev Descriptor describing identity data for response * \param[in] data Payload of the IPA CCM ID GET request * \param[in] len Length of \a data in octets -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38804?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6da9516ebc5df41205326843a1d7c56fce01618a Gerrit-Change-Number: 38804 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 1 week

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: testenv: install dbg pkgs with --binary-repo too

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38803?usp=email ) Change subject: testenv: install dbg pkgs with --binary-repo too ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38803?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4dc57257b944126fed2c7b031c92c77a3d4286e0 Gerrit-Change-Number: 38803 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Nov 2024 13:41:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: testenv: install dbg pkgs with --binary-repo too

by osmith

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38803?usp=email ) Change subject: testenv: install dbg pkgs with --binary-repo too ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38803?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4dc57257b944126fed2c7b031c92c77a3d4286e0 Gerrit-Change-Number: 38803 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 18 Nov 2024 13:36:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

7 months, 1 week

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: testenv: install dbg pkgs with --binary-repo too

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38803?usp=email ) Change subject: testenv: install dbg pkgs with --binary-repo too ...................................................................... testenv: install dbg pkgs with --binary-repo too When using --binary-repo, figure out the -dbg and -dbgsym packages for all dependencies of packages to be installed, and install them as well. This will make debug symbols available in jenkins, useful for the related issue. Before this patch debug symbols were only available when building locally without --binary-repo. Related: OS#6630 Change-Id: I4dc57257b944126fed2c7b031c92c77a3d4286e0 --- M _testenv/data/podman/Dockerfile M _testenv/testenv/podman_install.py 2 files changed, 58 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/03/38803/1 diff --git a/_testenv/data/podman/Dockerfile b/_testenv/data/podman/Dockerfile index 6f6c739..5321bfe 100644 --- a/_testenv/data/podman/Dockerfile +++ b/_testenv/data/podman/Dockerfile @@ -19,6 +19,7 @@ -y \ --no-install-recommends \ -o Dpkg::Options::="--force-confold" \ + apt-rdepends \ autoconf \ automake \ bc \ diff --git a/_testenv/testenv/podman_install.py b/_testenv/testenv/podman_install.py index 9c680b9..77183ed 100644 --- a/_testenv/testenv/podman_install.py +++ b/_testenv/testenv/podman_install.py @@ -3,6 +3,9 @@ import logging import multiprocessing import os +import shlex +import string +import subprocess import sys import testenv.cmd import testenv.podman @@ -30,6 +33,58 @@ os.makedirs(git_dir, exist_ok=True) +def get_dbg_pkgs(dep): + ret = [f"{dep}-dbg", f"{dep}-dbgsym"] + + # Get from e.g. libosmocore22 to libosmocore-dbg + dep_nodigits = dep.rstrip(string.digits) + if dep_nodigits != dep: + ret += [f"{dep_nodigits}-dbg", f"{dep_nodigits}-dbgsym"] + + return ret + + +def apt_get_dbg_pkgs(pkgs): + dbg_pkgs_all = os.path.join(testenv.args.cache, "podman", "dbg_pkgs_all") + dbg_pkgs = {} + + testenv.cmd.run(f"apt-cache pkgnames | grep -- -dbg > {shlex.quote(dbg_pkgs_all)}") + + for pkg in pkgs: + # Iterate over apt-rdepends, example output: + # osmo-mgw + # Depends: libc6 (>= 2.34) + # Depends: libosmoabis13 + rdeps = testenv.cmd.run(["apt-rdepends", pkg], stdout=subprocess.PIPE) + for line in rdeps.stdout.decode("utf-8").split("\n"): + if line.startswith(" "): + continue + dep = line.rstrip() + + if dep not in dbg_pkgs: + for dbg_pkg in get_dbg_pkgs(dep): + # Use subprocess.run so we don't get lots of log messages. + # Also we don't need to run grep through podman. + grep = subprocess.run(["grep", "-q", f"^{dbg_pkg}$", dbg_pkgs_all]) + + if grep.returncode == 0: + dbg_pkgs[dep] = dbg_pkg + break + + if dep not in dbg_pkgs: + dbg_pkgs[dep] = None + + if dbg_pkgs[dep]: + logging.debug(f"{pkg} -> {dep}: installing {dbg_pkgs[dep]}") + + ret = [] + for dep, dbg in dbg_pkgs.items(): + if dbg: + ret += [dbg] + + return ret + + def apt_install(pkgs): if not pkgs: return @@ -37,6 +92,8 @@ # Remove duplicates pkgs = list(set(pkgs)) + pkgs += apt_get_dbg_pkgs(pkgs) + logging.info(f"Installing packages: {', '.join(pkgs)}") testenv.cmd.run(["apt-get", "-q", "install", "-y", "--no-install-recommends"] + pkgs) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38803?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4dc57257b944126fed2c7b031c92c77a3d4286e0 Gerrit-Change-Number: 38803 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

7 months, 1 week

1
0
0 0

[S] Change in libosmo-abis[master]: raa_prime_encode: rework is_z_seq() to improve performance

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38752?usp=email ) Change subject: raa_prime_encode: rework is_z_seq() to improve performance ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I haven't done any measurements, and I know that "premature optimization is the root of all evil". […] In this case with older code can also unrol the loop, and it has early return, so I'm not really sure it's really an improvement... I don't really think this has an impact at all running once every 20ms. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38752?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I43f4a85102114b51a8f2d9fa8fe3b941800b56fa Gerrit-Change-Number: 38752 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Nov 2024 12:09:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

7 months, 1 week

1
0
0 0

[S] Change in libosmo-abis[master]: raa_prime_encode: rework is_z_seq() to improve performance

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38752?usp=email ) Change subject: raa_prime_encode: rework is_z_seq() to improve performance ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Is it really improving performance? Does this really matter? I haven't done any measurements, and I know that "premature optimization is the root of all evil". But in the case of osmo-bts.git this code is executed one or several times for each TCH/F14.4 TCH.ind coming from the PHY every 20 ms. As I general rule, I believe it's better to avoid `if` statements in loops if they can be avoided. This way the compiler can easily unroll loops. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38752?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I43f4a85102114b51a8f2d9fa8fe3b941800b56fa Gerrit-Change-Number: 38752 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Nov 2024 11:56:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

7 months, 1 week

1
0
0 0

[S] Change in libosmo-abis[master]: raa_prime_encode: rework is_z_seq() to improve performance

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38752?usp=email ) Change subject: raa_prime_encode: rework is_z_seq() to improve performance ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: Is it really improving performance? Does this really matter? -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38752?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I43f4a85102114b51a8f2d9fa8fe3b941800b56fa Gerrit-Change-Number: 38752 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Nov 2024 11:21:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

[S] Change in ...osmo-s1gw[master]: sctp_server: pass MME addr/port to sctp_proxy as opaque data

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38786?usp=email ) Change subject: sctp_server: pass MME addr/port to sctp_proxy as opaque data ...................................................................... Patch Set 1: (1 comment) File src/sctp_proxy.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38786/comment/b0d6abb2_0ee9… : PS1, Line 64: start_link(Aid, {MmeAddr, MmePort}) -> > It's because `gen_server` is now passing both MME address and MME port as one argument (tuple), but […] I'd say change the API to decrement amount of code. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38786?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I1bd5f17d940173c4ec2d8d7a1d48778098008c84 Gerrit-Change-Number: 38786 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Nov 2024 10:56:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

7 months, 1 week

1
0
0 0

[S] Change in ...osmo-s1gw[master]: sctp_server: pass MME addr/port to sctp_proxy as opaque data

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38786?usp=email ) Change subject: sctp_server: pass MME addr/port to sctp_proxy as opaque data ...................................................................... Patch Set 1: (1 comment) File src/sctp_proxy.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38786/comment/53b281fa_1053… : PS1, Line 64: start_link(Aid, {MmeAddr, MmePort}) -> > I wonder what's the point in maintaining the 2 versions of the start_link here... It's because `gen_server` is now passing both MME address and MME port as one argument (tuple), but the existing API expects two separate arguments. I could change the existing API rather than adding the new `/2` wrapper, either way is fine with me. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38786?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I1bd5f17d940173c4ec2d8d7a1d48778098008c84 Gerrit-Change-Number: 38786 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Nov 2024 10:54:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

7 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024