November 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: testenv: make it pass 'ruff check' linter

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38778?usp=email ) Change subject: testenv: make it pass 'ruff check' linter ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38778?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3e5cd05ce0aa241509d77391c5ed64e618f385ba Gerrit-Change-Number: 38778 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Nov 2024 16:59:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: mgw: fix RTP packets received while RX disabled

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38777?usp=email ) Change subject: mgw: fix RTP packets received while RX disabled ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38777?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ieaf5440a693448cdeeaac7f47e6110cb480bff5f Gerrit-Change-Number: 38777 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Nov 2024 16:59:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

[XS] Change in libosmo-abis[master]: ipaccess: Fix wrong pointer passed in sign_link_up user callback

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38805?usp=email ) Change subject: ipaccess: Fix wrong pointer passed in sign_link_up user callback ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > nice catch. […] This is just another consequence of the API mess I documented here 6 years ago: https://osmocom.org/issues/3622 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38805?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I8e514360d5ed1c311af97f8fa728a2ff0a027522 Gerrit-Change-Number: 38805 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 18 Nov 2024 16:59:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

7 months, 1 week

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: testenv: add run --until-nok

by laforge

Attention is currently required from: daniel, fixeria, osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38776?usp=email ) Change subject: testenv: add run --until-nok ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: I don't really have much expericene with testenv... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38776?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I17e1ebcc5d6ff1b6a087c4d4c9405a02798212f1 Gerrit-Change-Number: 38776 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Nov 2024 16:58:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

[XS] Change in libosmocore[master]: cosmetic: ipa: fix typo in documentation

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/38804?usp=email ) Change subject: cosmetic: ipa: fix typo in documentation ...................................................................... cosmetic: ipa: fix typo in documentation Change-Id: I6da9516ebc5df41205326843a1d7c56fce01618a --- M src/gsm/ipa.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/gsm/ipa.c b/src/gsm/ipa.c index 6e41fd9..963f97d 100644 --- a/src/gsm/ipa.c +++ b/src/gsm/ipa.c @@ -404,7 +404,7 @@ return msg; } -/*! Generate IPA CCM ID RESP based on requets payload +/*! Generate IPA CCM ID RESP based on request payload * \param[in] dev Descriptor describing identity data for response * \param[in] data Payload of the IPA CCM ID GET request * \param[in] len Length of \a data in octets -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38804?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6da9516ebc5df41205326843a1d7c56fce01618a Gerrit-Change-Number: 38804 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

7 months, 1 week

1
0
0 0

[XS] Change in libosmocore[master]: cosmetic: ipa: fix typo in documentation

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/38804?usp=email ) Change subject: cosmetic: ipa: fix typo in documentation ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38804?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6da9516ebc5df41205326843a1d7c56fce01618a Gerrit-Change-Number: 38804 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Nov 2024 16:57:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

[XS] Change in libosmo-abis[master]: ipaccess: Simplify code after early return if block

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38806?usp=email ) Change subject: ipaccess: Simplify code after early return if block ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: not much of an improvement, IMHO. but if you think it's worth... -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38806?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I406b4f4e973c9b75b102aea3d6fe6aab73d91185 Gerrit-Change-Number: 38806 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Nov 2024 16:57:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

[XS] Change in libosmo-abis[master]: ipaccess: Fix wrong pointer passed in sign_link_up user callback

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38805?usp=email ) Change subject: ipaccess: Fix wrong pointer passed in sign_link_up user callback ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: nice catch. I guess the sign_link_up is mostly relevant for E1 based BTS, where the presence/absence of LAPD signalling links is important. For IPA (IP) based transport, every signaling link has a TCP/IPA connection that the user knows about anyway -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38805?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I8e514360d5ed1c311af97f8fa728a2ff0a027522 Gerrit-Change-Number: 38805 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Nov 2024 16:56:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

7 months, 1 week

1
0
0 0

[XS] Change in libosmo-abis[master]: ipaccess: Simplify code after early return if block

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38806?usp=email ) Change subject: ipaccess: Simplify code after early return if block ...................................................................... ipaccess: Simplify code after early return if block Change-Id: I406b4f4e973c9b75b102aea3d6fe6aab73d91185 --- M src/input/ipaccess.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/06/38806/1 diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index f89db15..cab812c 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -967,11 +967,12 @@ } msgb_free(msg); return ret; - } else if (link->port == IPA_TCP_PORT_OML) + } + + if (link->port == IPA_TCP_PORT_OML) e1i_ts = e1inp_line_ipa_oml_ts(link->line); else if (link->port == IPA_TCP_PORT_RSL) e1i_ts = e1inp_line_ipa_rsl_ts(link->line, link->ofd->priv_nr - E1INP_SIGN_RSL); - OSMO_ASSERT(e1i_ts != NULL); if (e1i_ts->type == E1INP_TS_TYPE_NONE) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38806?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I406b4f4e973c9b75b102aea3d6fe6aab73d91185 Gerrit-Change-Number: 38806 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 1 week

1
0
0 0

[XS] Change in libosmo-abis[master]: ipaccess: Fix wrong pointer passed in sign_link_up user callback

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/38805?usp=email to look at the new patch set (#2). Change subject: ipaccess: Fix wrong pointer passed in sign_link_up user callback ...................................................................... ipaccess: Fix wrong pointer passed in sign_link_up user callback This bug was introduced in Jun 2011, 13 years ago, so probably this code path is not (usually) used at all. The commit introducing the regression changed sign_link_up() first param from msgb to struct ipaccess_unit, but compiler didn't catch it because it's being passed as a void pointer. Fixes: c9c4fd39055ab02c0af59d5519e62edc456e3d0b Related: OS#3622 Change-Id: I8e514360d5ed1c311af97f8fa728a2ff0a027522 --- M src/input/ipaccess.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/05/38805/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38805?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I8e514360d5ed1c311af97f8fa728a2ff0a027522 Gerrit-Change-Number: 38805 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

7 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024