Attention is currently required from: laforge, lynxis lazus.
fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email )
Change subject: SGSN: BSSGP_ConnHdlr: GMM Service Request: add support to expect authentication
......................................................................
Patch Set 3:
(3 comments)
File sgsn/BSSGP_ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396/comment/5d00e408_d228… :
PS3, Line 333:
one tab, not two
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396/comment/efcffb4c_2a29… :
PS3, Line 694: setverdict(pass);
so we don't expect service accept, but still we `setverdict(pass)`?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396/comment/ab7bc7f0_c114… :
PS3, Line 760: GSUP SAI Req
`GMM Auth Req`
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9ed08160bf5413e3a30d6e90eb947d4d799e1058
Gerrit-Change-Number: 38396
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Sat, 16 Nov 2024 16:35:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No