October 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ggsn[master]: doc: Document MTU features in User Manual and example config files
by pespin 23 Oct '24

23 Oct '24

Attention is currently required from: laforge, lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38500?usp=email ) Change subject: doc: Document MTU features in User Manual and example config files ...................................................................... Patch Set 8: (1 comment) File doc/manuals/chapters/running.adoc: https://gerrit.osmocom.org/c/osmo-ggsn/+/38500/comment/afd78893_5a95d158?us… : PS5, Line 57: When running osmo-ggsn, the user must take network Maximum Transmission Unit : (MTU) into consideration, and configure it based on network specific setup. > I'm not aware of any common breakage preventing transporting fragmented IP packets across networks. […] I rewrote and restructured the whole thing in the new patch version. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38500?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ib6e974b38107fe48072380f768e1881f0fc95e80 Gerrit-Change-Number: 38500 Gerrit-PatchSet: 8 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 23 Oct 2024 17:59:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ggsn[master]: doc: Document MTU features in User Manual and example config files
by pespin 23 Oct '24

23 Oct '24

Attention is currently required from: lynxis lazus, pespin. Hello Jenkins Builder, laforge, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38500?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: doc: Document MTU features in User Manual and example config files ...................................................................... doc: Document MTU features in User Manual and example config files Related: OS#6298 Related: SYS#7122 Change-Id: Ib6e974b38107fe48072380f768e1881f0fc95e80 --- M doc/examples/osmo-ggsn-kernel-gtp.cfg M doc/examples/osmo-ggsn.cfg M doc/manuals/chapters/configuration.adoc A doc/manuals/chapters/mtu.adoc M doc/manuals/chapters/running.adoc 5 files changed, 196 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/00/38500/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38500?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ib6e974b38107fe48072380f768e1881f0fc95e80 Gerrit-Change-Number: 38500 Gerrit-PatchSet: 8 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-ggsn[master]: doc: Document MTU features in User Manual and example config files
by pespin 23 Oct '24

23 Oct '24

Attention is currently required from: lynxis lazus, pespin. Hello Jenkins Builder, laforge, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38500?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: doc: Document MTU features in User Manual and example config files ...................................................................... doc: Document MTU features in User Manual and example config files Related: OS#6298 Related: SYS#7122 Change-Id: Ib6e974b38107fe48072380f768e1881f0fc95e80 --- M doc/examples/osmo-ggsn-kernel-gtp.cfg M doc/examples/osmo-ggsn.cfg M doc/manuals/chapters/configuration.adoc A doc/manuals/chapters/mtu.adoc M doc/manuals/chapters/running.adoc 5 files changed, 196 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/00/38500/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38500?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ib6e974b38107fe48072380f768e1881f0fc95e80 Gerrit-Change-Number: 38500 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in libosmocore[master]: tun: assert tundev!=NULL in osmo_tundev_send
by fixeria 23 Oct '24

23 Oct '24

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/38504?usp=email ) Change subject: tun: assert tundev!=NULL in osmo_tundev_send ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38504?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I892052f665d77bd01ac5a05649f8de40936f097f Gerrit-Change-Number: 38504 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Oct 2024 16:58:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ggsn[master]: Rename tun_encaps -> tun_inject_pkt
by pespin 23 Oct '24

23 Oct '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38508?usp=email ) Change subject: Rename tun_encaps -> tun_inject_pkt ...................................................................... Rename tun_encaps -> tun_inject_pkt The terminology of "encapsulating" used in tun_encaps is confusing, since in this case we are not really encapsulating anything, but actually delivering ("injecting") the packet to the system network stack. Using the "encapsulating" term is also confusing because readers may think it may be doing the GTP-U encapsulation, which is not. Change-Id: Ibb17c792b81668571e69d79918f3adf0e9e0f6c8 --- M ggsn/ggsn.c M lib/tun.c M lib/tun.h M sgsnemu/sgsnemu.c 4 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/08/38508/1 diff --git a/ggsn/ggsn.c b/ggsn/ggsn.c index 6b51bbc..062e542 100644 --- a/ggsn/ggsn.c +++ b/ggsn/ggsn.c @@ -815,7 +815,7 @@ osmo_hexdump(pack, len)); return -1; } - return tun_encaps((struct tun_t *)pdp->ipif, pack, len); + return tun_inject_pkt((struct tun_t *)pdp->ipif, pack, len); } /* callback for libgtp osmocom select loop integration */ diff --git a/lib/tun.c b/lib/tun.c index 5f73d32..3cce3a5 100644 --- a/lib/tun.c +++ b/lib/tun.c @@ -200,7 +200,7 @@ return 0; } -int tun_encaps(struct tun_t *tun, void *pack, unsigned len) +int tun_inject_pkt(struct tun_t *tun, void *pack, unsigned len) { struct msgb *msg; int rc; diff --git a/lib/tun.h b/lib/tun.h index a6b6181..4d41eb8 100644 --- a/lib/tun.h +++ b/lib/tun.h @@ -47,7 +47,7 @@ extern int tun_new(struct tun_t **tun, const char *dev_name, bool use_kernel, int fd0, int fd1u); extern int tun_free(struct tun_t *tun); -extern int tun_encaps(struct tun_t *tun, void *pack, unsigned len); +extern int tun_inject_pkt(struct tun_t *tun, void *pack, unsigned len); extern int tun_addaddr(struct tun_t *this, struct in46_addr *addr, size_t prefixlen); diff --git a/sgsnemu/sgsnemu.c b/sgsnemu/sgsnemu.c index c592aa9..d195fab 100644 --- a/sgsnemu/sgsnemu.c +++ b/sgsnemu/sgsnemu.c @@ -1827,7 +1827,7 @@ } /* printf("cb_gtpu_data_ind. Packet received: forwarding to tun\n"); */ - return tun_encaps((struct tun_t *)pdp->ipif, pack, len); + return tun_inject_pkt((struct tun_t *)pdp->ipif, pack, len); } int main(int argc, char **argv) -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38508?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ibb17c792b81668571e69d79918f3adf0e9e0f6c8 Gerrit-Change-Number: 38508 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ggsn[master]: ggsn: Rename confusing functions
by pespin 23 Oct '24

23 Oct '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38506?usp=email ) Change subject: ggsn: Rename confusing functions ...................................................................... ggsn: Rename confusing functions It's really confusing having a function operating on a rx path called "encaps" since it's not really encapsulating anything. This confuses the reader by thinking this is the function encapsulating packets into GTP-U. Change-Id: I7ff54f5e57ccc2c436becd1be1b0f728cbcdb12c --- M ggsn/ggsn.c M sgsnemu/sgsnemu.c 2 files changed, 16 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/06/38506/1 diff --git a/ggsn/ggsn.c b/ggsn/ggsn.c index a02b97f..6b51bbc 100644 --- a/ggsn/ggsn.c +++ b/ggsn/ggsn.c @@ -667,7 +667,8 @@ return rc; } -/* Internet-originated IP packet, needs to be sent via GTP towards MS */ +/* Rx Internet-originated IP packet from our tun iface, needs to be sent via + * GTPU towards MS. */ static int cb_tun_ind(struct tun_t *tun, void *pack, unsigned len) { struct apn_ctx *apn = tun->priv; @@ -747,8 +748,10 @@ return 0; } -/* MS-originated GTP1-U packet, needs to be sent via TUN device */ -static int encaps_tun(struct pdp_t *pdp, void *pack, unsigned len) +/* Rx MS-originated GTP-U packet, needs to be sent via TUN device. + * "pack" contains the GTP-U payload once decapsulated from GTP-U by libgtp. + * Hence, "pack" should contain an IP packet. */ +static int cb_gtpu_data_ind(struct pdp_t *pdp, void *pack, unsigned len) { struct iphdr *iph = (struct iphdr *)pack; struct ip6_hdr *ip6h = (struct ip6_hdr *)pack; @@ -963,7 +966,7 @@ rc = osmo_fd_register(&ggsn->gtp_fd1u); OSMO_ASSERT(rc == 0); - gtp_set_cb_data_ind(ggsn->gsn, encaps_tun); + gtp_set_cb_data_ind(ggsn->gsn, cb_gtpu_data_ind); gtp_set_cb_create_context_ind(ggsn->gsn, create_context_ind); gtp_set_cb_update_context_ind(ggsn->gsn, update_context_ind); gtp_set_cb_delete_context(ggsn->gsn, delete_context); diff --git a/sgsnemu/sgsnemu.c b/sgsnemu/sgsnemu.c index 9ab0f25..c592aa9 100644 --- a/sgsnemu/sgsnemu.c +++ b/sgsnemu/sgsnemu.c @@ -1196,7 +1196,7 @@ return 0; } -static int encaps_ping4(struct pdp_t *pdp, void *pack, unsigned len) +static int cb_gtpu_data_ind_ping4(struct pdp_t *pdp, void *pack, unsigned len) { struct timeval tv; struct timeval *tp; @@ -1258,7 +1258,7 @@ return 0; } -static int encaps_ping6(struct pdp_t *pdp, struct ip6_hdr *ip6h, unsigned len) +static int cb_gtpu_data_ind_ping6(struct pdp_t *pdp, struct ip6_hdr *ip6h, unsigned len) { const struct icmpv6_echo_hdr *ic6h = (struct icmpv6_echo_hdr *) ((uint8_t*)ip6h + sizeof(*ip6h)); struct timeval tv; @@ -1325,7 +1325,7 @@ } /* Handle a received ping packet. Print out line and update statistics. */ -static int encaps_ping(struct pdp_t *pdp, void *pack, unsigned len) +static int cb_gtpu_data_ind_ping(struct pdp_t *pdp, void *pack, unsigned len) { struct iphdr *iph = (struct iphdr *)pack; struct timeval tv; @@ -1343,9 +1343,9 @@ } switch(iph->version) { case 4: - return encaps_ping4(pdp, pack, len); + return cb_gtpu_data_ind_ping4(pdp, pack, len); case 6: - return encaps_ping6(pdp, (struct ip6_hdr *)pack, len); + return cb_gtpu_data_ind_ping6(pdp, (struct ip6_hdr *)pack, len); default: SYS_ERR(DSGSN, LOGL_ERROR, 0, "Unknown ip header version %d", iph->version); return -1; @@ -1812,7 +1812,7 @@ } } -static int encaps_tun(struct pdp_t *pdp, void *pack, unsigned len) +static int cb_gtpu_data_ind(struct pdp_t *pdp, void *pack, unsigned len) { struct iphdr *iph = (struct iphdr *)pack; struct icmpv6_radv_hdr *ra; @@ -1826,7 +1826,7 @@ break; } - /* printf("encaps_tun. Packet received: forwarding to tun\n"); */ + /* printf("cb_gtpu_data_ind. Packet received: forwarding to tun\n"); */ return tun_encaps((struct tun_t *)pdp->ipif, pack, len); } @@ -1883,9 +1883,9 @@ gtp_set_cb_delete_context(gsn, delete_context); gtp_set_cb_conf(gsn, _gtp_cb_conf); if (options.createif) - gtp_set_cb_data_ind(gsn, encaps_tun); + gtp_set_cb_data_ind(gsn, cb_gtpu_data_ind); else - gtp_set_cb_data_ind(gsn, encaps_ping); + gtp_set_cb_data_ind(gsn, cb_gtpu_data_ind_ping); #if defined(__linux__) if ((options.createif) && (options.netns)) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38506?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I7ff54f5e57ccc2c436becd1be1b0f728cbcdb12c Gerrit-Change-Number: 38506 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ggsn[master]: tun.h: Remove non-existent tun_decaps()
by pespin 23 Oct '24

23 Oct '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38507?usp=email ) Change subject: tun.h: Remove non-existent tun_decaps() ...................................................................... tun.h: Remove non-existent tun_decaps() Change-Id: If9cc5d2d54b87e38feefa55cb9410715fa9bd11f --- M lib/tun.h 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/07/38507/1 diff --git a/lib/tun.h b/lib/tun.h index 544e56a..a6b6181 100644 --- a/lib/tun.h +++ b/lib/tun.h @@ -47,7 +47,6 @@ extern int tun_new(struct tun_t **tun, const char *dev_name, bool use_kernel, int fd0, int fd1u); extern int tun_free(struct tun_t *tun); -extern int tun_decaps(struct tun_t *this); extern int tun_encaps(struct tun_t *tun, void *pack, unsigned len); extern int tun_addaddr(struct tun_t *this, struct in46_addr *addr, size_t prefixlen); -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38507?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: If9cc5d2d54b87e38feefa55cb9410715fa9bd11f Gerrit-Change-Number: 38507 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: netdev: Explicit cast time() to uint32_t seq_nr
by fixeria 23 Oct '24

23 Oct '24

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/38501?usp=email ) Change subject: netdev: Explicit cast time() to uint32_t seq_nr ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38501?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia4c1c9b2dcc751b6cbd01a957627f882bc63ba87 Gerrit-Change-Number: 38501 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Oct 2024 16:34:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ggsn[master]: ggsn: Avoid forwarding IPv6 solicited-node multicast addr to tun device
by fixeria 23 Oct '24

23 Oct '24

Attention is currently required from: laforge, lynxis lazus, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38505?usp=email ) Change subject: ggsn: Avoid forwarding IPv6 solicited-node multicast addr to tun device ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38505?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Iac8f14083620d86f3872aa951930fbe8f680ff24 Gerrit-Change-Number: 38505 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 23 Oct 2024 16:33:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ggsn[master]: tun: Fix null pointer derefence when in kernel gtp mode
by fixeria 23 Oct '24

23 Oct '24

fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38502?usp=email ) Change subject: tun: Fix null pointer derefence when in kernel gtp mode ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38502?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I508758696a0bcbb7c780a0ed33b28ba640602488 Gerrit-Change-Number: 38502 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Oct 2024 16:28:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0