October 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: netdev: Explicit cast time() to uint32_t seq_nr
by laforge 24 Oct '24

24 Oct '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/38501?usp=email ) Change subject: netdev: Explicit cast time() to uint32_t seq_nr ...................................................................... netdev: Explicit cast time() to uint32_t seq_nr Make coverity happy and also inform readers of the code that we are fine dropping the most significat part of the return value of time() when using it to set up a nl seq_nr. Related: Coverity CID#426078 Change-Id: Ia4c1c9b2dcc751b6cbd01a957627f882bc63ba87 --- M src/core/netdev.c 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/core/netdev.c b/src/core/netdev.c index 8e7fc28..1e886f9 100644 --- a/src/core/netdev.c +++ b/src/core/netdev.c @@ -479,7 +479,7 @@ nlh->nlmsg_type = RTM_GETLINK; nlh->nlmsg_flags = NLM_F_REQUEST | NLM_F_ACK; - nlh->nlmsg_seq = time(NULL); + nlh->nlmsg_seq = (uint32_t)time(NULL); ifm = mnl_nlmsg_put_extra_header(nlh, sizeof(*ifm)); ifm->ifi_family = AF_UNSPEC; @@ -512,7 +512,7 @@ nlh->nlmsg_type = RTM_NEWLINK; nlh->nlmsg_flags = NLM_F_REQUEST | NLM_F_ACK; - nlh->nlmsg_seq = time(NULL); + nlh->nlmsg_seq = (uint32_t)time(NULL); ifm = mnl_nlmsg_put_extra_header(nlh, sizeof(*ifm)); ifm->ifi_family = AF_UNSPEC; @@ -542,7 +542,7 @@ nlh->nlmsg_type = RTM_NEWLINK; nlh->nlmsg_flags = NLM_F_REQUEST | NLM_F_ACK; - nlh->nlmsg_seq = time(NULL); + nlh->nlmsg_seq = (uint32_t)time(NULL); ifm = mnl_nlmsg_put_extra_header(nlh, sizeof(*ifm)); ifm->ifi_family = AF_UNSPEC; @@ -568,7 +568,7 @@ nlh->nlmsg_type = RTM_NEWADDR; nlh->nlmsg_flags = NLM_F_REQUEST | NLM_F_CREATE | NLM_F_REPLACE | NLM_F_ACK; - nlh->nlmsg_seq = time(NULL); + nlh->nlmsg_seq = (uint32_t)time(NULL); ifm = mnl_nlmsg_put_extra_header(nlh, sizeof(*ifm)); ifm->ifa_family = osa->u.sa.sa_family; @@ -616,7 +616,7 @@ nlh->nlmsg_type = RTM_NEWROUTE; nlh->nlmsg_flags = NLM_F_REQUEST | NLM_F_CREATE | NLM_F_ACK; - nlh->nlmsg_seq = time(NULL); + nlh->nlmsg_seq = (uint32_t)time(NULL); rtm = mnl_nlmsg_put_extra_header(nlh, sizeof(*rtm)); rtm->rtm_family = dst_osa->u.sa.sa_family; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38501?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia4c1c9b2dcc751b6cbd01a957627f882bc63ba87 Gerrit-Change-Number: 38501 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in libosmocore[master]: tun: assert tundev!=NULL in osmo_tundev_send
by laforge 24 Oct '24

24 Oct '24

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/38504?usp=email ) Change subject: tun: assert tundev!=NULL in osmo_tundev_send ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38504?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I892052f665d77bd01ac5a05649f8de40936f097f Gerrit-Change-Number: 38504 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Oct 2024 04:12:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: netdev: Explicit cast time() to uint32_t seq_nr
by laforge 24 Oct '24

24 Oct '24

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/38501?usp=email ) Change subject: netdev: Explicit cast time() to uint32_t seq_nr ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38501?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia4c1c9b2dcc751b6cbd01a957627f882bc63ba87 Gerrit-Change-Number: 38501 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Oct 2024 04:12:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: pySim.esim.saip.templates: Fix DF_TELECOM FileID (7F10, not 7F11)
by laforge 24 Oct '24

24 Oct '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/38471?usp=email ) Change subject: pySim.esim.saip.templates: Fix DF_TELECOM FileID (7F10, not 7F11) ...................................................................... pySim.esim.saip.templates: Fix DF_TELECOM FileID (7F10, not 7F11) Change-Id: I4bc37f9d99c046cd6c6accaaf460a39eb79b660f --- M pySim/esim/saip/templates.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/esim/saip/templates.py b/pySim/esim/saip/templates.py index f69ec7a..3ec0b9b 100644 --- a/pySim/esim/saip/templates.py +++ b/pySim/esim/saip/templates.py @@ -293,7 +293,7 @@ oid = OID.DF_TELECOM base_path = Path('MF') files = [ - FileTemplate(0x7f11, 'DF.TELECOM', 'DF', None, None, 14, None, None, False, params=['pinStatusTemplateDO']), + FileTemplate(0x7f10, 'DF.TELECOM', 'DF', None, None, 14, None, None, False, params=['pinStatusTemplateDO']), FileTemplate(0x6f06, 'EF.ARR', 'LF', None, None, 10, None, None, True, ['nb_rec', 'size']), FileTemplate(0x6f53, 'EF.RMA', 'LF', None, None, 3, None, None, True, ['nb_rec', 'size']), FileTemplate(0x6f54, 'EF.SUME', 'TR', None, 22, 3, None, None, True), @@ -334,7 +334,7 @@ oid = OID.DF_TELECOM_v2 base_path = Path('MF') files = [ - FileTemplate(0x7f11, 'DF.TELECOM', 'DF', None, None, 14, None, None, False, params=['pinStatusTemplateDO']), + FileTemplate(0x7f10, 'DF.TELECOM', 'DF', None, None, 14, None, None, False, params=['pinStatusTemplateDO']), FileTemplate(0x6f06, 'EF.ARR', 'LF', None, None, 10, None, None, True, ['nb_rec', 'size']), FileTemplate(0x6f53, 'EF.RMA', 'LF', None, None, 3, None, None, True, ['nb_rec', 'size']), FileTemplate(0x6f54, 'EF.SUME', 'TR', None, 22, 3, None, None, True), -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38471?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4bc37f9d99c046cd6c6accaaf460a39eb79b660f Gerrit-Change-Number: 38471 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: pySim.esim.saip.templates: Fix DF_TELECOM FileID (7F10, not 7F11)
by laforge 24 Oct '24

24 Oct '24

Attention is currently required from: dexter. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38471?usp=email ) Change subject: pySim.esim.saip.templates: Fix DF_TELECOM FileID (7F10, not 7F11) ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38471?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4bc37f9d99c046cd6c6accaaf460a39eb79b660f Gerrit-Change-Number: 38471 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Oct 2024 04:10:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in pysim[master]: pySim.ts_31_102: Add support for EF.EARFCNList
by laforge 24 Oct '24

24 Oct '24

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38472?usp=email ) Change subject: pySim.ts_31_102: Add support for EF.EARFCNList ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38472?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I16797ca58c3ad6ebaf588d04fec011a0cbcfcef3 Gerrit-Change-Number: 38472 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 24 Oct 2024 04:10:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-msc[master]: csd_bs: cosmetic changes to csd_bs_list_to_bearer_cap()
by fixeria 23 Oct '24

23 Oct '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/38510?usp=email ) Change subject: csd_bs: cosmetic changes to csd_bs_list_to_bearer_cap() ...................................................................... csd_bs: cosmetic changes to csd_bs_list_to_bearer_cap() Change-Id: I101f55dfbd0d327269fcce76031a2db265ca2eb9 Related: OS#4394, OS#5730 --- M src/libmsc/csd_bs.c 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/10/38510/1 diff --git a/src/libmsc/csd_bs.c b/src/libmsc/csd_bs.c index ab0b643..c31b1f3 100644 --- a/src/libmsc/csd_bs.c +++ b/src/libmsc/csd_bs.c @@ -432,11 +432,9 @@ .coding = GSM48_BCAP_CODING_GSM_STD, .radio = GSM48_BCAP_RRQ_FR_ONLY, }; - enum csd_bs bs; - int i; - for (i = 0; i < list->count; i++) { - bs = list->bs[i]; + for (unsigned int i = 0; i < list->count; i++) { + const enum csd_bs bs = list->bs[i]; cap->data.rate_adaption = GSM48_BCAP_RA_V110_X30; cap->data.sig_access = GSM48_BCAP_SA_I440_I450; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38510?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I101f55dfbd0d327269fcce76031a2db265ca2eb9 Gerrit-Change-Number: 38510 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-msc[master]: csd_bs: do not hard-code GSM48_BCAP_ITCAP_UNR_DIG_INF
by fixeria 23 Oct '24

23 Oct '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/38511?usp=email ) Change subject: csd_bs: do not hard-code GSM48_BCAP_ITCAP_UNR_DIG_INF ...................................................................... csd_bs: do not hard-code GSM48_BCAP_ITCAP_UNR_DIG_INF We should respect the Information Transfer Capability indicated during the MO data call establishment. Hard-coding UDI breaks FAX calls for some FAX machines, such as Possia Greta. Change-Id: Ibfb9f0097ca86092320cebed13a7a642080370f1 Related: OS#4394, OS#5730 --- M src/libmsc/csd_bs.c M src/libmsc/gsm_04_08_cc.c 2 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/11/38511/1 diff --git a/src/libmsc/csd_bs.c b/src/libmsc/csd_bs.c index c31b1f3..41747ce 100644 --- a/src/libmsc/csd_bs.c +++ b/src/libmsc/csd_bs.c @@ -426,13 +426,6 @@ int csd_bs_list_to_bearer_cap(struct gsm_mncc_bearer_cap *cap, const struct csd_bs_list *list) { - *cap = (struct gsm_mncc_bearer_cap){ - .transfer = GSM_MNCC_BCAP_UNR_DIG, - .mode = GSM48_BCAP_TMOD_CIRCUIT, - .coding = GSM48_BCAP_CODING_GSM_STD, - .radio = GSM48_BCAP_RRQ_FR_ONLY, - }; - for (unsigned int i = 0; i < list->count; i++) { const enum csd_bs bs = list->bs[i]; diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c index dafb41c..e144b47 100644 --- a/src/libmsc/gsm_04_08_cc.c +++ b/src/libmsc/gsm_04_08_cc.c @@ -961,6 +961,13 @@ case GSM48_BCAP_ITCAP_3k1_AUDIO: case GSM48_BCAP_ITCAP_FAX_G3: case GSM48_BCAP_ITCAP_UNR_DIG_INF: + bearer_cap = (struct gsm_mncc_bearer_cap){ + .transfer = trans->bearer_cap.transfer, + .mode = GSM48_BCAP_TMOD_CIRCUIT, + .coding = GSM48_BCAP_CODING_GSM_STD, + .radio = GSM48_BCAP_RRQ_FR_ONLY, + }; + if (csd_bs_list_to_bearer_cap(&bearer_cap, &trans->cc.local.bearer_services) == 0) { LOG_TRANS(trans, LOGL_ERROR, "Error composing Bearer Capability for CC Setup\n"); -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38511?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ibfb9f0097ca86092320cebed13a7a642080370f1 Gerrit-Change-Number: 38511 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-msc[master]: csd_bs: fix setting of Rate Adaptation for FAX and 3.1 kHz audio
by fixeria 23 Oct '24

23 Oct '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/38512?usp=email ) Change subject: csd_bs: fix setting of Rate Adaptation for FAX and 3.1 kHz audio ...................................................................... csd_bs: fix setting of Rate Adaptation for FAX and 3.1 kHz audio Some FAX machines, like Siemens based Possia Greta, refuse MT data calls when the Rate Adaptation field is set to GSM48_BCAP_RA_V110_X30. Using GSM48_BCAP_RA_NONE makes the Greta machine happy. After looking at various tables in 3GPP TS 22.002, I deduced that GSM48_BCAP_RA_V110_X30 shall only be used for Unrestricted Digital Information. Use GSM48_BCAP_RA_NONE for both FAX and 3.1 kHz audio. Change-Id: I3d608f412859df8988ce7a51aaef65949c80865b Related: OS#4394, OS#5730 --- M src/libmsc/csd_bs.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/12/38512/1 diff --git a/src/libmsc/csd_bs.c b/src/libmsc/csd_bs.c index 41747ce..2bd6468 100644 --- a/src/libmsc/csd_bs.c +++ b/src/libmsc/csd_bs.c @@ -429,7 +429,10 @@ for (unsigned int i = 0; i < list->count; i++) { const enum csd_bs bs = list->bs[i]; - cap->data.rate_adaption = GSM48_BCAP_RA_V110_X30; + if (cap->transfer == GSM48_BCAP_ITCAP_UNR_DIG_INF) + cap->data.rate_adaption = GSM48_BCAP_RA_V110_X30; + else /* GSM48_BCAP_ITCAP_3k1_AUDIO or GSM48_BCAP_ITCAP_FAX_G3 */ + cap->data.rate_adaption = GSM48_BCAP_RA_NONE; cap->data.sig_access = GSM48_BCAP_SA_I440_I450; cap->data.async = bs_map[bs].async; if (bs_map[bs].transp) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38512?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3d608f412859df8988ce7a51aaef65949c80865b Gerrit-Change-Number: 38512 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: gsm48_encode_bearer_cap(): properly set 'Structure' in octet 4
by fixeria 23 Oct '24

23 Oct '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/38509?usp=email ) Change subject: gsm48_encode_bearer_cap(): properly set 'Structure' in octet 4 ...................................................................... gsm48_encode_bearer_cap(): properly set 'Structure' in octet 4 Before commit 714843a45 we hard-coded octet 4 to 0xb8, then we started hard-coding it to 0x88. Neither is correct. According to 3GPP TS 43.010, Annex A.1 "Attribute definition and their values", attribute 'Structure' can take two values: * Service data unit integrity, which is ** applicable for connection element "non transparent"; * Unstructured, which is ** applicable for connection element "transparent". This commit changes the output of tests/gsm0408/gsm0408_test: * Test `CSD 2400/V.22bis/transparent' is now passing. * csd_9600_v110_lv[] revert octet 4 back to 0xb8. Change-Id: I563becfdae75e22de3b5e5de3c810334a74e7ffb Fixes: 714843a45 ("gsm48_ie.c: change bearer cap structure in outgoing CSD calls") Related: OS#5730 --- M src/gsm/gsm48_ie.c M tests/gsm0408/gsm0408_test.c M tests/gsm0408/gsm0408_test.err M tests/gsm0408/gsm0408_test.ok 4 files changed, 19 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/09/38509/1 diff --git a/src/gsm/gsm48_ie.c b/src/gsm/gsm48_ie.c index b95609f..7a41ae8 100644 --- a/src/gsm/gsm48_ie.c +++ b/src/gsm/gsm48_ie.c @@ -339,8 +339,23 @@ case GSM48_BCAP_ITCAP_3k1_AUDIO: case GSM48_BCAP_ITCAP_FAX_G3: lv[i++] |= 0x80; /* last IE of octet 3 etc */ - /* octet 4 */ - lv[i++] = 0x88; + /* octet 4 + * 1... .... = Extension: No Extension + * .0.. .... = Compression: Not Allowed + * ..xx .... = Structure: (see below) + * .... 1... = Duplex mode: Full + * .... .0.. = Configuration: Point-to-point + * .... ..0. = NIRR: No meaning is associated with this value + * .... ...0 = Establishment: Demand + * + * For connection element "non transparent": + * ..00 .... = Structure: Service data unit integrity (0) + * For connection element "transparent": + * ..11 .... = Structure: Unstructured (3) */ + if ((bcap->data.transp & 0x01) == 0) + lv[i++] = 0x88 | (0x03 << 4); + else + lv[i++] = 0x88; /* octet 5 */ lv[i++] = 0x80 | ((bcap->data.rate_adaption & 3) << 3) | (bcap->data.sig_access & 7); diff --git a/tests/gsm0408/gsm0408_test.c b/tests/gsm0408/gsm0408_test.c index 8a89357..7456ed8 100644 --- a/tests/gsm0408/gsm0408_test.c +++ b/tests/gsm0408/gsm0408_test.c @@ -31,7 +31,7 @@ #include <osmocom/core/msgb.h> -static const uint8_t csd_9600_v110_lv[] = { 0x07, 0xa1, 0x88, 0x89, 0x21, 0x15, 0x63, 0x80 }; +static const uint8_t csd_9600_v110_lv[] = { 0x07, 0xa1, 0xb8, 0x89, 0x21, 0x15, 0x63, 0x80 }; static const struct gsm_mncc_bearer_cap bcap_csd_9600_v110 = { .transfer = GSM48_BCAP_ITCAP_UNR_DIG_INF, diff --git a/tests/gsm0408/gsm0408_test.err b/tests/gsm0408/gsm0408_test.err index 0102de0..8aeda3e 100644 --- a/tests/gsm0408/gsm0408_test.err +++ b/tests/gsm0408/gsm0408_test.err @@ -1,6 +1,3 @@ -Incorrect encoded result of CSD 2400/V.22bis/transparent: - should: 07 a2 b8 81 21 13 43 83 - is: 07 a2 88 81 21 13 43 83 Incorrect encoded result of Speech, without octet 3a: should: 01 a0 is: 02 20 80 diff --git a/tests/gsm0408/gsm0408_test.ok b/tests/gsm0408/gsm0408_test.ok index 721e2c5..3580591 100644 --- a/tests/gsm0408/gsm0408_test.ok +++ b/tests/gsm0408/gsm0408_test.ok @@ -1,6 +1,6 @@ Test `CSD 9600/V.110/transparent' passed Test `CSD 4800/RLP/non-transparent' passed -Test `CSD 2400/V.22bis/transparent' failed +Test `CSD 2400/V.22bis/transparent' passed Test `Speech, all codecs' passed Test `Speech, without octet 3a' failed Simple TMSI encoding test....passed -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38509?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I563becfdae75e22de3b5e5de3c810334a74e7ffb Gerrit-Change-Number: 38509 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0