October 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-msc[master]: Indicate errior and release BSS connection when SMS transaction fails
by jolly 24 Oct '24

24 Oct '24

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/38514?usp=email ) Change subject: Indicate errior and release BSS connection when SMS transaction fails ...................................................................... Indicate errior and release BSS connection when SMS transaction fails When the creation of the transaction structure fails, the MSC will send a CP-ERROR message. This patch ensures that the MSC_A use counter is decremented, so that the BSS connection is released, if it is not used by any other transaction. Without this patch, the msc_a_fsm would wait 5 seconds for an initial transaction before releasing the BSS connection. Related: OS#6427 Change-Id: I82da9c283205c69b19ceb4ba40ac5aa7f37d159b --- M src/libmsc/gsm_04_11.c 1 file changed, 20 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/14/38514/1 diff --git a/src/libmsc/gsm_04_11.c b/src/libmsc/gsm_04_11.c index 6536d0b..d2a919c 100644 --- a/src/libmsc/gsm_04_11.c +++ b/src/libmsc/gsm_04_11.c @@ -231,6 +231,20 @@ return gsm411_sendmsg(trans, msg); } +int gsm411_send_cp_error(struct msc_a *msc_a, uint8_t pdisc, uint8_t cause) +{ + struct msgb *msg = gsm411_msgb_alloc(); + struct gsm48_hdr *gh; + + msgb_put_u8(msg, cause); + + gh = (struct gsm48_hdr *) msgb_push(msg, sizeof(*gh)); + gh->proto_discr = pdisc; + gh->msg_type = GSM411_MT_CP_ERROR; + + return msc_a_tx_dtap_to_i(msc_a, msg); +} + /* mm_send: receive MMCCSMS sap message from SMC */ static int gsm411_mm_send(struct gsm411_smc_inst *inst, int msg_type, struct msgb *msg, int cp_msg_type) @@ -1318,7 +1332,12 @@ new_trans = 1; trans = gsm411_trans_init(net, vsub, msc_a, transaction_id, true); if (!trans) { - /* FIXME: send some error message */ + /* Send error message. */ + gsm411_send_cp_error(msc_a, GSM48_PDISC_SMS | (transaction_id << 4), + GSM411_CP_CAUSE_NET_FAIL); + /* Decrement use counter that has been incremented by CM Service Request (SMS). + * If there is no other service request, the BSS connection will be released. */ + msc_a_put(msc_a, MSC_A_USE_CM_SERVICE_SMS); return -ENOMEM; } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38514?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I82da9c283205c69b19ceb4ba40ac5aa7f37d159b Gerrit-Change-Number: 38514 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>

1 0

[S] Change in libosmocore[master]: gsm48_encode_bearer_cap(): properly set 'Structure' in octet 4
by laforge 24 Oct '24

24 Oct '24

Attention is currently required from: fixeria, manawyrm. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/38509?usp=email ) Change subject: gsm48_encode_bearer_cap(): properly set 'Structure' in octet 4 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38509?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I563becfdae75e22de3b5e5de3c810334a74e7ffb Gerrit-Change-Number: 38509 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Oct 2024 04:19:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-msc[master]: csd_bs: fix setting of Rate Adaptation for FAX and 3.1 kHz audio
by laforge 24 Oct '24

24 Oct '24

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-msc/+/38512?usp=email ) Change subject: csd_bs: fix setting of Rate Adaptation for FAX and 3.1 kHz audio ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38512?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3d608f412859df8988ce7a51aaef65949c80865b Gerrit-Change-Number: 38512 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Oct 2024 04:19:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-msc[master]: csd_bs: do not hard-code GSM48_BCAP_ITCAP_UNR_DIG_INF
by laforge 24 Oct '24

24 Oct '24

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-msc/+/38511?usp=email ) Change subject: csd_bs: do not hard-code GSM48_BCAP_ITCAP_UNR_DIG_INF ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38511?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ibfb9f0097ca86092320cebed13a7a642080370f1 Gerrit-Change-Number: 38511 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Oct 2024 04:18:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-msc[master]: csd_bs: cosmetic changes to csd_bs_list_to_bearer_cap()
by laforge 24 Oct '24

24 Oct '24

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-msc/+/38510?usp=email ) Change subject: csd_bs: cosmetic changes to csd_bs_list_to_bearer_cap() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38510?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I101f55dfbd0d327269fcce76031a2db265ca2eb9 Gerrit-Change-Number: 38510 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Oct 2024 04:18:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ggsn[master]: doc: Document MTU features in User Manual and example config files
by laforge 24 Oct '24

24 Oct '24

Attention is currently required from: lynxis lazus, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38500?usp=email ) Change subject: doc: Document MTU features in User Manual and example config files ...................................................................... Patch Set 8: Code-Review+1 (2 comments) Patchset: PS8: we might want to set a good example and provide nft command line examples rather than the lgecay iptables wrapper... File doc/manuals/chapters/mtu.adoc: https://gerrit.osmocom.org/c/osmo-ggsn/+/38500/comment/3f71a811_478e2e41?us… : PS8, Line 80: outter spelling: outer? -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38500?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ib6e974b38107fe48072380f768e1881f0fc95e80 Gerrit-Change-Number: 38500 Gerrit-PatchSet: 8 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 24 Oct 2024 04:17:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ggsn[master]: Rename tun_encaps -> tun_inject_pkt
by laforge 24 Oct '24

24 Oct '24

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38508?usp=email ) Change subject: Rename tun_encaps -> tun_inject_pkt ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38508?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ibb17c792b81668571e69d79918f3adf0e9e0f6c8 Gerrit-Change-Number: 38508 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Oct 2024 04:14:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ggsn[master]: ggsn: Rename confusing functions
by laforge 24 Oct '24

24 Oct '24

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38506?usp=email ) Change subject: ggsn: Rename confusing functions ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38506?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I7ff54f5e57ccc2c436becd1be1b0f728cbcdb12c Gerrit-Change-Number: 38506 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Oct 2024 04:13:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ggsn[master]: ggsn: Avoid forwarding IPv6 solicited-node multicast addr to tun device
by laforge 24 Oct '24

24 Oct '24

Attention is currently required from: lynxis lazus, osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38505?usp=email ) Change subject: ggsn: Avoid forwarding IPv6 solicited-node multicast addr to tun device ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38505?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Iac8f14083620d86f3872aa951930fbe8f680ff24 Gerrit-Change-Number: 38505 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 24 Oct 2024 04:13:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: tun: assert tundev!=NULL in osmo_tundev_send
by laforge 24 Oct '24

24 Oct '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/38504?usp=email ) Change subject: tun: assert tundev!=NULL in osmo_tundev_send ...................................................................... tun: assert tundev!=NULL in osmo_tundev_send Change-Id: I892052f665d77bd01ac5a05649f8de40936f097f --- M src/core/tun.c 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/src/core/tun.c b/src/core/tun.c index 28cec34..09a3f81 100644 --- a/src/core/tun.c +++ b/src/core/tun.c @@ -571,7 +571,10 @@ */ int osmo_tundev_send(struct osmo_tundev *tundev, struct msgb *msg) { - int rc = osmo_wqueue_enqueue(&tundev->wqueue, msg); + int rc; + + OSMO_ASSERT(tundev); + rc = osmo_wqueue_enqueue(&tundev->wqueue, msg); if (rc < 0) { LOGTUN(tundev, LOGL_ERROR, "Failed to enqueue the packet\n"); msgb_free(msg); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38504?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I892052f665d77bd01ac5a05649f8de40936f097f Gerrit-Change-Number: 38504 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0