October 2024 - gerrit-log - lists.osmocom.org

[L] Change in osmo-bts[master]: CSD NT modes: transmit properly aligned RLP frames on DL

by laforge

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/38557?usp=email ) Change subject: CSD NT modes: transmit properly aligned RLP frames on DL ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38557?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idaebfce6da13b23ba265a197502712d83991873e Gerrit-Change-Number: 38557 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 28 Oct 2024 13:50:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 4 weeks

1
0
0 0

[S] Change in libosmo-sigtran[master]: WIP: sccp: Send RELRE when CREQ is refused by peer

by pespin

pespin has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38551?usp=email ) Change subject: WIP: sccp: Send RELRE when CREQ is refused by peer ...................................................................... Abandoned we may actually want to release the RANAP Iu conn on top of it. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38551?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iea2e6f684a6cdbc978833785704b8cf2cbd4e645 Gerrit-Change-Number: 38551 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

7 months, 4 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_ranap_{cs,ps}_creq_cref

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38552?usp=email ) Change subject: hnbgw: Introduce test TC_ranap_{cs,ps}_creq_cref ...................................................................... hnbgw: Introduce test TC_ranap_{cs,ps}_creq_cref Related: SYS#6602 Change-Id: I0313ea741feca90492e25f0adc1c04844a860e41 --- M hnbgw/HNBGW_Tests.ttcn M hnbgw/expected-results.xml M library/SCCP_Templates.ttcn 3 files changed, 39 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 639904b..ed4ebda 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -48,6 +48,7 @@ import from RANAP_IEs all; import from RANAP_Templates all; import from RANAP_CodecPort all; +import from SCCP_Templates all; import from RAN_Adapter all; import from RAN_Emulation all; @@ -1300,6 +1301,38 @@ f_shutdown_helper(); } +/* SCCP Connect Req is answererd with Connect Refused: */ +private function f_tc_ranap_creq_cref_ConnHdlr(charstring id, TestHdlrParams pars) runs on ConnHdlr { + f_init_handler(pars); + + /* HNB -> MSC: InitialUE */ + f_iuh2iu_connect(f_build_initial_ue(g_pars)); + + /* This triggers a tx of SCCP CREF CN -> HNBGW: */ + BSSAP.send(ts_MSC_CONN_PRIM_DISC_REQ(sccp_par_reason_end_user_failure)); + /* HNBGW disconnects the session on the RUA side as a result: */ + RUA.receive(RUA_Disc_Ind:?); +} +private function f_tc_ranap_creq_cref(integer imsi_suffix, boolean ps_domain) runs on test_CT { + var ConnHdlr vc_conn; + g_num_hnbs := 1; + /* Instruct RAN_Emulation to avoid accepting the conn, we'll trigger an + * SCCP CREF by sending a DISC REQ primitive in ConnHdlr. */ + g_ran_ops.ranap_connect_ind_auto_res := false; + f_init(); + + vc_conn := f_start_handler_with_pars(refers(f_tc_ranap_creq_cref_ConnHdlr), f_TestHdlrParams(imsi_suffix, ps_domain)); + vc_conn.done; + + f_shutdown_helper(); +} +testcase TC_ranap_cs_creq_cref() runs on test_CT { + f_tc_ranap_creq_cref(7, false); +} +testcase TC_ranap_ps_creq_cref() runs on test_CT { + f_tc_ranap_creq_cref(8, true); +} + type record FTeid { HostName addr, OCT4 teid @@ -2398,6 +2431,8 @@ execute(TC_rab_assign_mgw_iuup_addr_chg()); execute(TC_ranap_cs_mo_disconnect()); execute(TC_ranap_ps_mo_disconnect()); + execute(TC_ranap_cs_creq_cref()); + execute(TC_ranap_ps_creq_cref()); if (mp_enable_pfcp_tests) { execute(TC_ps_rab_assignment_with_pfcp()); diff --git a/hnbgw/expected-results.xml b/hnbgw/expected-results.xml index 5f39bc5..0b67ec6 100644 --- a/hnbgw/expected-results.xml +++ b/hnbgw/expected-results.xml @@ -21,6 +21,8 @@ <testcase classname='HNBGW_Tests' name='TC_rab_assign_mgw_iuup_addr_chg' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_ranap_cs_mo_disconnect' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_ranap_ps_mo_disconnect' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_ranap_cs_creq_cref' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_ranap_ps_creq_cref' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_ps_rab_assignment_without_pfcp' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_mscpool_L3Compl_on_1_cnlink' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_mscpool_L3Complete_by_imsi_round_robin' time='MASKED'/> diff --git a/library/SCCP_Templates.ttcn b/library/SCCP_Templates.ttcn index 6c977ac..40a6156 100644 --- a/library/SCCP_Templates.ttcn +++ b/library/SCCP_Templates.ttcn @@ -15,6 +15,8 @@ import from SCCPasp_Types all; import from SCCP_Emulation all; +const integer sccp_par_reason_end_user_failure := 2; /* End user failure */ + /* construct a SCCP_PAR_Address with just SSN and no PC or GT */ template (value) SCCP_PAR_Address ts_SccpAddr_SSN(integer ssn) := { addressIndicator := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38552?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0313ea741feca90492e25f0adc1c04844a860e41 Gerrit-Change-Number: 38552 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months, 4 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_ranap_{cs,ps}_creq_cref

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38552?usp=email ) Change subject: hnbgw: Introduce test TC_ranap_{cs,ps}_creq_cref ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38552?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0313ea741feca90492e25f0adc1c04844a860e41 Gerrit-Change-Number: 38552 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Oct 2024 11:22:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 4 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_ranap_{cs,ps}_creq_cref

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38552?usp=email ) Change subject: hnbgw: Introduce test TC_ranap_{cs,ps}_creq_cref ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38552?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0313ea741feca90492e25f0adc1c04844a860e41 Gerrit-Change-Number: 38552 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Oct 2024 11:06:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 4 weeks

1
0
0 0

[XS] Change in osmo-hnbgw[master]: Log cn_disconnect.ind cause

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38563?usp=email ) Change subject: Log cn_disconnect.ind cause ...................................................................... Log cn_disconnect.ind cause Change-Id: I64cd596e55b102924f39264cd2eae7a41f5f3212 --- M TODO-RELEASE M src/osmo-hnbgw/hnbgw_cn.c 2 files changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/63/38563/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 0ed7189..8cc6151 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,3 +7,4 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line +libosmo-sigtran >2.0.0 use API osmo_sua_sccp_cause_name() \ No newline at end of file diff --git a/src/osmo-hnbgw/hnbgw_cn.c b/src/osmo-hnbgw/hnbgw_cn.c index 6618fb9..b984a8e 100644 --- a/src/osmo-hnbgw/hnbgw_cn.c +++ b/src/osmo-hnbgw/hnbgw_cn.c @@ -33,6 +33,7 @@ #include <osmocom/gsm/gsm23236.h> #include <osmocom/sigtran/protocol/m3ua.h> +#include <osmocom/sigtran/protocol/sua.h> #include <osmocom/sigtran/sccp_sap.h> #include <osmocom/sigtran/sccp_helpers.h> @@ -508,14 +509,16 @@ struct osmo_prim_hdr *oph) { struct hnbgw_context_map *map; + char cause_buf[128]; map = map_from_conn_id(hsu, param->conn_id, oph); if (!map || !map->cnlink) return -ENOENT; - LOGP(DCN, LOGL_DEBUG, "handle_cn_disc_ind() conn_id=%u responding_addr=%s\n", + LOGP(DCN, LOGL_DEBUG, "handle_cn_disc_ind() conn_id=%u responding_addr=%s cause=%s\n", param->conn_id, - cnlink_sccp_addr_to_str(map->cnlink, &param->responding_addr)); + cnlink_sccp_addr_to_str(map->cnlink, &param->responding_addr), + osmo_sua_sccp_cause_name(param->cause, cause_buf, sizeof(cause_buf))); return map_sccp_dispatch(map, MAP_SCCP_EV_RX_RELEASED, oph->msg); } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38563?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I64cd596e55b102924f39264cd2eae7a41f5f3212 Gerrit-Change-Number: 38563 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 4 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_ranap_{cs,ps}_creq_cref

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38552?usp=email ) Change subject: hnbgw: Introduce test TC_ranap_{cs,ps}_creq_cref ...................................................................... Patch Set 2: (1 comment) File hnbgw/HNBGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38552/comment/2c7d6990_b26f… : PS1, Line 1326: TC_ranap_ps_creq_cref > Done. […] Ah, I see https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38561 now. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38552?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0313ea741feca90492e25f0adc1c04844a860e41 Gerrit-Change-Number: 38552 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Oct 2024 10:46:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

7 months, 4 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_ranap_{cs,ps}_creq_cref

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38552?usp=email ) Change subject: hnbgw: Introduce test TC_ranap_{cs,ps}_creq_cref ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File hnbgw/HNBGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38552/comment/bc0fbf45_7c99… : PS1, Line 1326: TC_ranap_ps_creq_cref > I copied it from TC_ranap_cs_mo_disconnect and TC_ranap_ps_mo_disconnect above, so maybe there's a p […] Done. Would you submit a patch fixing `TC_ranap_cs_mo_disconnect`? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38552?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0313ea741feca90492e25f0adc1c04844a860e41 Gerrit-Change-Number: 38552 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Oct 2024 10:45:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 4 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_ranap_{cs,ps}_creq_cref

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38552?usp=email ) Change subject: hnbgw: Introduce test TC_ranap_{cs,ps}_creq_cref ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38552?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0313ea741feca90492e25f0adc1c04844a860e41 Gerrit-Change-Number: 38552 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Oct 2024 10:42:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

7 months, 4 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: hnbgw: Drop unused template

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38562?usp=email ) Change subject: hnbgw: Drop unused template ...................................................................... hnbgw: Drop unused template Change-Id: I7dfce4485a6eaeabcdf1755619509b4b0f2bff65 --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 48f02a0..639904b 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -2267,11 +2267,6 @@ f_vty_transceive(pt, "end"); } -template (present) RUA_Disc_Req tr_RUA_Disc_Req := { - ranap := ?, - cause := ? -}; - /* With a cnlink up, change the SCCP address, and verify that it restarts upon vty 'apply sccp' */ private function f_tc_apply_sccp(charstring id, TestHdlrParams pars) runs on ConnHdlr { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38562?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7dfce4485a6eaeabcdf1755619509b4b0f2bff65 Gerrit-Change-Number: 38562 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months, 4 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2024