October 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: RAN_Emulation: Support registering IuSigConId for connectionless RANA...

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38567?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: RAN_Emulation: Support registering IuSigConId for connectionless RANAP messages ...................................................................... RAN_Emulation: Support registering IuSigConId for connectionless RANAP messages This allows dispatching received RANAP connectionless (UNITDATA) messages which target potentially existing connections identified by IuSigConId, like RANAP Reset Resource (Ack) messages. Dispatching it to relevant ConnHdlrs allows explicitly waiting to receive the message and answer from there. Change-Id: I6a00a425ce52cb0c71b03b545207f27befa11a71 --- M library/RAN_Emulation.ttcnpp 1 file changed, 83 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/67/38567/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38567?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6a00a425ce52cb0c71b03b545207f27befa11a71 Gerrit-Change-Number: 38567 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de>

7 months, 4 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Set sccp_addr parameters during init

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38564?usp=email ) Change subject: hnbgw: Set sccp_addr parameters during init ...................................................................... hnbgw: Set sccp_addr parameters during init Those will be needed by other tests using UNITDATA primitives to send RANAP ResetResourceAck. Change-Id: I53f7e2e0a4622bb25667053b0b80e743e5f493bd --- M hnbgw/ConnHdlr.ttcn M hnbgw/HNBGW_Tests.ttcn 2 files changed, 5 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/64/38564/1 diff --git a/hnbgw/ConnHdlr.ttcn b/hnbgw/ConnHdlr.ttcn index 93875bd..a99aa03 100644 --- a/hnbgw/ConnHdlr.ttcn +++ b/hnbgw/ConnHdlr.ttcn @@ -164,7 +164,8 @@ integer tx_sccp_cr_data_len, charstring pfcp_local_addr, octetstring nas_pdu optional, - /* local and remote SCCP addresses, used in TC_mscpool_paging_* */ + /* local and remote SCCP addresses, used to transmit conectionless + * (unitdata) messages: */ SCCP_PAR_Address sccp_addr_msc optional, SCCP_PAR_Address sccp_addr_hnbgw optional, /* RAB release cause */ diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index ed4ebda..f7346a9 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -509,7 +509,7 @@ integer tx_sccp_cr_data_len := 0, integer cn_nr := 0, template (value) RANAP_IEs.Cause rab_rel_cause := ts_RanapCause_nas_normal) -return TestHdlrParams { + runs on test_CT return TestHdlrParams { var template (value) TestHdlrParams pars; pars := t_pars(imsi_suffix, ps_domain := ps_domain, @@ -519,6 +519,8 @@ pfcp_local_addr := mp_pfcp_ip_local, rab_rel_cause := rab_rel_cause, hnbgw_timer_x31 := mp_hnbgw_timer_x31); + pars.sccp_addr_hnbgw := g_cn[valueof(pars.cn_idx)].sccp_addr_peer; + pars.sccp_addr_msc := g_cn[valueof(pars.cn_idx)].sccp_addr_own; return valueof(pars); } @@ -2084,8 +2086,6 @@ var ConnHdlr vc_conn1; var template (value) TestHdlrParams pars1 := f_TestHdlrParams(0, ps_domain := ps_domain, cn_nr := 0); - pars1.sccp_addr_hnbgw := g_cn[valueof(pars1.cn_idx)].sccp_addr_peer; - pars1.sccp_addr_msc := g_cn[valueof(pars1.cn_idx)].sccp_addr_own; vc_conn1 := f_start_handler_with_pars(refers(f_tc_mscpool_paging_imsi), pars1); vc_conn1.done; f_ctrs_cn_expect(0, "cnpool:subscr:paged"); @@ -2137,8 +2137,6 @@ var ConnHdlr vc_conn1; var template (value) TestHdlrParams pars1 := f_TestHdlrParams(0, ps_domain := ps_domain, cn_nr := 0); - pars1.sccp_addr_hnbgw := g_cn[valueof(pars1.cn_idx)].sccp_addr_peer; - pars1.sccp_addr_msc := g_cn[valueof(pars1.cn_idx)].sccp_addr_own; vc_conn1 := f_start_handler_with_pars(refers(f_tc_mscpool_paging_tmsi), pars1); vc_conn1.done; f_ctrs_cn_expect(0, "cnpool:subscr:paged"); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38564?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I53f7e2e0a4622bb25667053b0b80e743e5f493bd Gerrit-Change-Number: 38564 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 4 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: RANAP_Templates: Add templates for ResetResource(Ack)

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38566?usp=email ) Change subject: RANAP_Templates: Add templates for ResetResource(Ack) ...................................................................... RANAP_Templates: Add templates for ResetResource(Ack) Change-Id: If6357c19b39ef63057a2d8d471975185f0161b22 --- M library/ranap/RANAP_Templates.ttcn 1 file changed, 96 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/66/38566/1 diff --git a/library/ranap/RANAP_Templates.ttcn b/library/ranap/RANAP_Templates.ttcn index 5cd9353..3f9c497 100644 --- a/library/ranap/RANAP_Templates.ttcn +++ b/library/ranap/RANAP_Templates.ttcn @@ -123,6 +123,102 @@ } /***************************************************************************************************** + * Reset Resource + *****************************************************************************************************/ + +template (present) RANAP_PDU +tr_RANAP_ResetResource(template (present) CN_DomainIndicator dom := ?, + template (present) Cause cause := ?, + template (present) IuSignallingConnectionIdentifier sigc_id := ?, + template ResetResource.protocolExtensions exts := *) := { + initiatingMessage := { + procedureCode := id_ResetResource, + criticality := reject, + value_ := { + resetResource := { + protocolIEs := { + { + id := id_CN_DomainIndicator, + criticality := reject, + value_ := { + cN_DomainIndicator := dom + } + },{ + id := id_Cause, + criticality := ignore, + value_ := { + cause := cause + } + },{ + id := id_IuSigConIdList, + criticality := ignore, + value_ := { + resetResourceList := { + { + { + id := id_IuSigConIdItem, + criticality := reject, + value_ := { + resetResourceItem := { + iuSigConId := sigc_id, + iE_Extensions := omit + } + } + } + } + } + } + }, * + }, + protocolExtensions := exts + } + } + } +} + +template (value) RANAP_PDU +ts_RANAP_ResetResourceAck(template (value) CN_DomainIndicator dom, + template (value) IuSignallingConnectionIdentifier sigc_id) := { + successfulOutcome := { + procedureCode := id_ResetResource, + criticality := reject, + value_ := { + resetResourceAcknowledge := { + protocolIEs := { + { + id := id_CN_DomainIndicator, + criticality := reject, + value_ := { + cN_DomainIndicator := dom + } + },{ + id := id_IuSigConIdList, + criticality := ignore, + value_ := { + resetResourceAckList := { + { + { + id := id_IuSigConIdItem, + criticality := reject, + value_ := { + resetResourceAckItem := { + iuSigConId := sigc_id, + iE_Extensions := omit + } + } + } + } + } + } + } + }, + protocolExtensions := omit + } + } + } +} + +/***************************************************************************************************** * Security Mode Control *****************************************************************************************************/ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38566?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If6357c19b39ef63057a2d8d471975185f0161b22 Gerrit-Change-Number: 38566 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 4 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: RAN_Emulation: Support registering IuSigConId for connectionless RANA...

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38567?usp=email ) Change subject: RAN_Emulation: Support registering IuSigConId for connectionless RANAP messages ...................................................................... RAN_Emulation: Support registering IuSigConId for connectionless RANAP messages This allows dispatching received RANAP connectionless (UNITDATA) messages which target potentially existing connections identified by IuSigConId, like RANAP Reset Resource (Ack) messages. Dispatching it to relevant ConnHdlrs allows explicitly waiting to receive the message and answer from there. Change-Id: I6a00a425ce52cb0c71b03b545207f27befa11a71 --- M library/RAN_Emulation.ttcnpp 1 file changed, 83 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/67/38567/1 diff --git a/library/RAN_Emulation.ttcnpp b/library/RAN_Emulation.ttcnpp index d1edcff..3fed7e9 100644 --- a/library/RAN_Emulation.ttcnpp +++ b/library/RAN_Emulation.ttcnpp @@ -57,6 +57,7 @@ #ifdef RAN_EMULATION_RANAP import from RANAP_CodecPort all; import from RANAP_PDU_Descriptions all; +import from RANAP_PDU_Contents all; import from RANAP_Constants all; import from RANAP_IEs all; import from RANAP_Templates all; @@ -239,6 +240,13 @@ OCT4 tmsi } +#ifdef RAN_EMULATION_RANAP +type record IuSigConIdMapping { + RAN_ConnHdlr comp_ref, + IuSignallingConnectionIdentifier sigc_id optional +} +#endif + type component RAN_Emulation_CT { /* SCCP ports on the bottom side, using ASP primitives */ #ifdef RAN_EMULATION_BSSAP @@ -246,6 +254,8 @@ #endif #ifdef RAN_EMULATION_RANAP port RANAP_CODEC_PT RANAP; + /* tables for mapping inbound unitdata (like Reset Resource) */ + var IuSigConIdMapping IuSigConIdTable[16]; #endif /* BSSAP port to the per-connection clients */ port RAN_Conn_PT CLIENT; @@ -427,6 +437,12 @@ ImsiTable[i].imsi := omit; ImsiTable[i].tmsi := 'FFFFFFFF'O; } +#ifdef RAN_EMULATION_RANAP + for (var integer i := 0; i < sizeof(IuSigConIdTable); i := i+1) { + IuSigConIdTable[i].comp_ref := null; + IuSigConIdTable[i].sigc_id := omit; + } +#endif } private function f_conn_table_add(RAN_ConnHdlr comp_ref, integer sccp_conn_id) @@ -711,8 +727,22 @@ return omit; } log("CommonRanapUnitdataCallback: IMSI/TMSI not found in table"); - } else { - log("CommonRanapUnitdataCallback: Not a paging message"); + } else if (match(ranap, tr_RANAP_ResetResource(?, ?, ?))) { + /* extract IuSigConId */ + if (lengthof(ranap.initiatingMessage.value_.resetResource.protocolIEs) > 2 and + ranap.initiatingMessage.value_.resetResource.protocolIEs[2].id == id_IuSigConIdList) { + var RANAP_PDU_Contents.ResetResourceList res_li := ranap.initiatingMessage.value_.resetResource.protocolIEs[2].value_.resetResourceList; + for (var integer i := 0; i < lengthof(res_li); i := i + 1) { + var IuSignallingConnectionIdentifier sigc_id sigc_id := res_li[i][0].value_.resetResourceItem.iuSigConId; + var RAN_ConnHdlr client := null; + log("CommonRanapUnitdataCallback: Lookup IuSigConId", sigc_id); + client := f_IuSigConId_table_find(sigc_id); + if (client != null) { + log("CommonRanapUnitdataCallback: IuSigConId found in table, dispatching to ", client); + CLIENT.send(ranap) to client; + } + } + } } /* ELSE: handle in user callback */ @@ -1284,6 +1314,9 @@ var hexstring imsi; var OCT4 tmsi; var integer targetPointCode; +#ifdef RAN_EMULATION_RANAP + var IuSignallingConnectionIdentifier sigc_id +#endif alt { [g_ran_ops.protocol == RAN_PROTOCOL_BSSAP] as_main_bssap(); @@ -1333,8 +1366,13 @@ f_destroy_imsi(imsi, vc_hdlr); PROC.reply(RAN_unregister_imsi:{imsi, vc_hdlr}) to vc_hdlr; } - +#ifdef RAN_EMULATION_RANAP + [] PROC.getcall(RAN_register_IuSigConId:{?,?}) -> param(sigc_id, vc_hdlr) { + f_create_IuSigConId(sigc_id, vc_hdlr); + PROC.reply(RAN_register_IuSigConId:{sigc_id, vc_hdlr}) to vc_hdlr; + } } +#endif } } @@ -1377,7 +1415,11 @@ type port RAN_PROC_PT procedure { inout RAN_register, RAN_register_imsi, RAN_unregister_imsi, RAN_register_n_connect, - RAN_register_sccp_cr_without_payload, RAN_last_n_sd, RAN_continue_after_n_sd; + RAN_register_sccp_cr_without_payload, RAN_last_n_sd, RAN_continue_after_n_sd +#ifdef RAN_EMULATION_RANAP + , RAN_register_IuSigConId +#endif + ; } with { extension "internal" }; #ifdef RAN_EMULATION_BSSAP @@ -1444,6 +1486,11 @@ #endif #ifdef RAN_EMULATION_RANAP + +/* procedure based port to register for incoming unitdata based on Iu Signalling + * Connection Identifier, useful to eg. catch RANAP Reset Resource */ +signature RAN_register_IuSigConId(in IuSignallingConnectionIdentifier sigc_id, in RAN_ConnHdlr hdlr); + /* CreateCallback that can be used as create_cb and will use the expectation table */ function RanapExpectedCreateCallback(RANAP_N_CONNECT_ind conn_ind, charstring id) runs on RAN_Emulation_CT return RAN_ConnHdlr { @@ -1482,6 +1529,30 @@ mtc.stop; return ret; } + +private function f_create_IuSigConId(IuSignallingConnectionIdentifier sigc_id, RAN_ConnHdlr hdlr) +runs on RAN_Emulation_CT { + for (var integer i := 0; i < sizeof(IuSigConIdTable); i := i+1) { + if (not ispresent(IuSigConIdTable[i].sigc_id)) { + IuSigConIdTable[i].sigc_id := sigc_id; + IuSigConIdTable[i].comp_ref := hdlr; + log("Created IuSigConId[", i, "] for ", sigc_id, " to be handled at ", hdlr); + return; + } + } + setverdict(fail, "No space left in IuSigConIdTable"); + mtc.stop; +} + +private function f_IuSigConId_table_find(IuSignallingConnectionIdentifier sigc_id) +runs on RAN_Emulation_CT return RAN_ConnHdlr { + for (var integer i := 0; i < sizeof(IuSigConIdTable); i := i+1) { + if (isvalue(IuSigConIdTable[i].sigc_id) and match(IuSigConIdTable[i].sigc_id, sigc_id)) { + return IuSigConIdTable[i].comp_ref; + } + } + return null; +} #endif private function f_create_expect(template octetstring l3, RAN_ConnHdlr hdlr, @@ -1593,6 +1664,14 @@ } #ifdef RAN_EMULATION_RANAP +/* helper function for clients to register their IMSI/TMSI */ +function f_ran_register_IuSigConId(IuSignallingConnectionIdentifier sigc_id) +runs on RAN_ConnHdlr { + BSSAP_PROC.call(RAN_register_IuSigConId:{sigc_id, self}) { + [] BSSAP_PROC.getreply(RAN_register_IuSigConId:{?,?}) {}; + } +} + /* expect a IuReleaseCommand; Confirm that; expect SCCP-level N-DISCONNET.ind */ altstep as_iu_release_compl_disc() runs on RAN_ConnHdlr { var RANAP_PDU ranap; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38567?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6a00a425ce52cb0c71b03b545207f27befa11a71 Gerrit-Change-Number: 38567 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 4 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hbngw: Store IuSigConid in ConnHdlr params

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38565?usp=email ) Change subject: hbngw: Store IuSigConid in ConnHdlr params ...................................................................... hbngw: Store IuSigConid in ConnHdlr params A follow-up patch will want to use the value to register it in order to get RANAP ResetResource messages. Change-Id: I7eb5716debcad8427c15341612d37152ca894e5a --- M hnbgw/ConnHdlr.ttcn 1 file changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/65/38565/1 diff --git a/hnbgw/ConnHdlr.ttcn b/hnbgw/ConnHdlr.ttcn index a99aa03..2a46bba 100644 --- a/hnbgw/ConnHdlr.ttcn +++ b/hnbgw/ConnHdlr.ttcn @@ -170,7 +170,8 @@ SCCP_PAR_Address sccp_addr_hnbgw optional, /* RAB release cause */ RANAP_IEs.Cause rab_rel_cause, - integer hnbgw_timer_x31 + integer hnbgw_timer_x31, + IuSignallingConnectionIdentifier sigc_id } template (value) TestHdlrParams @@ -196,7 +197,8 @@ sccp_addr_msc := omit, sccp_addr_hnbgw := omit, rab_rel_cause := rab_rel_cause, - hnbgw_timer_x31 := hnbgw_timer_x31 + hnbgw_timer_x31 := hnbgw_timer_x31, + sigc_id := int2bit(f_rnd_int(1000), 24) } @@ -393,7 +395,6 @@ sAC := int2oct(pars.hnb.sac, 2), iE_Extensions := omit } - var IuSignallingConnectionIdentifier sigc_id := int2bit(f_rnd_int(1000), 24); var GlobalRNC_ID grnc_id := { pLMNidentity := lai.pLMNidentity, rNC_ID := 2342 @@ -401,9 +402,9 @@ var template RANAP_PDU ret; if (pars.ps_domain) { var RANAP_IEs.RAC rac := '00'O; - ret := ts_RANAP_initialUE_PS(lai, rac, sai, nas, sigc_id, grnc_id); + ret := ts_RANAP_initialUE_PS(lai, rac, sai, nas, pars.sigc_id, grnc_id); } else { - ret := ts_RANAP_initialUE_CS(lai, sai, nas, sigc_id, grnc_id); + ret := ts_RANAP_initialUE_CS(lai, sai, nas, pars.sigc_id, grnc_id); } return valueof(ret); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38565?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7eb5716debcad8427c15341612d37152ca894e5a Gerrit-Change-Number: 38565 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 4 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: WIP: hnbgw: update test

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38568?usp=email ) Change subject: WIP: hnbgw: update test ...................................................................... WIP: hnbgw: update test Change-Id: I10065e506ac234a5e3b4203c493d76d9d9df6ffd --- M hnbgw/ConnHdlr.ttcn M hnbgw/HNBGW_Tests.ttcn 2 files changed, 18 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/68/38568/1 diff --git a/hnbgw/ConnHdlr.ttcn b/hnbgw/ConnHdlr.ttcn index 2a46bba..81fd615 100644 --- a/hnbgw/ConnHdlr.ttcn +++ b/hnbgw/ConnHdlr.ttcn @@ -235,6 +235,16 @@ } } +function f_ranap_domain_indicator() runs on ConnHdlr return RANAP_IEs.CN_DomainIndicator { + var RANAP_IEs.CN_DomainIndicator dom; + if (g_pars.ps_domain) { + dom := ps_domain; + } else { + dom := cs_domain; + } + return dom; +} + function f_bssap_expect(template (present) RANAP_PDU exp_rx) runs on ConnHdlr return RANAP_PDU { var RANAP_PDU rx; diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index f7346a9..7f5e967 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -226,7 +226,6 @@ } function MSC_UnitdataCallback(RANAP_PDU ranap) runs on RAN_Emulation_CT return template RANAP_PDU { - // TODO: Actually implement unitdata handling return omit; } @@ -1305,15 +1304,23 @@ /* SCCP Connect Req is answererd with Connect Refused: */ private function f_tc_ranap_creq_cref_ConnHdlr(charstring id, TestHdlrParams pars) runs on ConnHdlr { + var template (value) RANAP_PDU tx_ranap; f_init_handler(pars); + f_ran_register_IuSigConId(pars.sigc_id); + /* HNB -> MSC: InitialUE */ f_iuh2iu_connect(f_build_initial_ue(g_pars)); /* This triggers a tx of SCCP CREF CN -> HNBGW: */ BSSAP.send(ts_MSC_CONN_PRIM_DISC_REQ(sccp_par_reason_end_user_failure)); + + BSSAP.receive(tr_RANAP_ResetResource(f_ranap_domain_indicator(), { transmissionNetwork := 66 }, g_pars.sigc_id)); + tx_ranap := ts_RANAP_ResetResourceAck(f_ranap_domain_indicator(), g_pars.sigc_id); + BSSAP.send(ts_RANAP_UNITDATA_req(pars.sccp_addr_hnbgw, pars.sccp_addr_msc, tx_ranap)); /* HNBGW disconnects the session on the RUA side as a result: */ RUA.receive(RUA_Disc_Ind:?); + f_sleep(10.0); } private function f_tc_ranap_creq_cref(integer imsi_suffix, boolean ps_domain) runs on test_CT { var ConnHdlr vc_conn; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38568?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I10065e506ac234a5e3b4203c493d76d9d9df6ffd Gerrit-Change-Number: 38568 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 4 weeks

1
0
0 0

[L] Change in osmo-bts[master]: CSD: implement half-rate modes correctly

by falconia

Attention is currently required from: fixeria, pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/38553?usp=email ) Change subject: CSD: implement half-rate modes correctly ...................................................................... Patch Set 4: (1 comment) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/38553/comment/01f11b95_e3f9cbea?usp… : PS2, Line 2098: switch (lchan->tch_mode) { > > the only valid modes are 6.0k and 3.6k raw rates, and my code does OSMO_ASSERT on all others. […] Please see the new patch iteration: I implemented your approach, although I found it simpler to do the assert check on `bits_per_20ms` rather than on lchan type. Is it good enough now? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38553?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib35e910df263743cd243f51fb0bd6551ddfcf4c5 Gerrit-Change-Number: 38553 Gerrit-PatchSet: 4 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Oct 2024 17:38:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 4 weeks

1
0
0 0

[L] Change in osmo-bts[master]: CSD: implement half-rate modes correctly

by falconia

Attention is currently required from: falconia, fixeria, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/38553?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: CSD: implement half-rate modes correctly ...................................................................... CSD: implement half-rate modes correctly TCH/H4.8 and TCH/H2.4 modes are different from all other TCH in that the channel coder runs (statistically) every 40 ms instead of the usual 20 ms. However, the standard RTP interface of TS 48.103 still requires 20 ms packets for all CSD modes; furtherfore, this requirement is not just a matter of 3GPP spec being obstinent, but is highly useful for interoperability, both between FR and HR and between OsmoBTS and E1 BTS. The handling of CSD HR was totally broken in this regard: wrong RA2 packing mode, RTP clock model was violated, and even an internal mismatch with l1sap sending TCH.req prims at twice the rate at which the PHY expects them. With this patch CSD HR handling becomes correct for TCH/H2.4 and for TCH/H4.8 transparent; fully correct handling for TCH/H4.8 NT will appear in a follow-up patch. The packet/frame rate mismatch (40 ms Rx/Tx times while each RTP packet carries 20 ms worth of data) is reconciled by emitting two RTP packets directly back-to-back for UL, and pulling two RTP packets at a time from the Rx jitter buffer at the needed times for DL. Note: due to bug OS#6604, TTCN3 tests for CSD half-rate transparent modes will start failing once this patch is merged; to make them pass again, TTCN3 test code will need to be reworked to fix that bug. Related: OS#6577 Change-Id: Ib35e910df263743cd243f51fb0bd6551ddfcf4c5 --- M include/osmo-bts/csd_v110.h M src/common/csd_v110.c M src/common/l1sap.c M src/osmo-bts-trx/sched_lchan_tchh.c M tests/csd/csd_test.c M tests/csd/csd_test.err 6 files changed, 248 insertions(+), 112 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/53/38553/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38553?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib35e910df263743cd243f51fb0bd6551ddfcf4c5 Gerrit-Change-Number: 38553 Gerrit-PatchSet: 4 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

7 months, 4 weeks

1
0
0 0

[S] Change in osmo-bts[master]: CSD RTP: verify alignment of V.110 frames

by falconia

Attention is currently required from: falconia. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/38555?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: CSD RTP: verify alignment of V.110 frames ...................................................................... CSD RTP: verify alignment of V.110 frames Since the beginning of CSD implementation, OsmoBTS has operated with an implicit (unstated) policy that V.110 frames must be perfectly aligned within received clearmode RTP packets - a requirement which is NOT set anywhere in TS 48.103 or any of the other specs it references. This design policy is sensible from the standpoint of implementation complexity (both OsmoBTS and osmo_trau2rtp emit such perfectly aligned packets; if someone is building a gateway between an Osmocom GSM network and ISDN-style external networks, that gateway can act as the aligner), but it should be explicit rather than implicit. Check V.110 frame alignment in received clearmode RTP packets, and reject packets that fail this alignment check. Change-Id: Icd704dc7fa02e60074efc8a29ad7e42ebdf63783 --- M src/common/csd_v110.c 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/55/38555/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38555?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icd704dc7fa02e60074efc8a29ad7e42ebdf63783 Gerrit-Change-Number: 38555 Gerrit-PatchSet: 4 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org>

7 months, 4 weeks

1
0
0 0

[S] Change in osmo-bts[master]: csd_v110: set E2 bit correctly for TCH/[FH]4.8 NT

by falconia

Attention is currently required from: falconia, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/38554?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: csd_v110: set E2 bit correctly for TCH/[FH]4.8 NT ...................................................................... csd_v110: set E2 bit correctly for TCH/[FH]4.8 NT In all classic NT modes below 14.5 kbit/s, V.110 frame bits E2 and E3 are repurposed to indicate the alignment whereby a single 240-bit RLP frame is composed of 4 pseudo-V.110 frames in switching transport. (TS 48.020 section 15.1.) In the case of TCH/F9.6, setting both E2 and E3 is easy because all 4 pseudo-V.110 frames go out in the same clearmode RTP packet as a result of a single channel decoding operation. However, in the case of TCH/F4.8 there are two separate channel decoding operations producing two separate RTP packets 20 ms apart. Furthermore, GSM 05.03 section 3.4.1 specifies which TDMA frame positions hold which half of the RLP frame - therefore, the correct emission of bit E2 needs to be based on the TDMA frame number at which the block was received. A similar situation occurs with TCH/H4.8 NT: we receive a single block from the 05.03 decoder every 40 ms, containing a full RLP frame, but we emit it as two separate RTP packets, each carrying 20 ms worth of bits. These RTP packets also require correct setting of E2 bit. Related: OS#6579 Change-Id: I485af5e01ea87c1721a298a486cd344a17884200 --- M include/osmo-bts/csd_v110.h M src/common/csd_v110.c M src/common/l1sap.c M tests/csd/csd_test.c 4 files changed, 30 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/54/38554/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38554?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I485af5e01ea87c1721a298a486cd344a17884200 Gerrit-Change-Number: 38554 Gerrit-PatchSet: 4 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

7 months, 4 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2024