October 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: cosmetic: eliminate else-after-return in gsmtap_csd_rlp_process()
by falconia 28 Oct '24

28 Oct '24

Attention is currently required from: falconia. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/38558?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: cosmetic: eliminate else-after-return in gsmtap_csd_rlp_process() ...................................................................... cosmetic: eliminate else-after-return in gsmtap_csd_rlp_process() The code in this function used else-after-return constructs, which are now rejected by the linter for newly committed code. This function needs to be moved to a new source file, which will cause it to be treated as new code by the linter - hence fix this code style issue first. Change-Id: Ide00e819222bb0173eca42ee3714db7f7e1a6d1e --- M src/common/l1sap.c 1 file changed, 4 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/58/38558/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38558?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ide00e819222bb0173eca42ee3714db7f7e1a6d1e Gerrit-Change-Number: 38558 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org>

1 0

[S] Change in osmo-bts[master]: csd_v110_rtp_decode: preserve E2 & E3 bits for RLP alignment
by falconia 28 Oct '24

28 Oct '24

Attention is currently required from: falconia, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/38556?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: csd_v110_rtp_decode: preserve E2 & E3 bits for RLP alignment ...................................................................... csd_v110_rtp_decode: preserve E2 & E3 bits for RLP alignment Modify CSD RTP input path code so incoming bits E2 & E3 from V.110 frames reach the TCH-RTS.ind handler in l1sap. These bits will be used in the next patch to ensure proper alignment of DL RLP frames in non-transparent CSD modes. Related: OS#6579 Change-Id: I43b97caa6030b9401779998ca5dddc4cfe636e2f --- M include/osmo-bts/csd_v110.h M include/osmo-bts/msg_utils.h M src/common/csd_v110.c M src/common/l1sap.c M tests/csd/csd_test.c 5 files changed, 17 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/56/38556/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38556?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I43b97caa6030b9401779998ca5dddc4cfe636e2f Gerrit-Change-Number: 38556 Gerrit-PatchSet: 4 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-bts[master]: cosmetic: move gsmtap_csd_rlp_process() to csd_rlp.c
by falconia 28 Oct '24

28 Oct '24

Attention is currently required from: falconia. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/38559?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: cosmetic: move gsmtap_csd_rlp_process() to csd_rlp.c ...................................................................... cosmetic: move gsmtap_csd_rlp_process() to csd_rlp.c The next patch in the series will add code for alignment of downlink RLP frames in CSD NT modes; that code will go into new file csd_rlp.c. RLP GSMTAP code logically belongs in the same place - hence move it there in preparation. Change-Id: I824ce6614c8591cccc5f6bcdde767fe49d551378 --- M include/osmo-bts/Makefile.am A include/osmo-bts/csd_rlp.h M src/common/Makefile.am A src/common/csd_rlp.c M src/common/l1sap.c 5 files changed, 137 insertions(+), 76 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/59/38559/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38559?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I824ce6614c8591cccc5f6bcdde767fe49d551378 Gerrit-Change-Number: 38559 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org>

1 0

[XS] Change in osmo-msc[master]: Release BSS connection when CC transaction fails
by fixeria 28 Oct '24

28 Oct '24

Attention is currently required from: jolly, pespin. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/38513?usp=email ) Change subject: Release BSS connection when CC transaction fails ...................................................................... Patch Set 1: (2 comments) File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/38513/comment/c0c2dcb6_8bc2d073?usp… : PS1, Line 2640: return -EINVAL; shall we do something here? https://gerrit.osmocom.org/c/osmo-msc/+/38513/comment/01328342_665eadd3?usp… : PS1, Line 2645: return -EINVAL; shall we do something here? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38513?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Icb893d5c1ce4c77a29259ce66189576dcaa5a44a Gerrit-Change-Number: 38513 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Oct 2024 14:20:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-msc[master]: Indicate error and release BSS connection when SMS transaction fails
by fixeria 28 Oct '24

28 Oct '24

Attention is currently required from: jolly, pespin. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/38514?usp=email ) Change subject: Indicate error and release BSS connection when SMS transaction fails ...................................................................... Patch Set 3: (2 comments) File src/libmsc/gsm_04_11.c: https://gerrit.osmocom.org/c/osmo-msc/+/38514/comment/c4245291_2d92ec72?usp… : PS3, Line 1328: return -EINVAL; put `MSC_A_USE_CM_SERVICE_SMS` here? https://gerrit.osmocom.org/c/osmo-msc/+/38514/comment/e1e60e08_aedb0c17?usp… : PS3, Line 1341: LOG_TRANS(trans `trans` is `NULL` here! -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38514?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I82da9c283205c69b19ceb4ba40ac5aa7f37d159b Gerrit-Change-Number: 38514 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Oct 2024 14:03:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-msc[master]: Indicate error and release BSS connection when SMS transaction fails
by jolly 28 Oct '24

28 Oct '24

Attention is currently required from: fixeria, pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/38514?usp=email ) Change subject: Indicate error and release BSS connection when SMS transaction fails ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > This was not yet answered. […] This is something we cannot test, because the error cannot be triggered by the BSC end. (Maybe it is possible to overloading of gsm411_trans_init() for this test?) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38514?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I82da9c283205c69b19ceb4ba40ac5aa7f37d159b Gerrit-Change-Number: 38514 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Oct 2024 13:54:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN: BSSGP_ConnHdlr: GMM Service Request: optional expect an authent...
by laforge 28 Oct '24

28 Oct '24

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email ) Change subject: SGSN: BSSGP_ConnHdlr: GMM Service Request: optional expect an authentication ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Ok, I see your point. But what behavior is our goal here? […] we should test the specific behaviour we expect from our osmo-sgsn implementation. We don't aim to implement a generic SGSN test suite that will work with any third-party SGSN out-of-the-box. And if there are different scenarios, then ideally both (all) should be covered by creating/simulating each of them. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9ed08160bf5413e3a30d6e90eb947d4d799e1058 Gerrit-Change-Number: 38396 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 28 Oct 2024 13:54:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-msc[master]: Release BSS connection when CC transaction fails
by laforge 28 Oct '24

28 Oct '24

Attention is currently required from: jolly, pespin. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/38513?usp=email ) Change subject: Release BSS connection when CC transaction fails ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38513?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Icb893d5c1ce4c77a29259ce66189576dcaa5a44a Gerrit-Change-Number: 38513 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Oct 2024 13:51:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-e1-hardware[master]: doc: Update the icE1usb manual section about LEDs
by laforge 28 Oct '24

28 Oct '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/38560?usp=email ) Change subject: doc: Update the icE1usb manual section about LEDs ...................................................................... doc: Update the icE1usb manual section about LEDs Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: I557b416c336792db1e6e4ed9f544eceaf6ca9b79 --- M doc/manuals/chapters/icE1usb/firmware.adoc 1 file changed, 14 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/doc/manuals/chapters/icE1usb/firmware.adoc b/doc/manuals/chapters/icE1usb/firmware.adoc index 3b47206..3d094e4 100644 --- a/doc/manuals/chapters/icE1usb/firmware.adoc +++ b/doc/manuals/chapters/icE1usb/firmware.adoc @@ -138,16 +138,25 @@ [options="header"] |=== -|Color | Pattern | Meaning -|Green | Blinking (slow) | E1 Receiver attempting to align -|Green | On | E1 Receiver fully aligned +| Green LED | Yellow LED | Meaning +| Off | Off | Loss of Signal +| Blink | Off | Loss of Framing +| Blink | On | Loss of Framing, Receiving AIS +| On | Off | Aligned +| On | On | Aligned, Receiving RAI |=== - === Use of the Multi-Color RGB LED -FIXME: describe how it is used. +The led near the USB port is used to indicate general device status. +A blinking blue led indicates that the device is in bootloader mode. + +A slow breathing indicates that at least one of the two port is +active, communicating over USB. The color of the led then indicates +the E1 link status. If all links are without issues, it will be +green, but if at least one of the enabled port has an issue, +it will show up as red. === Firmware <-> USB Host Interface -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/38560?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I557b416c336792db1e6e4ed9f544eceaf6ca9b79 Gerrit-Change-Number: 38560 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-e1-hardware[master]: doc: Update the icE1usb manual section about LEDs
by laforge 28 Oct '24

28 Oct '24

Attention is currently required from: tnt. laforge has posted comments on this change by tnt. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/38560?usp=email ) Change subject: doc: Update the icE1usb manual section about LEDs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/38560?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I557b416c336792db1e6e4ed9f544eceaf6ca9b79 Gerrit-Change-Number: 38560 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Mon, 28 Oct 2024 13:50:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0