October 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ci[master]: jobs/ttcn3-testsuites{,-testenv}: add duration comments
by osmith 29 Oct '24

29 Oct '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/38571?usp=email ) Change subject: jobs/ttcn3-testsuites{,-testenv}: add duration comments ...................................................................... jobs/ttcn3-testsuites{,-testenv}: add duration comments Add the current "last duration" time from the jenkins jobs as comment, so we have a rough idea of how long these jobs take and can distribute them more evenly throughout the days. Even though the durations will change over time, this gives a good indicator of whether a job runs a few minutes or 1 or even 2 hours. Change-Id: Iee1af60f3f76663eb7af562821a825640d53ee1e --- M jobs/ttcn3-testsuites-testenv.yml M jobs/ttcn3-testsuites.yml 2 files changed, 103 insertions(+), 103 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/71/38571/1 diff --git a/jobs/ttcn3-testsuites-testenv.yml b/jobs/ttcn3-testsuites-testenv.yml index 726f6e8..79c7537 100644 --- a/jobs/ttcn3-testsuites-testenv.yml +++ b/jobs/ttcn3-testsuites-testenv.yml @@ -25,143 +25,143 @@ # --------------------------------------------- # Debian nightly # --------------------------------------------- - - ttcn3-hnbgw-test: + - ttcn3-hnbgw-test: # ~13 min testsuite: hnbgw args: -b osmocom:nightly -c all timer: H 03 * * * - - ttcn3-bsc-test: + - ttcn3-bsc-test: # ~96 min testsuite: bsc args: -b osmocom:nightly -c generic timer: H 04 * * * - - ttcn3-bsc-test-sccplite: + - ttcn3-bsc-test-sccplite: # ~76 min testsuite: bsc args: -b osmocom:nightly -c sccplite timer: H 04 * * * - - ttcn3-bsc-test-vamos: + - ttcn3-bsc-test-vamos: # ~4 min testsuite: bsc args: -b osmocom:nightly -c vamos timer: H 04 * * * - - ttcn3-pcu-test: + - ttcn3-pcu-test: # ~14 min testsuite: pcu args: -b osmocom:nightly -c generic timer: H 04 * * * - - ttcn3-pcu-test-sns: + - ttcn3-pcu-test-sns: # ~7 min testsuite: pcu args: -b osmocom:nightly -c sns timer: H 05 * * * - - ttcn3-hlr-test: + - ttcn3-hlr-test: # ~3 min testsuite: hlr args: -b osmocom:nightly timer: H 05 * * * - - ttcn3-mgw-test: + - ttcn3-mgw-test: # ~8 min testsuite: mgw args: -b osmocom:nightly timer: H 05 * * * - - ttcn3-sip-test: + - ttcn3-sip-test: # ~2 min testsuite: sip args: -b osmocom:nightly timer: H 05 * * * - - ttcn3-sgsn-test: + - ttcn3-sgsn-test: # ~15 min testsuite: sgsn args: -b osmocom:nightly -c generic timer: H 05 * * * - - ttcn3-sgsn-test-sns: + - ttcn3-sgsn-test-sns: # ~1 min testsuite: sgsn args: -b osmocom:nightly -c sns timer: H 05 * * * - - ttcn3-smlc-test: + - ttcn3-smlc-test: # ~2 min testsuite: smlc args: -b osmocom:nightly timer: H 06 * * * - - ttcn3-cbc-test: + - ttcn3-cbc-test: # ~6 min testsuite: cbc args: -b osmocom:nightly timer: H 06 * * * - - ttcn3-stp-test: + - ttcn3-stp-test: # ~10 min testsuite: stp args: -b osmocom:nightly timer: H 06 * * * - - ttcn3-hnodeb-test: + - ttcn3-hnodeb-test: # ~1 min testsuite: hnodeb args: -b osmocom:nightly timer: H 07 * * * - - ttcn3-dia2gsup-test: + - ttcn3-dia2gsup-test: # ~2 min testsuite: dia2gsup args: -b osmocom:nightly timer: H 07 * * * - - ttcn3-upf-test: + - ttcn3-upf-test: # ~1 min testsuite: upf args: -b osmocom:nightly timer: H 07 * * * - - ttcn3-hss-test-ogs: + - ttcn3-hss-test-ogs: # ~1 min testsuite: hss args: -b osmocom:nightly timer: H 07 * * * email: jenkins-notifications(a)lists.osmocom.org acetcom(a)gmail.com - - ttcn3-mme-test-ogs: + - ttcn3-mme-test-ogs: # ~2 min testsuite: mme args: -b osmocom:nightly timer: H 07 * * * email: jenkins-notifications(a)lists.osmocom.org acetcom(a)gmail.com - - ttcn3-pcrf-test-ogs: + - ttcn3-pcrf-test-ogs: # ~1 min testsuite: pcrf args: -b osmocom:nightly timer: H 07 * * * email: jenkins-notifications(a)lists.osmocom.org acetcom(a)gmail.com - - ttcn3-s1gw-test: + - ttcn3-s1gw-test: # ~2 min testsuite: s1gw args: -b osmocom:nightly timer: H 07 * * * - - ttcn3-ggsn-test: + - ttcn3-ggsn-test: # ~15 min testsuite: ggsn args: -b osmocom:nightly -c 'osmo_ggsn_*' timer: H 07 * * * - - ttcn3-ggsn-test-kernel: + - ttcn3-ggsn-test-kernel: # ~10 min testsuite: ggsn args: -b osmocom:nightly -c 'osmo_ggsn_v*_only' --debian-kernel timer: H 07 * * * - - ttcn3-ggsn-test-kernel-net-next: + - ttcn3-ggsn-test-kernel-net-next: # ~10 min testsuite: ggsn args: -b osmocom:nightly -c 'osmo_ggsn_v*_only' --custom-kernel kernel: net-next timer: H 07 * * * - - ttcn3-ggsn-test-kernel-torvalds: + - ttcn3-ggsn-test-kernel-torvalds: # ~10 min testsuite: ggsn args: -b osmocom:nightly -c 'osmo_ggsn_v*_only' --custom-kernel kernel: torvalds timer: H 07 * * * - - ttcn3-ggsn-test-ogs: + - ttcn3-ggsn-test-ogs: # ~10 min testsuite: ggsn args: -b osmocom:nightly -c open5gs timer: H 07 * * * email: jenkins-notifications(a)lists.osmocom.org acetcom(a)gmail.com - - ttcn3-pcap-client-test: + - ttcn3-pcap-client-test: # ~1 min testsuite: pcap-client args: -b osmocom:nightly timer: H 08 * * * @@ -169,116 +169,116 @@ # --------------------------------------------- # Debian latest # --------------------------------------------- - - ttcn3-pcu-test-latest: + - ttcn3-pcu-test-latest: # ~14 min testsuite: pcu args: -b osmocom:latest -c generic timer: H 08 * * * - - ttcn3-pcu-test-sns-latest: + - ttcn3-pcu-test-sns-latest: # ~8 min testsuite: pcu args: -b osmocom:latest -c sns timer: H 08 * * * - - ttcn3-hlr-test-latest: + - ttcn3-hlr-test-latest: # ~3 min testsuite: hlr args: -b osmocom:latest timer: H 08 * * * - - ttcn3-mgw-test-latest: + - ttcn3-mgw-test-latest: # ~8 min testsuite: mgw args: -b osmocom:latest timer: H 08 * * * - - ttcn3-sip-test-latest: + - ttcn3-sip-test-latest: # ~2 min testsuite: sip args: -b osmocom:latest timer: H 08 * * * - - ttcn3-sgsn-test-latest: + - ttcn3-sgsn-test-latest: # ~15 min testsuite: sgsn args: -b osmocom:latest -c generic timer: H 08 * * * - - ttcn3-sgsn-test-sns-latest: + - ttcn3-sgsn-test-sns-latest: # ~1 min testsuite: sgsn args: -b osmocom:latest -c sns timer: H 08 * * * - - ttcn3-smlc-test-latest: + - ttcn3-smlc-test-latest: # ~2 min testsuite: smlc args: -b osmocom:latest timer: H 09 * * * - - ttcn3-cbc-test-latest: + - ttcn3-cbc-test-latest: # ~6 min testsuite: cbc args: -b osmocom:latest timer: H 09 * * * - - ttcn3-stp-test-latest: + - ttcn3-stp-test-latest: # ~10 min testsuite: stp args: -b osmocom:latest timer: H 09 * * * - - ttcn3-hnbgw-test-latest: + - ttcn3-hnbgw-test-latest: # ~13 min testsuite: hnbgw args: -b osmocom:latest -c all timer: H 09 * * * - - ttcn3-hnodeb-test-latest: + - ttcn3-hnodeb-test-latest: # ~1 min testsuite: hnodeb args: -b osmocom:latest timer: H 10 * * * - - ttcn3-upf-test-latest: + - ttcn3-upf-test-latest: # ~1 min testsuite: upf args: -b osmocom:latest timer: H 10 * * * disabled: true - - ttcn3-s1gw-test-latest: + - ttcn3-s1gw-test-latest: # ~2 min testsuite: s1gw args: -b osmocom:latest timer: H 10 * * * disabled: true # disable until > 0.1.x release - - ttcn3-ggsn-test-latest: + - ttcn3-ggsn-test-latest: # ~15 min testsuite: ggsn args: -b osmocom:latest -c 'osmo_ggsn_*' timer: H 10 * * * - - ttcn3-ggsn-test-kernel-latest: + - ttcn3-ggsn-test-kernel-latest: # ~10 min testsuite: ggsn args: -b osmocom:latest -c 'osmo_ggsn_v*_only' --debian-kernel timer: H 10 * * * - - ttcn3-ggsn-test-kernel-latest-net-next: + - ttcn3-ggsn-test-kernel-latest-net-next: # ~10 min testsuite: ggsn args: -b osmocom:latest -c 'osmo_ggsn_v*_only' --custom-kernel kernel: net-next timer: H 10 * * * - - ttcn3-ggsn-test-kernel-latest-torvalds: + - ttcn3-ggsn-test-kernel-latest-torvalds: # ~10 min testsuite: ggsn args: -b osmocom:latest -c 'osmo_ggsn_v*_only' --custom-kernel kernel: torvalds timer: H 10 * * * - - ttcn3-bsc-test-latest: + - ttcn3-bsc-test-latest: # ~96 min testsuite: bsc args: -b osmocom:latest -c generic timer: H 11 * * * - - ttcn3-bsc-test-sccplite-latest: + - ttcn3-bsc-test-sccplite-latest: # ~76 min testsuite: bsc args: -b osmocom:latest -c sccplite timer: H 11 * * * - - ttcn3-bsc-test-vamos-latest: + - ttcn3-bsc-test-vamos-latest: # ~3 min testsuite: bsc args: -b osmocom:latest -c vamos timer: H 11 * * * - - ttcn3-pcap-client-test-latest: + - ttcn3-pcap-client-test-latest: # ~1 min testsuite: pcap-client args: -b osmocom:latest timer: H 11 * * * @@ -286,27 +286,27 @@ # --------------------------------------------- # Debian nightly + io_uring (OS#6357) # --------------------------------------------- - - ttcn3-mgw-test-io_uring: + - ttcn3-mgw-test-io_uring: # ~8 min testsuite: mgw args: -b osmocom:nightly --io-uring timer: H 11 * * * - - ttcn3-sgsn-test-io_uring: + - ttcn3-sgsn-test-io_uring: # ~15 min testsuite: sgsn args: -b osmocom:nightly --io-uring -c generic timer: H 11 * * * - - ttcn3-stp-test-io_uring: + - ttcn3-stp-test-io_uring: # ~10 min testsuite: stp args: -b osmocom:nightly --io-uring timer: H 11 * * * - - ttcn3-bsc-test-io_uring: + - ttcn3-bsc-test-io_uring: # ~96 min testsuite: bsc args: -b osmocom:nightly --io-uring -c generic timer: H 12 * * * - - ttcn3-hnbgw-test-io_uring: + - ttcn3-hnbgw-test-io_uring: # ~13 min testsuite: hnbgw args: -b osmocom:nightly --io-uring -c all timer: H 12 * * * @@ -314,72 +314,72 @@ # --------------------------------------------- # Debian nightly + asan (OS#5301) # --------------------------------------------- - - ttcn3-mgw-test-asan: + - ttcn3-mgw-test-asan: # ~8 min testsuite: mgw args: -b osmocom:nightly:asan timer: H 12 * * * - - ttcn3-hlr-test-asan: + - ttcn3-hlr-test-asan: # ~3 min testsuite: hlr args: -b osmocom:nightly:asan timer: H 12 * * * - - ttcn3-sip-test-asan: + - ttcn3-sip-test-asan: # ~2 min testsuite: sip args: -b osmocom:nightly:asan timer: H 12 * * * - - ttcn3-hnodeb-test-asan: + - ttcn3-hnodeb-test-asan: # ~1 min testsuite: hnodeb args: -b osmocom:nightly:asan timer: H 12 * * * - - ttcn3-smlc-test-asan: + - ttcn3-smlc-test-asan: # ~2 min testsuite: smlc args: -b osmocom:nightly:asan timer: H 12 * * * - - ttcn3-cbc-test-asan: + - ttcn3-cbc-test-asan: # ~6 min testsuite: cbc args: -b osmocom:nightly:asan timer: H 12 * * * - - ttcn3-sgsn-test-asan: + - ttcn3-sgsn-test-asan: # ~15 min testsuite: sgsn args: -b osmocom:nightly:asan -c generic timer: H 12 * * * - - ttcn3-ggsn-test-asan: + - ttcn3-ggsn-test-asan: # ~15 min testsuite: ggsn args: -b osmocom:nightly:asan -c 'osmo_ggsn_*' timer: H 12 * * * - - ttcn3-stp-test-asan: + - ttcn3-stp-test-asan: # ~10 min testsuite: stp args: -b osmocom:nightly:asan timer: H 13 * * * - - ttcn3-pcu-test-asan: + - ttcn3-pcu-test-asan: # ~14 min testsuite: pcu args: -b osmocom:nightly:asan -c generic timer: H 13 * * * - - ttcn3-pcu-test-sns-asan: + - ttcn3-pcu-test-sns-asan: # ~8 min testsuite: pcu args: -b osmocom:nightly:asan -c sns timer: H 13 * * * - - ttcn3-bsc-test-asan: + - ttcn3-bsc-test-asan: # ~96 min testsuite: bsc args: -b osmocom:nightly:asan -c generic timer: H 14 * * * - - ttcn3-pcap-client-test-asan: + - ttcn3-pcap-client-test-asan: # ~1 min testsuite: pcap-client args: -b osmocom:nightly:asan timer: H 14 * * * - - ttcn3-hnbgw-test-asan: + - ttcn3-hnbgw-test-asan: # ~13 min testsuite: hnbgw args: -b osmocom:nightly:asan -c all timer: H 12 * * * diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index df54b05..2dc0775 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -20,66 +20,66 @@ # timer: 10 per hour from 04:00 - 18:00, see jobs/README.adoc job-name: # debian nightly - order by time - - ttcn3-msc-test: + - ttcn3-msc-test: # ~35 min timer: H 03 * * * - - nplab-m3ua-test: + - nplab-m3ua-test: # ~1 min timer: H 04 * * * - - nplab-sua-test: + - nplab-sua-test: # ~1 min timer: H 04 * * * - - ttcn3-bts-test: + - ttcn3-bts-test: # ~135 min timer: H 05 * * * - - ttcn3-remsim-test: + - ttcn3-remsim-test: # ~6 min timer: H 05 * * * - - ttcn3-sccp-test: + - ttcn3-sccp-test: # ~2 min timer: H 06 * * * - - ttcn3-gbproxy-test: + - ttcn3-gbproxy-test: # ~15 min timer: H 06 * * * - - ttcn3-gbproxy-test-fr: + - ttcn3-gbproxy-test-fr: # ~26 min timer: H 06 * * * node: hdlc - - ttcn3-ns-test: + - ttcn3-ns-test: # ~7 min timer: H 06 * * * - - ttcn3-ns-test-sns: + - ttcn3-ns-test-sns: # ~3 min timer: H 06 * * * - - ttcn3-ns-test-fr: + - ttcn3-ns-test-fr: # ~10 min timer: H 06 * * * node: hdlc - - ttcn3-ns-test-sgsn-sns: + - ttcn3-ns-test-sgsn-sns: # ~ 1 min timer: H 06 * * * - - ttcn3-fr-test: + - ttcn3-fr-test: # ~ 10 min timer: H 07 * * * node: hdlc - - ttcn3-pgw-test: + - ttcn3-pgw-test: # ~7 min timer: H 07 * * * description: | Test open5gs-smfd + open5gs-upfd PGW main. email: jenkins-notifications(a)lists.osmocom.org acetcom(a)gmail.com - - ttcn3-epdg-test: + - ttcn3-epdg-test: # ~4 min timer: H 07 * * * # osmo-epdg requires OTP and kernel >= debian12: node: build4-deb12build-ansible - - ttcn3-asterisk-ims-ue-test: + - ttcn3-asterisk-ims-ue-test: # ~19 min timer: H 07 * * * # debian latest stable - - nplab-m3ua-test-latest: + - nplab-m3ua-test-latest: # ~1 min timer: H 07 * * * - - nplab-sua-test-latest: + - nplab-sua-test-latest: # ~1 min timer: H 08 * * * - - ttcn3-msc-test-latest: + - ttcn3-msc-test-latest: # ~35 min timer: H 08 * * * - - ttcn3-bts-test-latest: + - ttcn3-bts-test-latest: # ~135 min timer: H 08 * * * - - ttcn3-remsim-test-latest: + - ttcn3-remsim-test-latest: # ~6 min timer: H 09 * * * - - ttcn3-sccp-test-latest: + - ttcn3-sccp-test-latest: # ~2 min timer: H 09 * * * - - ttcn3-gbproxy-test-latest: + - ttcn3-gbproxy-test-latest: # ~15 min timer: H 09 * * * - - ttcn3-gbproxy-test-fr-latest: + - ttcn3-gbproxy-test-fr-latest: # ~23 min timer: H 09 * * * node: hdlc - - ttcn3-epdg-test-latest: + - ttcn3-epdg-test-latest: # ~5 min timer: H 07 * * * # osmo-epdg requires OTP and kernel >= debian12: node: build4-deb12build-ansible @@ -87,31 +87,31 @@ # Jobs below use uppercase TTCN3-$DISTRO, so they get listed separately from the ttcn3-* (debian) jobs # centos7 nightly - - TTCN3-centos7-pcap-client-test: + - TTCN3-centos7-pcap-client-test: # ~1 min timer: H 10 * * * # centos7 latest - - TTCN3-centos7-pcap-client-test-latest: + - TTCN3-centos7-pcap-client-test-latest: # ~1 min timer: H 10 * * * # With LIBOSMO_IO_BACKEND=IO_URING (OS#6357) - - ttcn3-msc-test-io_uring: + - ttcn3-msc-test-io_uring: # ~35 min timer: H 11 * * * - - ttcn3-gbproxy-test-io_uring: + - ttcn3-gbproxy-test-io_uring: # ~15 min timer: H 11 * * * - - ttcn3-bts-test-io_uring: + - ttcn3-bts-test-io_uring: # ~135 min timer: H 11 * * * # With sanitizer (OS#5301) - - ttcn3-bts-test-asan: + - ttcn3-bts-test-asan: # ~135 min timer: H 12 * * * - - ttcn3-gbproxy-test-asan: + - ttcn3-gbproxy-test-asan: # ~15 min timer: H 12 * * * - - ttcn3-msc-test-asan: + - ttcn3-msc-test-asan: # ~35 min timer: H 13 * * * - - ttcn3-remsim-test-asan: + - ttcn3-remsim-test-asan: # ~6 min timer: H 13 * * * - - ttcn3-sccp-test-asan: + - ttcn3-sccp-test-asan: # ~2 min timer: H 13 * * * -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38571?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iee1af60f3f76663eb7af562821a825640d53ee1e Gerrit-Change-Number: 38571 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in osmo-iuh[master]: ranap: Add API to encode Reset Resource into msgb
by pespin 29 Oct '24

29 Oct '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/38569?usp=email ) Change subject: ranap: Add API to encode Reset Resource into msgb ...................................................................... ranap: Add API to encode Reset Resource into msgb Related: SYS#6602 Change-Id: I5e7b647dee2887d9af7dc22bc9f46f499f676e01 --- M TODO-RELEASE M include/osmocom/ranap/ranap_msg_factory.h M src/ranap_msg_factory.c 3 files changed, 80 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/69/38569/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 0ed7189..a6b0779 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,3 +7,4 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line +libosmo-ranap add API ranap_new_msg_reset_resource() diff --git a/include/osmocom/ranap/ranap_msg_factory.h b/include/osmocom/ranap/ranap_msg_factory.h index 4b42d05..5ff2d54 100644 --- a/include/osmocom/ranap/ranap_msg_factory.h +++ b/include/osmocom/ranap/ranap_msg_factory.h @@ -66,3 +66,10 @@ /*! \brief generate RANAP RAB RELEASE REQUEST message */ struct msgb *ranap_new_msg_rab_rel_req(uint8_t rab_id, const RANAP_Cause_t *cause); + +/*! \brief generate RANAP INITIAL UE message */ +struct msgb *ranap_new_msg_reset_resource(int is_ps, + const RANAP_Cause_t *cause, + const uint32_t *conn_id_list, + unsigned int conn_id_list_len, + RANAP_GlobalRNC_ID_t *rnc_id); diff --git a/src/ranap_msg_factory.c b/src/ranap_msg_factory.c index 44b879f..f464214 100644 --- a/src/ranap_msg_factory.c +++ b/src/ranap_msg_factory.c @@ -965,3 +965,75 @@ return msg; } + +/*! \brief generate RANAP RAB RELEASE REQUEST message */ +struct msgb *ranap_new_msg_reset_resource(int is_ps, + const RANAP_Cause_t *cause, + const uint32_t *conn_id_list, + unsigned int conn_id_list_len, + RANAP_GlobalRNC_ID_t *rnc_id) +{ + RANAP_ResetResourceItemIEs_t item_ies; + RANAP_ResetResourceIEs_t ies; + RANAP_ResetResource_t out; + uint32_t ctxidbuf; + struct msgb *msg; + int rc; + + OSMO_ASSERT(conn_id_list); + OSMO_ASSERT(cause); + + memset(&item_ies, 0, sizeof(item_ies)); + memset(&ies, 0, sizeof(ies)); + memset(&out, 0, sizeof(out)); + + /* CN Domain Indicator */ + if (is_ps) + ies.cN_DomainIndicator = RANAP_CN_DomainIndicator_ps_domain; + else + ies.cN_DomainIndicator = RANAP_CN_DomainIndicator_cs_domain; + + /* Cause */ + memcpy(&ies.cause, cause, sizeof(ies.cause)); + + /* Reset Resource Item IEs */ + if (conn_id_list_len != 1) { + LOGP(DRANAP, LOGL_ERROR, "Encoding ResourceReset len %u != 1 not supported!\n", conn_id_list_len); + return NULL; + } + asn1_u24_to_bitstring(&item_ies.iuSigConIdItem.iuSigConId, &ctxidbuf, conn_id_list[0]); + + /* Encode items into the list: */ + rc = ranap_encode_resetresourceitemies(&ies.iuSigConIdList, &item_ies); + if (rc < 0) + return NULL; + + /* Global RNC-ID */ + if (rnc_id) { + ies.presenceMask = RESETIES_RANAP_GLOBALRNC_ID_PRESENT; + OCTET_STRING_noalloc(&ies.globalRNC_ID.pLMNidentity, + rnc_id->pLMNidentity.buf, + rnc_id->pLMNidentity.size); + ies.globalRNC_ID.rNC_ID = rnc_id->rNC_ID; + } + + /* encode the list IEs into the output */ + rc = ranap_encode_resetresourceies(&out, &ies); + + /* 'out' has been generated, we can release the input */ + ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_RANAP_ResetResourceList, &ies.iuSigConIdList); + + if (rc < 0) { + LOGP(DRANAP, LOGL_ERROR, "error encoding release request IEs: %d\n", rc); + return NULL; + } + + /* encode the output into the msgb */ + msg = ranap_generate_initiating_message(RANAP_ProcedureCode_id_ResetResource, + RANAP_Criticality_reject, + &asn_DEF_RANAP_ResetResource, &out); + + ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_RANAP_ResetResource, &out); + + return msg; +} -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38569?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I5e7b647dee2887d9af7dc22bc9f46f499f676e01 Gerrit-Change-Number: 38569 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: RAN_Emulation: Support registering IuSigConId for connectionless RANA...
by pespin 29 Oct '24

29 Oct '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38567?usp=email ) Change subject: RAN_Emulation: Support registering IuSigConId for connectionless RANAP messages ...................................................................... RAN_Emulation: Support registering IuSigConId for connectionless RANAP messages This allows dispatching received RANAP connectionless (UNITDATA) messages which target potentially existing connections identified by IuSigConId, like RANAP Reset Resource (Ack) messages. Dispatching it to relevant ConnHdlrs allows explicitly waiting to receive the message and answer from there. Change-Id: I6a00a425ce52cb0c71b03b545207f27befa11a71 --- M library/RAN_Emulation.ttcnpp 1 file changed, 83 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/library/RAN_Emulation.ttcnpp b/library/RAN_Emulation.ttcnpp index d1edcff..9f942f3 100644 --- a/library/RAN_Emulation.ttcnpp +++ b/library/RAN_Emulation.ttcnpp @@ -57,6 +57,7 @@ #ifdef RAN_EMULATION_RANAP import from RANAP_CodecPort all; import from RANAP_PDU_Descriptions all; +import from RANAP_PDU_Contents all; import from RANAP_Constants all; import from RANAP_IEs all; import from RANAP_Templates all; @@ -239,6 +240,13 @@ OCT4 tmsi } +#ifdef RAN_EMULATION_RANAP +type record IuSigConIdMapping { + RAN_ConnHdlr comp_ref, + IuSignallingConnectionIdentifier sigc_id optional +} +#endif + type component RAN_Emulation_CT { /* SCCP ports on the bottom side, using ASP primitives */ #ifdef RAN_EMULATION_BSSAP @@ -246,6 +254,8 @@ #endif #ifdef RAN_EMULATION_RANAP port RANAP_CODEC_PT RANAP; + /* tables for mapping inbound unitdata (like Reset Resource) */ + var IuSigConIdMapping IuSigConIdTable[16]; #endif /* BSSAP port to the per-connection clients */ port RAN_Conn_PT CLIENT; @@ -427,6 +437,12 @@ ImsiTable[i].imsi := omit; ImsiTable[i].tmsi := 'FFFFFFFF'O; } +#ifdef RAN_EMULATION_RANAP + for (var integer i := 0; i < sizeof(IuSigConIdTable); i := i+1) { + IuSigConIdTable[i].comp_ref := null; + IuSigConIdTable[i].sigc_id := omit; + } +#endif } private function f_conn_table_add(RAN_ConnHdlr comp_ref, integer sccp_conn_id) @@ -711,8 +727,22 @@ return omit; } log("CommonRanapUnitdataCallback: IMSI/TMSI not found in table"); - } else { - log("CommonRanapUnitdataCallback: Not a paging message"); + } else if (match(ranap, tr_RANAP_ResetResource(?, ?, ?))) { + /* extract IuSigConId */ + if (lengthof(ranap.initiatingMessage.value_.resetResource.protocolIEs) > 2 and + ranap.initiatingMessage.value_.resetResource.protocolIEs[2].id == id_IuSigConIdList) { + var RANAP_PDU_Contents.ResetResourceList res_li := ranap.initiatingMessage.value_.resetResource.protocolIEs[2].value_.resetResourceList; + for (var integer i := 0; i < lengthof(res_li); i := i + 1) { + var IuSignallingConnectionIdentifier sigc_id sigc_id := res_li[i][0].value_.resetResourceItem.iuSigConId; + var RAN_ConnHdlr client := null; + log("CommonRanapUnitdataCallback: Lookup IuSigConId", sigc_id); + client := f_IuSigConId_table_find(sigc_id); + if (client != null) { + log("CommonRanapUnitdataCallback: IuSigConId found in table, dispatching to ", client); + CLIENT.send(ranap) to client; + } + } + } } /* ELSE: handle in user callback */ @@ -1284,6 +1314,9 @@ var hexstring imsi; var OCT4 tmsi; var integer targetPointCode; +#ifdef RAN_EMULATION_RANAP + var IuSignallingConnectionIdentifier sigc_id; +#endif alt { [g_ran_ops.protocol == RAN_PROTOCOL_BSSAP] as_main_bssap(); @@ -1333,7 +1366,12 @@ f_destroy_imsi(imsi, vc_hdlr); PROC.reply(RAN_unregister_imsi:{imsi, vc_hdlr}) to vc_hdlr; } - +#ifdef RAN_EMULATION_RANAP + [] PROC.getcall(RAN_register_IuSigConId:{?,?}) -> param(sigc_id, vc_hdlr) { + f_create_IuSigConId(sigc_id, vc_hdlr); + PROC.reply(RAN_register_IuSigConId:{sigc_id, vc_hdlr}) to vc_hdlr; + } +#endif } } } @@ -1377,7 +1415,11 @@ type port RAN_PROC_PT procedure { inout RAN_register, RAN_register_imsi, RAN_unregister_imsi, RAN_register_n_connect, - RAN_register_sccp_cr_without_payload, RAN_last_n_sd, RAN_continue_after_n_sd; + RAN_register_sccp_cr_without_payload, RAN_last_n_sd, RAN_continue_after_n_sd +#ifdef RAN_EMULATION_RANAP + , RAN_register_IuSigConId +#endif + ; } with { extension "internal" }; #ifdef RAN_EMULATION_BSSAP @@ -1444,6 +1486,11 @@ #endif #ifdef RAN_EMULATION_RANAP + +/* procedure based port to register for incoming unitdata based on Iu Signalling + * Connection Identifier, useful to eg. catch RANAP Reset Resource */ +signature RAN_register_IuSigConId(in IuSignallingConnectionIdentifier sigc_id, in RAN_ConnHdlr hdlr); + /* CreateCallback that can be used as create_cb and will use the expectation table */ function RanapExpectedCreateCallback(RANAP_N_CONNECT_ind conn_ind, charstring id) runs on RAN_Emulation_CT return RAN_ConnHdlr { @@ -1482,6 +1529,30 @@ mtc.stop; return ret; } + +private function f_create_IuSigConId(IuSignallingConnectionIdentifier sigc_id, RAN_ConnHdlr hdlr) +runs on RAN_Emulation_CT { + for (var integer i := 0; i < sizeof(IuSigConIdTable); i := i+1) { + if (not ispresent(IuSigConIdTable[i].sigc_id)) { + IuSigConIdTable[i].sigc_id := sigc_id; + IuSigConIdTable[i].comp_ref := hdlr; + log("Created IuSigConId[", i, "] for ", sigc_id, " to be handled at ", hdlr); + return; + } + } + setverdict(fail, "No space left in IuSigConIdTable"); + mtc.stop; +} + +private function f_IuSigConId_table_find(IuSignallingConnectionIdentifier sigc_id) +runs on RAN_Emulation_CT return RAN_ConnHdlr { + for (var integer i := 0; i < sizeof(IuSigConIdTable); i := i+1) { + if (isvalue(IuSigConIdTable[i].sigc_id) and match(IuSigConIdTable[i].sigc_id, sigc_id)) { + return IuSigConIdTable[i].comp_ref; + } + } + return null; +} #endif private function f_create_expect(template octetstring l3, RAN_ConnHdlr hdlr, @@ -1593,6 +1664,14 @@ } #ifdef RAN_EMULATION_RANAP +/* helper function for clients to register their IMSI/TMSI */ +function f_ran_register_IuSigConId(IuSignallingConnectionIdentifier sigc_id) +runs on RAN_ConnHdlr { + BSSAP_PROC.call(RAN_register_IuSigConId:{sigc_id, self}) { + [] BSSAP_PROC.getreply(RAN_register_IuSigConId:{?,?}) {}; + } +} + /* expect a IuReleaseCommand; Confirm that; expect SCCP-level N-DISCONNET.ind */ altstep as_iu_release_compl_disc() runs on RAN_ConnHdlr { var RANAP_PDU ranap; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38567?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6a00a425ce52cb0c71b03b545207f27befa11a71 Gerrit-Change-Number: 38567 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: RAN_Emulation: Support registering IuSigConId for connectionless RANA...
by pespin 29 Oct '24

29 Oct '24

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38567?usp=email ) Change subject: RAN_Emulation: Support registering IuSigConId for connectionless RANAP messages ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38567?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6a00a425ce52cb0c71b03b545207f27befa11a71 Gerrit-Change-Number: 38567 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Oct 2024 12:03:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: hbngw: Store IuSigConid in ConnHdlr params
by pespin 29 Oct '24

29 Oct '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38565?usp=email ) Change subject: hbngw: Store IuSigConid in ConnHdlr params ...................................................................... hbngw: Store IuSigConid in ConnHdlr params A follow-up patch will want to use the value to register it in order to get RANAP ResetResource messages. Change-Id: I7eb5716debcad8427c15341612d37152ca894e5a --- M hnbgw/ConnHdlr.ttcn 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/hnbgw/ConnHdlr.ttcn b/hnbgw/ConnHdlr.ttcn index a99aa03..2a46bba 100644 --- a/hnbgw/ConnHdlr.ttcn +++ b/hnbgw/ConnHdlr.ttcn @@ -170,7 +170,8 @@ SCCP_PAR_Address sccp_addr_hnbgw optional, /* RAB release cause */ RANAP_IEs.Cause rab_rel_cause, - integer hnbgw_timer_x31 + integer hnbgw_timer_x31, + IuSignallingConnectionIdentifier sigc_id } template (value) TestHdlrParams @@ -196,7 +197,8 @@ sccp_addr_msc := omit, sccp_addr_hnbgw := omit, rab_rel_cause := rab_rel_cause, - hnbgw_timer_x31 := hnbgw_timer_x31 + hnbgw_timer_x31 := hnbgw_timer_x31, + sigc_id := int2bit(f_rnd_int(1000), 24) } @@ -393,7 +395,6 @@ sAC := int2oct(pars.hnb.sac, 2), iE_Extensions := omit } - var IuSignallingConnectionIdentifier sigc_id := int2bit(f_rnd_int(1000), 24); var GlobalRNC_ID grnc_id := { pLMNidentity := lai.pLMNidentity, rNC_ID := 2342 @@ -401,9 +402,9 @@ var template RANAP_PDU ret; if (pars.ps_domain) { var RANAP_IEs.RAC rac := '00'O; - ret := ts_RANAP_initialUE_PS(lai, rac, sai, nas, sigc_id, grnc_id); + ret := ts_RANAP_initialUE_PS(lai, rac, sai, nas, pars.sigc_id, grnc_id); } else { - ret := ts_RANAP_initialUE_CS(lai, sai, nas, sigc_id, grnc_id); + ret := ts_RANAP_initialUE_CS(lai, sai, nas, pars.sigc_id, grnc_id); } return valueof(ret); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38565?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7eb5716debcad8427c15341612d37152ca894e5a Gerrit-Change-Number: 38565 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Set sccp_addr parameters during init
by pespin 29 Oct '24

29 Oct '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38564?usp=email ) Change subject: hnbgw: Set sccp_addr parameters during init ...................................................................... hnbgw: Set sccp_addr parameters during init Those will be needed by other tests using UNITDATA primitives to send RANAP ResetResourceAck. Change-Id: I53f7e2e0a4622bb25667053b0b80e743e5f493bd --- M hnbgw/ConnHdlr.ttcn M hnbgw/HNBGW_Tests.ttcn 2 files changed, 5 insertions(+), 6 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/hnbgw/ConnHdlr.ttcn b/hnbgw/ConnHdlr.ttcn index 93875bd..a99aa03 100644 --- a/hnbgw/ConnHdlr.ttcn +++ b/hnbgw/ConnHdlr.ttcn @@ -164,7 +164,8 @@ integer tx_sccp_cr_data_len, charstring pfcp_local_addr, octetstring nas_pdu optional, - /* local and remote SCCP addresses, used in TC_mscpool_paging_* */ + /* local and remote SCCP addresses, used to transmit conectionless + * (unitdata) messages: */ SCCP_PAR_Address sccp_addr_msc optional, SCCP_PAR_Address sccp_addr_hnbgw optional, /* RAB release cause */ diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index ed4ebda..f7346a9 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -509,7 +509,7 @@ integer tx_sccp_cr_data_len := 0, integer cn_nr := 0, template (value) RANAP_IEs.Cause rab_rel_cause := ts_RanapCause_nas_normal) -return TestHdlrParams { + runs on test_CT return TestHdlrParams { var template (value) TestHdlrParams pars; pars := t_pars(imsi_suffix, ps_domain := ps_domain, @@ -519,6 +519,8 @@ pfcp_local_addr := mp_pfcp_ip_local, rab_rel_cause := rab_rel_cause, hnbgw_timer_x31 := mp_hnbgw_timer_x31); + pars.sccp_addr_hnbgw := g_cn[valueof(pars.cn_idx)].sccp_addr_peer; + pars.sccp_addr_msc := g_cn[valueof(pars.cn_idx)].sccp_addr_own; return valueof(pars); } @@ -2084,8 +2086,6 @@ var ConnHdlr vc_conn1; var template (value) TestHdlrParams pars1 := f_TestHdlrParams(0, ps_domain := ps_domain, cn_nr := 0); - pars1.sccp_addr_hnbgw := g_cn[valueof(pars1.cn_idx)].sccp_addr_peer; - pars1.sccp_addr_msc := g_cn[valueof(pars1.cn_idx)].sccp_addr_own; vc_conn1 := f_start_handler_with_pars(refers(f_tc_mscpool_paging_imsi), pars1); vc_conn1.done; f_ctrs_cn_expect(0, "cnpool:subscr:paged"); @@ -2137,8 +2137,6 @@ var ConnHdlr vc_conn1; var template (value) TestHdlrParams pars1 := f_TestHdlrParams(0, ps_domain := ps_domain, cn_nr := 0); - pars1.sccp_addr_hnbgw := g_cn[valueof(pars1.cn_idx)].sccp_addr_peer; - pars1.sccp_addr_msc := g_cn[valueof(pars1.cn_idx)].sccp_addr_own; vc_conn1 := f_start_handler_with_pars(refers(f_tc_mscpool_paging_tmsi), pars1); vc_conn1.done; f_ctrs_cn_expect(0, "cnpool:subscr:paged"); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38564?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I53f7e2e0a4622bb25667053b0b80e743e5f493bd Gerrit-Change-Number: 38564 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: RANAP_Templates: Add templates for ResetResource(Ack)
by pespin 29 Oct '24

29 Oct '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38566?usp=email ) Change subject: RANAP_Templates: Add templates for ResetResource(Ack) ...................................................................... RANAP_Templates: Add templates for ResetResource(Ack) Change-Id: If6357c19b39ef63057a2d8d471975185f0161b22 --- M library/ranap/RANAP_Templates.ttcn 1 file changed, 96 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/library/ranap/RANAP_Templates.ttcn b/library/ranap/RANAP_Templates.ttcn index 5cd9353..3f9c497 100644 --- a/library/ranap/RANAP_Templates.ttcn +++ b/library/ranap/RANAP_Templates.ttcn @@ -123,6 +123,102 @@ } /***************************************************************************************************** + * Reset Resource + *****************************************************************************************************/ + +template (present) RANAP_PDU +tr_RANAP_ResetResource(template (present) CN_DomainIndicator dom := ?, + template (present) Cause cause := ?, + template (present) IuSignallingConnectionIdentifier sigc_id := ?, + template ResetResource.protocolExtensions exts := *) := { + initiatingMessage := { + procedureCode := id_ResetResource, + criticality := reject, + value_ := { + resetResource := { + protocolIEs := { + { + id := id_CN_DomainIndicator, + criticality := reject, + value_ := { + cN_DomainIndicator := dom + } + },{ + id := id_Cause, + criticality := ignore, + value_ := { + cause := cause + } + },{ + id := id_IuSigConIdList, + criticality := ignore, + value_ := { + resetResourceList := { + { + { + id := id_IuSigConIdItem, + criticality := reject, + value_ := { + resetResourceItem := { + iuSigConId := sigc_id, + iE_Extensions := omit + } + } + } + } + } + } + }, * + }, + protocolExtensions := exts + } + } + } +} + +template (value) RANAP_PDU +ts_RANAP_ResetResourceAck(template (value) CN_DomainIndicator dom, + template (value) IuSignallingConnectionIdentifier sigc_id) := { + successfulOutcome := { + procedureCode := id_ResetResource, + criticality := reject, + value_ := { + resetResourceAcknowledge := { + protocolIEs := { + { + id := id_CN_DomainIndicator, + criticality := reject, + value_ := { + cN_DomainIndicator := dom + } + },{ + id := id_IuSigConIdList, + criticality := ignore, + value_ := { + resetResourceAckList := { + { + { + id := id_IuSigConIdItem, + criticality := reject, + value_ := { + resetResourceAckItem := { + iuSigConId := sigc_id, + iE_Extensions := omit + } + } + } + } + } + } + } + }, + protocolExtensions := omit + } + } + } +} + +/***************************************************************************************************** * Security Mode Control *****************************************************************************************************/ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38566?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If6357c19b39ef63057a2d8d471975185f0161b22 Gerrit-Change-Number: 38566 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-hnbgw[master]: Log cn_disconnect.ind cause
by pespin 29 Oct '24

29 Oct '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38563?usp=email ) Change subject: Log cn_disconnect.ind cause ...................................................................... Log cn_disconnect.ind cause Change-Id: I64cd596e55b102924f39264cd2eae7a41f5f3212 --- M TODO-RELEASE M src/osmo-hnbgw/hnbgw_cn.c 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index 0ed7189..8cc6151 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,3 +7,4 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line +libosmo-sigtran >2.0.0 use API osmo_sua_sccp_cause_name() \ No newline at end of file diff --git a/src/osmo-hnbgw/hnbgw_cn.c b/src/osmo-hnbgw/hnbgw_cn.c index 6618fb9..b984a8e 100644 --- a/src/osmo-hnbgw/hnbgw_cn.c +++ b/src/osmo-hnbgw/hnbgw_cn.c @@ -33,6 +33,7 @@ #include <osmocom/gsm/gsm23236.h> #include <osmocom/sigtran/protocol/m3ua.h> +#include <osmocom/sigtran/protocol/sua.h> #include <osmocom/sigtran/sccp_sap.h> #include <osmocom/sigtran/sccp_helpers.h> @@ -508,14 +509,16 @@ struct osmo_prim_hdr *oph) { struct hnbgw_context_map *map; + char cause_buf[128]; map = map_from_conn_id(hsu, param->conn_id, oph); if (!map || !map->cnlink) return -ENOENT; - LOGP(DCN, LOGL_DEBUG, "handle_cn_disc_ind() conn_id=%u responding_addr=%s\n", + LOGP(DCN, LOGL_DEBUG, "handle_cn_disc_ind() conn_id=%u responding_addr=%s cause=%s\n", param->conn_id, - cnlink_sccp_addr_to_str(map->cnlink, &param->responding_addr)); + cnlink_sccp_addr_to_str(map->cnlink, &param->responding_addr), + osmo_sua_sccp_cause_name(param->cause, cause_buf, sizeof(cause_buf))); return map_sccp_dispatch(map, MAP_SCCP_EV_RX_RELEASED, oph->msg); } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38563?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I64cd596e55b102924f39264cd2eae7a41f5f3212 Gerrit-Change-Number: 38563 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: RAN_Emulation: Support registering IuSigConId for connectionless RANA...
by osmith 29 Oct '24

29 Oct '24

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38567?usp=email ) Change subject: RAN_Emulation: Support registering IuSigConId for connectionless RANAP messages ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38567?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6a00a425ce52cb0c71b03b545207f27befa11a71 Gerrit-Change-Number: 38567 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Oct 2024 11:35:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: RANAP_Templates: Add templates for ResetResource(Ack)
by osmith 29 Oct '24

29 Oct '24

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38566?usp=email ) Change subject: RANAP_Templates: Add templates for ResetResource(Ack) ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38566?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If6357c19b39ef63057a2d8d471975185f0161b22 Gerrit-Change-Number: 38566 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Oct 2024 11:30:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0