Attention is currently required from: fixeria, pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38573?usp=email )
Change subject: RUA_Emulation: Support passing no RANAP PDU in RUA_Disc_Req
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38573?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id9c3d5a1e45aa6ca58a71b61e142dc041a335cc9
Gerrit-Change-Number: 38573
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 30 Oct 2024 14:35:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/38570?usp=email )
Change subject: jobs/ttcn3-testsuites: remove bscnat-test{-latest}
......................................................................
jobs/ttcn3-testsuites: remove bscnat-test{-latest}
These testsuites have been disabled for > 3 years, and the related SUT
is not developed any further. Remove the entries to unclutter the list
for now, we could add them back later easily if it makes sense.
Change-Id: I727924227809c8133a852a4adbf82bcd6508bcf1
---
M jobs/ttcn3-testsuites.yml
1 file changed, 0 insertions(+), 6 deletions(-)
Approvals:
fixeria: Looks good to me, approved
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml
index 947d890..df54b05 100644
--- a/jobs/ttcn3-testsuites.yml
+++ b/jobs/ttcn3-testsuites.yml
@@ -28,9 +28,6 @@
timer: H 04 * * *
- ttcn3-bts-test:
timer: H 05 * * *
- - ttcn3-bscnat-test:
- timer: H 05 * * *
- disabled: true
- ttcn3-remsim-test:
timer: H 05 * * *
- ttcn3-sccp-test:
@@ -73,9 +70,6 @@
timer: H 08 * * *
- ttcn3-bts-test-latest:
timer: H 08 * * *
- - ttcn3-bscnat-test-latest:
- timer: H 09 * * *
- disabled: true
- ttcn3-remsim-test-latest:
timer: H 09 * * *
- ttcn3-sccp-test-latest:
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38570?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I727924227809c8133a852a4adbf82bcd6508bcf1
Gerrit-Change-Number: 38570
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38578?usp=email )
Change subject: library/s1ap: rework {ts,tr}_S1AP_RABSetupRsp templates
......................................................................
Patch Set 1:
(2 comments)
File library/s1ap/S1AP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38578/comment/def5edd7_7e90… :
PS1, Line 1287: template E_RABSetupResponse
I am not adding `(present)` restriction here because I need to do `rsp.protocolIEs[idx] := *` below. If I add it, the code does not compile (TITAN complains about violating template restrictions).
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38578/comment/4cd623a2_57ca… :
PS1, Line 1321: rsp.protocolIEs[idx] := *;
Sadly, we cannot use `superset` here because the `protocolIEs[]` is a `record of`, while `superset` wants a `set of`. Adding `*` at the end results in a template that matches at most those IEs that are preceding it (in fixed order) and ignores the remaining IEs (if any).
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38578?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic369ae720179483a19383af2bddf56186965eae3
Gerrit-Change-Number: 38578
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 29 Oct 2024 21:27:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38310?usp=email )
Change subject: s1gw: add TC_e_rab_setup_failure
......................................................................
Patch Set 3:
(1 comment)
This change is ready for review.
File s1gw/S1GW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38310/comment/fd516c8d_636e… :
PS1, Line 405: XXX: expect E-RAB SETUP RESPONSE here
> this needs to be addressed
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38310?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I97102292678e732265dcae04d60f7a708a5246dc
Gerrit-Change-Number: 38310
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 29 Oct 2024 21:16:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>