October 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: Get rid of pars param in void_fn
by pespin 30 Oct '24

30 Oct '24

Attention is currently required from: osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38575?usp=email ) Change subject: hnbgw: Get rid of pars param in void_fn ...................................................................... Patch Set 1: (1 comment) File hnbgw/HNBGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38575/comment/01a4ae72_5447… : PS1, Line 571: //vc_conn.start(derefers(fn)(id, pars)); > do you want to keep the commented out line? I'll remove it, thanks. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38575?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I674b2a6a6a0e39f2904f9125783180da8ade5f44 Gerrit-Change-Number: 38575 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Oct 2024 15:34:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_cs_iu_release_req_rua_disconnect
by pespin 30 Oct '24

30 Oct '24

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38576?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: hnbgw: Introduce test TC_cs_iu_release_req_rua_disconnect ...................................................................... hnbgw: Introduce test TC_cs_iu_release_req_rua_disconnect Related: SYS#6602 Change-Id: I6782920c4a86d3311eb54239ab13a18e393c1ec0 --- M hnbgw/HNBGW_Tests.ttcn M hnbgw/expected-results.xml M library/ranap/RANAP_Templates.ttcn 3 files changed, 56 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/76/38576/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38576?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6782920c4a86d3311eb54239ab13a18e393c1ec0 Gerrit-Change-Number: 38576 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-hnbgw[master]: Fix SCCP RLSD not sent upon rx RUA Disconnect due to error condition
by pespin 30 Oct '24

30 Oct '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38581?usp=email ) Change subject: Fix SCCP RLSD not sent upon rx RUA Disconnect due to error condition ...................................................................... Fix SCCP RLSD not sent upon rx RUA Disconnect due to error condition Scenario: HNB tears down the RUA/Iu conn by first sending RUA_DATA[RANAP IuReleaseReq], followed shortly by a RUA Disconnect with no RANAP and Cause!=Normal. HNBGW should release the SCCP connection through RLSD since it's impossible to terminate the Iu connection in a normal condition. Validated with TTCN-3 HNBGW_Tests.TC_cs_iu_release_req_rua_disconnect. Related: osmo-ttcn3-hacks.git Change-Id I6782920c4a86d3311eb54239ab13a18e393c1ec0 Related: SYS#6602 Change-Id: I1b7f72034eaf40bfa60d552d434847467ac4e97a --- M src/osmo-hnbgw/context_map_sccp.c 1 file changed, 15 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/81/38581/1 diff --git a/src/osmo-hnbgw/context_map_sccp.c b/src/osmo-hnbgw/context_map_sccp.c index 511577c..881d5ce 100644 --- a/src/osmo-hnbgw/context_map_sccp.c +++ b/src/osmo-hnbgw/context_map_sccp.c @@ -364,11 +364,21 @@ return; case MAP_SCCP_EV_RAN_DISC: - /* RUA has disconnected, and usually has sent an Iu-ReleaseComplete along with its RUA Disconnect. On - * SCCP, the Iu-ReleaseComplete should still be forwarded as N-Data (SCCP Data Form 1), and we will - * expect the CN to send an SCCP RLSD soon. */ - map_sccp_fsm_state_chg(MAP_SCCP_ST_WAIT_RLSD); - tx_sccp_df1(fi, ranap_msg); + /* 3GPP TS 25.468 9.1.5: RUA has disconnected. + * - Under normal conditions (cause=Normal) the RUA Disconnect contains a RANAP Iu-ReleaseComplete. + * On SCCP, the Iu-ReleaseComplete should still be forwarded as N-Data SCCP Data Form 1), + * and we will expect the CN to send an SCCP RLSD soon. + * - Under error conditions, cause!=Normal and the's no RANAP message. + * In that case, we need to tear down the associated SCCP link towards CN, + * which in turn will tear down the upper layer Iu conn. + */ + if (msg_has_l2_data(ranap_msg)) { + map_sccp_fsm_state_chg(MAP_SCCP_ST_WAIT_RLSD); + tx_sccp_df1(fi, ranap_msg); + } else { + tx_sccp_rlsd(fi); + map_sccp_fsm_state_chg(MAP_SCCP_ST_DISCONNECTED); + } return; case MAP_SCCP_EV_RAN_LINK_LOST: -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38581?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I1b7f72034eaf40bfa60d552d434847467ac4e97a Gerrit-Change-Number: 38581 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_cs_iu_release_req_rua_disconnect
by pespin 30 Oct '24

30 Oct '24

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38576?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: hnbgw: Introduce test TC_cs_iu_release_req_rua_disconnect ...................................................................... hnbgw: Introduce test TC_cs_iu_release_req_rua_disconnect Related: SYS#6602 Change-Id: I6782920c4a86d3311eb54239ab13a18e393c1ec0 --- M hnbgw/HNBGW_Tests.ttcn M hnbgw/expected-results.xml M library/ranap/RANAP_Templates.ttcn 3 files changed, 56 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/76/38576/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38576?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6782920c4a86d3311eb54239ab13a18e393c1ec0 Gerrit-Change-Number: 38576 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: run podman command with logfile
by osmith 30 Oct '24

30 Oct '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38580?usp=email ) Change subject: testenv: run podman command with logfile ...................................................................... testenv: run podman command with logfile In very rare cases it seems podman is just crashing with no reason in jenkins. Add logging to the main script we run inside podman, and run podman with a logfile attached to figure out why. Related: OS#6607 Change-Id: Ife3c0ae559c94f7df8b5912bb0e338ae6283cb7f --- M _testenv/data/scripts/testenv-podman-main.sh M _testenv/testenv/podman.py 2 files changed, 31 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/80/38580/1 diff --git a/_testenv/data/scripts/testenv-podman-main.sh b/_testenv/data/scripts/testenv-podman-main.sh index d0bc586..4b080a6 100755 --- a/_testenv/data/scripts/testenv-podman-main.sh +++ b/_testenv/data/scripts/testenv-podman-main.sh @@ -5,16 +5,20 @@ # This ensures the podman container stops a few seconds after a jenkins job was # aborted, or if a test is stuck in a loop for hours. +echo "Running testenv-podman-main.sh" + stop_time=$(($(date +%s) + 3600 * 4)) while [ $(date +%s) -lt $stop_time ]; do sleep 10 if ! [ -e /tmp/watchdog ]; then - break + echo "ERROR: /tmp/watchdog was not created, exiting" + exit 1 fi rm /tmp/watchdog done +echo "ERROR: timeout reached!" exit 1 diff --git a/_testenv/testenv/podman.py b/_testenv/testenv/podman.py index faa1837..f849408 100644 --- a/_testenv/testenv/podman.py +++ b/_testenv/testenv/podman.py @@ -185,6 +185,27 @@ pass +def wait_until_started(): + for i in range(100): + time.sleep(0.1) + if is_running(): + return + raise RuntimeError("Podman failed to start") + + +def start_in_background(cmd): + log_dir = os.path.join(testenv.testdir.testdir_topdir, "podman") + os.makedirs(log_dir, exist_ok=True) + + logging.debug(f"+ {cmd}") + subprocess.Popen(cmd, env=testenv.cmd.generate_env()) + + wait_until_started() + + feed_watchdog_process = multiprocessing.Process(target=feed_watchdog_loop) + feed_watchdog_process.start() + + def start(): global container_name global feed_watchdog_process @@ -202,7 +223,10 @@ "--rm", "--name", container_name, - "--detach", + "--log-driver", + "json-file", + "--log-opt", + f"path={testdir_topdir}/podman/{container_name}.log", f"--security-opt=seccomp={seccomp}", "--cap-add=NET_ADMIN", # for dumpcap, tun devices, osmo-pcap-client "--cap-add=NET_RAW", # for dumpcap, osmo-pcap-client @@ -243,10 +267,7 @@ os.path.join(testenv.data_dir, "scripts/testenv-podman-main.sh"), ] - testenv.cmd.run(cmd, no_podman=True) - - feed_watchdog_process = multiprocessing.Process(target=feed_watchdog_loop) - feed_watchdog_process.start() + start_in_background(cmd) exec_cmd(["rm", "/etc/apt/apt.conf.d/docker-clean"]) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38580?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ife3c0ae559c94f7df8b5912bb0e338ae6283cb7f Gerrit-Change-Number: 38580 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in osmo-iuh[master]: ranap: Add API to encode Reset Resource into msgb
by fixeria 30 Oct '24

30 Oct '24

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-iuh/+/38569?usp=email ) Change subject: ranap: Add API to encode Reset Resource into msgb ...................................................................... Patch Set 1: (2 comments) File include/osmocom/ranap/ranap_msg_factory.h: https://gerrit.osmocom.org/c/osmo-iuh/+/38569/comment/e009aa75_75648c0d?usp… : PS1, Line 71: int is_ps Change it to `bool` before Pau notices this! Oh, it's Pau's patch ;) </SCNR> (Personally I am absolutely fine with using `int` for boolean logic. Especially since using an `int` here is consistent with the existing API. But I remember getting review comments like "no! new code shall be using boool!") File src/ranap_msg_factory.c: https://gerrit.osmocom.org/c/osmo-iuh/+/38569/comment/569efbf6_d3960cd5?usp… : PS1, Line 1027: release request same problem here -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38569?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I5e7b647dee2887d9af7dc22bc9f46f499f676e01 Gerrit-Change-Number: 38569 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Oct 2024 15:17:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ttcn3-hacks[master]: bsc: testenv: set MTU=1500 for lo
by osmith 30 Oct '24

30 Oct '24

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38546?usp=email ) Change subject: bsc: testenv: set MTU=1500 for lo ...................................................................... Patch Set 2: (1 comment) This change is ready for review. Patchset: PS1: > I'm sorry but I think we should really figure out why is that error happening instead of just mergin […] I've spent a lot more time analyzing it and made an upstream bug report: https://gitlab.eclipse.org/eclipse/titan/titan.TestPorts.SCTPasp/-/issues/3 IMHO it is reasonable to merge this workaround now, please take another look. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38546?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifeda66954263fe8d2637377d0701a2208a19c332 Gerrit-Change-Number: 38546 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Oct 2024 15:05:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_cs_iu_release_req_rua_disconnect
by osmith 30 Oct '24

30 Oct '24

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38576?usp=email ) Change subject: hnbgw: Introduce test TC_cs_iu_release_req_rua_disconnect ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38576?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6782920c4a86d3311eb54239ab13a18e393c1ec0 Gerrit-Change-Number: 38576 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Oct 2024 14:46:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: Get rid of pars param in void_fn
by osmith 30 Oct '24

30 Oct '24

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38575?usp=email ) Change subject: hnbgw: Get rid of pars param in void_fn ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File hnbgw/HNBGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38575/comment/3de250da_69a0… : PS1, Line 571: //vc_conn.start(derefers(fn)(id, pars)); do you want to keep the commented out line? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38575?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I674b2a6a6a0e39f2904f9125783180da8ade5f44 Gerrit-Change-Number: 38575 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Oct 2024 14:43:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: hnbgw: Add missing timer stop after use
by osmith 30 Oct '24

30 Oct '24

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38574?usp=email ) Change subject: hnbgw: Add missing timer stop after use ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38574?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2c722f524de603b75f2b7c6ba85d074518d1f51c Gerrit-Change-Number: 38574 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Oct 2024 14:35:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0