January 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-hnbgw[master]: gitignore: add *.la, hnbgw_vty_reference.xml
by pespin 19 Jan '24

19 Jan '24

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619?usp=email ) Change subject: gitignore: add *.la, hnbgw_vty_reference.xml ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File .gitignore: https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619/comment/da432f15_a99b6242 PS1, Line 71: doc/manuals/vty/hnbgw_vty_reference.xml > This file gets automatically created when building with manuals inside the tree, therefore it should […] Ah I got confused by another similar one, eg: osmo-msc/doc/manuals/osmomsc-vty-reference.xml But your file is inside the vty/ subdirectory. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I5c9ec6cf01d75b10a86098755064ad187de815c1 Gerrit-Change-Number: 35619 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Jan 2024 13:49:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: gitignore: add *.la, hnbgw_vty_reference.xml
by osmith 19 Jan '24

19 Jan '24

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619?usp=email ) Change subject: gitignore: add *.la, hnbgw_vty_reference.xml ...................................................................... Patch Set 1: (2 comments) File .gitignore: https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619/comment/75eda8a9_d3cd6317 PS1, Line 49: src/osmo-hnbgw/libhnbgw.la > You should instead add "*.la" in line 5. Done https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619/comment/593498a2_54d5f749 PS1, Line 71: doc/manuals/vty/hnbgw_vty_reference.xml > Why are you adding this here? I think it's totally sane having this outside of gitignore. […] This file gets automatically created when building with manuals inside the tree, therefore it should be in gitignore like e.g. in osmo-msc.git. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I5c9ec6cf01d75b10a86098755064ad187de815c1 Gerrit-Change-Number: 35619 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Jan 2024 13:47:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: gitignore: add *.la, hnbgw_vty_reference.xml
by osmith 19 Jan '24

19 Jan '24

Attention is currently required from: fixeria, osmith. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: gitignore: add *.la, hnbgw_vty_reference.xml ...................................................................... gitignore: add *.la, hnbgw_vty_reference.xml Change-Id: I5c9ec6cf01d75b10a86098755064ad187de815c1 --- M .gitignore 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/19/35619/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I5c9ec6cf01d75b10a86098755064ad187de815c1 Gerrit-Change-Number: 35619 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in docker-playground[master]: ttcn3-epdg: Add section to control logging
by pespin 19 Jan '24

19 Jan '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35608?usp=email ) Change subject: ttcn3-epdg: Add section to control logging ...................................................................... ttcn3-epdg: Add section to control logging Similar as to what's defined in osmo-epdg.git/config/sys.config. Change-Id: I7b9a3421b5f0f384324bb0f9b6de3fffdceaef53 --- M ttcn3-epdg-test/osmo-epdg.config 1 file changed, 37 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/ttcn3-epdg-test/osmo-epdg.config b/ttcn3-epdg-test/osmo-epdg.config index 63a2f26..ac17e43 100644 --- a/ttcn3-epdg-test/osmo-epdg.config +++ b/ttcn3-epdg-test/osmo-epdg.config @@ -38,5 +38,30 @@ {gtpc_remote_ip, "172.18.10.103"}, {gtpc_remote_port, 2123} ] - } + }, + % %% =========================================== + %% Lager logging config + %% =========================================== + {lager, [ + {log_root, "/data/"}, + {colored, true}, + {handlers, + [{lager_console_backend, [{level, debug}]}, + {lager_file_backend, + [{file, "console.log"}, {level, debug}, {size, 104857600}, {date, "$D0"}, {count, 10}]}, + {lager_file_backend, + [{file, "error.log"}, {level, error}, {size, 104857600}, {date, "$D0"}, {count, 10}]}]}, + {crash_log, "crash.log"}, + {crash_log_msg_size, 65536}, + {crash_log_size, 104857600}, + {crash_log_date, "$D0"}, + {crash_log_count, 10}, + {error_logger_redirect, true} + ]}, + {kernel, [ + {logger, [{handler, debug, logger_std_h, % {handler, HandlerId, Module, + #{config => #{file => "/data/erlang.log"}} + }] + } + ]} ]. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35608?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I7b9a3421b5f0f384324bb0f9b6de3fffdceaef53 Gerrit-Change-Number: 35608 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in ...osmo-epdg[master]: Update osmo_gsup dependency in rebar.config and update rebar.lock
by pespin 19 Jan '24

19 Jan '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35621?usp=email ) Change subject: Update osmo_gsup dependency in rebar.config and update rebar.lock ...................................................................... Update osmo_gsup dependency in rebar.config and update rebar.lock osmo_gsup dep was pointing to a temporary branch of mine which is no longer existing, because the fix required was applied in osmo-ttcn3-hacks.git. Change-Id: I523acb49e4604e8a62d41d07d53d512158b28670 --- M rebar.config M rebar.lock 2 files changed, 17 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/rebar.config b/rebar.config index d834c32..a2db3ea 100644 --- a/rebar.config +++ b/rebar.config @@ -6,7 +6,7 @@ {lager, {git, "https://github.com/erlang-lager/lager", {tag, "3.9.2"}}}, {gtplib, "3.2.0"}, {osmo_ss7, {git, "https://gitea.osmocom.org/erlang/osmo_ss7", {ref, "9f294d3612f998860004820d1d85b4264721577b"}}}, - {osmo_gsup, {git, "https://gitea.osmocom.org/erlang/osmo_gsup", {ref, "07672d8ab1608aa9c9e50ca035521876558fcd42"}}} + {osmo_gsup, {git, "https://gitea.osmocom.org/erlang/osmo_gsup", {branch, "lynxis/epdg"}}} ]}. {minimum_otp_vsn, "20.3"}. diff --git a/rebar.lock b/rebar.lock index 8f00ea6..322e84d 100644 --- a/rebar.lock +++ b/rebar.lock @@ -2,7 +2,7 @@ [{<<"cut">>,{pkg,<<"cut">>,<<"1.0.3">>},1}, {<<"epcap">>, {git,"https://github.com/msantos/epcap", - {ref,"d5c03caf608c1369e68cfed0a606d3eb82ddfd21"}}, + {ref,"b98edbfbb0392101cd874b098caa5180f2f44b2e"}}, 1}, {<<"goldrush">>,{pkg,<<"goldrush">>,<<"0.1.9">>},1}, {<<"gtplib">>,{pkg,<<"gtplib">>,<<"3.2.0">>},0}, @@ -12,7 +12,7 @@ 0}, {<<"osmo_gsup">>, {git,"https://gitea.osmocom.org/erlang/osmo_gsup", - {ref,"e23f118e6e8f7ee1247db34e4cb79e4cecdb0947"}}, + {ref,"07672d8ab1608aa9c9e50ca035521876558fcd42"}}, 0}, {<<"osmo_ss7">>, {git,"https://gitea.osmocom.org/erlang/osmo_ss7", @@ -20,7 +20,7 @@ 0}, {<<"parse_trans">>, {git,"https://github.com/uwiger/parse_trans", - {ref,"cdb01ba260ba9a00b2aafa17affead0f6fac081c"}}, + {ref,"d99fb36755c813a5db23e6f93741aa58323ef911"}}, 1}, {<<"pkt">>, {git,"https://github.com/msantos/pkt", -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35621?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I523acb49e4604e8a62d41d07d53d512158b28670 Gerrit-Change-Number: 35621 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in ...osmo-epdg[master]: Update osmo_gsup dependency in rebar.config and update rebar.lock
by pespin 19 Jan '24

19 Jan '24

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35621?usp=email ) Change subject: Update osmo_gsup dependency in rebar.config and update rebar.lock ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35621?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I523acb49e4604e8a62d41d07d53d512158b28670 Gerrit-Change-Number: 35621 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Jan 2024 13:40:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: VTY: Add command `show bts brief`
by pespin 19 Jan '24

19 Jan '24

Attention is currently required from: jolly, laforge, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35567?usp=email ) Change subject: VTY: Add command `show bts brief` ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35567?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I003fd32e589ddf53b7dd42089f904cfb598e3625 Gerrit-Change-Number: 35567 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 19 Jan 2024 13:40:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: Also track downtime when OML link is lost
by pespin 19 Jan '24

19 Jan '24

Attention is currently required from: jolly, laforge, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35566?usp=email ) Change subject: Also track downtime when OML link is lost ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35566?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1776099cbfef51af1d5a3a056fb0654abd7366a9 Gerrit-Change-Number: 35566 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 19 Jan 2024 13:39:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: debian: fix having no manuals in osmo-hnbgw-doc
by pespin 19 Jan '24

19 Jan '24

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35620?usp=email ) Change subject: debian: fix having no manuals in osmo-hnbgw-doc ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35620?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I8daeba6b267b2f7793a26a0e1fbc74ab17401cde Gerrit-Change-Number: 35620 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Jan 2024 13:38:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: gitignore: add libhnbgw.la, hnbgw_vty_reference.xml
by pespin 19 Jan '24

19 Jan '24

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619?usp=email ) Change subject: gitignore: add libhnbgw.la, hnbgw_vty_reference.xml ...................................................................... Patch Set 1: (2 comments) File .gitignore: https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619/comment/62a120df_a0d6fe3f PS1, Line 49: src/osmo-hnbgw/libhnbgw.la You should instead add "*.la" in line 5. https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619/comment/e6b23882_3b195aa9 PS1, Line 71: doc/manuals/vty/hnbgw_vty_reference.xml Why are you adding this here? I think it's totally sane having this outside of gitignore. Check other repos like osmo-bsc. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I5c9ec6cf01d75b10a86098755064ad187de815c1 Gerrit-Change-Number: 35619 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Jan 2024 13:38:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0