Attention is currently required from: fixeria, osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619?usp=email )
Change subject: gitignore: add *.la, hnbgw_vty_reference.xml
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File .gitignore:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619/comment/da432f15_a99b6242
PS1, Line 71: doc/manuals/vty/hnbgw_vty_reference.xml
> This file gets automatically created when building with manuals inside the tree, therefore it should […]
Ah I got confused by another similar one, eg:
osmo-msc/doc/manuals/osmomsc-vty-reference.xml
But your file is inside the vty/ subdirectory.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I5c9ec6cf01d75b10a86098755064ad187de815c1
Gerrit-Change-Number: 35619
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 19 Jan 2024 13:49:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria, pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619?usp=email )
Change subject: gitignore: add *.la, hnbgw_vty_reference.xml
......................................................................
Patch Set 1:
(2 comments)
File .gitignore:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619/comment/75eda8a9_d3cd6317
PS1, Line 49: src/osmo-hnbgw/libhnbgw.la
> You should instead add "*.la" in line 5.
Done
https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619/comment/593498a2_54d5f749
PS1, Line 71: doc/manuals/vty/hnbgw_vty_reference.xml
> Why are you adding this here? I think it's totally sane having this outside of gitignore. […]
This file gets automatically created when building with manuals inside the tree, therefore it should be in gitignore like e.g. in osmo-msc.git.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I5c9ec6cf01d75b10a86098755064ad187de815c1
Gerrit-Change-Number: 35619
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 19 Jan 2024 13:47:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria, osmith.
Hello Jenkins Builder, fixeria, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: gitignore: add *.la, hnbgw_vty_reference.xml
......................................................................
gitignore: add *.la, hnbgw_vty_reference.xml
Change-Id: I5c9ec6cf01d75b10a86098755064ad187de815c1
---
M .gitignore
1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/19/35619/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I5c9ec6cf01d75b10a86098755064ad187de815c1
Gerrit-Change-Number: 35619
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: fixeria, osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619?usp=email )
Change subject: gitignore: add libhnbgw.la, hnbgw_vty_reference.xml
......................................................................
Patch Set 1:
(2 comments)
File .gitignore:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619/comment/62a120df_a0d6fe3f
PS1, Line 49: src/osmo-hnbgw/libhnbgw.la
You should instead add "*.la" in line 5.
https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619/comment/e6b23882_3b195aa9
PS1, Line 71: doc/manuals/vty/hnbgw_vty_reference.xml
Why are you adding this here? I think it's totally sane having this outside of gitignore. Check other repos like osmo-bsc.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I5c9ec6cf01d75b10a86098755064ad187de815c1
Gerrit-Change-Number: 35619
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 19 Jan 2024 13:38:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment