Attention is currently required from: fixeria.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35583?usp=email )
Change subject: mobile: implement sending CSD data over UNIX socket
......................................................................
Patch Set 5:
(1 comment)
File src/host/layer23/src/mobile/tch_data_sock.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/35583/comment/5b8bfdbf_1e44c40f
PS5, Line 168: osmo_fd_read_disable(&state->listen_bfd);
You disable read of socket listening fd. This would cause any other client connection to lock until read is enabled again. Maybe you want to reject any other connection instead by closing the socket, while there is already a socket client connection.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35583?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Id054af7b3d9d0a41715f7981deb420f6e09bf30c
Gerrit-Change-Number: 35583
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 19 Jan 2024 09:09:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: fixeria, pespin.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35581?usp=email )
Change subject: mobile: split voice specific TCH handling into its own file
......................................................................
Patch Set 4:
(1 comment)
File src/host/layer23/src/mobile/tch.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/35581/comment/53457f43_93ca39fe
PS4, Line 111: tch_voice_serve_ms(ms);
Why is the return value not forwarded? Is the return value of gapk_io_serve_ms() relevant for the user of this function.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35581?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ib917d95fe77da3e60bc932cce56714d81095c7d4
Gerrit-Change-Number: 35581
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 19 Jan 2024 08:23:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35615?usp=email )
Change subject: tests/gsm0408: add two more samples to bcap_tests[]
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
You should probably document that mismatch as a comment in the code, so people looking at the mismatch in the output knows out of the box why that happens.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35615?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4fc519c02b4fad8b0f40fa649d9de14b1183d10d
Gerrit-Change-Number: 35615
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Jan 2024 19:10:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge, lynxis lazus, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35604?usp=email )
Change subject: GSUP_Types: Add missing message_class to EPDGTunnel* messages
......................................................................
Patch Set 3:
(1 comment)
File library/GSUP_Types.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35604/comment/edead2b5_cc32…
PS3, Line 734: ts_GSUP_IE_Message_Class
Still the same problem here: it should be after the `Cause IE`.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35604?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib7d6156402645867cadc8d3e0ffdd07247a1abd2
Gerrit-Change-Number: 35604
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 18 Jan 2024 19:03:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment