Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619?usp=email ) Change subject: gitignore: add *.la, hnbgw_vty_reference.xml ...................................................................... Patch Set 1: (2 comments) File .gitignore: https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619/comment/75eda8a9_d3cd6317 PS1, Line 49: src/osmo-hnbgw/libhnbgw.la

You should instead add "*.la" in line 5. Done

https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619/comment/593498a2_54d5f749 PS1, Line 71: doc/manuals/vty/hnbgw_vty_reference.xml

Why are you adding this here? I think it's totally sane having this outside of gitignore. […] This file gets automatically created when building with manuals inside the tree, therefore it should be in gitignore like e.g. in osmo-msc.git.

-- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35619?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I5c9ec6cf01d75b10a86098755064ad187de815c1 Gerrit-Change-Number: 35619 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Fri, 19 Jan 2024 13:47:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment