January 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-gsm-manuals[master]: gsup.adoc: Update spec reference s/TS 09.60/TS 29.060/
by pespin 21 Jan '24

21 Jan '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35623?usp=email ) Change subject: gsup.adoc: Update spec reference s/TS 09.60/TS 29.060/ ...................................................................... gsup.adoc: Update spec reference s/TS 09.60/TS 29.060/ Change-Id: I42f4c5ce96823a91918cb01a6263cb7075226551 --- M common/chapters/gsup.adoc 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/common/chapters/gsup.adoc b/common/chapters/gsup.adoc index a9cffd9..d9a87ca 100644 --- a/common/chapters/gsup.adoc +++ b/common/chapters/gsup.adoc @@ -1117,7 +1117,7 @@ ==== PDP Type The PDP type value consists of 2 octets that are encoded like octet 4-5 of the -End User Address defined in 3GPP TS 09.60, 7.9.18. +End User Address (EUA) defined in 3GPP TS 29.060, 7.7.27. [packetdiag] ---- @@ -1134,7 +1134,7 @@ } ---- -The spare bits are left undefined. While 09.60 defines them as '1 1 1 1', there +The spare bits are left undefined. While 29.060 defines them as '1 1 1 1', there are MAP traces where these bits are set to '0 0 0 0'. So the receiver shall ignore these bits. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35623?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I42f4c5ce96823a91918cb01a6263cb7075226551 Gerrit-Change-Number: 35623 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-gsm-manuals[master]: Update spec reference s/TS 04.08/TS 24.008/
by pespin 21 Jan '24

21 Jan '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35622?usp=email ) Change subject: Update spec reference s/TS 04.08/TS 24.008/ ...................................................................... Update spec reference s/TS 04.08/TS 24.008/ Change-Id: Ie9feade73eff8c61232deffbad24ef34d97d32ac --- M common/chapters/gsup.adoc M common/chapters/oap.adoc 2 files changed, 17 insertions(+), 8 deletions(-) Approvals: fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/common/chapters/gsup.adoc b/common/chapters/gsup.adoc index 6d07e6b..a9cffd9 100644 --- a/common/chapters/gsup.adoc +++ b/common/chapters/gsup.adoc @@ -1091,7 +1091,7 @@ ==== IP Address The value part is encoded like in the Packet data protocol address IE defined -in 3GPP TS 04.08, Chapter 10.5.6.4. PDP type organization must be set to +in 3GPP TS 24.008, Chapter 10.5.6.4. PDP type organization must be set to 'IETF allocated address'. [[gsup-ie-pdpinfo]] @@ -1285,7 +1285,7 @@ [options="header",cols="15%,35%,50%"] |=== |IEI|Info Element|Type / Encoding -|0x01|IMSI|Mobile Identity, 3GPP TS 04.08 Ch. 10.5.1.4 +|0x01|IMSI|Mobile Identity, 3GPP TS 24.008 Ch. 10.5.1.4 |0x02|Cause|<<gsup-ie-cause>> |0x03|Auth Tuple|<<gsup-ie-authtuple>> |0x04|PDP Info Compl|<<gsup-ie-empty>> @@ -1351,7 +1351,7 @@ ==== IMSI The IMSI is encoded like in octet 4-N of the Called Party BCD Number -defined in 3GPP TS 04.08, 10.5.4.7. +defined in 3GPP TS 24.008, 10.5.4.7. [packetdiag] ---- @@ -1377,7 +1377,7 @@ ==== ISDN-AddressString / MSISDN / Called Party BCD Number The MSISDN is encoded as an ISDN-AddressString in 3GPP TS 09.02 and Called Party -BCD Number in 3GPP TS 04.08. It will be stored by the SGSN or VLR and then passed as is +BCD Number in 3GPP TS 24.008. It will be stored by the SGSN or VLR and then passed as is to the GGSN during the activation of the primary PDP Context. [packetdiag] @@ -1479,7 +1479,7 @@ ==== Cause This IE shall be encoded according to the 'GMM Cause' as described in -Chapter 10.5.5.14 of 3GPP TS 04.08. +Chapter 10.5.5.14 of 3GPP TS 24.008. [[gsup-ie-ss-info]] ==== Supplementary Service Info @@ -1491,7 +1491,7 @@ [[gsup-ie-imei]] ==== IMEI -The IMEI encoded as Called Party BCD Number in 3GPP TS 04.08. +The IMEI encoded as Called Party BCD Number in 3GPP TS 24.008. [[gsup-ie-imei-result]] ==== IMEI Check Result diff --git a/common/chapters/oap.adoc b/common/chapters/oap.adoc index 425ff75..5255b4a 100644 --- a/common/chapters/oap.adoc +++ b/common/chapters/oap.adoc @@ -136,7 +136,7 @@ |=== |IEI|IE|Type|Presence|Format|Length | |Message Type|<<common-oap-ie-msgtype>>|M|V|1 -|02|Cause|GMM Cause, TS 04.08: 10.5.5.14|M|TLV|3 +|02|Cause|GMM Cause, TS 24.008: 10.5.5.14|M|TLV|3 |=== ==== Register Result @@ -169,7 +169,7 @@ |=== |IEI|IE|Type|Presence|Format|Length | |Message Type|<<common-oap-ie-msgtype>>|M|V|1 -|02|Cause|GMM Cause, TS 04.08: 10.5.5.14|M|TLV|3 +|02|Cause|GMM Cause, TS 24.008: 10.5.5.14|M|TLV|3 |=== ==== Challenge Result -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35622?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ie9feade73eff8c61232deffbad24ef34d97d32ac Gerrit-Change-Number: 35622 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-gsm-manuals[master]: gsup: Convert PDP-Type IE to PDP-Address IE
by fixeria 21 Jan '24

21 Jan '24

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35628?usp=email ) Change subject: gsup: Convert PDP-Type IE to PDP-Address IE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35628?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ifb4e44b23d19ea049f03a3602c39f2471ff1bff4 Gerrit-Change-Number: 35628 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 21 Jan 2024 10:18:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-gsm-manuals[master]: gsup.adoc: Update spec reference s/TS 09.60/TS 29.060/
by fixeria 21 Jan '24

21 Jan '24

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35623?usp=email ) Change subject: gsup.adoc: Update spec reference s/TS 09.60/TS 29.060/ ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35623?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I42f4c5ce96823a91918cb01a6263cb7075226551 Gerrit-Change-Number: 35623 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 21 Jan 2024 10:18:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-gsm-manuals[master]: Update spec reference s/TS 04.08/TS 24.008/
by fixeria 21 Jan '24

21 Jan '24

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35622?usp=email ) Change subject: Update spec reference s/TS 04.08/TS 24.008/ ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35622?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ie9feade73eff8c61232deffbad24ef34d97d32ac Gerrit-Change-Number: 35622 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 21 Jan 2024 10:18:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: vlr: Use new libosmogsm struct osmo_gsup_pdp_info fields
by fixeria 21 Jan '24

21 Jan '24

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35631?usp=email ) Change subject: vlr: Use new libosmogsm struct osmo_gsup_pdp_info fields ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35631?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ia002fd6e0334d56de34d352a0bf1a8604e2e9fd3 Gerrit-Change-Number: 35631 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 21 Jan 2024 10:17:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: cosmetic: vlc: Fix whitespace formatting in struct sgsn_subscriber_pd...
by fixeria 21 Jan '24

21 Jan '24

Attention is currently required from: lynxis lazus, neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35630?usp=email ) Change subject: cosmetic: vlc: Fix whitespace formatting in struct sgsn_subscriber_pdp_data ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35630?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: If6194e778dc5a4a140c7893a74cafcb6511d5803 Gerrit-Change-Number: 35630 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 21 Jan 2024 10:16:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-hnbgw[master]: pfcp: implement sending Network Instance IEs
by fixeria 21 Jan '24

21 Jan '24

Attention is currently required from: laforge, neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35645?usp=email ) Change subject: pfcp: implement sending Network Instance IEs ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/osmo-hnbgw/hnbgw_vty.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/35645/comment/76389ef7_a323106b PS3, Line 862: LOGP(DLPFCP, LOGL_NOTICE, "cfg: pfcp netinst %s %s\n", access_or_core, *str); looks like a debugging leftover -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35645?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ief53dbfacf1645c32a07847d590c4884d4c8ca56 Gerrit-Change-Number: 35645 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 21 Jan 2024 10:15:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: pfcp: fix missing vty_write of pfcp local-port
by fixeria 21 Jan '24

21 Jan '24

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35644?usp=email ) Change subject: pfcp: fix missing vty_write of pfcp local-port ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35644?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I180e67b8abdd3c0d91b30f1e7668b02f1a323809 Gerrit-Change-Number: 35644 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sun, 21 Jan 2024 10:11:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-hnbgw[master]: add tests/pfcp_cfg.vty.with_pfcp
by fixeria 21 Jan '24

21 Jan '24

Attention is currently required from: laforge, neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35643?usp=email ) Change subject: add tests/pfcp_cfg.vty.with_pfcp ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35643?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ibb1797bb43a18f26fc693e0c8920cfd1f5fb9ede Gerrit-Change-Number: 35643 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 21 Jan 2024 10:11:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0