January 2024 - gerrit-log - lists.osmocom.org

[L] Change in osmocom-bb[master]: mobile: implement sending CSD data over UNIX socket
by laforge 20 Jan '24

20 Jan '24

Attention is currently required from: fixeria, osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35583?usp=email ) Change subject: mobile: implement sending CSD data over UNIX socket ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35583?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id054af7b3d9d0a41715f7981deb420f6e09bf30c Gerrit-Change-Number: 35583 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 20 Jan 2024 08:37:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmocom-bb[master]: mobile: split voice specific TCH handling into its own file
by laforge 20 Jan '24

20 Jan '24

Attention is currently required from: fixeria, jolly, osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35581?usp=email ) Change subject: mobile: split voice specific TCH handling into its own file ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35581?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib917d95fe77da3e60bc932cce56714d81095c7d4 Gerrit-Change-Number: 35581 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 20 Jan 2024 08:36:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: firmware (libosmocore): fix gsm48_chan_mode for TCH/[FH]2.4
by laforge 20 Jan '24

20 Jan '24

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35637?usp=email ) Change subject: firmware (libosmocore): fix gsm48_chan_mode for TCH/[FH]2.4 ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35637?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I99f528f3e1cd4c04ebb9d8becf1572688dd531ae Gerrit-Change-Number: 35637 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 20 Jan 2024 08:35:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-hnbgw[master]: pfcp: implement sending Network Instance IEs
by laforge 20 Jan '24

20 Jan '24

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35645?usp=email ) Change subject: pfcp: implement sending Network Instance IEs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35645?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ief53dbfacf1645c32a07847d590c4884d4c8ca56 Gerrit-Change-Number: 35645 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 20 Jan 2024 08:35:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: pfcp: fix missing vty_write of pfcp local-port
by laforge 20 Jan '24

20 Jan '24

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35644?usp=email ) Change subject: pfcp: fix missing vty_write of pfcp local-port ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35644?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I180e67b8abdd3c0d91b30f1e7668b02f1a323809 Gerrit-Change-Number: 35644 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 20 Jan 2024 08:34:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-hnbgw[master]: add tests/pfcp_cfg.vty.with_pfcp
by laforge 20 Jan '24

20 Jan '24

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35643?usp=email ) Change subject: add tests/pfcp_cfg.vty.with_pfcp ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35643?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ibb1797bb43a18f26fc693e0c8920cfd1f5fb9ede Gerrit-Change-Number: 35643 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 20 Jan 2024 08:34:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: tweak vty doc: "UDP port"
by laforge 20 Jan '24

20 Jan '24

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35642?usp=email ) Change subject: tweak vty doc: "UDP port" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35642?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I24e52143a8f3d0c9f92985f6bb0420b34926eb33 Gerrit-Change-Number: 35642 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 20 Jan 2024 08:33:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: pfcp: fix modification of wrong FAR ID
by laforge 20 Jan '24

20 Jan '24

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35641?usp=email ) Change subject: pfcp: fix modification of wrong FAR ID ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35641?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I596f1785d280d7e53e0cef649d6bb5df01ebf648 Gerrit-Change-Number: 35641 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 20 Jan 2024 08:33:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-hnbgw[master]: add tests/pfcp_cfg.vty.with_pfcp
by neels 20 Jan '24

20 Jan '24

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35643?usp=email ) Change subject: add tests/pfcp_cfg.vty.with_pfcp ...................................................................... add tests/pfcp_cfg.vty.with_pfcp So far, we had no pfcp.vty test, because PFCP support is built conditionally, and the pfcp.vty test would always fail without PFCP support. Add a pfcp test for the VTY, conditionally: use suffix .vty.with_pfcp to identify tests that need PFCP support, and run those only when configured with --enable-pfcp. Related: SYS#5895 Change-Id: Ibb1797bb43a18f26fc693e0c8920cfd1f5fb9ede --- M tests/Makefile.am A tests/pfcp_cfg.vty.with_pfcp 2 files changed, 78 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/43/35643/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index d499c33..f8b109d 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -29,6 +29,7 @@ $(srcdir)/*.ctrl \ $(srcdir)/config/*.cfg \ $(srcdir)/config/*.vty \ + $(srcdir)/config/*.vty.with_pfcp \ $(srcdir)/config/run_tests.sh \ $(NULL) @@ -50,7 +51,11 @@ endif # Run a specific test with: 'make vty-test VTY_TEST=osmo-hnbgw.vty' +if ENABLE_PFCP +VTY_TEST ?= *.vty* +else VTY_TEST ?= *.vty +endif # To update the VTY script from current application behavior, # pass -u to vty_script_runner.py by doing: diff --git a/tests/pfcp_cfg.vty.with_pfcp b/tests/pfcp_cfg.vty.with_pfcp new file mode 100644 index 0000000..a093ffb --- /dev/null +++ b/tests/pfcp_cfg.vty.with_pfcp @@ -0,0 +1,55 @@ +OsmoHNBGW> enable +OsmoHNBGW# configure terminal + +OsmoHNBGW(config)# hnbgw +OsmoHNBGW(config-hnbgw)# list +... + pfcp +... +OsmoHNBGW(config-hnbgw)# pfcp? + pfcp Configure PFCP for GTP tunnel mapping + +OsmoHNBGW(config-hnbgw)# pfcp +OsmoHNBGW(config-hnbgw-pfcp)# list +... + local-addr IP_ADDR + local-port <1-65535> + remote-addr IP_ADDR + +OsmoHNBGW(config-hnbgw-pfcp)# local-addr? + local-addr Local address for PFCP +OsmoHNBGW(config-hnbgw-pfcp)# local-addr ? + IP_ADDR IP address + +OsmoHNBGW(config-hnbgw-pfcp)# local-port? + local-port Local port for PFCP +OsmoHNBGW(config-hnbgw-pfcp)# local-port ? + <1-65535> UDP port + +OsmoHNBGW(config-hnbgw-pfcp)# remote-addr? + remote-addr Remote UPF's listen IP address; where to send PFCP requests +OsmoHNBGW(config-hnbgw-pfcp)# remote-addr ? + IP_ADDR IP address + + +OsmoHNBGW(config-hnbgw-pfcp)# show running-config +... +hnbgw +... + pfcp +msc 0 +... + +OsmoHNBGW(config-hnbgw-pfcp)# remote-addr 127.0.0.2 +OsmoHNBGW(config-hnbgw-pfcp)# local-addr 127.0.0.1 +OsmoHNBGW(config-hnbgw-pfcp)# local-port 8805 + +OsmoHNBGW(config-hnbgw-pfcp)# show running-config +... +hnbgw +... + pfcp + local-addr 127.0.0.1 + remote-addr 127.0.0.2 +msc 0 +... -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35643?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ibb1797bb43a18f26fc693e0c8920cfd1f5fb9ede Gerrit-Change-Number: 35643 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-hnbgw[master]: tweak vty doc: "UDP port"
by neels 20 Jan '24

20 Jan '24

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35642?usp=email ) Change subject: tweak vty doc: "UDP port" ...................................................................... tweak vty doc: "UDP port" Change-Id: I24e52143a8f3d0c9f92985f6bb0420b34926eb33 --- M src/osmo-hnbgw/hnbgw_vty.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/42/35642/1 diff --git a/src/osmo-hnbgw/hnbgw_vty.c b/src/osmo-hnbgw/hnbgw_vty.c index 62fe4aa..674832b 100644 --- a/src/osmo-hnbgw/hnbgw_vty.c +++ b/src/osmo-hnbgw/hnbgw_vty.c @@ -836,7 +836,7 @@ DEFUN(cfg_pfcp_local_port, cfg_pfcp_local_port_cmd, "local-port <1-65535>", "Local port for PFCP\n" - "IP port\n") + "UDP port\n") { g_hnbgw->config.pfcp.local_port = atoi(argv[0]); return CMD_SUCCESS; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35642?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I24e52143a8f3d0c9f92985f6bb0420b34926eb33 Gerrit-Change-Number: 35642 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 0