Attention is currently required from: fixeria.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/35616?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: tests/gsm0408: cosmetic: adjust coding style (make linter happy)
......................................................................
tests/gsm0408: cosmetic: adjust coding style (make linter happy)
Change-Id: I203033e2b3c27cb8b258faf1ff3c5ec4c0083458
---
M tests/gsm0408/gsm0408_test.c
1 file changed, 32 insertions(+), 23 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/16/35616/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35616?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I203033e2b3c27cb8b258faf1ff3c5ec4c0083458
Gerrit-Change-Number: 35616
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35647?usp=email )
Change subject: Remove unused OpenBSC leftover 'openbscdefines.h'
......................................................................
Remove unused OpenBSC leftover 'openbscdefines.h'
Change-Id: Iafc9f387a07f1eba66d291a84017e7dee56c4cb7
---
M include/osmocom/bsc/Makefile.am
D include/osmocom/bsc/openbscdefines.h
2 files changed, 9 insertions(+), 35 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/47/35647/1
diff --git a/include/osmocom/bsc/Makefile.am b/include/osmocom/bsc/Makefile.am
index 2010d6b..a560f23 100644
--- a/include/osmocom/bsc/Makefile.am
+++ b/include/osmocom/bsc/Makefile.am
@@ -46,7 +46,6 @@
neighbor_ident.h \
network_listen.h \
nm_common_fsm.h \
- openbscdefines.h \
osmo_bsc.h \
osmo_bsc_grace.h \
osmo_bsc_rf.h \
diff --git a/include/osmocom/bsc/openbscdefines.h b/include/osmocom/bsc/openbscdefines.h
deleted file mode 100644
index c6ac153..0000000
--- a/include/osmocom/bsc/openbscdefines.h
+++ /dev/null
@@ -1,34 +0,0 @@
-/*
- * (C) 2009 by Holger Hans Peter Freyther <zecke(a)selfish.org>
- *
- * All Rights Reserved
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License as published by
- * the Free Software Foundation; either version 3 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License
- * along with this program. If not, see <http://www.gnu.org/licenses/>.
- *
- */
-
-#ifndef OPENBSCDEFINES_H
-#define OPENBSCDEFINES_H
-
-#ifdef BUILDING_ON_WINDOWS
- #ifdef BUILDING_OPENBSC
- #define BSC_API __declspec(dllexport)
- #else
- #define BSC_API __declspec(dllimport)
- #endif
-#else
- #define BSC_API __attribute__((visibility("default")))
-#endif
-
-#endif
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35647?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Iafc9f387a07f1eba66d291a84017e7dee56c4cb7
Gerrit-Change-Number: 35647
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: fixeria, laforge, osmith.
Hello Jenkins Builder, fixeria, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/docker-playground/+/35607?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Verified+1 by Jenkins Builder
Change subject: ttcn3-epdg: Run osmo-epdg with CAP_NET_ADMIN
......................................................................
ttcn3-epdg: Run osmo-epdg with CAP_NET_ADMIN
This will be needed since soon osmo-epdg will start creating tunnel
devices througth gtp_u_kmod, which requires CAP_NET_ADMIN, plus it will
need probably need to set up local IP addresses.
Change-Id: I48eea0e8d7969cc0a3ad2ed08f696decf064c474
---
M ttcn3-epdg-test/jenkins.sh
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/07/35607/3
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35607?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I48eea0e8d7969cc0a3ad2ed08f696decf064c474
Gerrit-Change-Number: 35607
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge, osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35607?usp=email )
Change subject: ttcn3-epdg: Run osmo-epdg with CAP_NET_ADMIN
......................................................................
Patch Set 2:
(2 comments)
File ttcn3-epdg-test/jenkins.sh:
https://gerrit.osmocom.org/c/docker-playground/+/35607/comment/0a24878e_59e…
PS2, Line 26: --cap-add=NET_ADMIN --device /dev/net/tun:/dev/net/tun \
> could you put one parameter in one line?
Done
https://gerrit.osmocom.org/c/docker-playground/+/35607/comment/2672a479_497…
PS2, Line 28: -v /sys/fs/cgroup:/sys/fs/cgroup:ro \
> Seems I actually I don't need it for now, I copied from another dockerfile thinking I may need it fo […]
Done
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35607?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I48eea0e8d7969cc0a3ad2ed08f696decf064c474
Gerrit-Change-Number: 35607
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 22 Jan 2024 12:45:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: laforge, osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35607?usp=email )
Change subject: ttcn3-epdg: Run osmo-epdg with CAP_NET_ADMIN
......................................................................
Patch Set 2:
(1 comment)
File ttcn3-epdg-test/jenkins.sh:
https://gerrit.osmocom.org/c/docker-playground/+/35607/comment/2aa4f058_fe7…
PS2, Line 28: -v /sys/fs/cgroup:/sys/fs/cgroup:ro \
> why do you need to forward /sys/fs/cgroup? […]
Seems I actually I don't need it for now, I copied from another dockerfile thinking I may need it for netns, but agree let's remove it for now.
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35607?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I48eea0e8d7969cc0a3ad2ed08f696decf064c474
Gerrit-Change-Number: 35607
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 22 Jan 2024 12:45:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment