January 2024 - gerrit-log - lists.osmocom.org

[L] Change in osmocom-bb[master]: mobile: integrate V.110 TA & soft-UART from libosmocore
by fixeria 22 Jan '24

22 Jan '24

Attention is currently required from: laforge, osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35582?usp=email ) Change subject: mobile: integrate V.110 TA & soft-UART from libosmocore ...................................................................... Patch Set 6: Code-Review+2 (2 comments) Patchset: PS6: Re-applying Harald's and Oliver's votes. File src/host/layer23/src/mobile/tch_data.c: https://gerrit.osmocom.org/c/osmocom-bb/+/35582/comment/ad04bc5b_115143f2 PS6, Line 323: nmsg->l2h = msgb_put(nmsg, 33); /* XXX: proper size */ > what about this? The firmware [for Calypso] is expecting all `TRAFFIC.req` to contain 33 bytes, regardless of the channel type. This should be fixed in a separate patch, I am just adding a comment. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35582?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7ac9c0e5010730fa4d8bc7a7a3c7ff85e11731c0 Gerrit-Change-Number: 35582 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 22 Jan 2024 19:09:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: GSUP: Fix missing and wrongly sorted IEs in ts_GSUP_IE_PdpInfo
by pespin 22 Jan '24

22 Jan '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35652?usp=email ) Change subject: GSUP: Fix missing and wrongly sorted IEs in ts_GSUP_IE_PdpInfo ...................................................................... GSUP: Fix missing and wrongly sorted IEs in ts_GSUP_IE_PdpInfo Sort them to follow libosmocore implementation. Change-Id: I65e586187d7230f122644c101f8467becae6e204 --- M library/GSUP_Templates.ttcn 1 file changed, 19 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/52/35652/1 diff --git a/library/GSUP_Templates.ttcn b/library/GSUP_Templates.ttcn index 7146e97..ea2b489 100644 --- a/library/GSUP_Templates.ttcn +++ b/library/GSUP_Templates.ttcn @@ -175,21 +175,23 @@ } } -template GSUP_IE ts_GSUP_IE_PdpInfo(template (value) octetstring apn, - template (value) GSUP_PDP_Address pdp_address, - template (value) octetstring pdp_qos) := { +template (value) GSUP_IE ts_GSUP_IE_PdpInfo(template (value) OCT1 ctx_id, + template (value) octetstring apn, + template (value) GSUP_PDP_Address pdp_address, + template (value) octetstring pdp_qos) := { tag := OSMO_GSUP_PDP_INFO_IE, len := 0, /* overwritten */ val := { pdp_info := { - valueof(ts_GSUP_IE_APN(apn)), + valueof(ts_GSUP_IE_PDP_CONTEXT_ID(ctx_id)), valueof(ts_GSUP_IE_PDP_ADDRESS(pdp_address)), + valueof(ts_GSUP_IE_APN(apn)), valueof(ts_GSUP_IE_PDP_QOS(pdp_qos)) } } } -template (value) GSUP_IE ts_GSUP_IE_PDP_CONTEXT_ID(OCT1 ctx_id) := { +template (value) GSUP_IE ts_GSUP_IE_PDP_CONTEXT_ID(template (value) OCT1 ctx_id) := { tag := OSMO_GSUP_PDP_CONTEXT_ID_IE, len := 0, val := { @@ -197,7 +199,7 @@ } } -template GSUP_IE tr_GSUP_IE_PDP_CONTEXT_ID(template OCT1 ctx_id) := { +template (present) GSUP_IE tr_GSUP_IE_PDP_CONTEXT_ID(template OCT1 ctx_id) := { tag := OSMO_GSUP_PDP_CONTEXT_ID_IE, len := ?, val := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35652?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I65e586187d7230f122644c101f8467becae6e204 Gerrit-Change-Number: 35652 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-ttcn3-hacks[master]: GSUP: Fix build of IEs in f_gen_tr_ies(), add PdpInfo(Compl) IEs to it
by pespin 22 Jan '24

22 Jan '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35653?usp=email ) Change subject: GSUP: Fix build of IEs in f_gen_tr_ies(), add PdpInfo(Compl) IEs to it ...................................................................... GSUP: Fix build of IEs in f_gen_tr_ies(), add PdpInfo(Compl) IEs to it The previous conditions "isvalue()" were wrong. Passing an array of templates to isvalue() returns false, which is unexpected here. Change-Id: Iaad47b1ec7e2a7477fa554df9caeb866ffa594eb --- M epdg/EPDG_Tests.ttcn M library/GSUP_Templates.ttcn 2 files changed, 117 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/53/35653/1 diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn index 554dd07..0e9cbed 100644 --- a/epdg/EPDG_Tests.ttcn +++ b/epdg/EPDG_Tests.ttcn @@ -506,8 +506,15 @@ GSUP.send(ts_GSUP_EPDGTunnel_REQ(g_pars.imsi)); f_GTP2C_CreateSession_success(); /* Expect a positive response back to the translator; */ + var template (present) GSUP_IEs pdp_info := { + tr_GSUP_IE_PDP_CONTEXT_ID(?), + tr_GSUP_IE_PDP_ADDRESS(?), + tr_GSUP_IE_APN(?), + tr_GSUP_IE_PDP_QOS(?), + tr_GSUP_IE_Charging_Characteristics(?) + }; alt { - [] GSUP.receive(tr_GSUP_EPDGTunnel_RES(g_pars.imsi)); + [] GSUP.receive(tr_GSUP_EPDGTunnel_RES(g_pars.imsi, pdp_info)); [] GSUP.receive(GSUP_PDU:?) -> value rx_gsup { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Unexpected GSUP msg rx: ", rx_gsup)); } diff --git a/library/GSUP_Templates.ttcn b/library/GSUP_Templates.ttcn index ea2b489..68e4fd1 100644 --- a/library/GSUP_Templates.ttcn +++ b/library/GSUP_Templates.ttcn @@ -190,6 +190,34 @@ } } } +template (value) GSUP_IE ts_GSUP_IE_PdpInfo_ie(template (value) GSUP_IEs pdp_info) := { + tag := OSMO_GSUP_PDP_INFO_IE, + len := 0, /* overwritten */ + val := { + pdp_info := pdp_info + } +} + +template (present) GSUP_IE tr_GSUP_IE_PdpInfo(template (present) OCT1 ctx_id, + template (present) octetstring apn, + template (present) GSUP_PDP_Address pdp_address) := { + tag := OSMO_GSUP_PDP_INFO_IE, + len := ?, + val := { + pdp_info := { + tr_GSUP_IE_PDP_CONTEXT_ID(ctx_id), + tr_GSUP_IE_PDP_ADDRESS(pdp_address), + tr_GSUP_IE_APN(apn) + } + } +} +template (present) GSUP_IE tr_GSUP_IE_PdpInfo_ie(template (present) GSUP_IEs pdp_info := ?) := { + tag := OSMO_GSUP_PDP_INFO_IE, + len := ?, + val := { + pdp_info := pdp_info + } +} template (value) GSUP_IE ts_GSUP_IE_PDP_CONTEXT_ID(template (value) OCT1 ctx_id) := { tag := OSMO_GSUP_PDP_CONTEXT_ID_IE, @@ -207,7 +235,6 @@ } } - template (value) GSUP_IE ts_GSUP_IE_PDP_ADDRESS(template (value) GSUP_PDP_Address pdp_address) := { tag := OSMO_GSUP_PDP_ADDRESS_IE, len := 0, @@ -216,6 +243,14 @@ } } +template (present) GSUP_IE tr_GSUP_IE_PDP_ADDRESS(template (present) GSUP_PDP_Address pdp_address := ?) := { + tag := OSMO_GSUP_PDP_ADDRESS_IE, + len := ?, + val := { + pdp_address := pdp_address + } +} + template (value) GSUP_IE ts_GSUP_IE_PDP_QOS(template (value) octetstring pdp_qos) := { tag := OSMO_GSUP_PDP_QOS_IE, len := 0, @@ -224,6 +259,29 @@ } } +template (present) GSUP_IE tr_GSUP_IE_PDP_QOS(template (present) octetstring pdp_qos := ?) := { + tag := OSMO_GSUP_PDP_QOS_IE, + len := ?, + val := { + pdp_qos := pdp_qos + } +} + +template (value) GSUP_IE ts_GSUP_IE_Charging_Characteristics(template (value) octetstring charg_char) := { + tag := OSMO_GSUP_CHARG_CHAR_IE, + len := 0, + val := { + charg_char := charg_char + } +} + +template (present) GSUP_IE tr_GSUP_IE_Charging_Characteristics(template (present) octetstring charg_char := ?) := { + tag := OSMO_GSUP_CHARG_CHAR_IE, + len := ?, + val := { + charg_char := charg_char + } +} template GSUP_PDU tr_GSUP(template GSUP_MessageType msgt := ?, template GSUP_IEs ies := *) := { msg_type := msgt, @@ -428,19 +486,25 @@ template (value) GSUP_PDU ts_GSUP_EPDGTunnel_RES(hexstring imsi, + template (value) GSUP_IEs pdp_info, GSUP_Message_Class message_class := OSMO_GSUP_MESSAGE_CLASS_IPSEC_EPDG, octetstring destination_name := ''O) := ts_GSUP(OSMO_GSUP_MSGT_EPDG_TUNNEL_RESULT, { valueof(ts_GSUP_IE_IMSI(imsi)), + valueof(ts_GSUP_IE_PdpInfoCompl), + valueof(ts_GSUP_IE_PdpInfo_ie(pdp_info)), valueof(ts_GSUP_IE_Message_Class(message_class)), valueof(ts_GSUP_IE_Destination_Name(destination_name)) }); template (present) GSUP_PDU tr_GSUP_EPDGTunnel_RES(template (present) hexstring imsi, + template (present) GSUP_IEs pdp_info, template (present) GSUP_Message_Class message_class := OSMO_GSUP_MESSAGE_CLASS_IPSEC_EPDG, template octetstring destination_name := omit) := tr_GSUP(OSMO_GSUP_MSGT_EPDG_TUNNEL_RESULT, f_gen_tr_ies(imsi, + pdp_info_compl := true, + pdp_info := pdp_info, message_class := message_class, destination_name := destination_name)); @@ -1077,6 +1141,7 @@ } private function f_gen_ts_ies(hexstring imsi, + template (omit) boolean pdp_info_compl := omit, template (omit) GSUP_Message_Class message_class := omit, template (omit) hexstring imei := omit, template (omit) GSUP_CnDomain dom := omit, @@ -1091,6 +1156,10 @@ ies := ies & { valueof(ts_GSUP_IE_CnDomain(dom)) }; } + if (isvalue(pdp_info_compl) and valueof(pdp_info_compl)) { + ies := ies & { valueof(ts_GSUP_IE_PdpInfoCompl) }; + } + if (isvalue(imei)) { ies := ies & { valueof(ts_GSUP_IE_IMEI(valueof(imei))) }; } @@ -1111,6 +1180,8 @@ } private function f_gen_tr_ies(template hexstring imsi, + template boolean pdp_info_compl := omit, + template GSUP_IEs pdp_info := omit, template GSUP_Message_Class message_class := omit, template integer cause := omit, template hexstring msisdn := omit, @@ -1123,27 +1194,37 @@ }; var integer idx := 1; - if (isvalue(cause)) { - ies[idx] := tr_GSUP_IE_Cause(cause); - idx := idx + 1; - } - - if (isvalue(msisdn)) { + if (not istemplatekind(msisdn, "omit")) { ies[idx] := tr_GSUP_IE_MSISDN(msisdn); idx := idx + 1; } - if (isvalue(imei_result)) { + if (not istemplatekind(cause, "omit")) { + ies[idx] := tr_GSUP_IE_Cause(cause); + idx := idx + 1; + } + + if (not istemplatekind(pdp_info_compl, "omit")) { + ies[idx] := tr_GSUP_IE_PdpInfoCompl; + idx := idx + 1; + } + + if (not istemplatekind(pdp_info, "omit")) { + ies[idx] := tr_GSUP_IE_PdpInfo_ie(pdp_info); + idx := idx + 1; + } + + if (not istemplatekind(imei_result, "omit")) { ies[idx] := tr_GSUP_IE_IMEI_Result(imei_result); idx := idx + 1; } - if (isvalue(message_class)) { + if (not istemplatekind(message_class, "omit")) { ies[idx] := tr_GSUP_IE_Message_Class(message_class); idx := idx + 1; } - if (isvalue(source_name)) { + if (not istemplatekind(source_name, "omit")) { ies[idx] := tr_GSUP_IE_Source_Name(source_name); idx := idx + 1; } @@ -1151,8 +1232,12 @@ ies[idx] := *; idx := idx + 1; - if (isvalue(destination_name)) { - ies[idx] := tr_GSUP_IE_Destination_Name(destination_name); + if (not istemplatekind(destination_name, "omit")) { + if (istemplatekind(destination_name, "*")) { + ies[idx] := *; + } else { + ies[idx] := tr_GSUP_IE_Destination_Name(destination_name); + } idx := idx + 1; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35653?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaad47b1ec7e2a7477fa554df9caeb866ffa594eb Gerrit-Change-Number: 35653 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: GSUP: Fix PDPInfoCompl IE
by pespin 22 Jan '24

22 Jan '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35651?usp=email ) Change subject: GSUP: Fix PDPInfoCompl IE ...................................................................... GSUP: Fix PDPInfoCompl IE Change-Id: I7b6e584f12828019fc9c0f961a0c8692c0b44b1c --- M library/GSUP_Templates.ttcn M library/GSUP_Types.ttcn 2 files changed, 28 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/51/35651/1 diff --git a/library/GSUP_Templates.ttcn b/library/GSUP_Templates.ttcn index 634cfc3..7146e97 100644 --- a/library/GSUP_Templates.ttcn +++ b/library/GSUP_Templates.ttcn @@ -159,6 +159,22 @@ } } +template (value) GSUP_IE ts_GSUP_IE_PdpInfoCompl := { + tag := OSMO_GSUP_PDP_INFO_COMPL_IE, + len := 0, /* overwritten */ + val := { + pdp_info_compl := ''O + } +} + +template (present) GSUP_IE tr_GSUP_IE_PdpInfoCompl := { + tag := OSMO_GSUP_PDP_INFO_COMPL_IE, + len := 0, /* overwritten */ + val := { + pdp_info_compl := ''O + } +} + template GSUP_IE ts_GSUP_IE_PdpInfo(template (value) octetstring apn, template (value) GSUP_PDP_Address pdp_address, template (value) octetstring pdp_qos) := { diff --git a/library/GSUP_Types.ttcn b/library/GSUP_Types.ttcn index 666d8d0..07356f7 100644 --- a/library/GSUP_Types.ttcn +++ b/library/GSUP_Types.ttcn @@ -244,6 +244,7 @@ cause, tag = OSMO_GSUP_CAUSE_IE; cancel_type, tag = OSMO_GSUP_CANCEL_TYPE_IE; auth_tuple, tag = OSMO_GSUP_AUTH_TUPLE_IE; + pdp_info_compl, tag = OSMO_GSUP_PDP_INFO_COMPL_IE; auts, tag = OSMO_GSUP_AUTS_IE; rand, tag = OSMO_GSUP_RAND_IE; sres, tag = OSMO_GSUP_SRES_IE; @@ -301,8 +302,8 @@ hexstring imsi, integer cause, GSUP_CancelType cancel_type, - //boolean pdp_info_compl, - //boolean freeze_ptmsi, + octetstring pdp_info_compl, + //octetstring freeze_ptmsi, GSUP_IEs auth_tuple, octetstring auts, octetstring rand, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35651?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7b6e584f12828019fc9c0f961a0c8692c0b44b1c Gerrit-Change-Number: 35651 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in pysim[master]: osmo-smdpp: Implement eUICC + EUM certificate signature chain validation
by laforge 22 Jan '24

22 Jan '24

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/35635?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: osmo-smdpp: Implement eUICC + EUM certificate signature chain validation ...................................................................... osmo-smdpp: Implement eUICC + EUM certificate signature chain validation Change-Id: I961827c50ed5e34c6507bfdf853952ece5b0d121 --- M osmo-smdpp.py M pySim/esim/rsp.py 2 files changed, 43 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/35/35635/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35635?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I961827c50ed5e34c6507bfdf853952ece5b0d121 Gerrit-Change-Number: 35635 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in pysim[master]: osmo-smdpp: Handle case where client sends empty list of Pki Cert IDs
by laforge 22 Jan '24

22 Jan '24

laforge has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/35650?usp=email ) Change subject: osmo-smdpp: Handle case where client sends empty list of Pki Cert IDs ...................................................................... Abandoned merged in previous patch -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35650?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4541d11dc6f660b59a1ec5225428ddde8401817d Gerrit-Change-Number: 35650 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon

1 0

[M] Change in pysim[master]: osmo-smdpp: Implement eUICC + EUM certificate signature chain validation
by laforge 22 Jan '24

22 Jan '24

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/35635?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: osmo-smdpp: Implement eUICC + EUM certificate signature chain validation ...................................................................... osmo-smdpp: Implement eUICC + EUM certificate signature chain validation Change-Id: I961827c50ed5e34c6507bfdf853952ece5b0d121 --- M osmo-smdpp.py M pySim/esim/rsp.py 2 files changed, 43 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/35/35635/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35635?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I961827c50ed5e34c6507bfdf853952ece5b0d121 Gerrit-Change-Number: 35635 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in pysim[master]: New pySim.esim.x509_cert module for X.509 certificate handling
by laforge 22 Jan '24

22 Jan '24

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/35633?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: New pySim.esim.x509_cert module for X.509 certificate handling ...................................................................... New pySim.esim.x509_cert module for X.509 certificate handling Change-Id: Ia8cc2dac02fcd96624dc6d9348f103373eeeb614 --- A pySim/esim/x509_cert.py 1 file changed, 146 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/33/35633/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35633?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia8cc2dac02fcd96624dc6d9348f103373eeeb614 Gerrit-Change-Number: 35633 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in pysim[master]: Move X.509 related code from osmo-smdpp to pySim.esim.x509_cert
by laforge 22 Jan '24

22 Jan '24

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/35634?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Move X.509 related code from osmo-smdpp to pySim.esim.x509_cert ...................................................................... Move X.509 related code from osmo-smdpp to pySim.esim.x509_cert Change-Id: I230ba0537b702b0bf6e9da9a430908ed2a21ca61 --- M osmo-smdpp.py M pySim/esim/x509_cert.py 2 files changed, 86 insertions(+), 74 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/34/35634/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35634?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I230ba0537b702b0bf6e9da9a430908ed2a21ca61 Gerrit-Change-Number: 35634 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in pysim[master]: osmo-smdpp: Actually dump Rx/Tx JSON in JSON format and not as python...
by laforge 22 Jan '24

22 Jan '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/35613?usp=email ) Change subject: osmo-smdpp: Actually dump Rx/Tx JSON in JSON format and not as python dict ...................................................................... osmo-smdpp: Actually dump Rx/Tx JSON in JSON format and not as python dict Change-Id: Ieea3fd2d0f0239acfa6a5c4cfdbfd558d1a3e0ea --- M osmo-smdpp.py 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/osmo-smdpp.py b/osmo-smdpp.py index 6ae5be8..41cdfc8 100755 --- a/osmo-smdpp.py +++ b/osmo-smdpp.py @@ -252,13 +252,13 @@ # TODO: reject any non-JSON Content-type content = json.loads(request.content.read()) - print("Rx JSON: %s" % content) + print("Rx JSON: %s" % json.dumps(content)) set_headers(request) output = func(self, request, content) or {} build_resp_header(output) - print("Tx JSON: %s" % output) + print("Tx JSON: %s" % json.dumps(output)) return json.dumps(output) return _api_wrapper -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35613?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ieea3fd2d0f0239acfa6a5c4cfdbfd558d1a3e0ea Gerrit-Change-Number: 35613 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0