January 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-trx[master]: Transceiver::ctrl_sock_handle_rx(): fix copy-pasted comments
by fixeria 23 Jan '24

23 Jan '24

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/35655?usp=email ) Change subject: Transceiver::ctrl_sock_handle_rx(): fix copy-pasted comments ...................................................................... Transceiver::ctrl_sock_handle_rx(): fix copy-pasted comments Change-Id: If31c0de0b3562c06220dcb9ad6f0c13d8621f6e3 --- M Transceiver52M/Transceiver.cpp 1 file changed, 11 insertions(+), 3 deletions(-) Approvals: Hoernchen: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index fed4289..f5ddd9b 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -959,19 +959,18 @@ sprintf(response, "RSP NOHANDOVER 0 %u %u", ts, ss); } } else if (match_cmd(command, "SETMAXDLY", &params)) { - //set expected maximum time-of-arrival + //set expected maximum time-of-arrival for Access Bursts int maxDelay; sscanf(params, "%d", &maxDelay); mMaxExpectedDelayAB = maxDelay; // 1 GSM symbol is approx. 1 km sprintf(response,"RSP SETMAXDLY 0 %d",maxDelay); } else if (match_cmd(command, "SETMAXDLYNB", &params)) { - //set expected maximum time-of-arrival + //set expected maximum time-of-arrival for Normal Bursts int maxDelay; sscanf(params, "%d", &maxDelay); mMaxExpectedDelayNB = maxDelay; // 1 GSM symbol is approx. 1 km sprintf(response,"RSP SETMAXDLYNB 0 %d",maxDelay); } else if (match_cmd(command, "SETRXGAIN", &params)) { - //set expected maximum time-of-arrival int newGain; sscanf(params, "%d", &newGain); newGain = mRadioInterface->setRxGain(newGain, chan); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/35655?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If31c0de0b3562c06220dcb9ad6f0c13d8621f6e3 Gerrit-Change-Number: 35655 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: GSUP: Fix missing and wrongly sorted IEs in ts_GSUP_IE_PdpInfo
by pespin 23 Jan '24

23 Jan '24

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35652?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: GSUP: Fix missing and wrongly sorted IEs in ts_GSUP_IE_PdpInfo ...................................................................... GSUP: Fix missing and wrongly sorted IEs in ts_GSUP_IE_PdpInfo Sort them to follow libosmocore implementation. Change-Id: I65e586187d7230f122644c101f8467becae6e204 --- M library/GSUP_Templates.ttcn M sgsn/SGSN_Tests.ttcn 2 files changed, 20 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/52/35652/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35652?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I65e586187d7230f122644c101f8467becae6e204 Gerrit-Change-Number: 35652 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-trx[master]: Transceiver::ctrl_sock_handle_rx(): fix copy-pasted comments
by Hoernchen 23 Jan '24

23 Jan '24

Attention is currently required from: fixeria. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/35655?usp=email ) Change subject: Transceiver::ctrl_sock_handle_rx(): fix copy-pasted comments ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/35655?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If31c0de0b3562c06220dcb9ad6f0c13d8621f6e3 Gerrit-Change-Number: 35655 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Jan 2024 10:13:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmocom-bb[master]: mobile: add a separate logging category for CSD
by pespin 23 Jan '24

23 Jan '24

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35656?usp=email ) Change subject: mobile: add a separate logging category for CSD ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35656?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If9db0759aeb4324ace9ae258c852787f37897d83 Gerrit-Change-Number: 35656 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Jan 2024 10:13:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-trx[master]: Transceiver::ctrl_sock_handle_rx(): fix copy-pasted comments
by pespin 23 Jan '24

23 Jan '24

Attention is currently required from: Hoernchen, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/35655?usp=email ) Change subject: Transceiver::ctrl_sock_handle_rx(): fix copy-pasted comments ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/35655?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If31c0de0b3562c06220dcb9ad6f0c13d8621f6e3 Gerrit-Change-Number: 35655 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Jan 2024 10:11:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: osmo-bts-trx: add test VTY command to send arbitrary TRXC messages
by pespin 23 Jan '24

23 Jan '24

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35654?usp=email ) Change subject: osmo-bts-trx: add test VTY command to send arbitrary TRXC messages ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35654?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iabc9b702e5f1513187e24f45d9ffe06ea940c3ec Gerrit-Change-Number: 35654 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 Jan 2024 10:09:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: mobile: handle V.24 line status updates from V.110 TA
by fixeria 22 Jan '24

22 Jan '24

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35640?usp=email ) Change subject: mobile: handle V.24 line status updates from V.110 TA ...................................................................... Patch Set 3: (1 comment) File src/host/layer23/src/mobile/tch_data.c: https://gerrit.osmocom.org/c/osmocom-bb/+/35640/comment/540f71ec_ebfe76da PS2, Line 210: LOGP(DL1C, LOGL_NOTICE, "V.110 TA circuit %s (%s) is %s\n", > this is something that happens on aregular basis, IMHO it should be DEBUG and not NOTICE. […] I agree in genral, but I don't expect the circuit state to change too often, unless the flow control is employed. Even in the later case, `LOGL_INFO` should be ok. See also: https://gerrit.osmocom.org/c/osmocom-bb/+/35656. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35640?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I05ba2e10fefe3cae687831b5ced971aa244ad336 Gerrit-Change-Number: 35640 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 22 Jan 2024 21:30:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[M] Change in osmocom-bb[master]: [TEST] mobile: add config files for convenience
by fixeria 22 Jan '24

22 Jan '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35657?usp=email ) Change subject: [TEST] mobile: add config files for convenience ...................................................................... [TEST] mobile: add config files for convenience Change-Id: Ib01245b31edee0833bd415aca608baba943a0731 --- A src/host/layer23/cfg/1.ba A src/host/layer23/cfg/mobile1.cfg A src/host/layer23/cfg/mobile2.cfg 3 files changed, 227 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/57/35657/1 diff --git a/src/host/layer23/cfg/1.ba b/src/host/layer23/cfg/1.ba new file mode 100644 index 0000000..f0531c4 --- /dev/null +++ b/src/host/layer23/cfg/1.ba Binary files differ diff --git a/src/host/layer23/cfg/mobile1.cfg b/src/host/layer23/cfg/mobile1.cfg new file mode 100644 index 0000000..84c5504 --- /dev/null +++ b/src/host/layer23/cfg/mobile1.cfg @@ -0,0 +1,108 @@ +log gsmtap 127.0.1.1 + logging level set-all debug + logging filter all 1 +log stderr + logging filter all 1 + logging print file basename + logging print category-hex 0 + logging print category 1 + logging print level 1 + logging timestamp 0 + logging color 1 + ! + logging level set-all notice + logging level lglobal info + logging level lsms info + logging level rsl notice + logging level rr debug + logging level plmn debug + logging level cs debug + logging level nb notice + logging level mm debug + logging level cc debug + logging level ss debug + logging level sms debug + logging level mncc debug + logging level meas debug + logging level pag debug + logging level l1c error + logging level sap debug + logging level sum debug + logging level sim debug + logging level gps debug + logging level mob debug + logging level prim debug + logging level lua debug +! +line vty + no login + bind 127.0.1.1 +! +no hide-default +! +gsmtap + remote-host 127.0.1.1 +ms 1 + layer2-socket /tmp/osmocom_l2.1 + sap-socket /tmp/osmocom_sap.1 + sim test + network-selection-mode auto + imei 350608603062429 0 + imei-fixed + no emergency-imsi +! sms-service-center +491722270333 + no call-waiting + no auto-answer + no force-rekey + no clip + no clir + tx-power auto + no simulated-delay + stick 74 + location-updating + no neighbour-measurement + codec full-speed prefer + codec half-speed + no abbrev + support + sms + a5/1 + no a5/2 + p-gsm + e-gsm + r-gsm + no gsm-850 + dcs + no pcs + class-900 4 + class-850 4 + class-dcs 1 + class-pcs 1 + channel-capability sdcch+tchf + full-speech-v1 + full-speech-v2 + half-speech-v1 + no full-data-14400 + full-data-9600 + full-data-4800 + half-data-4800 + full-data-2400 + half-data-2400 + min-rxlev -106 + dsc-max 90 + no skip-max-per-band + test-sim + imsi 001010000000001 + ki comp128 ca 7c 46 10 0f 8d 25 e6 16 eb a9 b7 a6 6d 13 7f + no barred-access + rplmn 901 70 + hplmn-search everywhere + c7-any-timeout 30 + tch-data + io-handler unix-sock + io-tch-format ti + unix-socket /tmp/ms_data.1 + tch-voice + io-handler loopback +! io-tch-format ti + no shutdown diff --git a/src/host/layer23/cfg/mobile2.cfg b/src/host/layer23/cfg/mobile2.cfg new file mode 100644 index 0000000..4e43f42 --- /dev/null +++ b/src/host/layer23/cfg/mobile2.cfg @@ -0,0 +1,110 @@ +log gsmtap 127.0.2.1 + logging level set-all debug + logging filter all 1 +log stderr + logging filter all 1 + logging print file basename + logging print category-hex 0 + logging print category 1 + logging print level 1 + logging timestamp 0 + logging color 1 + ! + logging level set-all notice + logging level lglobal info + logging level lsms info + logging level rsl notice + logging level rr debug + logging level plmn debug + logging level cs debug + logging level nb notice + logging level mm debug + logging level cc debug + logging level ss debug + logging level sms debug + logging level mncc debug + logging level meas debug + logging level pag debug + logging level l1c error + logging level sap debug + logging level sum debug + logging level sim debug + logging level gps debug + logging level mob debug + logging level prim debug + logging level lua debug +! +line vty + no login + bind 127.0.2.1 +! +no gps enable +! +no hide-default +! +gsmtap + remote-host 127.0.2.1 +ms 1 + layer2-socket /tmp/osmocom_l2.2 + sap-socket /tmp/osmocom_sap.2 + sim test + network-selection-mode auto + imei 350608603062429 0 + imei-fixed + no emergency-imsi +! sms-service-center +491722270333 + no call-waiting + no auto-answer + no force-rekey + no clip + no clir + tx-power auto + no simulated-delay + stick 74 + location-updating + no neighbour-measurement + codec full-speed prefer + codec half-speed + no abbrev + support + sms + a5/1 + no a5/2 + p-gsm + e-gsm + r-gsm + no gsm-850 + dcs + no pcs + class-900 4 + class-850 4 + class-dcs 1 + class-pcs 1 + channel-capability sdcch+tchf + full-speech-v1 + full-speech-v2 + half-speech-v1 + no full-data-14400 + full-data-9600 + full-data-4800 + half-data-4800 + full-data-2400 + half-data-2400 + min-rxlev -106 + dsc-max 90 + no skip-max-per-band + test-sim + imsi 001010000000002 + ki comp128 ca 7c 46 10 0f 8d 25 e6 16 eb a9 b7 a6 6d 13 7f + no barred-access + rplmn 901 70 + hplmn-search everywhere + c7-any-timeout 30 + tch-data + io-handler unix-sock + io-tch-format ti + unix-socket /tmp/ms_data.2 + tch-voice + io-handler loopback +! io-tch-format ti + no shutdown -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35657?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib01245b31edee0833bd415aca608baba943a0731 Gerrit-Change-Number: 35657 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmocom-bb[master]: mobile: add a separate logging category for CSD
by fixeria 22 Jan '24

22 Jan '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35656?usp=email ) Change subject: mobile: add a separate logging category for CSD ...................................................................... mobile: add a separate logging category for CSD Change-Id: If9db0759aeb4324ace9ae258c852787f37897d83 Related: OS#4396 --- M src/host/layer23/include/osmocom/bb/common/logging.h M src/host/layer23/src/common/logging.c M src/host/layer23/src/mobile/tch_data.c M src/host/layer23/src/mobile/tch_data_sock.c 4 files changed, 36 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/56/35656/1 diff --git a/src/host/layer23/include/osmocom/bb/common/logging.h b/src/host/layer23/include/osmocom/bb/common/logging.h index 40a7e81..3920d2e 100644 --- a/src/host/layer23/include/osmocom/bb/common/logging.h +++ b/src/host/layer23/include/osmocom/bb/common/logging.h @@ -28,6 +28,7 @@ DPRIM, DLUA, DGAPK, + DCSD, DTUN, DRLCMAC, DLLC, diff --git a/src/host/layer23/src/common/logging.c b/src/host/layer23/src/common/logging.c index 0401360..283b7f1 100644 --- a/src/host/layer23/src/common/logging.c +++ b/src/host/layer23/src/common/logging.c @@ -159,6 +159,12 @@ .color = "\033[0;36m", .enabled = 1, .loglevel = LOGL_DEBUG, }, + [DCSD] = { + .name = "DCSD", + .description = "Circuit Switched Data", + .color = "\033[0;36m", + .enabled = 1, .loglevel = LOGL_DEBUG, + }, [DTUN] = { .name = "DTUN", .description = "Tunnel interface", diff --git a/src/host/layer23/src/mobile/tch_data.c b/src/host/layer23/src/mobile/tch_data.c index 6ee89dc..7169efa 100644 --- a/src/host/layer23/src/mobile/tch_data.c +++ b/src/host/layer23/src/mobile/tch_data.c @@ -81,7 +81,7 @@ { struct tch_data_state *state = (struct tch_data_state *)priv; - LOGP(DL1C, LOGL_DEBUG, "%s(): [flags=0x%08x] %s\n", + LOGP(DCSD, LOGL_DEBUG, "%s(): [flags=0x%08x] %s\n", __func__, flags, msgb_hexdump(msg)); if (state->sock != NULL && msgb_length(msg) > 0) @@ -96,7 +96,7 @@ tch_csd_sock_recv(state->sock, msg); - LOGP(DL1C, LOGL_DEBUG, "%s(): [n_bytes=%u/%u] %s\n", + LOGP(DCSD, LOGL_DEBUG, "%s(): [n_bytes=%u/%u] %s\n", __func__, msg->len, msg->data_len, msgb_hexdump(msg)); } @@ -166,7 +166,7 @@ tch_csd_sock_recv(state->sock, msg); if (msgb_length(msg) < buf_size) { - LOGP(DL1C, LOGL_NOTICE, + LOGP(DCSD, LOGL_NOTICE, "%s(): not enough bytes for sync Tx (%u < %zu)\n", __func__, msgb_length(msg), buf_size); } @@ -189,7 +189,7 @@ static void tch_v110_ta_status_update_cb(void *priv, unsigned int status) { - LOGP(DL1C, LOGL_DEBUG, "%s(): [status=0x%08x]\n", __func__, status); + LOGP(DCSD, LOGL_DEBUG, "%s(): [status=0x%08x]\n", __func__, status); /* TODO: update status lines of the soft-UART (if state.suart != NULL) */ } @@ -233,7 +233,7 @@ * signalling rate shall be adapted to a synchronous 600 bit/s stream. */ case BCAP_RATE(GSM48_BCAP_IR_8k, GSM48_BCAP_UR_300): default: - LOGP(DCC, LOGL_ERROR, + LOGP(DCSD, LOGL_ERROR, "%s(): IR 0x%02x / UR 0x%02x combination is not supported\n", __func__, bcap->data.interm_rate, bcap->data.user_rate); return NULL; @@ -367,20 +367,20 @@ static int tch_data_check_bcap(const struct gsm_mncc_bearer_cap *bcap) { if (bcap == NULL) { - LOGP(DL1C, LOGL_ERROR, + LOGP(DCSD, LOGL_ERROR, "%s(): CC transaction without BCap\n", __func__); return -ENODEV; } if (bcap->mode != GSM48_BCAP_TMOD_CIRCUIT) { - LOGP(DCC, LOGL_ERROR, + LOGP(DCSD, LOGL_ERROR, "%s(): Transfer mode 0x%02x is not supported\n", __func__, bcap->mode); return -ENOTSUP; } if (bcap->coding != GSM48_BCAP_CODING_GSM_STD) { - LOGP(DCC, LOGL_ERROR, + LOGP(DCSD, LOGL_ERROR, "%s(): Coding standard 0x%02x is not supported\n", __func__, bcap->coding); return -ENOTSUP; @@ -392,26 +392,26 @@ case GSM48_BCAP_ITCAP_FAX_G3: break; default: - LOGP(DCC, LOGL_ERROR, + LOGP(DCSD, LOGL_ERROR, "%s(): Information transfer capability 0x%02x is not supported\n", __func__, bcap->transfer); return -ENOTSUP; } if (bcap->data.rate_adaption != GSM48_BCAP_RA_V110_X30) { - LOGP(DCC, LOGL_ERROR, + LOGP(DCSD, LOGL_ERROR, "%s(): Rate adaption (octet 5) 0x%02x is not supported\n", __func__, bcap->data.rate_adaption); return -ENOTSUP; } if (bcap->data.sig_access != GSM48_BCAP_SA_I440_I450) { - LOGP(DCC, LOGL_ERROR, + LOGP(DCSD, LOGL_ERROR, "%s(): Signalling access protocol (octet 5) 0x%02x is not supported\n", __func__, bcap->data.sig_access); return -ENOTSUP; } if (bcap->data.transp != GSM48_BCAP_TR_TRANSP) { - LOGP(DCC, LOGL_ERROR, + LOGP(DCSD, LOGL_ERROR, "%s(): only transparent calls are supported so far\n", __func__); return -ENOTSUP; @@ -514,7 +514,7 @@ struct tch_data_state *state = NULL; if (ms->tch_state == NULL || ms->tch_state->is_voice) { - LOGP(DCC, LOGL_INFO, "No data call is ongoing, " + LOGP(DCSD, LOGL_INFO, "No data call is ongoing, " "ignoring [dis]connection event for CSD socket\n"); return; } diff --git a/src/host/layer23/src/mobile/tch_data_sock.c b/src/host/layer23/src/mobile/tch_data_sock.c index 7bfebf3..7ce5a4f 100644 --- a/src/host/layer23/src/mobile/tch_data_sock.c +++ b/src/host/layer23/src/mobile/tch_data_sock.c @@ -51,7 +51,7 @@ { struct osmo_fd *bfd = &state->conn_bfd; - LOGP(DMOB, LOGL_NOTICE, "TCH CSD sock has closed connection\n"); + LOGP(DCSD, LOGL_NOTICE, "TCH CSD sock has closed connection\n"); tch_csd_sock_state_cb(state->ms, false); @@ -155,25 +155,25 @@ len = sizeof(un_addr); rc = accept(bfd->fd, (struct sockaddr *)&un_addr, &len); if (rc < 0) { - LOGP(DMOB, LOGL_ERROR, "Failed to accept() a new connection\n"); + LOGP(DCSD, LOGL_ERROR, "Failed to accept() a new connection\n"); return -1; } if (conn_bfd->fd >= 0) { - LOGP(DMOB, LOGL_NOTICE, "TCH CSD sock already has an active connection\n"); + LOGP(DCSD, LOGL_NOTICE, "TCH CSD sock already has an active connection\n"); close(rc); /* reject this connection request */ return 0; } osmo_fd_setup(conn_bfd, rc, OSMO_FD_READ, &tch_csd_sock_cb, state, 0); if (osmo_fd_register(conn_bfd) != 0) { - LOGP(DMOB, LOGL_ERROR, "osmo_fd_register() failed\n"); + LOGP(DCSD, LOGL_ERROR, "osmo_fd_register() failed\n"); close(conn_bfd->fd); conn_bfd->fd = -1; return -1; } - LOGP(DMOB, LOGL_NOTICE, "TCH CSD sock got a connection\n"); + LOGP(DCSD, LOGL_NOTICE, "TCH CSD sock got a connection\n"); tch_csd_sock_state_cb(state->ms, true); @@ -200,7 +200,7 @@ rc = osmo_sock_unix_init_ofd(bfd, SOCK_STREAM, 0, sock_path, OSMO_SOCK_F_BIND); if (rc < 0) { - LOGP(DMOB, LOGL_ERROR, "Could not create unix socket: %s\n", strerror(errno)); + LOGP(DCSD, LOGL_ERROR, "Could not create unix socket: %s\n", strerror(errno)); talloc_free(state); return NULL; } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35656?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If9db0759aeb4324ace9ae258c852787f37897d83 Gerrit-Change-Number: 35656 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmocom-bb[master]: mobile: handle V.24 line status updates from V.110 TA
by fixeria 22 Jan '24

22 Jan '24

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/35640?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: mobile: handle V.24 line status updates from V.110 TA ...................................................................... mobile: handle V.24 line status updates from V.110 TA Change-Id: I05ba2e10fefe3cae687831b5ced971aa244ad336 Related: OS#4396 --- M src/host/layer23/src/mobile/tch_data.c 1 file changed, 36 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/40/35640/3 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35640?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I05ba2e10fefe3cae687831b5ced971aa244ad336 Gerrit-Change-Number: 35640 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0