August 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-sgsn[master]: sgsn_rim: forward message based on RIM ROUTING ADDRESS

by osmith

Attention is currently required from: pespin, dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/34122 ) Change subject: sgsn_rim: forward message based on RIM ROUTING ADDRESS ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/34122 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ifd2b915ed2f05130cff8ee77714b82005c17de3d Gerrit-Change-Number: 34122 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Aug 2023 13:00:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 12 months

1
0
0 0

[S] Change in pysim[master]: sim-reset-server: fix error printing sw_match_error

by osmith

Attention is currently required from: dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34155 ) Change subject: sim-reset-server: fix error printing sw_match_error ...................................................................... Patch Set 1: (1 comment) File contrib/sim-rest-server.py: https://gerrit.osmocom.org/c/pysim/+/34155/comment/c6e47279_21e638f9 PS1, Line 104: failure.value If the information inside value.error is useful, I'd suggest converting it to a string instead. Looks like str(failure.value) would fix this. As I understand it, failure.value is of type ApiError when the error mentioned in the commit message appears. And the same line already converts an ApiError to str() the same way. Another (IMHO more elegant) way to write this would be with f-string, which implictly converts failure.value to string: ``` return str(ApiError(f"Card Communication Error: {failure.value}"), sw) ``` -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34155 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5a1d19abeb00c2c9dc26517abc44a5c916f2d658 Gerrit-Change-Number: 34155 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Aug 2023 12:50:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 12 months

1
0
0 0

[S] Change in pysim[master]: sim-rest-server: fix REST method info

by osmith

Attention is currently required from: dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34154 ) Change subject: sim-rest-server: fix REST method info ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34154 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib0178823abb18187404249cfed71cfb3123d1d74 Gerrit-Change-Number: 34154 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Aug 2023 12:40:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 12 months

1
0
0 0

[S] Change in pysim[master]: sim-rest-server: use UiccCardBase instead of UsimCard

by osmith

Attention is currently required from: dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34153 ) Change subject: sim-rest-server: use UiccCardBase instead of UsimCard ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34153 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3676f033833665751c0d953176eafe175b20c14a Gerrit-Change-Number: 34153 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Aug 2023 12:39:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 12 months

1
0
0 0

[S] Change in pysim[master]: sim-rest-server: do not select ADF.USIM in connect_to_card

by osmith

Attention is currently required from: dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34152 ) Change subject: sim-rest-server: do not select ADF.USIM in connect_to_card ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34152 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I16e7f3c991c83f81989ecc4e4764bb6cc799c01d Gerrit-Change-Number: 34152 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Aug 2023 12:38:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 12 months

1
0
0 0

[S] Change in pysim[master]: cards: get rid of method read_iccid

by osmith

Attention is currently required from: dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34151 ) Change subject: cards: get rid of method read_iccid ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34151 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ied3ae6fd107992abcc1b5ea3edb0eb4bdcd2f892 Gerrit-Change-Number: 34151 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Aug 2023 12:37:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 12 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: MME_Tests: add testcase TC_s1ap_reset

by osmith

Attention is currently required from: dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34156 ) Change subject: MME_Tests: add testcase TC_s1ap_reset ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34156 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I23f4d5f2c39790b6cb0dacaec1e31912177af3ec Gerrit-Change-Number: 34156 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Aug 2023 12:34:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 12 months

1
0
0 0

[M] Change in osmo-gsm-manuals[master]: build: replace inkscape with rsvg-convert

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/34158 ) Change subject: build: replace inkscape with rsvg-convert ...................................................................... Patch Set 1: Verified+1 (1 comment) Patchset: PS1: I have verified that it works. CI fails because it needs to be merged at the same time as the docker-playground patch (to make rsvg-convert available). -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/34158 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I0d132f8f6fd73fbe14b5bfa10a8659acaddf38f7 Gerrit-Change-Number: 34158 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Aug 2023 12:10:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 12 months

1
0
0 0

[M] Change in osmo-gsm-manuals[master]: build: replace inkscape with rsvg-convert

by osmith

Attention is currently required from: osmith. osmith has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/34158 ) Change subject: build: replace inkscape with rsvg-convert ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/34158 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I0d132f8f6fd73fbe14b5bfa10a8659acaddf38f7 Gerrit-Change-Number: 34158 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: deleteVote

1 year, 12 months

1
0
0 0

[S] Change in docker-playground[master]: debian-bookworm-build: inkscape -> librsvg2-bin

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/34162 ) Change subject: debian-bookworm-build: inkscape -> librsvg2-bin ...................................................................... debian-bookworm-build: inkscape -> librsvg2-bin Merge at the same time as the osmo-gsm-manuals patch. Depends: osmo-gsm-manuals I0d132f8f6fd73fbe14b5bfa10a8659acaddf38f7 Change-Id: I012c61eb777e6dc267dd4a52500da98c01ac1438 --- M debian-bookworm-build/Dockerfile 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/62/34162/1 diff --git a/debian-bookworm-build/Dockerfile b/debian-bookworm-build/Dockerfile index f019bd0..5c4c829 100644 --- a/debian-bookworm-build/Dockerfile +++ b/debian-bookworm-build/Dockerfile @@ -84,7 +84,6 @@ gnupg \ graphviz \ htop \ - inkscape \ iproute2 \ latexmk \ lcov \ @@ -97,6 +96,7 @@ libdbd-sqlite3 \ libdbi-dev \ libelf-dev \ + librsvg2-bin \ libffi-dev \ libfftw3-dev \ libgmp-dev \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34162 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I012c61eb777e6dc267dd4a52500da98c01ac1438 Gerrit-Change-Number: 34162 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 12 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2023