Attention is currently required from: dexter.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34134 )
Change subject: pcuif_proto: get rid of _DT, _dt (Direct TLLI)
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File include/osmocom/pcu/pcuif_proto.h:
https://gerrit.osmocom.org/c/osmo-pcu/+/34134/comment/032edab9_9717a475
PS1, Line 21: #define PCU_IF_MSG_DATA_CNF_DT 0x11 /* confirm (using message id) */
I'm not sure if we need backwards compatibility here (keep the old define next to the new one)? But given that Pau already +1'd probably not.
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34134
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: If641b507dcb6b176109c99dce7cff2a7561364b0
Gerrit-Change-Number: 34134
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 17 Aug 2023 13:13:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: dexter.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34101 )
Change subject: bts: get rid of fn parameter in bts_rcv_imm_ass_cnf
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34101
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I35bc99eaec5d0287ae3916bc668f0babaddfd6ce
Gerrit-Change-Number: 34101
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 17 Aug 2023 13:09:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment