August 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bsc[master]: pcuif_proto: rename tlli to msg_id

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34106 ) Change subject: pcuif_proto: rename tlli to msg_id ...................................................................... pcuif_proto: rename tlli to msg_id To confirm downlink IMMEDIATE ASSIGNMENT messages, we use the TLLI as an identifier and the related struct member is also called "tlli". Unfortunately this is misleading since the message identifier does not necessarly have to be a TLLI. It is just an implementation detail that osmo-pcu uses the TLLI as a message identifier. To make that clear, lets rename the tlli member (and variable and parameter names where it is passed on) to "msg_id". (Since this change only renames variables and struct members it will not break compatibility with other programs that use the PCUIF) Related: OS#5927 Depends: osmo-pcu.git I4a25039dfe329e68879bc68936e49c4b190625e6 Change-Id: Ifb3f257099b52c50e525768484f9e93282089d0f --- M include/osmocom/bsc/abis_rsl.h M include/osmocom/bsc/pcu_if.h M include/osmocom/bsc/pcuif_proto.h M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/pcu_sock.c 5 files changed, 41 insertions(+), 21 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/include/osmocom/bsc/abis_rsl.h b/include/osmocom/bsc/abis_rsl.h index 3da0d6c..a6b2cef 100644 --- a/include/osmocom/bsc/abis_rsl.h +++ b/include/osmocom/bsc/abis_rsl.h @@ -67,7 +67,7 @@ int rsl_relase_request(struct gsm_lchan *lchan, uint8_t link_id); /* Ericcson vendor specific RSL extensions */ -int rsl_ericsson_imm_assign_cmd(const struct gsm_bts *bts, uint32_t tlli, uint8_t len, +int rsl_ericsson_imm_assign_cmd(const struct gsm_bts *bts, uint32_t msg_id, uint8_t len, const uint8_t *val, uint8_t pag_grp); /* Siemens vendor-specific RSL extensions */ diff --git a/include/osmocom/bsc/pcu_if.h b/include/osmocom/bsc/pcu_if.h index 525b2e4..d2d3444 100644 --- a/include/osmocom/bsc/pcu_if.h +++ b/include/osmocom/bsc/pcu_if.h @@ -25,7 +25,7 @@ uint8_t is_11bit, enum ph_burst_type burst_type); /* Confirm the sending of an immediate assignment to the pcu */ -int pcu_tx_pch_confirm(struct gsm_bts *bts, uint32_t tlli); +int pcu_tx_pch_confirm(struct gsm_bts *bts, uint32_t msg_id); /* Open connection to PCU */ int pcu_sock_init(struct gsm_network *net); diff --git a/include/osmocom/bsc/pcuif_proto.h b/include/osmocom/bsc/pcuif_proto.h index 1dda160..80e3b6d 100644 --- a/include/osmocom/bsc/pcuif_proto.h +++ b/include/osmocom/bsc/pcuif_proto.h @@ -41,7 +41,7 @@ #define PCU_IF_SAPI_PDTCH 0x05 /* packet data/control/ccch block */ #define PCU_IF_SAPI_PRACH 0x06 /* packet random access channel */ #define PCU_IF_SAPI_PTCCH 0x07 /* packet TA control channel */ -#define PCU_IF_SAPI_PCH_DT 0x08 /* assignment on PCH (confirmed using TLLI) */ +#define PCU_IF_SAPI_PCH_DT 0x08 /* assignment on PCH (confirmed using message id) */ /* flags */ #define PCU_IF_FLAG_ACTIVE (1 << 0)/* BTS is active */ @@ -93,10 +93,10 @@ int16_t lqual_cb; /* !< \brief Link quality in centiBel */ } __attribute__ ((packed)); -/* data confirmation with direct tlli (instead of raw mac block with tlli) */ +/* data confirmation with message id (instead of raw mac block) */ struct gsm_pcu_if_data_cnf_dt { uint8_t sapi; - uint32_t tlli; + uint32_t msg_id; uint32_t fn; uint16_t arfcn; uint8_t trx_nr; @@ -274,8 +274,8 @@ /* Struct to send a (confirmed) IMMEDIATE ASSIGNMENT message via PCH. The struct is sent as a data request * (data_req) under SAPI PCU_IF_SAPI_PCH_DT. */ struct gsm_pcu_if_pch_dt { - /* TLLI as reference for confirmation */ - uint32_t tlli; + /* message id as reference for confirmation */ + uint32_t msg_id; /* IMSI (to derive paging group) */ char imsi[OSMO_IMSI_BUF_SIZE]; /* GSM mac-block (with immediate assignment message) */ diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 3bc5808..5440a23 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -995,7 +995,7 @@ } /* Chapter 8.5.6 Immediate Assignment Command (with Ericcson vendor specific RSL extension) */ -int rsl_ericsson_imm_assign_cmd(const struct gsm_bts *bts, uint32_t tlli, uint8_t len, +int rsl_ericsson_imm_assign_cmd(const struct gsm_bts *bts, uint32_t msg_id, uint8_t len, const uint8_t *val, uint8_t pag_grp) { struct msgb *msg = rsl_imm_assign_cmd_common(bts, len, val); @@ -1009,7 +1009,7 @@ /* ericsson can handle a reference at the end of the message which is used in * the confirm message. The confirm message is only sent if the trailer is present */ msgb_put_u8(msg, RSL_IE_ERIC_MOBILE_ID); - msgb_put_u32(msg, tlli); + msgb_put_u32(msg, msg_id); return abis_rsl_sendmsg(msg); } @@ -2552,7 +2552,7 @@ { struct e1inp_sign_link *sign_link = msg->dst; struct abis_rsl_dchan_hdr *dh = msgb_l2(msg); - uint32_t tlli; + uint32_t msg_id; LOGP(DRSL, LOGL_INFO, "IMM.ass sent\n"); msgb_pull(msg, sizeof(*dh)); @@ -2564,8 +2564,8 @@ LOGP(DRSL, LOGL_ERROR, "unsupported IMM.ass message format! (please fix)\n"); else { msgb_pull(msg, 1); /* drop previous data to use msg_pull_u32 */ - tlli = msgb_pull_u32(msg); - pcu_tx_pch_confirm(sign_link->trx->bts, tlli); + msg_id = msgb_pull_u32(msg); + pcu_tx_pch_confirm(sign_link->trx->bts, msg_id); } return 0; } diff --git a/src/osmo-bsc/pcu_sock.c b/src/osmo-bsc/pcu_sock.c index 8a1d5b0..5353081 100644 --- a/src/osmo-bsc/pcu_sock.c +++ b/src/osmo-bsc/pcu_sock.c @@ -436,13 +436,13 @@ } /* Confirm the sending of an immediate assignment to the pcu */ -int pcu_tx_pch_confirm(struct gsm_bts *bts, uint32_t tlli) +int pcu_tx_pch_confirm(struct gsm_bts *bts, uint32_t msg_id) { struct msgb *msg; struct gsm_pcu_if *pcu_prim; struct gsm_pcu_if_data_cnf_dt *data_cnf_dt; - LOG_BTS(bts, DPCU, LOGL_INFO, "Sending PCH confirm with direct TLLI\n"); + LOG_BTS(bts, DPCU, LOGL_INFO, "Sending PCH confirm with message id\n"); msg = pcu_msgb_alloc(PCU_IF_MSG_DATA_CNF_DT, bts->nr); if (!msg) @@ -451,7 +451,7 @@ data_cnf_dt = &pcu_prim->u.data_cnf_dt; data_cnf_dt->sapi = PCU_IF_SAPI_PCH_DT; - data_cnf_dt->tlli = tlli; + data_cnf_dt->msg_id = msg_id; return pcu_sock_send(bts->network, msg); } @@ -508,15 +508,15 @@ static int pcu_rx_rr_imm_ass_pch(struct gsm_bts *bts, uint8_t paging_group, const struct gsm_pcu_if_pch_dt *pch_dt) { - LOG_BTS(bts, DPCU, LOGL_DEBUG, "PCU Sends immediate assignment via PCH (TLLI=0x%08x, IMSI=%s, Paging group=0x%02x)\n", - pch_dt->tlli, pch_dt->imsi, paging_group); + LOG_BTS(bts, DPCU, LOGL_DEBUG, "PCU Sends immediate assignment via PCH (msg_id=0x%08x, IMSI=%s, Paging group=0x%02x)\n", + pch_dt->msg_id, pch_dt->imsi, paging_group); /* NOTE: Sending an IMMEDIATE ASSIGNMENT via PCH became necessary with GPRS in order to be able to * assign downlink TBFs directly through the paging channel. However, this method never became part * of the RSL specs. This means that each BTS vendor has to come up with a proprietary method. At * the moment we only support Ericsson RBS here. */ if (is_ericsson_bts(bts)) - return rsl_ericsson_imm_assign_cmd(bts, pch_dt->tlli, sizeof(pch_dt->data), pch_dt->data, paging_group); + return rsl_ericsson_imm_assign_cmd(bts, pch_dt->msg_id, sizeof(pch_dt->data), pch_dt->data, paging_group); LOG_BTS(bts, DPCU, LOGL_ERROR, "BTS model does not support sending immediate assignment via PCH!\n"); return -ENOTSUP; @@ -541,9 +541,6 @@ rc = -EIO; break; case PCU_IF_SAPI_PCH_DT: - /* DT = direct TLLI. A tlli is prefixed so that the BSC/BTS can confirm the sending of the downlink - * IMMEDIATE ASSIGNMENT or PAGING COMMAND towards the PCU using this TLLI as a reference. */ - if (data_req->len < sizeof(struct gsm_pcu_if_pch_dt)) { LOG_BTS(bts, DPCU, LOGL_ERROR, "Received PCU data request with invalid/small length %d\n", data_req->len); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34106 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifb3f257099b52c50e525768484f9e93282089d0f Gerrit-Change-Number: 34106 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 12 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: PCUIF: rename tlli to msg_id

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34108 ) Change subject: PCUIF: rename tlli to msg_id ...................................................................... PCUIF: rename tlli to msg_id To confirm downlink IMMEDIATE ASSIGNMENT messages, we use the TLLI as an identifier and the related record member is also called "tlli". Unfortunately this is misleading since the message identifier does not necessarly have to be a TLLI. It is just an implementation detail that osmo-pcu uses the TLLI as a message identifier. To make that clear, lets rename the tlli member (and variable and parameter names where it is passed on) to "msg_id". (Since this change only renames variables and struct members it will not break compatibility with other programs that use the PCUIF) Related: OS#5927 Depends: osmo-pcu.git I4a25039dfe329e68879bc68936e49c4b190625e6 Change-Id: I1db29d5b1920e351c452b798c3260654c2cbe0cb --- M bts/BTS_Tests.ttcn M library/PCUIF_CodecPort.ttcn M library/PCUIF_Types.ttcn M pcu/PCUIF_Components.ttcn 4 files changed, 38 insertions(+), 15 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 1ab0f8a..e8ae1c0 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -5820,7 +5820,7 @@ f_pcu_data_req(0, 0, 0, 0, 0, PCU_IF_SAPI_PCH, '313233'O & c_PCU_DATA); } else { var PCUIF_pch_dt pch_dt; - pch_dt.tlli := '01020304'O; + pch_dt.msg_id := '01020304'O; pch_dt.imsi := "00101000000000123"; pch_dt.data := c_PCU_DATA; f_pcu_data_req(0, 0, 0, 0, 0, PCU_IF_SAPI_PCH_DT, enc_PCUIF_pch_dt(pch_dt)); diff --git a/library/PCUIF_CodecPort.ttcn b/library/PCUIF_CodecPort.ttcn index 8824a11..87a5b15 100644 --- a/library/PCUIF_CodecPort.ttcn +++ b/library/PCUIF_CodecPort.ttcn @@ -140,7 +140,7 @@ } function f_PCUIF_tx_imm_ass_pch(PCUIF_CODEC_PT pt, integer conn_id, octetstring imm_ass, hexstring imsi, - uint8_t bts_nr := 0, boolean wait_for_cnf := true, OCT4 tlli := '01020304'O) return uint32_t { + uint8_t bts_nr := 0, boolean wait_for_cnf := true, OCT4 msg_id := '01020304'O) return uint32_t { var PCUIF_send_data sd; timer T := 3.0; @@ -156,7 +156,7 @@ ts_PCUIF_DATA_REQ(bts_nr, 0, 0, 0, 0, PCU_IF_SAPI_PCH, prefix & imm_ass))); } else { var PCUIF_pch_dt pch_dt; - pch_dt.tlli := tlli; + pch_dt.msg_id := msg_id; pch_dt.imsi := hex2str(imsi); pch_dt.data := imm_ass; pt.send(t_SD_PCUIF(conn_id, ts_PCUIF_DATA_REQ(bts_nr, 0, 0, 0, 0, PCU_IF_SAPI_PCH_DT, enc_PCUIF_pch_dt(pch_dt)))); diff --git a/library/PCUIF_Types.ttcn b/library/PCUIF_Types.ttcn index 94056b9..2e3667a 100644 --- a/library/PCUIF_Types.ttcn +++ b/library/PCUIF_Types.ttcn @@ -106,7 +106,7 @@ type record PCUIF_data_cnf_dt { PCUIF_Sapi sapi, - OCT4 tlli, + OCT4 msg_id, uint32_t fn, uint16_t arfcn, uint8_t trx_nr, @@ -315,11 +315,11 @@ /* Record to send a (confirmed) IMMEDIATE ASSIGNMENT message via PCH. The record is sent by the PCU to the BTS as a * data request (data_req) under SAPI PCU_IF_SAPI_PCH_DT. */ type record PCUIF_pch_dt { - OCT4 tlli, + OCT4 msg_id, charstring imsi length(17), octetstring data length(23) } with { - variant (tlli) "BYTEORDER(last)" + variant (msg_id) "BYTEORDER(last)" variant (imsi) "FIELDLENGTH(17)" variant (data) "FIELDLENGTH(23)" }; @@ -698,14 +698,14 @@ template (value) uint32_t fn, template (value) uint16_t arfcn, template (value) PCUIF_Sapi sapi, - template (value) OCT4 tlli) := { + template (value) OCT4 msg_id) := { msg_type := PCU_IF_MSG_DATA_CNF_DT, bts_nr := bts_nr, spare := '0000'O, u := { data_cnf_dt := { sapi := sapi, - tlli := tlli, + msg_id := msg_id, fn := fn, arfcn := arfcn, trx_nr := trx_nr, @@ -722,14 +722,14 @@ template uint8_t trx_nr := ?, template uint8_t ts_nr := ?, template PCUIF_Sapi sapi := ?, - template OCT4 tlli := ?) := { + template OCT4 msg_id := ?) := { msg_type := PCU_IF_MSG_DATA_CNF_DT, bts_nr := bts_nr, spare := ?, u := { data_cnf_dt := { sapi := sapi, - tlli := tlli, + msg_id := msg_id, fn := ?, arfcn := ?, trx_nr := trx_nr, diff --git a/pcu/PCUIF_Components.ttcn b/pcu/PCUIF_Components.ttcn index 8a1207a..a6c5bae 100644 --- a/pcu/PCUIF_Components.ttcn +++ b/pcu/PCUIF_Components.ttcn @@ -140,7 +140,7 @@ type record BTS_CCCH_Block { uint8_t bts_nr, PCUIF_data raw, - OCT4 tlli optional, + OCT4 msg_id optional, charstring imsi optional, GsmRrMessage rr_msg }; @@ -161,11 +161,11 @@ template BTS_CCCH_Block tr_PCUIF_DATA_RR(template uint8_t bts_nr, template PCUIF_data raw, template GsmRrMessage rr_msg := ?, - template OCT4 tlli := *, + template OCT4 msg_id := *, template charstring imsi := *) := { bts_nr := bts_nr, raw := raw, - tlli := tlli, + msg_id := msg_id, imsi := imsi, rr_msg := rr_msg }; @@ -550,11 +550,11 @@ if (pcu_msg_rr.raw.sapi == PCU_IF_SAPI_PCH_DT) { pch_dt := dec_PCUIF_pch_dt(pcu_msg_rr.raw.data); - pcu_msg_rr.tlli := pch_dt.tlli; + pcu_msg_rr.msg_id := pch_dt.msg_id; pcu_msg_rr.imsi := pch_dt.imsi; pcu_msg_rr.rr_msg := dec_GsmRrMessage(pch_dt.data); } else { - pcu_msg_rr.tlli := omit; + pcu_msg_rr.msg_id := omit; pcu_msg_rr.imsi := omit; pcu_msg_rr.rr_msg := dec_GsmRrMessage(data); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1db29d5b1920e351c452b798c3260654c2cbe0cb Gerrit-Change-Number: 34108 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 12 months

1
0
0 0

[S] Change in pysim[master]: README.md: sort dependencies, document smpp.pdu

by Florian Klink

Attention is currently required from: lynxis lazus. Florian Klink has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34147 ) Change subject: README.md: sort dependencies, document smpp.pdu ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: thanks for the +2! Not sure if there's any additional submit requirements here unmet, but I'm unable to press the submit button here by myself. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34147 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I89760dd4008829c91fafbd442483d076c92a7ed4 Gerrit-Change-Number: 34147 Gerrit-PatchSet: 1 Gerrit-Owner: Florian Klink <flokli(a)flokli.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 17 Aug 2023 14:00:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 12 months

1
0
0 0

[S] Change in osmo-mgw[master]: vty: include local port when dumping RTP conns

by dexter

Attention is currently required from: keith. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34150 ) Change subject: vty: include local port when dumping RTP conns ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/libosmo-mgcp/mgcp_conn.c: https://gerrit.osmocom.org/c/osmo-mgw/+/34150/comment/7887e4ea_6d34a7ad PS1, Line 373: "rtp:%u<->%u rtcp:%u)", I don't know how long these lines are, but maybe print the port numbers directly behind ip, like "ip:192.168.100.10:1234/1235" ? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34150 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ib89a6779e1d68c6600f00699d4303f6c0ee07132 Gerrit-Change-Number: 34150 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Thu, 17 Aug 2023 13:59:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 12 months

1
0
0 0

[S] Change in pysim[master]: sim-reset-server: fix error printing sw_match_error

by dexter

Attention is currently required from: osmith. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34155 ) Change subject: sim-reset-server: fix error printing sw_match_error ...................................................................... Patch Set 1: (1 comment) File contrib/sim-rest-server.py: https://gerrit.osmocom.org/c/pysim/+/34155/comment/498a8dbd_1e22f395 PS1, Line 104: failure.value > If the information inside value.error is useful, I'd suggest converting it to a string instead. […] Unfortunately str(failure.value) didn't fix the problem. That was one of the things I tried before. This still makes me wonder, shouldn't str() work on any object? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34155 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5a1d19abeb00c2c9dc26517abc44a5c916f2d658 Gerrit-Change-Number: 34155 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Aug 2023 13:54:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 12 months

1
0
0 0

[S] Change in pysim[master]: README.md: sort dependencies, document smpp.pdu

by osmith

Attention is currently required from: Florian Klink, lynxis lazus. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34147 ) Change subject: README.md: sort dependencies, document smpp.pdu ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34147 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I89760dd4008829c91fafbd442483d076c92a7ed4 Gerrit-Change-Number: 34147 Gerrit-PatchSet: 1 Gerrit-Owner: Florian Klink <flokli(a)flokli.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Florian Klink <flokli(a)flokli.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 17 Aug 2023 13:41:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 12 months

1
0
0 0

[S] Change in pysim[master]: setup.py: fix package name

by osmith

Attention is currently required from: Florian Klink, lynxis lazus. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34146 ) Change subject: setup.py: fix package name ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I71ef6a19a487101e552219f10f2fa6215b966abd Gerrit-Change-Number: 34146 Gerrit-PatchSet: 1 Gerrit-Owner: Florian Klink <flokli(a)flokli.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Florian Klink <flokli(a)flokli.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 17 Aug 2023 13:41:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 12 months

1
0
0 0

[M] Change in osmo-e1d[master]: octoi: Add force-send-all-ts mode

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/34149 ) Change subject: octoi: Add force-send-all-ts mode ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/34149 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I6d17d3829b2c1c62e701a1d8c021d93d93593613 Gerrit-Change-Number: 34149 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 17 Aug 2023 13:39:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 12 months

1
0
0 0

[S] Change in osmo-mgw[master]: vty: include local port when dumping RTP conns

by osmith

Attention is currently required from: keith. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34150 ) Change subject: vty: include local port when dumping RTP conns ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34150 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ib89a6779e1d68c6600f00699d4303f6c0ee07132 Gerrit-Change-Number: 34150 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Thu, 17 Aug 2023 13:35:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 12 months

1
0
0 0

[M] Change in osmo-bsc[master]: pcuif_proto: get rid of _DT, _dt (Direct TLLI)

by osmith

Attention is currently required from: dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34136 ) Change subject: pcuif_proto: get rid of _DT, _dt (Direct TLLI) ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34136 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I628aaf19999a0004d0760d25ecd323cdbc0076f5 Gerrit-Change-Number: 34136 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Aug 2023 13:15:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 12 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2023