August 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: MME_Tests: add testcase TC_s1ap_reset
by dexter 22 Aug '23

22 Aug '23

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34156 ) Change subject: MME_Tests: add testcase TC_s1ap_reset ...................................................................... MME_Tests: add testcase TC_s1ap_reset There is currently no testcase that makes sure that the S1AP reset works. Related: OS#5760 Change-Id: I23f4d5f2c39790b6cb0dacaec1e31912177af3ec --- M library/s1ap/S1AP_Templates.ttcn M mme/MME_Tests.ttcn 2 files changed, 53 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/s1ap/S1AP_Templates.ttcn b/library/s1ap/S1AP_Templates.ttcn index 46ec779..9e75cec 100644 --- a/library/s1ap/S1AP_Templates.ttcn +++ b/library/s1ap/S1AP_Templates.ttcn @@ -251,8 +251,18 @@ } } } - - +template (present) S1AP_PDU +tr_S1AP_ResetAck_any := { + successfulOutcome := { + procedureCode := id_Reset, + criticality := reject, + value_ := { + ResetAcknowledge := { + protocolIEs := ? + } + } + } +} /********************************************************************************* @@ -938,7 +948,7 @@ /* all non-UE-related S1AP messages */ template (present) S1AP_PDU tr_S1AP_nonUErelated := (tr_S1AP_SetupReq, tr_S1AP_SetupResp, tr_S1AP_SetupFail, - tr_S1AP_Reset, tr_S1AP_ResetAck, tr_S1AP_MMEDirectInfTrans + tr_S1AP_Reset, tr_S1AP_ResetAck, tr_S1AP_ResetAck_any, tr_S1AP_MMEDirectInfTrans ); } diff --git a/mme/MME_Tests.ttcn b/mme/MME_Tests.ttcn index ebfb673..17a4d60 100644 --- a/mme/MME_Tests.ttcn +++ b/mme/MME_Tests.ttcn @@ -905,6 +905,31 @@ vc_conn.done; } +/* Successful RESET procedure from eNB to MME */ +testcase TC_s1ap_reset() runs on MTC_CT { + var charstring id := testcasename(); + f_init_s1ap(id, 3); + f_s1ap_setup(0); + + var template (value) Cause reset_cause := {misc := om_intervention}; + var template (value) ResetType reset_type := {s1_Interface := reset_all}; + timer T := 5.0; + + S1AP_UNIT[0].send(ts_S1AP_Reset(reset_cause, reset_type)); + T.start; + alt { + [] S1AP_UNIT[0].receive(tr_S1AP_ResetAck_any) { + setverdict(pass); + } + [] S1AP_UNIT[0].receive { + setverdict(fail, "Received unexpected S1AP"); + } + [] T.timeout { + setverdict(fail, "Timeout waiting for S1AP Setup result"); + } + } +} + control { execute( TC_s1ap_setup_wrong_plmn() ); execute( TC_s1ap_setup_wrong_tac() ); @@ -912,6 +937,8 @@ execute( TC_s1ap_attach() ); execute( TC_gn_echo_request() ); execute( TC_RIM_RAN_INF() ); + execute( TC_s1ap_reset() ); } + } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34156 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I23f4d5f2c39790b6cb0dacaec1e31912177af3ec Gerrit-Change-Number: 34156 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in libosmocore[master]: osmo_io: Avoid potential double free when sending msgb
by daniel 22 Aug '23

22 Aug '23

Attention is currently required from: pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34144 ) Change subject: osmo_io: Avoid potential double free when sending msgb ...................................................................... Patch Set 2: (3 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/34144/comment/9ecd61d6_911ec2b4 PS1, Line 16: mean time. To avoid that set the parent of any msgb in the tx queue to the > time is indeed mean sometimes. Just wait until you're my age.. Patchset: PS1: > All the talloc parent in here looks already quite complex and I have the feeling it's becoming even […] I'm also not 100% happy with it. All msgbs should be owned by the iofd except for the msgbs passed to the read callback. I'll change the code that iofd is the default parent of new msgbs and only talloc_steal() the msgbs before they are passed to the read_cb. I think that both simplifies things and makes the intent clear. File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/34144/comment/22b931a0_67927036 PS1, Line 324: > non-related ws Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34144 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3a279b55a3adff96948120683c844e1508d0ba94 Gerrit-Change-Number: 34144 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Aug 2023 14:35:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: osmo_io: Avoid potential double free when sending msgb
by daniel 22 Aug '23

22 Aug '23

Attention is currently required from: pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/34144 to look at the new patch set (#2). Change subject: osmo_io: Avoid potential double free when sending msgb ...................................................................... osmo_io: Avoid potential double free when sending msgb Ensure that a msgb has the proper talloc parent: All msgbs inside an iofd get the iofd as parent. Received msgbs are reparented to iofd->msgb_alloc.ctx (which was set in osmo_iofd_setup()) before being passed to the receive callback. Before this change the code could fail for msgbs that are submitted via uring where the (failed) write returns after the iofd has already been osmo_iofd_free()d. free()ing the iofd is deferred until the write completes, but the (iofd) parent context could have been free()d in the meantime. Change-Id: I3a279b55a3adff96948120683c844e1508d0ba94 --- M src/core/osmo_io.c M src/core/osmo_io_internal.h M src/core/osmo_io_poll.c 3 files changed, 42 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/44/34144/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34144 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3a279b55a3adff96948120683c844e1508d0ba94 Gerrit-Change-Number: 34144 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[L] Change in libosmocore[master]: osmo_io: Add io_uring backend
by daniel 22 Aug '23

22 Aug '23

Attention is currently required from: fixeria, pespin. daniel has uploaded a new patch set (#11) to the change originally created by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/32536 ) Change subject: osmo_io: Add io_uring backend ...................................................................... osmo_io: Add io_uring backend Change-Id: I5152129eb84b31ccc9e02bc2a5c5bdb046d331bc --- M configure.ac M contrib/libosmocore.spec.in M debian/control M include/osmocom/core/osmo_io.h M src/core/Makefile.am M src/core/osmo_io.c M src/core/osmo_io_internal.h A src/core/osmo_io_uring.c M tests/osmo_io/osmo_io_test.c 9 files changed, 486 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/36/32536/11 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32536 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5152129eb84b31ccc9e02bc2a5c5bdb046d331bc Gerrit-Change-Number: 32536 Gerrit-PatchSet: 11 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[L] Change in libosmocore[master]: osmo_io: Add io_uring backend
by daniel 22 Aug '23

22 Aug '23

Attention is currently required from: fixeria, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32536 ) Change subject: osmo_io: Add io_uring backend ...................................................................... Patch Set 11: (15 comments) File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/2cb864d2_dc8a8633 PS10, Line 118: return > Looks like `msg` is leaked here. […] I also combined submit_read() and submit_recvmsg() into one function since they are nearly identical https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/5a0f9c27_c3519917 PS10, Line 126: Could not get io_uring_sqe > missing `\n` Done https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/0b8eac9f_12888db1 PS10, Line 130: // Prep msgb/iov > cosmetic: use the `/* ... […] Done https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/4c811e23_9aec738b PS10, Line 135: // NOTE: This only works if we have one read per fd > cosmetic: use the `/* ... […] Done https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/c4490aee_cb46df3b PS10, Line 153: return > Again, looks like `msg` is leaked here. Done https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/84577c9c_84851497 PS10, Line 165: Could not get io_uring_sqe > Again missing `\n`. Done https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/1ac096b2_2394de44 PS10, Line 275: /* Fallthrough */ > This comment is not really needed since there is no code preceding it. Done https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/cd73e497_51a04bba PS10, Line 295: io_uring_peek_cqe > Are you sure this is correct? […] No, it looks wrong. Seems like I still got all cqes because peek would (eventually) return the same completion until its io_uring_cqe_seen() https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/71151ea0_c55ac0f9 PS10, Line 326: Could not get io_uring_sqe > missing '\n' Done https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/fd1a42a5_7defc65a PS10, Line 360: if (!sqe) : OSMO_ASSERT(0); > `OSMO_ASSERT(sqe != NULL)` Ack https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/ef12b6cb_28afeab0 PS10, Line 362: (void *)0x0 > Why not `NULL`? Done https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/f4f7cacc_5236b267 PS10, Line 369: if (!sqe) : OSMO_ASSERT(0); > `OSMO_ASSERT(sqe != NULL)` Done https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/517eb248_f5f18ca1 PS10, Line 397: return > `msg` is leaked here. Done https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/34689a92_515ad1e0 PS10, Line 404: Could not get io_uring_sqe > missing `\n` Done https://gerrit.osmocom.org/c/libosmocore/+/32536/comment/2a74067c_3fa9d3b9 PS10, Line 438: > ws Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32536 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5152129eb84b31ccc9e02bc2a5c5bdb046d331bc Gerrit-Change-Number: 32536 Gerrit-PatchSet: 11 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Aug 2023 14:35:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests: rewrite outdated comment
by dexter 22 Aug '23

22 Aug '23

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34065 ) Change subject: BTS_Tests: rewrite outdated comment ...................................................................... BTS_Tests: rewrite outdated comment We are no longer "appending" imsi digits. This is now done properly using a struct but let's still mention what we use the IMSI for. Related: OS#5927 Change-Id: I3d943cd96e1d9627ad68e3439b2a649baa5785f1 --- M bts/BTS_Tests.ttcn 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 63a9a05..d39bb77 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -5847,7 +5847,7 @@ f_init_l1ctl(); f_l1_tune(L1CTL); - /* append 3 last imsi digits so BTS can compute pagng group */ + /* The BTS will use the last three IMSI digits to compute paging group. */ f_PCUIF_tx_imm_ass_pch(PCU, g_pcu_conn_id, imm_ass, '123459987'H); timer T := 0.5; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34065 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3d943cd96e1d9627ad68e3439b2a649baa5785f1 Gerrit-Change-Number: 34065 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests: rewrite outdated comment
by osmith 22 Aug '23

22 Aug '23

Attention is currently required from: pespin, dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34065 ) Change subject: BTS_Tests: rewrite outdated comment ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34065 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3d943cd96e1d9627ad68e3439b2a649baa5785f1 Gerrit-Change-Number: 34065 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Aug 2023 14:21:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests: rewrite outdated comment
by dexter 22 Aug '23

22 Aug '23

Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34065 ) Change subject: BTS_Tests: rewrite outdated comment ...................................................................... Patch Set 2: (1 comment) File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34065/comment/e9a6d5f6_6243… PS1, Line 5850: /* The BTS will use the last three IMSI digits to compute pagng group. */ > typo: paging Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34065 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3d943cd96e1d9627ad68e3439b2a649baa5785f1 Gerrit-Change-Number: 34065 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 22 Aug 2023 13:47:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests: rewrite outdated comment
by dexter 22 Aug '23

22 Aug '23

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34065 to look at the new patch set (#2). Change subject: BTS_Tests: rewrite outdated comment ...................................................................... BTS_Tests: rewrite outdated comment We are no longer "appending" imsi digits. This is now done properly using a struct but let's still mention what we use the IMSI for. Related: OS#5927 Change-Id: I3d943cd96e1d9627ad68e3439b2a649baa5785f1 --- M bts/BTS_Tests.ttcn 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/65/34065/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34065 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3d943cd96e1d9627ad68e3439b2a649baa5785f1 Gerrit-Change-Number: 34065 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-pcu[master]: vty: Allow modifying default msclass
by pespin 22 Aug '23

22 Aug '23

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33983 ) Change subject: vty: Allow modifying default msclass ...................................................................... Patch Set 4: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33983 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If80fdd793db7dad029faa83dbf980ffc4959e2e5 Gerrit-Change-Number: 33983 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 22 Aug 2023 11:01:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2026

2025

2024

2023

2022

gerrit-log August 2023