Attention is currently required from: laforge, pespin.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34114 )
Change subject: stream: Use new flag OSMO_SOCK_F_SCTP_ASCONF_SUPPORTED for SCTP sockets
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34114
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I807b3748b8535d8e75ceea812d7baaf153fa1d60
Gerrit-Change-Number: 34114
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 23 Aug 2023 07:25:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34046 )
Change subject: rlcmac: ul_tbf: Implement TBF_Starting time (phase1)
......................................................................
Patch Set 8: Code-Review+1
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/libosmo-gprs/+/34046/comment/5bf1d075_7609ab3f
PS8, Line 9: since lower layers are always
: sending hardcoded fn=0
We already have a patch fixing this in review, so not sure if this should be in the commit message.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34046
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: If6b7766ee1ba6667db4e54e897f376f5b27ad73d
Gerrit-Change-Number: 34046
Gerrit-PatchSet: 8
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 22 Aug 2023 17:59:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34044 )
Change subject: rlcmac: Fix Starting Time rfn->fn calculation
......................................................................
Patch Set 6: Code-Review+1
(3 comments)
File src/rlcmac/rlcmac_dec.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/34044/comment/169eaa6c_4c70e47b
PS6, Line 437: t3 = tbf_start_time->N51
Are you sure this is correct? On the left (before this patch) `t3` field was assigned the value of `tbf_start_time->N26`, but now it's `tbf_start_time->N51`. Ah, now it matches what `gsm_fn2gsmtime()` is doing, so looks correct. Nevermind.
https://gerrit.osmocom.org/c/libosmo-gprs/+/34044/comment/ba487d5a_6fce381f
PS6, Line 439: 51 * OSMO_MOD_FLR((t3 - t2), 26) + t3 + 51 * 26 * t1p;
AFAICS, this is pretty much a copy-paste from libosmogsm. Is there a reason to reinvent `gsm_gsmtime2fn()` here? Can't we keep the function as it was, and simply do `gsm_rfn2fn`?
```
const uint16_t rfn = gsm_gsmtime2fn(&g_time);
const uint32_t fn = gsm_rfn2fn(rfn, curr_fn);
```
File tests/rlcmac/rlcmac_types_test.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/34044/comment/d0ec9690_54c93307
PS3, Line 54: printf
> This allows easily separating internal logging from test specific logging. […]
Not blocking, marking as resolved.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34044
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I00741289333853a8db472950ee2ac38dc2c74fd3
Gerrit-Change-Number: 34044
Gerrit-PatchSet: 6
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 22 Aug 2023 17:53:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment