Attention is currently required from: pespin.

daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34144 )

Change subject: osmo_io: Avoid potential double free when sending msgb ......................................................................

Patch Set 2:

(3 comments)

Commit Message:

https://gerrit.osmocom.org/c/libosmocore/+/34144/comment/9ecd61d6_911ec2b4 PS1, Line 16: mean time. To avoid that set the parent of any msgb in the tx queue to the

time is indeed mean sometimes.

Just wait until you're my age..

Patchset:

PS1:

All the talloc parent in here looks already quite complex and I have the feeling it's becoming even […]

I'm also not 100% happy with it. All msgbs should be owned by the iofd except for the msgbs passed to the read callback. I'll change the code that iofd is the default parent of new msgbs and only talloc_steal() the msgbs before they are passed to the read_cb. I think that both simplifies things and makes the intent clear.

File src/core/osmo_io.c:

https://gerrit.osmocom.org/c/libosmocore/+/34144/comment/22b931a0_67927036 PS1, Line 324:

non-related ws

Done