Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34077 )
Change subject: SGSN_Tests: add RIM ROUTING ADDRESS field in request
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34077/comment/0bc066ce_4bb4…
PS1, Line 13:
> I have changed the commit message now a bit, but I am still a bit confused. […]
I think that one thing is what the specs says it's mandatory or not, and another one it's a whole rant about how do we handle that 😄
Without looking into much details, my understanding is that the spec marks that as optional since some implementation may decide to have some sort of default route and really not care about the destination.
Feel free to add a test reproducing both with and without address being present. In any case, without address it should be handled as 3G, which are not really supporting right now anyway afair.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34077
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id944c66f28d787a18c6c6f7c9dc885997d83e94c
Gerrit-Change-Number: 34077
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Aug 2023 13:02:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: laforge, pespin, fixeria.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34057 )
Change subject: stream: Split cli/srv specific code out of stream.c
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Patchset:
PS3:
> > Most of the io work was already merged, at least the initial big commits, so I expect minimal cras […]
The remaining commits have server and client side split neatly so I guess that rebasing shouldn't be too much effort.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34057
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I22af01bba2040eb320ba48fd1b46c090c98be159
Gerrit-Change-Number: 34057
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Aug 2023 12:55:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34077
to look at the new patch set (#3).
Change subject: SGSN_Tests: add RIM ROUTING ADDRESS field in request
......................................................................
SGSN_Tests: add RIM ROUTING ADDRESS field in request
When sending the RAN INFORMATION REQUEST on GTP-C, we do not add a RIM
ROUTING ADDRESS + RIM ROUTING ADDRESS DISCRIMINATOR field. Those fields
are optional but commonly added so that the SGSN does not have to
disassemble the RAN TRANSPARENT CONTAINTER to know the destination
address.
see also: 3gpp TS 29.060, section 7.5.14 and
3GPP TS 23.060, section 8.1.5.2.2
Change-Id: Id944c66f28d787a18c6c6f7c9dc885997d83e94c
Related: OS#6095
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 27 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/77/34077/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34077
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id944c66f28d787a18c6c6f7c9dc885997d83e94c
Gerrit-Change-Number: 34077
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge, pespin.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34075
to look at the new patch set (#2).
Change subject: GTP_Templates: Add templates for RIM ROUTING ADDRESS
......................................................................
GTP_Templates: Add templates for RIM ROUTING ADDRESS
The IE types RIM_RoutingAddress and RIM_RoutingAddress_Discriminator
have not coresponding templates yet.
Related: OS#6095
Change-Id: If79f94ac3b7ec9a76763141ee2d8cac50c69d60b
---
M library/GTP_Templates.ttcn
1 file changed, 39 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/75/34075/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34075
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If79f94ac3b7ec9a76763141ee2d8cac50c69d60b
Gerrit-Change-Number: 34075
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset