Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34044 )
Change subject: rlcmac: Fix Starting Time rfn->fn calculation
......................................................................
Patch Set 3:
(3 comments)
File src/rlcmac/rlcmac_dec.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/34044/comment/98766f3e_727ca34f
PS3, Line 434: rfn_to_fn
May be a good idea to have this function in libosmocore.git (`src/gsm/gsm0502.c`), since we need this calculation in several projects (osmocom-bb.git, osmo-pcu.git) IIRC.
File tests/rlcmac/Makefile.am:
https://gerrit.osmocom.org/c/libosmo-gprs/+/34044/comment/c693e25d_c77ed27f
PS3, Line 52: rlcmac_types_test_LDADD = $(LDADD)
" No newline at end of right file. "
File tests/rlcmac/rlcmac_types_test.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/34044/comment/76d3c34a_07fbafc1
PS3, Line 54: printf
Why not printing to `stderr`? It's easier to read/review stuff when it's in one file.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34044
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I00741289333853a8db472950ee2ac38dc2c74fd3
Gerrit-Change-Number: 34044
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Aug 2023 15:03:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34076 )
(
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: GTP_Templates: add decoder/encoder functions for RIM_Routing_Address_GTPC
......................................................................
GTP_Templates: add decoder/encoder functions for RIM_Routing_Address_GTPC
When forwarding RAN TRANSPARENT CONTAINERs containers on GTP-C, the
sender adds a RIM ROUTING ADDRESS and a RIM ROUTING ADDRESS
DISCRIMINATOR. The RIM ROUTING ADDRESS is represented as an
octet-string, so we need encoder/decoder functions for it.
Related: OS#6095
Change-Id: I45d1f5b019f3847fd611c38dc19d78d6fe027c5a
---
M library/GTP_Templates.ttcn
1 file changed, 19 insertions(+), 0 deletions(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/library/GTP_Templates.ttcn b/library/GTP_Templates.ttcn
index f6fda36..ebd9142 100644
--- a/library/GTP_Templates.ttcn
+++ b/library/GTP_Templates.ttcn
@@ -1082,6 +1082,10 @@
number_of_SI_PSI := int2bit(si_psi_num, 7),
sI_PSI := si_psi
}
+ external function enc_RIM_Routing_Address_GTPC(in RIM_Routing_Address_GTPC ra) return octetstring
+ with { extension "prototype(convert) encode(RAW)" };
+ external function dec_PCUIF_pch_dt(in octetstring stream) return RIM_Routing_Address_GTPC
+ with { extension "prototype(convert) decode(RAW)" };
/* RAN_Information_Request */
template (value) RAN_Information_Request_RIM_Container_GTPC
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34076
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I45d1f5b019f3847fd611c38dc19d78d6fe027c5a
Gerrit-Change-Number: 34076
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: laforge, pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34087 )
Change subject: GTP_Templates: add template restriction qualifiers
......................................................................
Patch Set 2:
(2 comments)
File library/GTP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34087/comment/20c63915_5c01…
PS1, Line 112: template (value) Recovery_gtpc ts_Recovery(OCT1 restart_counter) := {
> this would actually be a "template (value)"
It is already a template (value) ... (or do you mean template (value) OCT1 ...?)
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34087/comment/97074e27_0a76…
PS1, Line 117: template (present) Recovery_gtpc tr_Recovery(template OCT1 restart_counter) := {
> I think I specially meant the restrictions in the parameters: template (present) OCT1 restart_counte […]
I now went through the code once more and added the qualifiers.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34087
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic439b4ae85b417fde0ddfb8fa00758d6486b57c8
Gerrit-Change-Number: 34087
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Aug 2023 14:39:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin, dexter.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34075
to look at the new patch set (#3).
Change subject: GTP_Templates: Add templates for RIM ROUTING ADDRESS
......................................................................
GTP_Templates: Add templates for RIM ROUTING ADDRESS
The IE types RIM_RoutingAddress and RIM_RoutingAddress_Discriminator
have not coresponding templates yet.
Related: OS#6095
Change-Id: If79f94ac3b7ec9a76763141ee2d8cac50c69d60b
---
M library/GTP_Templates.ttcn
1 file changed, 39 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/75/34075/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34075
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If79f94ac3b7ec9a76763141ee2d8cac50c69d60b
Gerrit-Change-Number: 34075
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newpatchset