August 2023 - gerrit-log - lists.osmocom.org

[M] Change in docker-playground[master]: ttcn3-mme-test-ogs: configure Gn interface

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/34086 ) Change subject: ttcn3-mme-test-ogs: configure Gn interface ...................................................................... ttcn3-mme-test-ogs: configure Gn interface The Gn interface is not configured yet, hence TC_gn_echo_request fails. Related: OS#5760 Change-Id: Ia89a137103f558ae96e269c935fabe80bb2e2884 --- M ttcn3-mme-test-ogs/ogs/MME_Tests.cfg M ttcn3-mme-test-ogs/ogs/open5gs-mme.yaml 2 files changed, 68 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/86/34086/1 diff --git a/ttcn3-mme-test-ogs/ogs/MME_Tests.cfg b/ttcn3-mme-test-ogs/ogs/MME_Tests.cfg index 59cf865..6f873f2 100644 --- a/ttcn3-mme-test-ogs/ogs/MME_Tests.cfg +++ b/ttcn3-mme-test-ogs/ogs/MME_Tests.cfg @@ -27,6 +27,11 @@ mp_vlr_name := "vlr.example.net"; mp_mme_name := "mmec01.mmegi0001.mme.epc.mnc070.mcc901.3gppnetwork.org"; +# Gn interface +mp_gn_local_ip := "172.18.3.202"; +mp_gn_local_port := 2123; +mp_gn_remote_ip := "172.18.3.201"; + [MAIN_CONTROLLER] [EXECUTE] diff --git a/ttcn3-mme-test-ogs/ogs/open5gs-mme.yaml b/ttcn3-mme-test-ogs/ogs/open5gs-mme.yaml index 22797f2..ac72335 100644 --- a/ttcn3-mme-test-ogs/ogs/open5gs-mme.yaml +++ b/ttcn3-mme-test-ogs/ogs/open5gs-mme.yaml @@ -474,6 +474,57 @@ - 172.18.3.201 - ::1 + +# <GTP-C Client> +# +# o Specify SGSN addresses the GTP-C must connect to +# +# o One SGSN is defined. +# If prefer_ipv4 is not true, [fd69:f21d:873c:fa::2] is selected. +# sgsn: +# - gtpc: +# addr: +# - 127.0.0.3 +# - fd69:f21d:873c:fa::2 +# routes: +# - rai: XYZ +# ci: XYZ +# +# o Three SGW are defined. MME selects SGW with round-robin manner per UE +# sgsn: +# - gtpc: +# addr: +# - 127.0.0.3 +# - fd69:f21d:873c:fa::2 +# routes: +# - rai: XYZ +# ci: XYZ +# - gtpc: +# addr +# - 127.0.0.22 +# - fd69:f21d:873c:fa::12 +# routes: +# - rai: XYZ +# ci: XYZ +# - name: sgsn3.open5gs.org +# routes: +# - rai: XYZ +# ci: XYZ +# +sgsn: + - gtpc: + addr: + - 172.18.3.202 + routes: + - rai: + lai: + plmn_id: + mcc: 262 + mnc: 42 + lac: 43690 + rac: 187 + ci: 1223 + # # o Disable use of IPv4 addresses (only IPv6) # parameter: -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34086 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia89a137103f558ae96e269c935fabe80bb2e2884 Gerrit-Change-Number: 34086 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years

1
0
0 0

[S] Change in libosmo-netif[master]: stream_srv: Increase logging level of SCTP MSG_NOTIFICATION lines

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34081 ) Change subject: stream_srv: Increase logging level of SCTP MSG_NOTIFICATION lines ...................................................................... Patch Set 1: (1 comment) File src/stream_srv.c: https://gerrit.osmocom.org/c/libosmo-netif/+/34081/comment/010d02fa_c6bbaf85 PS1, Line 848: LOGP(DLINP, LOGL_DEBUG, "NOTIFICATI another even more critical problem of this function is that it logs no contxt whatsoever. You have no idea to which of your many sockets/associations it may relate to. This should be re-factored into something that generates the same prefix as LOGSSRV. If the function is to be shared between client + server (I think so), then one could just have a 'const char *prefix' argument and let the caller generate that prefix. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I0ed84cc2effb71b6ef1f6efb3f8b663c602a5a31 Gerrit-Change-Number: 34081 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 05 Aug 2023 08:09:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years

1
0
0 0

[M] Change in libosmo-netif[master]: stream_cli: Forward SCTP MSG_NOTIFICATION to upper layers

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34080 ) Change subject: stream_cli: Forward SCTP MSG_NOTIFICATION to upper layers ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: can we try to avoid copy+pasting virtually the same function between server/client? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34080 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I4cb94d264109f1b763cccd44c6ba049cc7509319 Gerrit-Change-Number: 34080 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 05 Aug 2023 08:07:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years

1
0
0 0

[M] Change in libosmo-netif[master]: stream_srv: Log SCTP REMOTE_ERROR events

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34084 ) Change subject: stream_srv: Log SCTP REMOTE_ERROR events ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I49f5a648fd474e320101424fb6873a37442339bf Gerrit-Change-Number: 34084 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 05 Aug 2023 08:06:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in libosmo-netif[master]: stream_srv: sctp: Log error cause of COMM_LOST event

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34083 ) Change subject: stream_srv: sctp: Log error cause of COMM_LOST event ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34083 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ie48360d22ce1e35eefb1a305dde106948dfa80e8 Gerrit-Change-Number: 34083 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 05 Aug 2023 08:05:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in libosmo-netif[master]: sctp: Document relevant RFC specs

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34082 ) Change subject: sctp: Document relevant RFC specs ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34082 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Iae325b787fdb7fc95aa6922975a7e1fcf368527a Gerrit-Change-Number: 34082 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 05 Aug 2023 08:05:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in libosmo-netif[master]: stream_srv: Increase logging level of SCTP MSG_NOTIFICATION lines

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34081 ) Change subject: stream_srv: Increase logging level of SCTP MSG_NOTIFICATION lines ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/stream_srv.c: https://gerrit.osmocom.org/c/libosmo-netif/+/34081/comment/e91b56b5_005c0607 PS1, Line 834: static int _sctp_recvmsg_wrapper(int fd, struct msgb *msg) the problem I always had with this function that it doesn't differentiate the log level based on the kind of event/notification. For example, I would say "SEND FAILED or "SHUTDOWN" are even worth NOTICE, but given that we use LOGPC we cannot change the log level of the prefix printed in the LOGP. Changing everything to INFO is the right direction, of course. One might argue everything except "UP" is NOTICE. But then it's awkward if you have level notice set and you see only the disconencts but never the new connects... -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I0ed84cc2effb71b6ef1f6efb3f8b663c602a5a31 Gerrit-Change-Number: 34081 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 05 Aug 2023 08:05:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in libosmo-netif[master]: stream_cli: Proper handling of send() socket errors

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34079 ) Change subject: stream_cli: Proper handling of send() socket errors ...................................................................... Patch Set 1: (1 comment) File src/stream_cli.c: https://gerrit.osmocom.org/c/libosmo-netif/+/34079/comment/937e450e_175fd1ec PS1, Line 292: error to send this is making it consistent with the server side, but makes it just as unreadable. don't expect the reader to be able to assume that "send" is referring to a system call/function here. "error to send" sounds like: "We have an error to send to somebody" - or "we are communicating an error towards an entity called send". -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34079 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I462cb176ebc51f3e99ee796310e8665144c84ccc Gerrit-Change-Number: 34079 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 05 Aug 2023 08:02:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in libosmo-netif[master]: stream_srv: Handle ESHUTDOWN and other write() errors destroying the ...

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34078 ) Change subject: stream_srv: Handle ESHUTDOWN and other write() errors destroying the socket ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/stream_srv.c: https://gerrit.osmocom.org/c/libosmo-netif/+/34078/comment/9c8066ea_df70ad20 PS2, Line 593: error to send one might also make that message readable at some point, if one is touching that code anyway now. "error in resposne to send()", for example. or "error during send()". -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34078 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I84ddebabdffe47733cb529bcfebec8757e6a172b Gerrit-Change-Number: 34078 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 05 Aug 2023 08:00:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in libosmo-netif[master]: stream: Append data to current tail of message upon recv()

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34074 ) Change subject: stream: Append data to current tail of message upon recv() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34074 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I2cfcd4f61545e6a76d84495c3467999efccf22df Gerrit-Change-Number: 34074 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 05 Aug 2023 07:58:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2023